6433 Commits (f045e4f00e3e45bf977a8a1cbf048aab617ae95c)

Author SHA1 Message Date
Adriaan de Groot 10991346b7
Merge pull request #1561 from gportay/partition-set-swap-partition-name
[partition] Allow a configurable swap Partition name
6 years ago
Adriaan de Groot 7578768c46
Merge pull request #1562 from gportay/partition-group-efi-things-together
[partition] Group EFI things together
6 years ago
Artem Grinev 4e54a2aefe [users] Cleaned error handling a bit 6 years ago
Artem Grinev 8e07bb00f9 [users] Construct icu::UnicodeString from QString's utf16 chars directly 6 years ago
Artem Grinev 48eae463cc [users] Full name transliteration support for user creation 6 years ago
Adriaan de Groot 0bad5469fc [libcalamares] Fix tests failures from JobQueue asserts
Some compile flags changed recently, triggering assert()
in the jobqueue when there is more than one. There's no
real reason for JobQueue to be a singleton, but it wants
to be. So clean up pointers a little more enthusiastically.
6 years ago
Adriaan de Groot 4746754344 [keyboard] Translate layouts as well 6 years ago
Adriaan de Groot 6863db0dc1 [keyboard] Use the translations if they were loaded 6 years ago
Adriaan de Groot f088efdf84 [keyboard] Re-jig translation extraction
- Use classes to prompt lupdate to extract with a better
  context (e.g. the class name, rather than plain "QObject")
  so that the translation-lookup can use the named context.
- Add hard-coded "default" variant
- Add totally bogus Tajik translations, for testing purposes
6 years ago
Adriaan de Groot 1a5fa36fb6 i18n: build keyboard translations
This is the Wrong Thing To Do, but we'll do it for now: build the
keyboard translations into the executable. In the medium term
they should move to the modules that use them, with the re-vamp
of how translation changes are signalled.
6 years ago
Adriaan de Groot 4a08fdbb92 [partition] Reduce warnings from KPMCore
- make KPMHelper.h an "everything include" and suppress warnings
  from it, then use it in the tests.
6 years ago
Adriaan de Groot d26fde6647 [partition] Reduce warnings
- Add a helper header that munges the warnings-settings so that
  KPMcore headers can be included.
6 years ago
Adriaan de Groot c41ff94f8a [locale] Reduce warnings (C++17)
Now that Calamares is compiled as C++17, we get this:

src/modules/locale/timezonewidget/TimeZoneImage.cpp:28:55: warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated]
/* static constexpr */ const QSize TimeZoneImageList::imageSize;
6 years ago
Adriaan de Groot 4d444cbfbb [partition] Reduce warnings (Clang, FreeBSD)
The code doesn't match the comment: there are no by-ref captures
in the code, and the shadowing of parameters and local variables
is confusing. Remove one variable that is passed in as an argument
(and just pass the value as argument) and copy-capture the other
rather than doing weird argument passing.
6 years ago
Adriaan de Groot 0a44ce381e [partition] Reduce warnings (Clang, FreeBSD)
- remove unused this captures from lambda
- rename variables that are short, cryptic, and shadowed
- remove documentation for parameters that don't exist
6 years ago
Gaël PORTAY 3967cfe0eb [partition] Group EFI things together 6 years ago
Gaël PORTAY a1d45122eb [partition] Update partition.conf 6 years ago
Gaël PORTAY dad9587c3e [partition] Allow a configurable swap Partition name
This commit adds the new configuration `swapPartitionName` to the file
partition.conf.

This option sets the partition name to the swap partition that is
created. If this option is unset, the partition is left unnamed.
6 years ago
Adriaan de Groot 4387b8061e [keyboard] Move responsibility for retranslation to Config
- only widgets get language change events, so we need to
  hook that up to the ViewSteps and inform the Config
  object so that it can (re)load translations for the
  keyboard data.
6 years ago
Adriaan de Groot 71e0081fce [keyboard] SPDX-tagging 6 years ago
Adriaan de Groot 7db398cfdf
Merge pull request #1558 from gportay/partition-cleanups
[partition] cleanups
6 years ago
Adriaan de Groot 89a180ee58 [keyboard] Initial support for translated keyboard names 6 years ago
Adriaan de Groot b72eba8157 [libcalamares] Extend the Deleter-helper with "preserve"
Sometimes you want to keep the thing around after all.
6 years ago
Adriaan de Groot 7659dfdb9d [libcalamares] Expose a translations-loading function 6 years ago
Gaël PORTAY f03ae06deb [partition] Rename execute to createPartitions 6 years ago
Gaël PORTAY f2bfe2bd6a [partition] Fix coding style 6 years ago
Gaël PORTAY cd725fbb4b Fix missing SPDX-FileCopyrightText in header 6 years ago
Gaël PORTAY 2007335865 [partition] Rename the KPMCore Partition local to part 6 years ago
Gaël PORTAY 32c1f81fbf [partition] Rename iterator in for loop to entry 6 years ago
Gaël PORTAY 3016b93c8f [partition] Simplify the method execute
- Rename the "size" locals using "sectors" in their name. Size may be
  confusing or not enough specific as it can be interpreted a size in
  Byte.
    partSizeMap -> partSectorsMap,
    totalSize -> totalSectors,
    availablesize -> availableSectors,
    size -> sectors,
    minSize -> minSectors
    maxSize -> maxSectors
- Create a the new local currentSector to iterate over the sectors;
  instead of using the parameter firstSector.
- Remove the variable end that does not help much; too many variable
  already. Expand its expression instead.
6 years ago
Gaël PORTAY 81bec68b3d [partition] Introduce new constructors for PartitionEntry
- Introduces new constructors for PartitionEntry: copy constructory and
  constructor with all attributes.
- Use the new constructor in method addEntry().
6 years ago
Gaël PORTAY 3f2dd516d3 [partition] Simplify the retrieval of the size attributes
- The variant helper toString() takes a default value since commit
  c9f942ad6 ([libcalamares] Add default value to variant helpers).
- Set the default value to 0 and simplify the retreival of size values
  by calling the helper toString() and removing the temporary variables.
6 years ago
Gaël PORTAY 03df5f6891 [libcalamares] Fix constness of functions 6 years ago
Gaël PORTAY aec066359a [libcalamares] Fix coding style 6 years ago
Gaël PORTAY db7cf74034 [partition] Remove the call the method contains
- The variant helper getString() calls contains() already.
6 years ago
Gaël PORTAY d6ea30b23e [partition] Move initLayout logic to object PartitionLayout
- The logic of the method initLayout belongs to the object
  PartitionLayout. Move logic to that object.
- Use a single method initLayout in object PartitionCoreModule.
- Member m_partLayout in object PartitionCoreModule is no longer
  allocated.
6 years ago
Gaël PORTAY eae1e90dce [partition] Remove unused PartitionLayout constructor
- The constructor PartitionLayout with PartitionEntry appears to be
  unused since its always. Drop it!
6 years ago
Gaël PORTAY f2960366c8 [partition] Remove unused addEntry method
- The method addEntry with PartitionEntry appears to be unused since its
  always. Drop it!
6 years ago
Adriaan de Groot ac6c9fae4a [libcalamares] Do not use moved-from object 6 years ago
Adriaan de Groot 2e9a44269c [keyboard] Extracted strings from keyboard list 6 years ago
Adriaan de Groot 5a378090c2 [keyboard] Do not munge keyboard model name
The translation happens whenever this code is run, which may
not match the language the user subsequently selects.
It also causes general problems with the translation,
since we end up with a possibly-partly-translated name.
6 years ago
Adriaan de Groot 7ec8c454bd [keyboard] Ukranian needs a switcher, too 6 years ago
Adriaan de Groot 8457a00ad0 [keyboard] Fix group-switcher multiplying
FIXES #1556
6 years ago
Adriaan de Groot daaf16d331 Merge branch 'calamares' into issue-1523 6 years ago
Adriaan de Groot cd9c0ea781 [keyboard] Reduce debugging output 6 years ago
Adriaan de Groot 2e5301c5c9 [keyboard] Simplify back down to lambdas
- With debugging and untangling done, the lambdas are simple
  and short, so return to using them. One point of improvement
  might be to give the models suitable slots themselves,
  to avoid even this indirection.
6 years ago
Adriaan de Groot 0bf28b0b94 [keyboard] Sanity in setCurrentIndex() parameters 6 years ago
Adriaan de Groot 9e141636c5 [keyboard] Tidy up the debugging output, add docs 6 years ago
Adriaan de Groot 14a76a386a [keyboard] Replace broken-ish variants model with k-v list
- Use the just-refactored XKBListModel to store the xkb key-value
  pairs for variants, drop most of the complicated implementation,
  store just a single list of values.
6 years ago
Adriaan de Groot d536173d66 [keyboard] Factor out a 2-column k-v list 6 years ago
Adriaan de Groot 5afe54132b [keyboard] Use the models from Config
- Remove code that is duplicated in Config.
- Hook up UI for physical keyboard model, and back.
- For now, introduce some named slots with debugging output.
  This makes debugging a lot easier since we have function names
  to work with rather than anonymous lambdas
6 years ago
Adriaan de Groot 168be02c96 [keyboard] Hook up the model-selection again 6 years ago
Adriaan de Groot 87aafb2442 [keyboard] Tear up connections between widgets and model 6 years ago
Adriaan de Groot 193efe1710 [keyboard] Restore the notion of PC105 default index 6 years ago
Adriaan de Groot 6aedf4401f [keyboard] Apply coding style 6 years ago
Adriaan de Groot 365a2ad6fd [keyboard] Re-do the keyboard physical models model from scratch 6 years ago
Adriaan de Groot a1c70b46a1 [keyboard] Typo in comment 6 years ago
Adriaan de Groot 5f1d7b2e8d [keyboard] Rename UI widgets to make code clearer 6 years ago
Adriaan de Groot d464e98e89 [keyboard] Move remaining variables to Config
- Config already *has* everythind, but drop the useless copies
  and duplicated code from the Page
- Plug the models model into the Page
- While here, document the model / layout / variant distinctions

The code doesn't fill the UI properly, and the drop-down
for the models combobox is not right, but at least the data
is shared.
6 years ago
Adriaan de Groot fe5757c7d1 [keyboard] Matching of layouts is very suspect 6 years ago
Adriaan de Groot 4f0d6a8f25 Merge branch 'calamares' into fix-keyboardq 6 years ago
Adriaan de Groot dca9ae0c93
Merge pull request #1553 from LordTermor/calamares
Initial additional layout support for non-ASCII layouts
6 years ago
Artem Grinev 4434e85d4d [keyboard] Simplified variable name 6 years ago
Artem Grinev 3552233bf1 [keyboard] Minor logic rework 6 years ago
Artem Grinev 6667ea834f [keyboard] Adjusted indents 6 years ago
Artem Grinev 996c82160e [keyboard] fixed typo 6 years ago
Adriaan de Groot 4a3273d634 [keyboard] Remove superfluous variable (set to true, never changed) 6 years ago
Artem Grinev bfc60ad2cf [keyboard] Implemented X11 config writing for additional layout 6 years ago
Artem Grinev 0dd027af90 [keyboard] Fixed condition bug 6 years ago
Artem Grinev 19b1fb3358 [keyboard] Added explanatory comment for xkbmap_query_grp_option 6 years ago
Artem Grinev 384b1ba8c6 [keyboard] Swapped primary and additional layouts in selection 6 years ago
Artem Grinev 354dc1613a [keyboard] Removed unnecessary repacking in xkbmap_layout_args 6 years ago
Artem Grinev 09b5e42734 [keyboard] Minor additional layout info rework 6 years ago
Artem Grinev 17b9647016 [keyboard] Support for additional layout if current layout is not ASCII-
capable in live system
6 years ago
Adriaan de Groot 8cf3bd23b9 [keyboardq] Remove superfluous variable (set to true, never changed) 6 years ago
Adriaan de Groot 734dbece8a [keyboardq] Fix include style, remove unnecessary declarations 6 years ago
Adriaan de Groot 0947cd8354 [keyboard] Migrate to Config::onActivate() which is badly-named 6 years ago
Adriaan de Groot 0ffa500432 [keyboard] Remove unused code
- this has already migrated to Config but had not been removed locally
6 years ago
Adriaan de Groot 35a2bd3f0f [keyboard] Use Config's own finalize() 6 years ago
Adriaan de Groot 14c079d1d6 [keyboard] Replace own copy of status by the one from Config 6 years ago
Adriaan de Groot acb5190217 [keyboard] Use Config methods rather than own copy
- this continues the port of the keyboard module to use the Config
  object, which was horribly botched earlier.
6 years ago
Adriaan de Groot 679f613955 [keyboard] Rename mysterious Config::init() to descriptive name 6 years ago
Adriaan de Groot a940be2bb4 [keyboardq] Load configuration into Config object 6 years ago
Adriaan de Groot 8142d6f86c [keyboardq] Drop unnecessary variable -- just use the Config status 6 years ago
Adriaan de Groot 98c7cec732 CMake: restore NOTREACHED, without the macro-mess
- gcc (up to at least version 10) is worse at recognizing that all
  cases have been handled, so it complains about all the switches
  that cover enum values.
6 years ago
demmm f6e6774f92 [keyboardq] fix build 6 years ago
Adriaan de Groot fea403186f [libcalamares] Search for balance between warnings and annotations
- CI's gcc is too old to analyse a switch() for completeness,
  so the CI build fails.
6 years ago
Adriaan de Groot 478c394d99 [partition] Don't needlessly expose a test symbol 6 years ago
Adriaan de Groot 2b9fa0f982 CMake: drop the NOTREACHED macro
- both clang and g++ support __builtin_unreachable(); (as Kevin
   Kofler pointed out) so we don't need the macro to do different things;
 - the compilers have gotten better at detecting unreachable code,
   so instead of inserting macros or fiddly bits, just drop them
   and the unreachable code they comment.
6 years ago
Adriaan de Groot 9a2fca7f5b CMake: prefer normal C++17 [[fallthrough]] annotation 6 years ago
Adriaan de Groot 7fa1c1b787 [libcalamares] Avoid object-slice
g++ warns that error_already_set is polymorphic, and we're catching
by-value (although we don't use that value). Avoid that.
6 years ago
Adriaan de Groot 84936a95fc [libcalamaresui] Warnings-- for Qt 5.15 deprecations
Introduce a GUI-oriented compatibility header that introduces aliases
for some enum values that are deprecated in Qt 5.15
6 years ago
Adriaan de Groot b28a50de6f [libcalamares] Remove useless variable
- describe() is for debugging purposes, doesn't need to calculate
  whether the requirements are accepted.
6 years ago
Adriaan de Groot 6c7d295712 CMake: simplify C and C++ flags
- reduce the difference between clang and g++ builds, factor
  common flags out of the CMake-if
- drop special boost-warning-suppression, we do that differently
  most of the time in the affected source files
6 years ago
Adriaan de Groot 27f6eaaf75 [partition] Remove unused variables 6 years ago
Adriaan de Groot 89b1f8d96b [partition] Warnings-- in tests related to virtual destructors 6 years ago
Adriaan de Groot 01b75ef4b5 [partition] Use C++-style cast 6 years ago
Adriaan de Groot 6605e11394 [partition] Warnings-- in test: don't expose internal variable 6 years ago
Adriaan de Groot cb2b53ebf3 Merge remote-tracking branch 'origin/issue-1515' into calamares 6 years ago
Adriaan de Groot d7e64de24a [partition] Adjust docs to function
- @params referring to things that don't exist
- @brief that is 3 lines long
6 years ago
Adriaan de Groot eb8e95bb87 [partition] Warnings--, explain why we're using a void* 6 years ago
Adriaan de Groot 9910b23152 [partition] Avoid uninitialized variable
- if the partition size is invalid, then warn about it but do
  not print the (uninitialized) size of the partition.
- shuffle code to continue earlier, allowing the "good path"
  code to be out-dented.
6 years ago
Adriaan de Groot 687a795b71 [partition] Warnings-- by initialization order 6 years ago
Adriaan de Groot 44a11bd93b [partition] Initialize in the initializer list, if possible 6 years ago
Adriaan de Groot 51b47862cd [partition] Mark destructors `override`
This reduces compiler warnings related to virtual-overriding
functions: all the destructors are virtual.
6 years ago
Adriaan de Groot aa6109d470 [machineid] Improve config-documentation 6 years ago
Adriaan de Groot daeee09fdb [machineid] Simplify loading of the list of entropy-files 6 years ago
Adriaan de Groot 275e6b9342
Merge pull request #1542 from gportay/fix-message-if-no-option-available
[partition] Fix message user if no option available
6 years ago
Adriaan de Groot 9e624c7bd5 [unpackfs] Fix schema validation
- the *weight* key was introduced without a corresponding schema
  change, so the examples didn't validate anymore.
6 years ago
Adriaan de Groot 0d4d3e3c4d [users] Set up GS rootMountPoint for test 6 years ago
Adriaan de Groot 63196ab58f [users] Avoid crashes in tests due to nullptr GS 6 years ago
Adriaan de Groot c412e285c2 [libcalamares] Link publicly to yaml-cpp
Needed on FreeBSD, where you otherwise might not get the
include paths for yaml-cpp added -- and utils/Yaml.h
expects them to be there.
6 years ago
Adriaan de Groot cd8c3089cb [users] Fix build: renamed moc file 6 years ago
Gaël PORTAY d91683eec6 [partition] Fix message user if no option available
The button m_eraseButton is not tested while the button
m_somethingElseButton is tested twice.
6 years ago
Adriaan de Groot 89d495d5fb [users] Rename file to match its purpose 6 years ago
Adriaan de Groot 5b4f9d0b98 [users] Adjust tests for changed API 6 years ago
Adriaan de Groot f1772a7eae [users] Create groups in a separate job 6 years ago
Adriaan de Groot 03541470d5 [users] Handle system-group creating specially 6 years ago
Adriaan de Groot fa1d314b13 [users] Refactor group-creation into separate Job 6 years ago
Adriaan de Groot 3d289f345a [users] Refactor users functionality to a static lib
- this makes it less fragile to share all the functionality
  with usersq, since it ends up in the library which is shared
  between the modules.
6 years ago
Adriaan de Groot 6560ef00a1 [usersq] Fix build of usersq after refactor elsewhere 6 years ago
Adriaan de Groot 29e6934672 [users] Factor out Sudo creation into separate job 6 years ago
Adriaan de Groot 0cb6c89876 [netinstall] Don't update selection state for items with no children
The special setup for nicely-named groups which have a single
hidden subgroup containing the actual packages, has the problem
that there is a non-empty subgroups item, but this results
in zero actual children: then the number of selected and partly
selected children is also zero in updateSelected() and therefore
the item ends up unselected.

Special-case this to avoid unnecessarily unselecting the item.
Reported by Vitor L.
6 years ago
Adriaan de Groot 328a5bbbfb [users] Don't allow continuing with an empty login name
The status for an empty login name is '' (empty), for ok -- this is
so that there is no complaint about it. But it's not ok to
continue with an empty name.
6 years ago
Adriaan de Groot 27dc81f8b9 [partition] Fix typo in debug message, reported by Kevin Kofler 6 years ago
Adriaan de Groot 4d3f20f4a7 [users] Don't allow continuing with an empty login name
The status for an empty login name is '' (empty), for ok -- this is
so that there is no complaint about it. But it's not ok to
continue with an empty name.
6 years ago
Adriaan de Groot 3313a5341d [partitions] Adapt to KPMcore 4.2 changes 6 years ago
Adriaan de Groot 36396d0cfd [partition] Adjust message and fix debug message 6 years ago
Adriaan de Groot ee302debdf
Merge pull request #1539 from yurchor/patch-3
[partition] Add missing space
6 years ago
Calamares CI 2be2e1808a i18n: [dummypythonqt] Automatic merge of Transifex translations 6 years ago
Adriaan de Groot 81f12cb230 [libcalamares] Do GeoIP lookups with a fake User-Agent 6 years ago
Adriaan de Groot 3b14e354b0 [libcalamares] Log more HTTP errors during requests 6 years ago
Adriaan de Groot 436e1de820 [libcalamares] Be more chatty in GeoIP test application 6 years ago
Yuri Chornoivan 1448a9b9a1
Add missing space 6 years ago
Adriaan de Groot 7734d84925 [shellprocess] Bump the default timeout to 30, emphasise tuning the timeout
FIXES #1536
6 years ago
Adriaan de Groot 0b61a02c31 [fstab] Avoid dd in creating a zeroed-file for swap
- Create a 16kiB buffer of zeroes
- write that out in a loop
6 years ago
Adriaan de Groot c7c7e6a6c1 [keyboard] Move configuration to the Config object
- information from the configuration file -> Config object
- job creation -> Config object

Ignore keyboardq for now.
6 years ago
Adriaan de Groot 0f6602cad7 [keyboard] Improve xkb parsing 6 years ago
Adriaan de Groot ec42e3294f [keyboard] Refactor argument-lists for setxkbmap
- separate functions for model, and layout+variant settings
6 years ago
Adriaan de Groot b54273f904 [keyboard] Move all the keyboard (AbstractList)Models to the models file 6 years ago
Adriaan de Groot 2911c789f9 [users] Fix up tests for login status
- an empty login name is "ok" even if it isn't -- there's no
  warning message in that case
6 years ago
Adriaan de Groot 89e279c96a [users] Set auto- and sudo-groups correctly
- Was updating GS only, not internals
- restructure all to update internals, then GS, then emit change signals
6 years ago
Adriaan de Groot f726634c2f [users] Fix tests for setting shell
- The EXPECT_FAIL value "Abort" stops the test (I wanted 'if this
  unexpectedly passes, raise an error' -- should have read the
  documentation more closely).
- Set the shell in the config object, not just in GS.
6 years ago
Adriaan de Groot 6b2d7f6a42 [users] Protect against JobQueue or GS being NULL
- Avoid SIGSEGV in tests, make sure JobQueue exists, GS optional
6 years ago
Adriaan de Groot 788a233319 [users] Introduce a test for Config getters and setters 6 years ago
Adriaan de Groot 58f10739e1 [users] Show progress during the module
- add a status member so the different steps can show progress
  as the user is created and configured. The progress values
  are hard-coded guesses as to how much work is done for each step.
- while here, reduce the scope of the global storage variable
6 years ago
Adriaan de Groot ef70b2c32e [users] Run CreateUserJob off of the Config object
- don't pass in copies or bits of the Config, hand over the whole Config
- don't pluck some parts of the Config from Global Storage
6 years ago
Adriaan de Groot 02e9872a99 [users] Handle detailed groups list
Groups can be specified with must_exist and/or system set,
so they fill in the groups list more carefully.
6 years ago
Adriaan de Groot a86374386b [users] Add test for new notation for groups-with-details 6 years ago
Adriaan de Groot 07027c2430 [users] Test distinguishes system groups from user groups 6 years ago
Adriaan de Groot ff9abdfc08 [users] The fallback groups are all **system** groups 6 years ago
Adriaan de Groot b20c80a28c [users] Introduce class-scoped aliases for true and false for the bools
This is somewhat experimental and weird; the idea is that bool
arguments are a lot easier to understand if there are proper
names attached, rather than "true" and "false".
6 years ago
Adriaan de Groot 1d696253c3 [displaymanager] Missing space in user-visible string due to line-breaks 6 years ago
Adriaan de Groot 61100f1a73 [netinstall] Massage the documentation a little 6 years ago
Adriaan de Groot 958fb7e7b0 [netinstall] Complain about nonsensical hidden groups 6 years ago
Adriaan de Groot f093789deb [netinstall] Complain about bad config
- it's easy to miss a  in hidden subgroups and other complex
  groups configurations, so complain loudly.
6 years ago
Adriaan de Groot ceeab7087c [users] Fix implementation so existing tests pass 6 years ago
Adriaan de Groot e46d9f735d [users] Adjust tests to changed groups-list 6 years ago
Adriaan de Groot d3135898fd [users] More fine-grained group descriptions
Describe groups with more detail:
 - groups can be system groups (low GID) or not
 - groups may be pre-configured (e.g. come from the unpackfs stage)
6 years ago
Adriaan de Groot 6221c6497a [shellprocess] Allow customizing the name of the job 6 years ago
Adriaan de Groot 21598ef4b3 [libcalamaresui] Update progress message only if it is non-empty
This improves the situation for jobs that do not provide
a status: their blank status does not overwrite the status
bar, and since (previous commit) the description or name
is used to start the job if the status is empty, at least
**something** is displayed.

SEE #1528
6 years ago
Adriaan de Groot 86fd014bbd [libcalamares] Fallback from status -> description -> name for progress 6 years ago
Adriaan de Groot 2f83d85e29 [libcalamares] Explain process failure in debug log a bit better 6 years ago
Adriaan de Groot 9c457f9449 [shellprocess] Improve documentation and examples 6 years ago
Adriaan de Groot a955791766 Apply coding style globally again 6 years ago
Adriaan de Groot 1df4239c02
Merge pull request #1436 from gportay/osprober-strip-extra-file-after-at-sign
[partition] Strip extra file after the at sign
6 years ago
Gaël PORTAY 2b1e516ec1 [partition] Strip extra file after the at sign
- os-proper may return an extra file after the device:
  /dev/sda1:Ubuntu 19.10 (19.10):Ubuntu:linux
  /dev/sdb1@/EFI/Microsoft/Boot/bootmgfw.efi:Windows Boot Manager:Windows:efi
6 years ago
Gaël PORTAY 2bbbb68838 [partition] Add setting for requiredPartitionTableType 6 years ago
Gaël PORTAY 70f8beb931 [partition] Add setting for defaultPartitionTableType 6 years ago
Adriaan de Groot 9486ee6fbf
Merge pull request #1524 from gportay/partition-message-user-if-no-option-available
[partition] Message user if no option available
6 years ago
Adriaan de Groot 9ce08beead [libcalamares] Fix build
- The API definitions are just the symbols to define; these
  are variously added through add_definitions() (needs -D)
  or target_add_definitions() (doesn't).
6 years ago
Adriaan de Groot 40aa0fcaba CMake: add a helper module for finding KPMcore
I think we had this (kind of) module a long time ago and it was
removed for over-complicating things; re-introduce one now that
KPMcore is used in 3 different places and all would benefit
from consistent API handling / defines.
6 years ago
Adriaan de Groot db537535ee [partition] Support KPMCore 3.3 in tests 6 years ago
Adriaan de Groot f28d28a455 [partition] Ignore KPMCore 4 beta versions 6 years ago
Adriaan de Groot 88b1d36009 Merge branch 'issues-1166' into calamares
FIXES #1166
6 years ago
Adriaan de Groot faa496be4a
Merge pull request #1522 from kadler15/issue-1521
[preservefiles] Fix global storage JSON dump
6 years ago
Corentin Noël a7bd1040c5 [partition] Add tests for Layout-constrained partionning 6 years ago
Adriaan de Groot 77e2701365 [partition] Coding style
- various clang-format versions battle for supremacy
6 years ago
Adriaan de Groot b4cbf73e2d Merge branch 'calamares' into issues-1166 6 years ago
Adriaan de Groot 0b3a6baeea [fstab] If swap is "file" then create it here
- handle swapfiles when writing /etc/fstab in the target system
  - special-case mountpoint
  - since swapfiles are not a partition, take the setting out
    of partitionChoices
- create the physical swapfile as well (there's no other place
  where it would make sense)
6 years ago
Adriaan de Groot 029c3f1c74 [partition] Write the install choices to Global Storage 6 years ago
Adriaan de Groot 92a874dae7 [partition] move the swap-choice to Config 6 years ago
Corentin Noël 08138f5a41 [partition] Reduce direct dependency of PartUtils on PartitionCoreModule 6 years ago
Adriaan de Groot 672e27564e [unpackfs] Also report progress every half-second, if possible
This still won't help if there's one really huge file that takes
several seconds to write, but if there's a bunch of files together
that is less than a file_chunk_count but take more than a half-
second to write, update anyway
6 years ago
Adriaan de Groot 57fa51ecd9 [unpackfs] Simplify progress reporting more
If there's thousands of files in a squashfs (e.g. 400000 like on
some ArcoLinux ISOs) then progress would be reported every
4000 files, which can take quite some time to write. Reduce
file_chunk_count to at most 500, so that progress is reported
more often even if that wouldn't lead to a visible change
in the percentage progress: instead we **do** get a change
in files-transferred numbers.

- The total weight is only needed by the UnpackOperation,
  not by each entry.
- Use a chunk size of 107 so that the number-complete seems busy:
  the whole larger-or-smaller chunk size doesn't really matter.
- The progress-report was missing the weight of the current
  module, so would report way too low if weight > 1. This affects
  ArcoLinux configurations where one entry is huge and one is a
  single file, so weights 50 and 1 are appropriate.
6 years ago
Adriaan de Groot bc591f9bc1 [unpackfs] Re-vamp progress reporting
- simplify calculation of progress
6 years ago
Adriaan de Groot 8173b68a71 [unpackfs] Debug-log the weights of the modules 6 years ago
Adriaan de Groot 632445a431 [unpackfs] Give entries a weight
When there are multiple entries, the overall weight of the
module is divided between the entries: currently each entry
takes an equal amount of space in the overall progress.

When there are multiple entries which take wildly different
amounts of time (e.g. a squash-fs and a single file) then
the progress overall looks weird: the squash-fs gets half
of this module's weight, and the single file does too.
With the new *weight* key for entries, that division can
be tweaked so that progress looks more "even".
6 years ago
Adriaan de Groot 44f8a7ae47 [libcalamares] Reduce chattiness again of job progress 6 years ago
Gaël PORTAY 79740c77a3 [partition] Message user if no option available 6 years ago
Kris Adler e92927cff9 [preservefiles] Fix global storage JSON dump
fixes calamares/calamares#1521
6 years ago
Adriaan de Groot ddf3b2d399 Merge branch 'debug-job-progress' into calamares
This makes things fairly chatty, especially again during
rsync, so will be dialed back before release.
6 years ago
Adriaan de Groot 6e30a7b8f6 [partition] Move is-manual-partitioning-allowed to the Config object 6 years ago
Adriaan de Groot f79fbd4105 [partition] Add swap choice to config object 6 years ago
Adriaan de Groot 0f4fe6294c [partition] Migrate type for SwapChoice to Config object 6 years ago
Adriaan de Groot 881661e94b [partition] Migrate InstallChoice to the Config object 6 years ago
Corentin Noël 0293015b09 [partition] Fix regression in partition size assignment
In some cases, the partition size was set to zero as the maxSize isn't always defined.
6 years ago
Adriaan de Groot 010526ee2a [partition] Coding style 6 years ago
Adriaan de Groot b41e4624c9 [partition] Move 'selected installation option' to Config 6 years ago
Adriaan de Groot 10d194d693 [partition] Simplify button-selection 6 years ago
Adriaan de Groot a92cb32cef [partition] set the right buttons if an action is pre-selected 6 years ago
Adriaan de Groot b518ef7dfe [partition] Select initial swap choice 6 years ago
Adriaan de Groot 9f0f600aa4 [partition] Remove the 'swapfile-unsupported' message 6 years ago
Adriaan de Groot 3bb5adcfca [partition] Simplify *efiSystemPartition* settings 6 years ago
Adriaan de Groot f155c8351b [partition] Only one setting for partitionLayout is supported 6 years ago
Adriaan de Groot b6dd23a384 Merge branch 'calamares' into issues-1166 6 years ago
Adriaan de Groot ace6323987 [libcalamares] Be even more chatty in job progress
This is for debugging-job-progress reports.
6 years ago
Adriaan de Groot 75b01cfc0a [libcalamares] Some debugging output for job progress, so you can double-check that the settings are being picked up 6 years ago
Adriaan de Groot ffed7b6d71 [partition] Warnings-- over QButtonGroup
- this was deprecated in 5.15 and an alternative introduced also
  in 5.15, so it's a pain in the butt for backwards-compatibility.
6 years ago
Adriaan de Groot 6b07bdf6ed [keyboard] Do not use deprecated Qt4-era indexChanged for text 6 years ago
Adriaan de Groot 02423c823d [libcalamaresui] Nothing uses the opacity for pixmaps, drop that too 6 years ago
Adriaan de Groot 268cf203a8 [libcalamaresui] Remove unused parameter/functionality
- nothing in Calamares uses the tinting, and it triggers some
  deprecation warnings, so just remove it.
6 years ago
Adriaan de Groot 2878c474c5 Warnings-- (~T() override)
Change all the places that had
	virtual ~T() override
to the less redundant form without override.
6 years ago
Adriaan de Groot 2126be6d6d Warnings-- (~T() override)
Consistently use
	~T() override;
in class declarations (so no virtual in front, and avoid
warnings due to the missing override in back).
6 years ago
Adriaan de Groot 7d5a209dd0 [modules] Warnings-- in tests (~Test() override) 6 years ago
Adriaan de Groot 8b66009d59 [libcalamares] Warnings-- in tests (~T() override) 6 years ago
Adriaan de Groot 0cffac10c6 [libcalamares] Ignore more warnings for system header YAML 6 years ago
Adriaan de Groot fbab554dfa [libcalamares] Remove unused parameter for PythonJob
- parameter instanceKey was left over from previous work that
  special-cased the weight of Python modules.
- while here, consistently do `~T() override`
6 years ago
Adriaan de Groot 8e9bf1c2a9 [libcalamaresui] Another allow-to-fall-back-to-eventloop
With 1 CPU, Calamares still spawns 9 threads or so: eventloop,
dbus loop, QML loop, ... many of those are invisible to the
application. Contention occurs on startup when the UI is constructed,
and we end up with the module manager creating widgets alongside,
or ahead of, the main window UI. This can result in deadlock:

 - in CalamaresApplication::initViewSteps
 - in QML imports

This is partly because the signal-slots connections get "deep":
from loadModules() we emit *modulesLoaded* which ends up showing
the main window in initViewSteps(). Avoid this with a QTimer:
drop back to the event loop and release whatever locks are held,
so the QML thread can get on with it already. Then the timer
goes off and the view steps are created.
6 years ago
Adriaan de Groot 705756b9bb [libcalamaresui] Give UI chance to catch up before modules are done 6 years ago
Adriaan de Groot 53cb27ebc8 [calamares] Provide i18n context for "Key" 6 years ago
Adriaan de Groot ac0b2092f2 [partition] Remove superfluous logging 6 years ago
Adriaan de Groot cadd9765db [usersq] Remove trailing . 6 years ago
Adriaan de Groot e37c7da60d [partition] Introduce dummy argument to LVM jobs
- Give LVM jobs a dummy argument Device* so that they
  fit the functionality of makeJob for partitioning.
  For those jobs that already take an LVMDevice*, this should
  be the self-same device, but that isn't checked.
6 years ago
Adriaan de Groot 1f77441333 [partition] add job-removal to the support classes 6 years ago
Corentin Noël 75fd1dd114 [partition] Correctly handle percentage-define partitions
* Use the minSize when the target storage is smaller than the sum of sizes
 * Percentage-defined partitions should be computed after setting hard-defined ones

This fixes issues when 0 byte partitions were created when the disk is too small.
Also fixes an issue with percent-defined partitions being forced to be defined at the end of the disk.
6 years ago
Adriaan de Groot e94c17e331 Merge branch 'calamares' into issues-1166 6 years ago
Adriaan de Groot c159ffe491 [machineid] Polish up the tests
- create dirs as needed (this will normally be done by
  unsquash, but for tests with paths it needs to be done
  by hand)
- log what file is being checked
- filePath() doesn't like the absolute paths we have
  (they're absolute in the chroot, and existing code
  just sticks rootMountPoint in front)
6 years ago
Adriaan de Groot 5f7c9a00a0 [machineid] Test that random-files are created 6 years ago
Adriaan de Groot a5887e6dda [machineid] Test config-settings for entropy files 6 years ago
Adriaan de Groot 8be5c2ed10 [machineid] Support multiple entropy files 6 years ago
Adriaan de Groot 8b22786bd2 Merge branch 'issue-1397' into calamares
Document keyboard change for Turkish F layout, and document
the keyboard configuration value better, with alternate
path used in e.g. openSUSE

FIXES #1397
6 years ago
Adriaan de Groot 633186778b [keyboard] Add test for Turkish F variant
- test keyboard lookup for "tr" - "f" variations
- add data mapping "tr" - "f" to legacy keymap "trf"

FIXES #1397
6 years ago
Adriaan de Groot aeffbac9cd CMake: add resources to tests
Some tests -- notably the keyboard module -- need to have the
QRC for the module loaded as well (e.g. because of data in the
QRC). Add a RESOURCES parameter to calamares_add_test()
like calamares_add_plugin() already has, to build the
resources into the test.

Keyboard test now passes, since it was missing the data for
lookups before.
6 years ago
Adriaan de Groot 2aece7ff1b [keyboard] Warn if QRC is not available 6 years ago
Adriaan de Groot 0d8e0d9b96 [keyboard] Add a stub for unit tests 6 years ago
Adriaan de Groot af3261b16f [keyboard] Refactor findLegacyKeymap into something testable 6 years ago
Adriaan de Groot 466e08a8ba [welcome] Set some localeConf values from the welcome page 6 years ago
Adriaan de Groot 634a53d27a [locale] Use new convenience function for updating localeConf 6 years ago
Adriaan de Groot e0ba5a6ba2 [libcalamares] Convenience functions for localeConf GS entry 6 years ago
Adriaan de Groot d94b9caba5 [libcalamaresui] Less mutex shenanigans 6 years ago
Adriaan de Groot 32649f78ea [libcalamares] Restore finish() slot to job queue
FIXES #1507
6 years ago
Adriaan de Groot d5eaacf67a i18n: used wrong list of languages
FIXES #1505
6 years ago
Adriaan de Groot ec0b68084f [users] Refactor setting GS
- both changing the autologin and changing the user (login) name
  affect global storage, and both may need to change the autologin
  username; split it into a free function.
- the fullname change was bypassing the login in changing the
  login name, **but** then it needs a back-workaround to keep
  the "custom" setting off (when custom is off, auto-fill username
  and hostname is active).
- after loading the config, fill GS already.
- when finalizing GS, get the autologin settings again.
6 years ago
Adriaan de Groot d7dc48d201 [users] Add now-obvious missed initialization
- start the checkbox off in the state from config
6 years ago
Adriaan de Groot 15b5ef467e [users] Hook up strong- and reuse- password checkboxes
- setup the visibility and initial checked-state of the reuse-user-
  password-for-root near where it gets connected; do similar
  for the require-strong-password
- squash the lambda slot into the regular slot: no sense in
  connecting twice to the same signal with the same receiver.
- only connect config->ui once
- only connect at all if the setting is visible (e.g. when weak
  passwords are allowed for the require-strong checkbox, or
  when root's password will be written for the reuse-password)
6 years ago
Adriaan de Groot d584a96335 [users] Improve naming of widget 6 years ago
Adriaan de Groot 3ae545c8b1 REUSE: qmldir file format doesn't leave space for license information 6 years ago
Adriaan de Groot ba2b52ed1d Merge branch 'fix-debugwindow-queue' into calamares
3.2.29 dropped the Job Queue information from the debug
window, this restores the list of names.
6 years ago
Adriaan de Groot b37a675657 [libcalamares] Reimplement JobQueue::queueChanged
- switch to QStringList as parameter, since consumers (that is,
  the debug dialog, which is what this is for) are interested
  just in the **names** of the jobs.
- to allow mutex locking in const methods, mark them mutable.
6 years ago