Warnings-- (~T() override)

Change all the places that had
	virtual ~T() override
to the less redundant form without override.

src/calamares/CalamaresWindow.h

@@ -28,7 +28,7 @@ class CalamaresWindow : public QWidget
     Q_OBJECT
 public:
     CalamaresWindow( QWidget* parent = nullptr );
-    virtual ~CalamaresWindow() override {}
+    ~CalamaresWindow() override {}
 
 public slots:
     /**

src/calamares/progresstree/ProgressTreeView.h

@@ -22,7 +22,7 @@ class ProgressTreeView : public QListView
     Q_OBJECT
 public:
     explicit ProgressTreeView( QWidget* parent = nullptr );
-    virtual ~ProgressTreeView() override;
+    ~ProgressTreeView() override;
 
     /**
      * @brief setModel assigns a model to this view.

src/calamares/testmain.cpp

@@ -140,7 +140,7 @@ public:
         , m_delay( t )
     {
     }
-    virtual ~ExecViewJob() override;
+    ~ExecViewJob() override;
 
     QString prettyName() const override { return m_name; }
 

src/libcalamares/ProcessJob.h

@@ -27,7 +27,7 @@ public:
                          bool runInChroot = false,
                          std::chrono::seconds secondsTimeout = std::chrono::seconds( 30 ),
                          QObject* parent = nullptr );
-    virtual ~ProcessJob() override;
+    ~ProcessJob() override;
 
     QString prettyName() const override;
     QString prettyStatusMessage() const override;

src/libcalamares/Tests.cpp

@@ -484,7 +484,7 @@ public:
         : Calamares::Job( parent )
     {
     }
-    virtual ~DummyJob() override;
+    ~DummyJob() override;
 
     QString prettyName() const override;
     Calamares::JobResult exec() override;

src/libcalamares/modulesystem/RequirementsChecker.h

@@ -34,7 +34,7 @@ class RequirementsChecker : public QObject
 
 public:
     RequirementsChecker( QVector< Module* > modules, RequirementsModel* model, QObject* parent = nullptr );
-    virtual ~RequirementsChecker() override;
+    ~RequirementsChecker() override;
 
 public Q_SLOTS:
     /// @brief Start checking all the requirements

src/libcalamares/network/Manager.h

@@ -99,7 +99,7 @@ public:
      * to keep the reference.
      */
     static Manager& instance();
-    virtual ~Manager() override;
+    ~Manager() override;
 
     /** @brief Checks if the given @p url returns data.
      *

src/libcalamares/utils/CalamaresUtilsSystem.h

@@ -126,7 +126,7 @@ public:
      * @param parent the QObject parent.
      */
     explicit System( bool doChroot, QObject* parent = nullptr );
-    virtual ~System() override;
+    ~System() override;
 
     static System* instance();
 

src/libcalamaresui/ViewManager.h

@@ -212,7 +212,7 @@ signals:
 
 private:
     explicit ViewManager( QObject* parent = nullptr );
-    virtual ~ViewManager() override;
+    ~ViewManager() override;
 
     void insertViewStep( int before, ViewStep* step );
     void updateButtonLabels();

src/libcalamaresui/modulesystem/CppJobModule.h

@@ -34,7 +34,7 @@ protected:
 
 private:
     explicit CppJobModule();
-    virtual ~CppJobModule() override;
+    ~CppJobModule() override;
 
     QPluginLoader* m_loader;
     job_ptr m_job;

src/libcalamaresui/modulesystem/ModuleManager.h

@@ -37,7 +37,7 @@ class ModuleManager : public QObject
     Q_OBJECT
 public:
     explicit ModuleManager( const QStringList& paths, QObject* parent = nullptr );
-    virtual ~ModuleManager() override;
+    ~ModuleManager() override;
 
     static ModuleManager* instance();
 

src/libcalamaresui/modulesystem/ProcessJobModule.h

@@ -33,7 +33,7 @@ protected:
 
 private:
     explicit ProcessJobModule();
-    virtual ~ProcessJobModule() override;
+    ~ProcessJobModule() override;
 
     QString m_command;
     QString m_workingPath;

src/libcalamaresui/modulesystem/PythonJobModule.h

@@ -30,7 +30,7 @@ protected:
 
 private:
     explicit PythonJobModule();
-    virtual ~PythonJobModule() override;
+    ~PythonJobModule() override;
 
     QString m_scriptFileName;
     QString m_workingPath;

src/libcalamaresui/modulesystem/ViewModule.h

@@ -37,7 +37,7 @@ protected:
 
 private:
     explicit ViewModule();
-    virtual ~ViewModule() override;
+    ~ViewModule() override;
 
     QPluginLoader* m_loader;
     ViewStep* m_viewStep = nullptr;

src/libcalamaresui/viewpages/BlankViewStep.h

@@ -29,7 +29,7 @@ public:
                             const QString& description,
                             const QString& details = QString(),
                             QObject* parent = nullptr );
-    virtual ~BlankViewStep() override;
+    ~BlankViewStep() override;
 
     QString prettyName() const override;
 

src/libcalamaresui/viewpages/QmlViewStep.h

@@ -50,7 +50,7 @@ public:
      * @see Qml.h for available Calamares internals.
      */
     QmlViewStep( QObject* parent = nullptr );
-    virtual ~QmlViewStep() override;
+    ~QmlViewStep() override;
 
     virtual QString prettyName() const override;
 

src/libcalamaresui/viewpages/Slideshow.h

@@ -91,7 +91,7 @@ class SlideshowQML : public Slideshow
     Q_OBJECT
 public:
     SlideshowQML( QWidget* parent );
-    virtual ~SlideshowQML() override;
+    ~SlideshowQML() override;
 
     QWidget* widget() override;
     void changeSlideShowState( Action a ) override;
@@ -123,7 +123,7 @@ class SlideshowPictures : public Slideshow
     Q_OBJECT
 public:
     SlideshowPictures( QWidget* parent );
-    virtual ~SlideshowPictures() override;
+    ~SlideshowPictures() override;
 
     QWidget* widget() override;
     virtual void changeSlideShowState( Action a ) override;

src/libcalamaresui/viewpages/ViewStep.h

@@ -41,7 +41,7 @@ class UIDLLEXPORT ViewStep : public QObject
     Q_OBJECT
 public:
     explicit ViewStep( QObject* parent = nullptr );
-    virtual ~ViewStep() override;
+    ~ViewStep() override;
 
     /** @brief Human-readable name of the step
      *

src/libcalamaresui/widgets/ClickableLabel.h

@@ -32,7 +32,7 @@ class UIDLLEXPORT ClickableLabel : public QLabel
 public:
     explicit ClickableLabel( QWidget* parent = nullptr );
     explicit ClickableLabel( const QString& text, QWidget* parent = nullptr );
-    virtual ~ClickableLabel() override;
+    ~ClickableLabel() override;
 
 signals:
     void clicked();

src/libcalamaresui/widgets/FixedAspectRatioLabel.h

@@ -19,7 +19,7 @@ class FixedAspectRatioLabel : public QLabel
     Q_OBJECT
 public:
     explicit FixedAspectRatioLabel( QWidget* parent = nullptr );
-    virtual ~FixedAspectRatioLabel() override;
+    ~FixedAspectRatioLabel() override;
 
 public slots:
     void setPixmap( const QPixmap& pixmap );

src/modules/contextualprocess/ContextualProcessJob.h

@@ -26,7 +26,7 @@ class PLUGINDLLEXPORT ContextualProcessJob : public Calamares::CppJob
 
 public:
     explicit ContextualProcessJob( QObject* parent = nullptr );
-    virtual ~ContextualProcessJob() override;
+    ~ContextualProcessJob() override;
 
     QString prettyName() const override;
 

src/modules/dracutlukscfg/DracutLuksCfgJob.h

@@ -26,7 +26,7 @@ class PLUGINDLLEXPORT DracutLuksCfgJob : public Calamares::CppJob
 
 public:
     explicit DracutLuksCfgJob( QObject* parent = nullptr );
-    virtual ~DracutLuksCfgJob() override;
+    ~DracutLuksCfgJob() override;
 
     QString prettyName() const override;
 

src/modules/dummycpp/DummyCppJob.h

@@ -26,7 +26,7 @@ class PLUGINDLLEXPORT DummyCppJob : public Calamares::CppJob
 
 public:
     explicit DummyCppJob( QObject* parent = nullptr );
-    virtual ~DummyCppJob() override;
+    ~DummyCppJob() override;
 
     QString prettyName() const override;
 

src/modules/finished/FinishedViewStep.h

@@ -36,7 +36,7 @@ public:
     static QString modeName( RestartMode m );
 
     explicit FinishedViewStep( QObject* parent = nullptr );
-    virtual ~FinishedViewStep() override;
+    ~FinishedViewStep() override;
 
     QString prettyName() const override;
 

src/modules/fsresizer/ResizeFSJob.h

@@ -33,7 +33,7 @@ class PLUGINDLLEXPORT ResizeFSJob : public Calamares::CppJob
 
 public:
     explicit ResizeFSJob( QObject* parent = nullptr );
-    virtual ~ResizeFSJob() override;
+    ~ResizeFSJob() override;
 
     QString prettyName() const override;
 

src/modules/hostinfo/HostInfoJob.h

@@ -43,7 +43,7 @@ class PLUGINDLLEXPORT HostInfoJob : public Calamares::CppJob
 
 public:
     explicit HostInfoJob( QObject* parent = nullptr );
-    virtual ~HostInfoJob() override;
+    ~HostInfoJob() override;
 
     QString prettyName() const override;
 

src/modules/initcpio/InitcpioJob.h

@@ -23,7 +23,7 @@ class PLUGINDLLEXPORT InitcpioJob : public Calamares::CppJob
 
 public:
     explicit InitcpioJob( QObject* parent = nullptr );
-    virtual ~InitcpioJob() override;
+    ~InitcpioJob() override;
 
     QString prettyName() const override;
 

src/modules/initramfs/InitramfsJob.h

@@ -23,7 +23,7 @@ class PLUGINDLLEXPORT InitramfsJob : public Calamares::CppJob
 
 public:
     explicit InitramfsJob( QObject* parent = nullptr );
-    virtual ~InitramfsJob() override;
+    ~InitramfsJob() override;
 
     QString prettyName() const override;
 

src/modules/interactiveterminal/InteractiveTerminalViewStep.h

@@ -26,7 +26,7 @@ class PLUGINDLLEXPORT InteractiveTerminalViewStep : public Calamares::ViewStep
 
 public:
     explicit InteractiveTerminalViewStep( QObject* parent = nullptr );
-    virtual ~InteractiveTerminalViewStep() override;
+    ~InteractiveTerminalViewStep() override;
 
     QString prettyName() const override;
 

src/modules/keyboard/KeyboardViewStep.h

@@ -25,7 +25,7 @@ class PLUGINDLLEXPORT KeyboardViewStep : public Calamares::ViewStep
 
 public:
     explicit KeyboardViewStep( QObject* parent = nullptr );
-    virtual ~KeyboardViewStep() override;
+    ~KeyboardViewStep() override;
 
     QString prettyName() const override;
     QString prettyStatus() const override;

src/modules/license/LicenseViewStep.h

@@ -27,7 +27,7 @@ class PLUGINDLLEXPORT LicenseViewStep : public Calamares::ViewStep
 
 public:
     explicit LicenseViewStep( QObject* parent = nullptr );
-    virtual ~LicenseViewStep() override;
+    ~LicenseViewStep() override;
 
     QString prettyName() const override;
 

src/modules/license/LicenseWidget.h

@@ -24,7 +24,7 @@ class LicenseWidget : public QWidget
 {
 public:
     LicenseWidget( LicenseEntry e, QWidget* parent = nullptr );
-    virtual ~LicenseWidget() override;
+    ~LicenseWidget() override;
 
     void retranslateUi();
 

src/modules/locale/LocaleViewStep.h

@@ -27,7 +27,7 @@ class PLUGINDLLEXPORT LocaleViewStep : public Calamares::ViewStep
 
 public:
     explicit LocaleViewStep( QObject* parent = nullptr );
-    virtual ~LocaleViewStep() override;
+    ~LocaleViewStep() override;
 
     QString prettyName() const override;
     QString prettyStatus() const override;

src/modules/luksbootkeyfile/LuksBootKeyFileJob.h

@@ -25,7 +25,7 @@ class PLUGINDLLEXPORT LuksBootKeyFileJob : public Calamares::CppJob
     Q_OBJECT
 public:
     explicit LuksBootKeyFileJob( QObject* parent = nullptr );
-    virtual ~LuksBootKeyFileJob() override;
+    ~LuksBootKeyFileJob() override;
 
     QString prettyName() const override;
 

src/modules/machineid/MachineIdJob.h

@@ -29,7 +29,7 @@ class PLUGINDLLEXPORT MachineIdJob : public Calamares::CppJob
 
 public:
     explicit MachineIdJob( QObject* parent = nullptr );
-    virtual ~MachineIdJob() override;
+    ~MachineIdJob() override;
 
     QString prettyName() const override;
 

src/modules/netinstall/NetInstallViewStep.h

@@ -28,7 +28,7 @@ class PLUGINDLLEXPORT NetInstallViewStep : public Calamares::ViewStep
 
 public:
     explicit NetInstallViewStep( QObject* parent = nullptr );
-    virtual ~NetInstallViewStep() override;
+    ~NetInstallViewStep() override;
 
     QString prettyName() const override;
 

src/modules/notesqml/NotesQmlViewStep.h

@@ -22,7 +22,7 @@ class PLUGINDLLEXPORT NotesQmlViewStep : public Calamares::QmlViewStep
 
 public:
     NotesQmlViewStep( QObject* parent = nullptr );
-    virtual ~NotesQmlViewStep() override;
+    ~NotesQmlViewStep() override;
 
     QString prettyName() const override;
 

src/modules/oemid/OEMViewStep.cpp

@@ -32,7 +32,7 @@ public:
         CALAMARES_RETRANSLATE( m_ui->retranslateUi( this ); )
     }
 
-    virtual ~OEMPage() override;
+    ~OEMPage() override;
 
     Ui_OEMPage* m_ui;
 };

src/modules/oemid/OEMViewStep.h

@@ -25,7 +25,7 @@ class PLUGINDLLEXPORT OEMViewStep : public Calamares::ViewStep
 
 public:
     explicit OEMViewStep( QObject* parent = nullptr );
-    virtual ~OEMViewStep() override;
+    ~OEMViewStep() override;
 
     QString prettyName() const override;
     QString prettyStatus() const override;

src/modules/packagechooser/PackageChooserViewStep.h

@@ -29,7 +29,7 @@ class PLUGINDLLEXPORT PackageChooserViewStep : public Calamares::ViewStep
 
 public:
     explicit PackageChooserViewStep( QObject* parent = nullptr );
-    virtual ~PackageChooserViewStep() override;
+    ~PackageChooserViewStep() override;
 
     QString prettyName() const override;
 

src/modules/packagechooser/PackageModel.h

@@ -88,7 +88,7 @@ class PackageListModel : public QAbstractListModel
 public:
     PackageListModel( PackageList&& items, QObject* parent );
     PackageListModel( QObject* parent );
-    virtual ~PackageListModel() override;
+    ~PackageListModel() override;
 
     /** @brief Add a package @p to the model
      *

src/modules/partition/gui/PartitionBarsView.h

@@ -34,7 +34,7 @@ public:
     };
 
     explicit PartitionBarsView( QWidget* parent = nullptr );
-    virtual ~PartitionBarsView() override;
+    ~PartitionBarsView() override;
 
     void setNestedPartitionsMode( NestedPartitionsMode mode );
 

src/modules/partition/gui/PartitionLabelsView.h

@@ -28,7 +28,7 @@ class PartitionLabelsView : public QAbstractItemView
     Q_OBJECT
 public:
     explicit PartitionLabelsView( QWidget* parent = nullptr );
-    virtual ~PartitionLabelsView() override;
+    ~PartitionLabelsView() override;
 
     QSize minimumSizeHint() const override;
 

src/modules/partition/gui/PartitionViewStep.h

@@ -40,7 +40,7 @@ class PLUGINDLLEXPORT PartitionViewStep : public Calamares::ViewStep
 
 public:
     explicit PartitionViewStep( QObject* parent = nullptr );
-    virtual ~PartitionViewStep() override;
+    ~PartitionViewStep() override;
 
     QString prettyName() const override;
     QWidget* createSummaryWidget() const override;

src/modules/partition/tests/PartitionJobTests.h

@@ -27,7 +27,7 @@ class QueueRunner : public QObject
 {
 public:
     QueueRunner( Calamares::JobQueue* queue );
-    virtual ~QueueRunner() override;
+    ~QueueRunner() override;
 
     /**
      * Synchronously runs the queue. Returns true on success

src/modules/plasmalnf/PlasmaLnfJob.h

@@ -21,7 +21,7 @@ class PlasmaLnfJob : public Calamares::Job
 
 public:
     explicit PlasmaLnfJob( const QString& lnfPath, const QString& id );
-    virtual ~PlasmaLnfJob() override;
+    ~PlasmaLnfJob() override;
 
     QString prettyName() const override;
     QString prettyStatusMessage() const override;

src/modules/plasmalnf/PlasmaLnfViewStep.h

@@ -26,7 +26,7 @@ class PLUGINDLLEXPORT PlasmaLnfViewStep : public Calamares::ViewStep
 
 public:
     explicit PlasmaLnfViewStep( QObject* parent = nullptr );
-    virtual ~PlasmaLnfViewStep() override;
+    ~PlasmaLnfViewStep() override;
 
     QString prettyName() const override;
 

src/modules/preservefiles/PreserveFiles.h

@@ -41,7 +41,7 @@ class PLUGINDLLEXPORT PreserveFiles : public Calamares::CppJob
 
 public:
     explicit PreserveFiles( QObject* parent = nullptr );
-    virtual ~PreserveFiles() override;
+    ~PreserveFiles() override;
 
     QString prettyName() const override;
 

src/modules/removeuser/RemoveUserJob.h

@@ -23,7 +23,7 @@ class PLUGINDLLEXPORT RemoveUserJob : public Calamares::CppJob
 
 public:
     explicit RemoveUserJob( QObject* parent = nullptr );
-    virtual ~RemoveUserJob() override;
+    ~RemoveUserJob() override;
 
     QString prettyName() const override;
 

src/modules/shellprocess/ShellProcessJob.h

@@ -27,7 +27,7 @@ class PLUGINDLLEXPORT ShellProcessJob : public Calamares::CppJob
 
 public:
     explicit ShellProcessJob( QObject* parent = nullptr );
-    virtual ~ShellProcessJob() override;
+    ~ShellProcessJob() override;
 
     QString prettyName() const override;
 

src/modules/summary/SummaryViewStep.h

@@ -25,7 +25,7 @@ class PLUGINDLLEXPORT SummaryViewStep : public Calamares::ViewStep
 
 public:
     explicit SummaryViewStep( QObject* parent = nullptr );
-    virtual ~SummaryViewStep() override;
+    ~SummaryViewStep() override;
 
     QString prettyName() const override;
 

src/modules/tracking/TrackingViewStep.h

@@ -29,7 +29,7 @@ class PLUGINDLLEXPORT TrackingViewStep : public Calamares::ViewStep
 
 public:
     explicit TrackingViewStep( QObject* parent = nullptr );
-    virtual ~TrackingViewStep() override;
+    ~TrackingViewStep() override;
 
     QString prettyName() const override;
 

src/modules/users/UsersViewStep.h

@@ -27,7 +27,7 @@ class PLUGINDLLEXPORT UsersViewStep : public Calamares::ViewStep
 
 public:
     explicit UsersViewStep( QObject* parent = nullptr );
-    virtual ~UsersViewStep() override;
+    ~UsersViewStep() override;
 
     QString prettyName() const override;
 

src/modules/webview/WebViewStep.h

@@ -41,7 +41,7 @@ class PLUGINDLLEXPORT WebViewStep : public Calamares::ViewStep
 
 public:
     explicit WebViewStep( QObject* parent = nullptr );
-    virtual ~WebViewStep() override;
+    ~WebViewStep() override;
 
     QString prettyName() const override;
 

src/modules/welcome/WelcomeViewStep.h

@@ -37,7 +37,7 @@ class PLUGINDLLEXPORT WelcomeViewStep : public Calamares::ViewStep
 
 public:
     explicit WelcomeViewStep( QObject* parent = nullptr );
-    virtual ~WelcomeViewStep() override;
+    ~WelcomeViewStep() override;
 
     QString prettyName() const override;