6720 Commits (ddcfd861cc0c40dde9e4327014c73ca5c7aa7657)

Author SHA1 Message Date
Adriaan de Groot 6bf82e9c65 [welcome] Update .conf documentation
- fix typo
- don't suggest google as internetCheckUrl
- mark TODOs for #1384
4 years ago
Anubhav Choudhary 9738851261 YAML list for uploadServer key 4 years ago
Anubhav Choudhary 7057081bdf QUrl for serverURL + renames 4 years ago
Adriaan de Groot e49f0cf3ba [libcalamares] Document NamedEnum in much more detail 4 years ago
Adriaan de Groot 04f4441182 [netinstall] Build up a list of urls, rather than just one
- the list is unused, and doesn't drive the loading of groups either;
  the existing one-string entry is used.
4 years ago
Adriaan de Groot ca1ae6fd1d [netinstall] Support retranslation in the Config object 4 years ago
Adriaan de Groot 335ccbc149 [netinstall] Move other translation parts to Config 4 years ago
Adriaan de Groot cf7391696e [netinstall] Continue moving settings to the Config object 4 years ago
Adriaan de Groot f045e4f00e [libcalamares] Switch default language in Belarus
*If* the distro has GeoIP enabled and auto-selects the language for
Calamares, then Belarus now selects Russian, rather the Belarusian.
This is based on some personal input, mostly, and Wikipedia census data.

FIXES #1634
4 years ago
Chrysostomus 16eff98a06 Don't use f-strings yet. 4 years ago
Chrysostomus 0c92a36a53 Remove unnecessary comment 4 years ago
Chrysostomus 6d55005da0 Mount subvolumes to correct mountpoints 4 years ago
Chrysostomus b16bd6bb23 Fix name error 4 years ago
Chrysostomus 67aedd5582 Move comments closer to where they are used 4 years ago
Chrysostomus 16bf7925a2 Adjust comments 4 years ago
Chrysostomus 1896a38ccc Fix a typo 4 years ago
Chrysostomus 1e0295dc65 Fix name error 4 years ago
Adriaan de Groot 84240683f5 [finished] Apply coding style 4 years ago
Adriaan de Groot cb4248e56d [finished] Move config from viewstep to config object
- the configuration is still duplicated in the widget, and
  functionality still needs to move to the Config object
- the ViewStep is cut down to almost nothing
4 years ago
Adriaan de Groot c82b802f4e [libcalamares] Typo in documentation 4 years ago
Adriaan de Groot 4ae3a7af61 [finished] Start Config-ification
- Introduce a Config class with suitable properties for use in QML,
  read configuration; this is unused right now.
4 years ago
Adriaan de Groot b8a9c4c3b7 [users] Be more forgiving in tests
- the host system's /etc/group is being read, and that varies between
  host OS versions; since I was doing today's release on KaOS, the
  test was failing because of arbitrary differences between the
  default groups on each Linux flavor.
4 years ago
Adriaan de Groot 144b51f00e [partition] Use automount control
FIXES #1604

(Admittedly, this fixes the problem only when there's Plasma Solid automount
present, and not any of the other kinds; but none of those have been reported
yet, and adding them into AutoMount.cpp is opaque to the rest of the
system)
4 years ago
Adriaan de Groot 17f73b1294 [partition] Test automount job in a queue 4 years ago
Adriaan de Groot 38fa1d9567 [libcalamares] Distinguish logging raw, shared and unique pointers
- It shouldn't be necessary to explicitly .get() pointers for
  logging, and it's convenient to know when a pointer is smart.
  * no annotation means raw (e.g. @0x0)
  * S means shared
  * U means unique
4 years ago
Adriaan de Groot c43a6ab866 [partition] Improve logging in automount test
- switch logging in job to VERBOSE because we don't want to be printing
  pointers to the regular session log
- switch logging in test to VERBOSE to actually see the messages from the Job
- hook the test into the build
4 years ago
Adriaan de Groot c98a330bf9 [libcalamares] Store DBus reply value, drop debug-logging 4 years ago
Adriaan de Groot aae815cf3b [partition] Add trivial test for automount management job 4 years ago
Chrysostomus fcf6e2fb25 fix typos 4 years ago
Adriaan de Groot 1704ad5977 [partition] Add a job to handle automount behavior
- while here, nudge CalamaresUtils automount API a little,
  since it doesn't really need an rvalue-ref.
4 years ago
Adriaan de Groot f3752e200a [libcalamaresui] Display first 6, last 2 lines of long error messages, preserve newlines 4 years ago
Adriaan de Groot b9210721e6 Merge branch 'issue-1613' into calamares
The popup now cuts down messages to a manageable length.
Hopefully the part that is preserved, will still show
something meaningful for the user (8 lines of text should
be sufficient for the kind of things we do).

FIXES #1613
4 years ago
Adriaan de Groot eafb8149b3 [libcalamares] Test some degenerate truncation cases 4 years ago
Adriaan de Groot a383aa974a [users] Need <memory> for unique_ptr
- Although unique_ptr is only used when ICU is enabled, include it
  always because it is likely that we'll use more unique_ptr
  in the implementation at some point.
4 years ago
Adriaan de Groot caff0176b1 [libcalamares] Need <memory> for unique_ptr
FIXES #1631
4 years ago
Neal Gompa e56bdd019f modules/bootloader: Use the correct names for the shim binaries
Ever since signed shim binaries for multiple architectures became
available, the shim binaries installed in Linux distributions have
been renamed to include the EFI architecture in the binary names.

This started in Fedora, but is now used in openSUSE and Ubuntu too.

Reference for shim binary names comes from shim spec in Fedora:

d8c3c8e392/f/shim.spec (_23-32)
4 years ago
Adriaan de Groot 7ab9c63903 [libcalamares] Extend test with some degenerate cases 4 years ago
Adriaan de Groot 5c402ffd66 [libcalamares] Truncate to a character count as well 4 years ago
Adriaan de Groot 1542bad224 [libcalamares] Truncate strings without trailing newline properly 4 years ago
Adriaan de Groot 8e3ed3c933 [libcalamares] Remove redundant variable, use NEWLINE instead of character-literal 4 years ago
Adriaan de Groot 3623e9aefc [libcalamares] Extend tests of string-truncation 4 years ago
Adriaan de Groot b85e5b52c2 [libcalamaresui] Apply coding style
- Some minor bits snuck in with the string-truncation code
- While here, make UPDATE_BUTTON_PROPERTY more statement-like
  so it doesn't confuse code-formatters.
4 years ago
Adriaan de Groot db5f3bc309 Merge branch 'issue-1613' into calamares 4 years ago
Adriaan de Groot 319a720d1b [libcalamares Expand tests 4 years ago
Adriaan de Groot b144d81979 [libcalamares] Fix up smart-string-truncation
- off-by-one when source ends with a newline
- lastNewLine was being calculated as a left-index into the string,
  then used as a count-from-right
4 years ago
Adriaan de Groot 3be360e433 [libcalamares] Add tests to string truncation
- check that basic manipulations succeed
- trailing-lines selection fails, though
4 years ago
Adriaan de Groot 8cc114bf2c [libcalamares] Move smart-string-truncation to library
Expand the API a little to support first-lines, last-lines,
and something of both. Use strong types to make the names
clear for each.
4 years ago
benne-dee f8385d2cb8
Fix https in URL 4 years ago
benne-dee 13181a52ee
Define schema for groups in netinstall.schema.yaml 4 years ago
Chrysostomus 8c0c84f162 Create all fstab entries one way instead of having special handling 4 years ago
benne-dee 938edf5bd6
Create shellprocess.schema.yaml 4 years ago
Chrysostomus 14fbbd92dc Get configured subvolumes from the global storage 4 years ago
Chrysostomus 092374d08c Add modified list to global storage 4 years ago
Chrysostomus f53f43ad03 Remove some unnecessary bits 4 years ago
Chrysostomus 4b6718b354 Further generalize subvolume handling 4 years ago
Chrysostomus 942221c764 Generalize subvolume handling 4 years ago
Chrysostomus 945effb048 Amend subvolumes to include path 4 years ago
Chrysostomus b5cfa5109e Add schema definition 4 years ago
Chrysostomus 4ab30569c2 Add default configuration 4 years ago
Adriaan de Groot 4f78afe67e [libcalamaresui] Display a reduced amount of details
Cut the error message from down to a maximum of 8 lines
so that the messagebox does not hopelessly overflow.
4 years ago
Adriaan de Groot f0fd47eeb3 [libcalamares] Simplify logging-manipulators
Writing `Logger::NoQuote{}`` has annoyed me for a while, so
switch it to a constant, like SubEntry, so it looks more
like a regular manipulator object.
4 years ago
Adriaan de Groot c1064c5e08
Merge pull request #1597 from Chrysostomus/btrfs-swap
[fstab][mount] Btrfs swapfile handling
4 years ago
Anubhav Choudhary b4078f3634 Changed branding keynames + minor fixes 4 years ago
Anubhav Choudhary 186c065b4c PasteURL sent to clipboard 4 years ago
Anubhav Choudhary a2c930a714 Code-formatted and Copyright-text added 4 years ago
Anubhav Choudhary ff66e4b3d5 Redirecting logUpload vars to pasteUtility 4 years ago
Anubhav Choudhary f6cb879929 branding.desc updated 4 years ago
Adriaan de Groot 9a4c599e22 [libcalamares] Tidy logging a little for Python errors 4 years ago
Adriaan de Groot 6978ce3cb4 [partition] Collect more kpmcore 4.2 code 4 years ago
Adriaan de Groot 520f08bbba [partition] Fix build with legacy kpmcore 4 years ago
Adriaan de Groot 31bf38977e [partition] Refactor partition-labeling 4 years ago
Adriaan de Groot 3ade1fd84a Merge branch 'add-automount-control' into calamares 4 years ago
Adriaan de Groot b709ba7a5b
Merge pull request #1590 from deprov447/Back/Next_buttons_at_installation
Navigation buttons hideability during installation
4 years ago
Adriaan de Groot 9482935034
Merge pull request #1572 from gportay/partition-output-more-things-in-overiew
[partition] output more things in overiew
4 years ago
Adriaan de Groot 478af25cec
Merge pull request #1571 from gportay/unpackfs-skip-overlay-extended-attributes
[unpackfs] Skip overlay extended attributes
4 years ago
Anubhav Choudhary 0ff32784d1 hooked backAndNextVisible signal to nonQML navigation 4 years ago
Anubhav Choudhary a9539018e9 [fixed] backAndNextVisbility logic 4 years ago
Gaël PORTAY af5c57a713 [partition] Output filesystem features in overview 4 years ago
Gaël PORTAY c045af1975 [partition] Output GPT entries in overview 4 years ago
Gaël PORTAY bf9c9a64f1 [libcalamares] Introduce new function getPartitionTable 4 years ago
Adriaan de Groot 132ff59d9c [libcalamares] Make running commands less chatty
If there's no output, don't mention it; don't mention failure modes
if the command was successful.
4 years ago
Adriaan de Groot a3eae323f1 [libcalamares] Rename test-executable: avoid clashes with 'cala<tab>' 4 years ago
Adriaan de Groot d74bdbcfd0 [libcalamares] coding-style, logging in calautomount 4 years ago
Adriaan de Groot 3150785ff1 [libcalamares] Use shared_ptr instead of unique_ptr
The value inside a unique_ptr can't be opaque, it needs to be known
at any site where the pointer may be deleted. shared_ptr does not
have that (deletion is part of the shared_ptr object, which is larger
than the unique_ptr) and so can be used for opaque deletions.
4 years ago
Adriaan de Groot 1c4bf58fb4 [libcalamares] automount-manipulation test-program 4 years ago
Adriaan de Groot f0a33a235c [libcalamares] Make automountDisable() more flexible 4 years ago
Adriaan de Groot 9e6bddf31a [partition] Add new AutoMount-manipulating helpers 4 years ago
Adriaan de Groot 1c285f011b [libcalamares] Export partition-syncer symbols 4 years ago
Adriaan de Groot c963d8905f [netinstall] Merge the two descriptions of *immutable* 4 years ago
Chrysostomus 271122865f define global storage 4 years ago
Adriaan de Groot 2ccd5a2043 Docs: explain about loadmodule
The Python-specific `testmodule.py` was replaced by the more
general `loadmodule`.

FIXES #1596
4 years ago
Anubhav Choudhary e3a41571f0 Spacing added 4 years ago
Chrysostomus 727f7859b7 Mount @swap to /swap when needed 4 years ago
Chrysostomus b180cbd47d Generate a subvolume for swap if swapfile is used 4 years ago
Chrysostomus 97eb32bf5c Correct the path of swapfile on btrfs 4 years ago
Chrysostomus 80a538665e Generate entry for subvolume @swap 4 years ago
Chrysostomus 3f0612b4ad Use different location for swapfile on btrfs root 4 years ago
Anubhav Choudhary 0f2320bd47 Initializing bools in settings.h 4 years ago
Anubhav Choudhary 03d1fe434c Navigation button hideability added 4 years ago
Chrysostomus 59cfdcccdf Use variable instead of a function 4 years ago
Chrysostomus 0ed0d37693 Don't use plymouth-encrypt if there is keyfile in use, because it is buggy and asks for password even when it is not needed 4 years ago
Adriaan de Groot 06c6ea04c0 [users] Make status message consistent (no .) 4 years ago
Calamares CI 3c14d7092a i18n: [dummypythonqt] Automatic merge of Transifex translations 4 years ago
Adriaan de Groot a93e96da7c [branding] Restore dropped https 4 years ago
Anubhav Choudhary e8238ca713 Name added in copyright section 4 years ago
Anubhav Choudhary a4c759355b [Fix] WelcomePage links
"Generic support" and "Known Issues" links fixed
4 years ago
Adriaan de Groot f4133a97db [libcalamares] Make test a bit more verbose (before failing) 4 years ago
Adriaan de Groot fa7d2bda16 [libcalamares] Misplaced space in a test-filename 4 years ago
Adriaan de Groot 1f21b9ad73 [dracutlukscfg] Const data
The QLatin1String() might be replaced by char[], that trades one
initialization for two but with a simpler data section; this
probably is not worth profiling.
4 years ago
Adriaan de Groot 1f0aec5f87 [dracutlukscfg] Job-internal constant data doesn't need to be a member 4 years ago
Adriaan de Groot d2c7c42aec [dracutlukscfg] More static methods -> free functions 4 years ago
Adriaan de Groot 6d02bab098 [dracutlukscfg] static methods -> free functions
These methods don't touch anything in the class, and are more safely
tucked away as static (TU-local) free functions.
4 years ago
Adriaan de Groot 6df3c023c8 [luksbootkeyfile] Free functions that really are static (TU-local) 4 years ago
Adriaan de Groot b82da569d5 [plasmalnf] Remove unused (widget) files 4 years ago
Adriaan de Groot 06e2db946f [plasmalnf] Older Qt doesn't have -> for iterator
With Qt 5.15.2 (and clang), `k->first` works, but this breaks
with Qt 5.11 (and gcc), this is not available and the dereference
  must be written differently, `(*k).first`.
4 years ago
Adriaan de Groot ff66eacd0d Merge branch 'issue-1573' into calamares 4 years ago
Adriaan de Groot fb9fa347a0 [plasmalnf] Fix iteration
`for k : images` iterates over the values in the map, while we need
both the key (the theme-id) and the value (the image to hand to
that theme).
4 years ago
Adriaan de Groot bcff0454a3 [plasmalnf] Give the themes a selected-state
- This kind of runs around the selection model on the view,
  but we're drawing radio buttons ourselves **anyway**
  and the list of themes knows which is selected / current
  independent of the view.
4 years ago
Adriaan de Groot da4f8fffcf [plasmalnf] Give the theme list plenty of space 4 years ago
Adriaan de Groot cf538fb837 [plasmalnf] Implement a delegate for drawing the list of themes 4 years ago
Adriaan de Groot cc6611bac4 [plasmalnf] Make 'the size of screenshots' available outside ThemeInfo 4 years ago
Adriaan de Groot dac590a094 [plasmalnf] Rip out the intermediate model again, in prep for a delegate 4 years ago
Adriaan de Groot 61a2335909 [users] Stray space in message (reported by Transifex user Moo) 4 years ago
Adriaan de Groot ccfbd6b972
Merge pull request #1566 from Chrysostomus/calamares
Don't use a keyfile for encrypted partitions if /boot in unecrypted
4 years ago
Adriaan de Groot 2a30ae1e25 [unpackfs] Log failure during unpackfs more clearly 4 years ago
Adriaan de Groot 66da5f2fa4 [netinstall] Removing the last package should clear it out.
FIXES #1577
4 years ago
Adriaan de Groot 06cbabd189 [plasmalnf] Simplify (warnings--, debug--) 4 years ago
Adriaan de Groot faa1cb6b65 [plasmalnf] Demand-load image for a theme 4 years ago
Adriaan de Groot 58ea40c14d [plasmalnf] Add a description
- add a role for description
- change view to a table view
4 years ago
Adriaan de Groot 258a14bea2 [plasmalnf] Expose only the themes model
- make ThemeInfo and ThemeInfoList internal, expose only
  ThemesModel to the rest of the PlasmaLnF module
- don't build the widget anymore (needs to be replaced by
  a delegate)
4 years ago
Adriaan de Groot 04a6fbc4c4 [plasmalnf] Fix debug-logging
- ProcessResult isn't loggable, so operator bool() is called, so
  it logged 'false' on failure which isn't helpful.
4 years ago
Adriaan de Groot 0a88273e0d [plasmalnf] Replace combobox with a view 4 years ago
Adriaan de Groot 3909459563 [plasmalnf] Signal more changes to the model
- also individual changes need to be signalled
- use QSignalBlocker to avoid spamming changes when calling
  aggregate change methods
- refactor findById() so that also a row number can be
  obtained, which is needed for the change signals.
4 years ago
Adriaan de Groot f93cec031b [plasmalnf] Introduce an index-lookup function
- for signalling model changes, also need to know indexes / row
4 years ago
Adriaan de Groot f9e99da468 [plasmalnf] Improve lnf model
- remove useless widget pointer from themeinfo
- notify when data changes in the model
4 years ago
Adriaan de Groot 1f57a0ddda [plasmalnf] Very basic combo-box based UI 4 years ago
Adriaan de Groot aaa56b6903 [plasmalnf] Rip out most of the widget
- put a filter model in place, so only the themes with "show" set
  are displayed
- rip out the messing about with widgets, soon to introduce a model-
  based UI
4 years ago
Adriaan de Groot d4887426e2 [plasmalnf] Set screenshots on themes, filtering
- while here reorder the config so the effect of *showAll* is clearer
4 years ago
Adriaan de Groot 254933a488 [plasmalnf] Prep-work for loading the themes into the model 4 years ago
Adriaan de Groot 57907ca992 [plasmalnf] Move model to ThemeInfo files 4 years ago
Calamares CI 9bf0a3414f i18n: [dummypythonqt] Automatic merge of Transifex translations 4 years ago
Chrysostomus ff9f47ec83 Fix syntax errors 4 years ago
Chrysostomus 567b01eab0 call function at different scope to avoid name collision 4 years ago
Chrysostomus 09798a2a12 Use free functions (I wish I had known I can do this) 4 years ago
Chrysostomus 8676ce9a20 Simplify the generators 4 years ago
Gaël PORTAY feab8bebba [partition] Remove unused attribute m_defaultFsType
This attribute is used since the commit fcd0e8d36 [partition] Apply
partition layout when replacing free space
4 years ago
Adriaan de Groot dda2e1f29f Merge commit 'a8359696caf07b81b85db8acad2d3f44720d07fa' into calamares
This is the bugfix part (rather than the "clean up this widgets mess")
of issue-1573, ensuring that the LookAndFeelPackage setting is
saved to the target system config file.
4 years ago
Adriaan de Groot 27f1e82a8f [plasmalnf] Remove unused path-setting from the widget
- Only Config needs to know the path, since it is responsible for
  doing the actual lnf changes.
4 years ago
Adriaan de Groot a19109ed0b [plasmalnf] Prepare a new model
- start a model for available themes, to replace the list held
  by the widget which just duplicates information.
- move preselected theme to Config.
4 years ago
Adriaan de Groot 03e09cb7e6 [keyboard] When changing layouts, reset variant
- Need to update the variant that is in use, **and**
  explicitly update it in the widget, in order to re-load
  the keyboard image for the newly-selected layout+variant.
4 years ago
Adriaan de Groot fdfe3937e9 [keyboard] Tell the keyboard preview to update on config changes
These calls to setLayout() and setVariant() got lost in
the transition to Config object, in 5afe5413.

Reported by Harald Sitter.
4 years ago
Gaël PORTAY 2e6d632c7c [partition] Fix typo 4 years ago
Adriaan de Groot cba2733471 [plasmalnf] Move job creation to config 4 years ago
Adriaan de Groot 0af12546ef [plasmalnf] Migrate more settings to Config 4 years ago
Adriaan de Groot b4aca7e188 [libcalamares] Tidy up documentation for System::runCommand
- Make explicit which one runs in the host, which one is selectable.
- Document *location* parameter in the selectable version.
- Tidy up alignment of apidox.
4 years ago
Adriaan de Groot 00293d1111 [plasmalnf] Move the lookandfeeltool path setting to Config 4 years ago
Adriaan de Groot 0f07550006 [plasmalnf] Introduce (empty) Config object 4 years ago
Adriaan de Groot a8359696ca [plasmalnf] Remove unnecessary includes 4 years ago
Adriaan de Groot 76b0981918 [plasmalnf] Apply workaround for lookandfeeltool
The lookandfeeltool does not (always?) write the LookAndFeelPackage
key that the KCM does -- and which this module reads on startup
to find the default LnF. This seems to be a regression in recent
lookandfeeltool versions (or in the KCM code that backs it).

Workaround supplied by jghodd.

Fixes #1573
4 years ago
Adriaan de Groot 8f590848bd [plasmalnf] Simplify code
- Look-and-Feel job has no status to speak of
- Coding style
4 years ago
Chrysostomus 543a9e1afc Remove extra static keyword 4 years ago
Adriaan de Groot b503aa645b
Merge pull request #1563 from LordTermor/calamares
[users] Full name transliteration support for user creation
4 years ago
Artem Grinev 16eca3c1be [users] Apply code format 4 years ago
Artem Grinev ca033583a4 Simplified logic a bit, made punctuation handling more correct 4 years ago
Artem Grinev da5fb2d3e1 Improved comment 4 years ago
Artem Grinev d5e678157d Changed TRANSLITERATOR_ID type to array 4 years ago
Gaël PORTAY 7859d98a32 [unpackfs] Skip overlay extended attributes
The module preserves the extended attributes at rsync and the overlay
filesystem stores extended attributes by inodes.

The overlay filesystem keeps traces of the lower directory by encoding
and storing its UUID to the attribute trusted.overlay.origin. If the
index feature is on, that attribute is compared to the UUID of the lower
directory at every subsequent mounts and causes mount to fail with
ESTATE if it does not match.

This filters the namespace trusted.overlay.* by using the rsync option
--filter='-x trusted.overlay.*' to make sure the overlays extended
attributes are not preserved.

Fixes:
        # mount -t overlay -o lowerdir=...,upperdir,...,workdir= overlay /mnt/etc
        mount: /var/mnt/etc: mount(2) system call failed: Stale file handle.

        # dmesg
        (...)
        overlayfs: "xino" feature enabled using 32 upper inode bits.
        overlayfs: failed to verify origin (/etc, ino=524292, err=-116)
        overlayfs: failed to verify upper root origin
4 years ago
Chrysostomus e3ee3c623d Add some relevant looking stuff to header file 4 years ago
Adriaan de Groot b4c3236e4a [users] Consume error information from libpwquality
Previously, the auxerror information was never stored, and
the messages were all un-numbered or un-explained.
Now, consume that information and store it when check()
is called, ready to be used when (possibly much later,
or after a translation change) explanation() is called.
4 years ago
Adriaan de Groot 43565027f5 [users] m_auxerror never set, always nullptr 4 years ago
Adriaan de Groot f3e37f3cee [users] Remove unused PWQuality method 4 years ago
Adriaan de Groot a5dfe7cd68 i18n: update english translations 4 years ago
Adriaan de Groot 4e9c18a565 [users] Translate PWQuality error messages with numbers 4 years ago
Adriaan de Groot 2a9bbf1dd5 [users] Add test for jobs-creation
- This tries to avoid the now-fixed situation where a sudoersGroup job
  is not created at all (because of a logic error).
- While here, coding style
4 years ago
Chrysostomus adc8d7e624 Fix typo 4 years ago
Adriaan de Groot 3b152ba455 Merge branch 'fix-sudo-settings' into calamares 4 years ago
Adriaan de Groot 43e271dfec [users] Missing negation 4 years ago
Adriaan de Groot 8e53b83f9f [users] Test for setting / resetting sudo settings 4 years ago
Chrysostomus b7cc4860e0 Put the condition on a single line for prettiness sake 4 years ago
Chrysostomus 3731dfb146 Try not to create the keyfile if not necessary 4 years ago
Adriaan de Groot 6f41949bba [users] Log when sudo is skipped 4 years ago
Gaël PORTAY 6e9ce7194f [mount] Ignore unformatted filesystems only
Mount guesses the filesystem if it is unset or if it is set to auto,
thanks to blkid. That is the case for the bind mountpoints like /dev or
/run/udev in mount.conf. See `mount(8)` for more details.
4 years ago
Matti Hyttinen 73b5c62ab8
Update main.py
typo in a comment
4 years ago
Adriaan de Groot afb4e00f92 [keyboard] Pre-select pc105 4 years ago
Adriaan de Groot e5b7e66ee9 [locale] Filter zones combo always
The drop-down of zones was initially unfiltered, so you could start
in Europe/Amsterdam and the zones drop-down would also show Australian
zones; picking Perth would have weird effects, since Europe/Perth
doesn't exist and so you'd end up in New York instead.

- set the filtering region immediately, rather than only when the
  region changes.
4 years ago
Adriaan de Groot 83b2b95381 [libcalamares] Reduce object churn
- we don't need to allocate a new translator each time the language changes
4 years ago
Chrysostomus 741c1c5d1e Use constructor instead of a loop 4 years ago
Adriaan de Groot 59255c7a57 Changes: apply coding style 4 years ago
Adriaan de Groot be7b63051e Enable keyboard-model and layout-name translations.
SEE #1515
4 years ago
Chrysostomus 26b1c349d3 Set default value inside the relevant function 4 years ago
Adriaan de Groot c4de62cb9a Merge branch 'fix-keyboardq' into calamares
Various file writes were not being checked, and the code
was a bit tangled; specifically keyboardq did **not**
configure properly on KaOS and now seems ok.
4 years ago
Adriaan de Groot 83d2c06f68 [keyboard] Apply coding style 4 years ago
Adriaan de Groot 705e6dd8d6 [keyboard] Improve debug-logging for writing etc/default 4 years ago
Adriaan de Groot cbc376a206 [keyboard] Improve debug-logging for writing X11 config 4 years ago
Philip Müller 5191df2bde
Merge pull request #1568 from gportay/partition-fix-typo
[partition] Fix typo
4 years ago
Adriaan de Groot 57da222c72 [keyboard] Improve debug-logging for vconsole-config 4 years ago
Gaël PORTAY e2b00bc517 [partition] Fix typo 4 years ago
Gaël PORTAY e9e4be1c60 [umount] Fix list of mount-points to unmount
The root mount-point can end with a / while the mount-point read from
the file /etc/mtab does not end with a /.

This leads to skip the unmounting of the root mount-point and causes the
removal of the root mountpoint directory to fail with EBUSY because it
is still mounted.

This uses the python functions os.path.normpath() to normalize the root
mount-point (i.e. to drop the trailing /) and os.path.commonprefix() to
determine the longest common prefix between the two mount-points. If the
returned prefix is identical to the normalized root mount-point then the
mount-point must be added to the list of the mount-points to unmount.

More generally, the python modules should rely on the os.path functions
to compare for paths instead of using strings. It covers this way lots
of corner cases (path with "//", "/../", "/./", ...).
4 years ago
Adriaan de Groot 845fb3f6da [keyboard] Refactor writing-various-files
- put the writing of each kind of file in its own block -- this should
  become separate functions -- so that variables become more local
  and debugging can be improved.
- while here, fix the error message for /etc/default/keyboard:
  it would complain and name the vconsole file path if it ever failed.
4 years ago
Adriaan de Groot 3e51d77782 [keyboard] Check for successful file-write 4 years ago
Adriaan de Groot 2c297a068f [partition] Log when an EFI problem has been solved 4 years ago
Adriaan de Groot 0f38ee624e [partition] static-assert that our shortcut makes sense 4 years ago
Artem Grinev 94f7efb89f [users] Remove ' from transliterated string 4 years ago
Artem Grinev f20d0a7593 [users] Name cleanup after transliteration 4 years ago
Artem Grinev aa5ef7a6b8 [users] New transliterator ID 4 years ago
Adriaan de Groot 15ace5202d [partition] Simplify EFI-flags checking with KPMCore 4 4 years ago
Adriaan de Groot 85bb8c27b3 [partition] Simplify flags calculations
- factor out the flags-we-want from the flags-we-already-have
 - the use of ->activeFlags() meant that the state on *disk* was
   being compared with the flags-we-want; if a partition was re-edited,
   then you couldn't change the flags back to the state-on-disk
   (eg. enable a flag, then change your mind and disable it).
 - set the flags before refreshing the partition, because the
   refresh checks for EFI bootability and that needs the new flags,
   not the old ones.
4 years ago
Adriaan de Groot 949e33f1e8 [partition] Massage logging while checking for EFI boot 4 years ago
Adriaan de Groot 63964de4bd [partition] Explain underlying type for flags variant 4 years ago
Adriaan de Groot 87c77d9807 [partition] When flags are explicitly invalid, return early 4 years ago
Adriaan de Groot 356e13ae93 [partition] Improve logging readability 4 years ago
Chrysostomus fe291bc51a Write the crypttab entry still 4 years ago
Chrysostomus 9f52282e4c Don't use keyfile if there /boot is unencrypted 4 years ago
Chrysostomus 3eae98eac3 Don't enable grub password query if /boot is on unencrypted partition 4 years ago
Adriaan de Groot 72c9df67d2
Merge pull request #1565 from Chrysostomus/calamares
[initcpiocfg] Use graphical decryption prompt with plymouth
4 years ago
Adriaan de Groot f898840e16 [users] Expand schema to cover new possibilities 4 years ago
Chrysostomus 84558333bf Regular plymouth hook is also still needed 4 years ago
Chrysostomus 3bf57c7785 Use graphical decryption prompt with plymouth as adviced here: https://wiki.archlinux.org/index.php/plymouth#The_plymouth_hook 4 years ago
Adriaan de Groot 36f9fd56a3 [users] Expand the example config with new possibilities 4 years ago
Adriaan de Groot 7c268b2e4d [users] Correct terminology in configuration documentation 4 years ago
Adriaan de Groot 2516f18d1b
Merge pull request #1560 from gportay/partition-mount-make-mountPoint-and-filesystem-optionals
[partition,mount] Make mountPoint and filesystem optionals
4 years ago
Adriaan de Groot ffce79e30e [partition] Initialize the filesystem type, not the partition type
- Passing FileSystem::Type to the QString constructor for
  partition type is not what I intended.
4 years ago
Adriaan de Groot 73b5a0898d [partition] Migrate the defaultFS type
- remove the m_defaultFSType from PartitionLayout, because it is
  set on construction -- which is too early, before the configuration
  has been read.
- make the default FS explicit in the init() calls which pass in
  a configuration; this needs support in the intermediate
  PartitionCoreModule.
4 years ago
Adriaan de Groot 23eabd74c6 [partition] Set FS type explicitly if no layout is given
- the "simple" constructor for PartitionEntry left the FS type
  set as the constructor left it -- which is Unknown by default.
  This leads to install failures in systems that don't set a
  special layout but just want a single / -- because the FS is
  set to Unknown.
- massage the constructor and consumer of the code, push
  Ext4 FS in the tests and use the configured default in production.
4 years ago
Artem Grinev c85d1ae1fe Explanation why ICU is needed for usersq module 4 years ago
Adriaan de Groot f78752303b [partition] Improve constructors for layout
- initialize flags by default
- the copy constructor was just doing the default thing,
  so make that explicit
4 years ago
Gaël PORTAY 6013ed52f8 [partition] Ignore unformatted filesystem 4 years ago
Gaël PORTAY db08d2db8b [partition] Make filesystem optional and default to unformatted 4 years ago
Gaël PORTAY 163351a803 [mount] Ignore empty or unformatted filesystems 4 years ago
Gaël PORTAY c6feedf923 [mount] Ignore empty mountpoints 4 years ago
Gaël PORTAY 54fd1f4b26 [mount] Print a warning if mount failure
The return of the call to libcalamares.utils.mount is never tested and
it may fail silently; this causes some mounpoints to be missing.

This adds a warning if mountpoint cannot be mounted.

	chcon: failed to get security context of '/tmp/verity': Operation not supported
	06:44:23 [6]: static CalamaresUtils::ProcessResult CalamaresUtils::System::runCommand(CalamaresUtils::System::RunLocation, const QStringList&, const QString&, const QString&, std::chrono::seconds)
	    Running "env" ("mount", "-t", "unformatted", "/dev/sdb2", "/tmp/calamares-root-kv8dqgb5/tmp/verity")
	    ..  Finished. Exit code: 32
	    ..  Target cmd: ("mount", "-t", "unformatted", "/dev/sdb7", "/tmp/calamares-root-kv8dqgb5/tmp/verity") output:
	 mount: /tmp/calamares-root-kv8dqgb5/tmp/verity: unknown filesystem type 'unformatted'.
4 years ago
Gaël PORTAY 1f9f506a16 [partition] Make mountPoint optional
Some devices cannot be mounted (as DM_verity_hash), therefore, it is
nosense to set a mountPoint for them.
4 years ago
Adriaan de Groot 486cdaeeb6 [users] Shuffle library order to satisfy CI build 4 years ago
Adriaan de Groot 2bd3f1d8c1 Merge branch 'issue-1523' into calamares 4 years ago
Adriaan de Groot b61b5f8650 [users] Run an expected-to-fail test in creating groups 4 years ago
Adriaan de Groot 8127ae704c [users] Expand tests for groups a little 4 years ago
Adriaan de Groot e66f81f6ee CMake: comment on BUILD_AS_TEST 4 years ago
Adriaan de Groot 10991346b7
Merge pull request #1561 from gportay/partition-set-swap-partition-name
[partition] Allow a configurable swap Partition name
4 years ago
Adriaan de Groot 7578768c46
Merge pull request #1562 from gportay/partition-group-efi-things-together
[partition] Group EFI things together
4 years ago
Artem Grinev 4e54a2aefe [users] Cleaned error handling a bit 4 years ago
Artem Grinev 8e07bb00f9 [users] Construct icu::UnicodeString from QString's utf16 chars directly 4 years ago
Artem Grinev 48eae463cc [users] Full name transliteration support for user creation 4 years ago
Adriaan de Groot 0bad5469fc [libcalamares] Fix tests failures from JobQueue asserts
Some compile flags changed recently, triggering assert()
in the jobqueue when there is more than one. There's no
real reason for JobQueue to be a singleton, but it wants
to be. So clean up pointers a little more enthusiastically.
4 years ago
Adriaan de Groot 4746754344 [keyboard] Translate layouts as well 4 years ago
Adriaan de Groot 6863db0dc1 [keyboard] Use the translations if they were loaded 4 years ago
Adriaan de Groot f088efdf84 [keyboard] Re-jig translation extraction
- Use classes to prompt lupdate to extract with a better
  context (e.g. the class name, rather than plain "QObject")
  so that the translation-lookup can use the named context.
- Add hard-coded "default" variant
- Add totally bogus Tajik translations, for testing purposes
4 years ago
Adriaan de Groot 1a5fa36fb6 i18n: build keyboard translations
This is the Wrong Thing To Do, but we'll do it for now: build the
keyboard translations into the executable. In the medium term
they should move to the modules that use them, with the re-vamp
of how translation changes are signalled.
4 years ago
Adriaan de Groot 4a08fdbb92 [partition] Reduce warnings from KPMCore
- make KPMHelper.h an "everything include" and suppress warnings
  from it, then use it in the tests.
4 years ago
Adriaan de Groot d26fde6647 [partition] Reduce warnings
- Add a helper header that munges the warnings-settings so that
  KPMcore headers can be included.
4 years ago
Adriaan de Groot c41ff94f8a [locale] Reduce warnings (C++17)
Now that Calamares is compiled as C++17, we get this:

src/modules/locale/timezonewidget/TimeZoneImage.cpp:28:55: warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated]
/* static constexpr */ const QSize TimeZoneImageList::imageSize;
4 years ago
Adriaan de Groot 4d444cbfbb [partition] Reduce warnings (Clang, FreeBSD)
The code doesn't match the comment: there are no by-ref captures
in the code, and the shadowing of parameters and local variables
is confusing. Remove one variable that is passed in as an argument
(and just pass the value as argument) and copy-capture the other
rather than doing weird argument passing.
4 years ago
Adriaan de Groot 0a44ce381e [partition] Reduce warnings (Clang, FreeBSD)
- remove unused this captures from lambda
- rename variables that are short, cryptic, and shadowed
- remove documentation for parameters that don't exist
4 years ago
Gaël PORTAY 3967cfe0eb [partition] Group EFI things together 4 years ago
Gaël PORTAY a1d45122eb [partition] Update partition.conf 4 years ago
Gaël PORTAY dad9587c3e [partition] Allow a configurable swap Partition name
This commit adds the new configuration `swapPartitionName` to the file
partition.conf.

This option sets the partition name to the swap partition that is
created. If this option is unset, the partition is left unnamed.
4 years ago
Adriaan de Groot 4387b8061e [keyboard] Move responsibility for retranslation to Config
- only widgets get language change events, so we need to
  hook that up to the ViewSteps and inform the Config
  object so that it can (re)load translations for the
  keyboard data.
4 years ago
Adriaan de Groot 71e0081fce [keyboard] SPDX-tagging 4 years ago
Adriaan de Groot 7db398cfdf
Merge pull request #1558 from gportay/partition-cleanups
[partition] cleanups
4 years ago
Adriaan de Groot 89a180ee58 [keyboard] Initial support for translated keyboard names 4 years ago
Adriaan de Groot b72eba8157 [libcalamares] Extend the Deleter-helper with "preserve"
Sometimes you want to keep the thing around after all.
4 years ago
Adriaan de Groot 7659dfdb9d [libcalamares] Expose a translations-loading function 4 years ago
Gaël PORTAY f03ae06deb [partition] Rename execute to createPartitions 4 years ago
Gaël PORTAY f2bfe2bd6a [partition] Fix coding style 4 years ago
Gaël PORTAY cd725fbb4b Fix missing SPDX-FileCopyrightText in header 4 years ago
Gaël PORTAY 2007335865 [partition] Rename the KPMCore Partition local to part 4 years ago
Gaël PORTAY 32c1f81fbf [partition] Rename iterator in for loop to entry 4 years ago
Gaël PORTAY 3016b93c8f [partition] Simplify the method execute
- Rename the "size" locals using "sectors" in their name. Size may be
  confusing or not enough specific as it can be interpreted a size in
  Byte.
    partSizeMap -> partSectorsMap,
    totalSize -> totalSectors,
    availablesize -> availableSectors,
    size -> sectors,
    minSize -> minSectors
    maxSize -> maxSectors
- Create a the new local currentSector to iterate over the sectors;
  instead of using the parameter firstSector.
- Remove the variable end that does not help much; too many variable
  already. Expand its expression instead.
4 years ago
Gaël PORTAY 81bec68b3d [partition] Introduce new constructors for PartitionEntry
- Introduces new constructors for PartitionEntry: copy constructory and
  constructor with all attributes.
- Use the new constructor in method addEntry().
4 years ago
Gaël PORTAY 3f2dd516d3 [partition] Simplify the retrieval of the size attributes
- The variant helper toString() takes a default value since commit
  c9f942ad6 ([libcalamares] Add default value to variant helpers).
- Set the default value to 0 and simplify the retreival of size values
  by calling the helper toString() and removing the temporary variables.
4 years ago
Gaël PORTAY 03df5f6891 [libcalamares] Fix constness of functions 4 years ago
Gaël PORTAY aec066359a [libcalamares] Fix coding style 4 years ago
Gaël PORTAY db7cf74034 [partition] Remove the call the method contains
- The variant helper getString() calls contains() already.
4 years ago
Gaël PORTAY d6ea30b23e [partition] Move initLayout logic to object PartitionLayout
- The logic of the method initLayout belongs to the object
  PartitionLayout. Move logic to that object.
- Use a single method initLayout in object PartitionCoreModule.
- Member m_partLayout in object PartitionCoreModule is no longer
  allocated.
4 years ago
Gaël PORTAY eae1e90dce [partition] Remove unused PartitionLayout constructor
- The constructor PartitionLayout with PartitionEntry appears to be
  unused since its always. Drop it!
4 years ago
Gaël PORTAY f2960366c8 [partition] Remove unused addEntry method
- The method addEntry with PartitionEntry appears to be unused since its
  always. Drop it!
4 years ago
Adriaan de Groot ac6c9fae4a [libcalamares] Do not use moved-from object 4 years ago
Adriaan de Groot 2e9a44269c [keyboard] Extracted strings from keyboard list 4 years ago
Adriaan de Groot 5a378090c2 [keyboard] Do not munge keyboard model name
The translation happens whenever this code is run, which may
not match the language the user subsequently selects.
It also causes general problems with the translation,
since we end up with a possibly-partly-translated name.
4 years ago
Adriaan de Groot 7ec8c454bd [keyboard] Ukranian needs a switcher, too 4 years ago
Adriaan de Groot 8457a00ad0 [keyboard] Fix group-switcher multiplying
FIXES #1556
4 years ago
Adriaan de Groot daaf16d331 Merge branch 'calamares' into issue-1523 4 years ago
Adriaan de Groot cd9c0ea781 [keyboard] Reduce debugging output 4 years ago
Adriaan de Groot 2e5301c5c9 [keyboard] Simplify back down to lambdas
- With debugging and untangling done, the lambdas are simple
  and short, so return to using them. One point of improvement
  might be to give the models suitable slots themselves,
  to avoid even this indirection.
4 years ago
Adriaan de Groot 0bf28b0b94 [keyboard] Sanity in setCurrentIndex() parameters 4 years ago
Adriaan de Groot 9e141636c5 [keyboard] Tidy up the debugging output, add docs 4 years ago
Adriaan de Groot 14a76a386a [keyboard] Replace broken-ish variants model with k-v list
- Use the just-refactored XKBListModel to store the xkb key-value
  pairs for variants, drop most of the complicated implementation,
  store just a single list of values.
4 years ago
Adriaan de Groot d536173d66 [keyboard] Factor out a 2-column k-v list 4 years ago
Adriaan de Groot 5afe54132b [keyboard] Use the models from Config
- Remove code that is duplicated in Config.
- Hook up UI for physical keyboard model, and back.
- For now, introduce some named slots with debugging output.
  This makes debugging a lot easier since we have function names
  to work with rather than anonymous lambdas
4 years ago
Adriaan de Groot 168be02c96 [keyboard] Hook up the model-selection again 4 years ago
Adriaan de Groot 87aafb2442 [keyboard] Tear up connections between widgets and model 4 years ago
Adriaan de Groot 193efe1710 [keyboard] Restore the notion of PC105 default index 4 years ago
Adriaan de Groot 6aedf4401f [keyboard] Apply coding style 4 years ago
Adriaan de Groot 365a2ad6fd [keyboard] Re-do the keyboard physical models model from scratch 4 years ago
Adriaan de Groot a1c70b46a1 [keyboard] Typo in comment 4 years ago
Adriaan de Groot 5f1d7b2e8d [keyboard] Rename UI widgets to make code clearer 4 years ago
Adriaan de Groot d464e98e89 [keyboard] Move remaining variables to Config
- Config already *has* everythind, but drop the useless copies
  and duplicated code from the Page
- Plug the models model into the Page
- While here, document the model / layout / variant distinctions

The code doesn't fill the UI properly, and the drop-down
for the models combobox is not right, but at least the data
is shared.
4 years ago
Adriaan de Groot fe5757c7d1 [keyboard] Matching of layouts is very suspect 4 years ago
Adriaan de Groot 4f0d6a8f25 Merge branch 'calamares' into fix-keyboardq 4 years ago
Adriaan de Groot dca9ae0c93
Merge pull request #1553 from LordTermor/calamares
Initial additional layout support for non-ASCII layouts
4 years ago
Artem Grinev 4434e85d4d [keyboard] Simplified variable name 4 years ago