Lioncash
5da4c78c6a
filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor
...
Avoids unnecessary atomic reference count incrementing and decrementing
7 years ago
Lioncash
abbf038191
filesystem: Use std::string's empty() function instead of comparing against a literal
...
This is simply a basic value check as opposed to potentially doing
string based operations (unlikely, but still, avoiding it is free).
7 years ago
Lioncash
2cc0ef83cf
filesystem: Remove pragma disabling global optimizations
...
This was just an artifact missed during PR review.
7 years ago
Lioncash
f317080f40
fsp_srv: Make IStorage constructor explicit
...
Prevents implicit conversions.
7 years ago
Lioncash
910ad2e110
fsp_srv: Add missing includes
...
Gets rid of relying on indirect inclusions.
7 years ago
Lioncash
6be342118a
fsp_srv: Resolve sign-mismatch warnings in assertion comparisons
7 years ago
Lioncash
d6e9b96e2f
fsp_srv: Respect write length in Write()
...
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
7 years ago
Lioncash
5c47ea1a4e
common/swap: Remove unnecessary const on return value of swap()
7 years ago
Lioncash
0a868641fa
common/swap: Use static_cast where applicable
7 years ago
Lioncash
1edf4dd7ef
common/swap: Use using aliases where applicable
7 years ago
Lioncash
9128271292
common/common_funcs: Remove unused rotation functions
...
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
7 years ago
Lioncash
e0b8a35937
common/misc: Deduplicate code in GetLastErrorMsg()
...
Android and macOS have supported thread_local for quite a while, but
most importantly is that we don't even really need it. Instead of using
a thread-local buffer, we can just return a non-static buffer as a
std::string, avoiding the need for that quality entirely.
7 years ago
Lioncash
ef03d0178a
externals: Update Xbyak to 5.65
...
Keeps the JIT assembler library up to date and ensures we don't run into
any issues that may have been resolved.
7 years ago
Lioncash
25f997097d
externals: Update catch to v2.2.3
...
Keeps the unit-testing library up to date.
7 years ago
Lioncash
63e64f0131
file_util: return string by const reference for GetExeDirectory()
...
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
7 years ago
bunnei
cd4fca8447
Merge pull request #700 from bunnei/update-dynarmic
...
externals: Update dynarmic to 5a91c94.
7 years ago
Lioncash
33fbcb45a7
string_util: Remove AsciiToHex()
...
Easy TODO
7 years ago
bunnei
368e1d25be
Merge pull request #692 from lioncash/assign
...
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
7 years ago
bunnei
85421f3406
Merge pull request #690 from lioncash/move
...
core/memory, core/hle/kernel: Use std::move where applicable
7 years ago
Lioncash
88ba94e8a2
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
...
This function doesn't alter class state.
7 years ago
Lioncash
9abc5763b6
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
...
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
7 years ago
bunnei
cf30c4be22
gl_state: Temporarily disable culling and depth test.
7 years ago
Lioncash
4790bb907d
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
...
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
7 years ago
Lioncash
87a9bb392b
content_archive: Add missing standard includes
7 years ago
bunnei
522bd5b736
externals: Update dynarmic to 5a91c94.
7 years ago
Lioncash
0b566f43a1
content_archive: std::move VirtualFile in NCA's constructor
...
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
7 years ago
Lioncash
5e626c774f
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
...
We can just use a generic lambda to avoid writing the same thing twice.
7 years ago
bunnei
1371e2fb6a
Merge pull request #691 from lioncash/guard
...
service/prepo: Add missing header guard
7 years ago
bunnei
b10905c8ae
Merge pull request #686 from lioncash/fmt
...
externals: update fmt to version 5.1.0
7 years ago
Lioncash
55ab369043
loader/nro: Resolve sign mismatch warnings
7 years ago
Lioncash
1831b5ef62
loader/nso: Remove unnecessary vector resizes
...
We can just initialize these vectors directly via their constructor.
7 years ago
Lioncash
e3a30ccc7c
loader/nso: Resolve sign mismatch warnings
7 years ago
bunnei
90ce935f3d
Merge pull request #688 from lioncash/comma
...
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
7 years ago
bunnei
3f93279047
Merge pull request #693 from lioncash/unused
...
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
7 years ago
bunnei
49b0966003
Merge pull request #687 from lioncash/instance
...
core: Don't construct instance of Core::System, just to access its live instance
7 years ago
bunnei
89f0acfd36
Merge pull request #680 from bunnei/fix-swizz
...
decoders: Fix calc of swizzle image_width_in_gobs.
7 years ago
bunnei
d883d3b64f
Merge pull request #685 from lioncash/build
...
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
7 years ago
bunnei
2975f7820e
Merge pull request #684 from lioncash/nonmember
...
game_list: Make ContainsAllWords an internally linked non-member function
7 years ago
bunnei
b496a9eefe
decoders: Fix calc of swizzle image_width_in_gobs.
7 years ago
Zach Hilman
29aff8d5ab
Virtual Filesystem 2: Electric Boogaloo ( #676 )
...
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
7 years ago
Lioncash
72207577b2
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
7 years ago
Lioncash
2cd3141c30
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
...
This was introduced within 4f81bc4e1b
, and
considering there's no comment indicating that this is intentional, this
is very likely a bug.
7 years ago
Lioncash
296e68fd43
service/prepo: Add missing header guard
7 years ago
Lioncash
93cba6f699
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
...
Without these, this would perform concatenation, which is definitely not
what we want here.
7 years ago
Lioncash
46458e7284
core/memory, core/hle/kernel: Use std::move where applicable
...
Avoids pointless copies
7 years ago
Lioncash
10d2ab8098
core: Make System's default constructor private
...
This makes it a compilation error to construct additional instances of
the System class directly, preventing accidental wasteful constructions
over and over.
7 years ago
Lioncash
3a4841e403
core: Don't construct instance of Core::System, just to access its live instance
...
This would result in a lot of allocations and related object
construction, just to toss it all away immediately after the call.
These are definitely not intentional, and it was intended that all of
these should have been accessing the static function GetInstance()
through the name itself, not constructed instances.
7 years ago
Lioncash
f5d7706ca1
externals: update fmt to version 5.1.0
...
Previously, we were on 4.1.0, which was a major version behind.
7 years ago
Lioncash
079be8032d
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
...
Previously this wouldn't compile, since no such function named
SaveStructDebugInfo() exists.
7 years ago
bunnei
924c473bb3
Merge pull request #683 from DarkLordZach/touch
...
Touchscreen Support
7 years ago