aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '9f9bab25da'
${ noResults }
depot_tools/tests
History
Aravind Vasudevan 9f9bab25da Reland "Update gclient to use git config caching" 
This reverts commit 3569608028.

Reason for revert: This includes a fix for crbug.com/324358728.

The rebase-update command has logic which tries to specifically set a key to an empty string and this has been intentionally set this way[1]. The new SetConfig implementation does treats empty string as None and hence tries to unset the config, resulting in error code 5. The patchset 2 fixes this bug and adds a test to ensure SetConfig can set an empty string to be backward compatible.

[1] https://codereview.chromium.org/228353003

Original change's description:
> Revert "Update gclient to use git config caching"
>
> This reverts commit 3edda8d185.
>
> Reason for revert: Breaks rebase-update; crbug.com/324358728
>
> Original change's description:
> > Update gclient to use git config caching
> >
> > This change updates all the modules used by gclient to use `scm.GIT` for git config calls over directly invoking the subprocess.
> >
> > This change currently doesn't modify git_cache since the config reads and writes within it are done on bare repository. A follow-up CL will update git_cache.
> >
> > A follow-up CL will also update git_cl and git_map_branches since they have shown performance improvements too: https://crrev.com/c/4697786.
> >
> > Benchmarking
> > ============
> > With chromium/src as the baseline super project, this change reduces about 380 git config calls out of 507 total calls on cache hits during no-op. The below numbers are benchmarked with `update_depot_tools` turned off.
> >
> > Windows Benchmark
> > =================
> > Baseline (gpaste/6360045736951808): ~1min 12 sec.
> > With Caching (gpaste/6480065209040896): ~1min 3sec.
> > ~12.5% decrease in gclient sync noop runtime.
> >
> > Linux Benchmark
> > ===============
> > Baseline (gpaste/4730436763254784): ~3.739 sec.
> > With Caching (gpaste/4849870978940928): ~3.534 sec.
> > ~5.5% decrease in gclient sync noop runtime.
> >
> > Bug: 1501984
> > Change-Id: Ib48df2d26a0c742a9b555a1e2ed6366221c7db17
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5252498
> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 1501984
> Change-Id: I4a603238d9ed43edafc8e574493800670520a1d9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5279198
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 1501984
Change-Id: I405abc16c2ef6f0689031c82c61af71aad302122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5280779
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 		1 year ago
..
gstools
…
OWNERS [ChromiumOS] Add a launcher for Bazel 2 years ago
auth_test.py [auth] Be able to generate id_token 2 years ago
autoninja_test.py autoninja: cache negative result of gcloud account check 1 year ago
bazel_test.py tests: switch to 4 space indent 2 years ago
bot_update_coverage_test.py Fix multiline comment formatting 1 year ago
cipd_bootstrap_test.py Update cipd_bootstrap_test to use a newer cipd client binary. 1 year ago
detect_host_arch_test.py [detect_host_arch] Cache HostArch() function 2 years ago
download_from_google_storage_unittest.py Remove __future__ imports 2 years ago
fetch_test.py fetch: stop setting submodules config as we are not using it at all 2 years ago
gclient_cipd_smoketest.py tests: switch to 4 space indent 2 years ago
gclient_eval_unittest.py Reland^3 "Upgrade python to 3.11" 1 year ago
gclient_git_mutates_smoketest.py tests: switch to 4 space indent 2 years ago
gclient_git_smoketest.py Remove .git suffix from git submodules 2 years ago
gclient_no_sync_smoketest.py tests: switch to 4 space indent 2 years ago
gclient_paths_test.py Cache values in gclient_paths.py 2 years ago
gclient_scm_test.py Reland "Update gclient to use git config caching" 1 year ago
gclient_smoketest.py tests: switch to 4 space indent 2 years ago
gclient_smoketest_base.py Fix multiline comment formatting 1 year ago
gclient_test.py Fix multiline comment formatting 1 year ago
gclient_transitions_smoketest.py Fix multiline comment formatting 1 year ago
gclient_utils_test.py tests: switch to 4 space indent 2 years ago
gerrit_client_test.py tests: switch to 4 space indent 2 years ago
gerrit_util_test.py Reland "Update gclient to use git config caching" 1 year ago
git_cache_test.py [git_cache] Track if git cache is fully initialized 1 year ago
git_cl_creds_check_report.txt Fix gerrit new-password URL 2 years ago
git_cl_test.py Reland "Update gclient to use git config caching" 1 year ago
git_common_test.py Reland "Update gclient to use git config caching" 1 year ago
git_dates_test.py tests: switch to 4 space indent 2 years ago
git_find_releases_test.py tests: switch to 4 space indent 2 years ago
git_footers_test.py tests: switch to 4 space indent 2 years ago
git_hyper_blame_test.py Fix multiline comment formatting 1 year ago
git_map_test.py tests: switch to 4 space indent 2 years ago
git_migrate_default_branch_test.py tests: switch to 4 space indent 2 years ago
git_number_test.py tests: switch to 4 space indent 2 years ago
git_rebase_update_test.py tests: switch to 4 space indent 2 years ago
gsutil_test.py [gsutil.py] Skip luci-auth wrapper on unsupported platforms 2 years ago
hooks_test.py Require prompt from users to confirm submodules commit. 2 years ago
lockfile_test.py tests: switch to 4 space indent 2 years ago
metrics_test.py tests: switch to 4 space indent 2 years ago
my_activity_test.py tests: switch to 4 space indent 2 years ago
ninja_reclient_test.py Fix deletion of old build logs 2 years ago
ninjalog_uploader_test.py ninjalog_uploader.py: use cipd to check authenticated account 2 years ago
owners_client_test.py tests: switch to 4 space indent 2 years ago
owners_finder_test.py tests: switch to 4 space indent 2 years ago
presubmit_canned_checks_test.py Fix multiline comment formatting 1 year ago
presubmit_support_test.py [presubmit] Don't replace os.environ 1 year ago
presubmit_unittest.py Revert "Reland "Refactor git functionality out of Change and _DiffCache"" 1 year ago
rdb_wrapper_test.py Remove __future__ imports 2 years ago
recipes_test.py tests: switch to 4 space indent 2 years ago
reclient_metrics_test.py tests: switch to 4 space indent 2 years ago
roll_dep_test.py tests: switch to 4 space indent 2 years ago
scm_unittest.py Reland "Update gclient to use git config caching" 1 year ago
split_cl_test.py tests: switch to 4 space indent 2 years ago
subcommand_test.py tests: switch to 4 space indent 2 years ago
subprocess2_test.py Fix multiline comment formatting 1 year ago
upload_to_google_storage_unittest.py Remove last py2 workarounds 2 years ago
utils_test.py tests: switch to 4 space indent 2 years ago
watchlists_unittest.py tests: switch to 4 space indent 2 years ago