fetch: stop setting submodules config as we are not using it at all

R=sokcevic

Bug: 1496925
Change-Id: I448fb1f49b225d1a5f60103dbbcacaea2c69bd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995365
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

fetch.py

@@ -146,11 +146,6 @@ class GclientGitCheckout(GclientCheckout, GitCheckout):
         wd = os.path.join(self.base, self.root)
         if self.options.dry_run:
             print('cd %s' % wd)
-        self.run_git(
-            'submodule',
-            'foreach',
-            'git config -f $toplevel/.git/config submodule.$name.ignore all',
-            cwd=wd)
         if not self.options.nohistory:
             self.run_git('config',
                          '--add',

tests/fetch_test.py

@@ -254,13 +254,13 @@ class TestGclientGitCheckout(unittest.TestCase):
     def test_init(self):
         self.checkout.init()
         self.assertEqual(2, self.run_gclient.call_count)
-        self.assertEqual(3, self.run_git.call_count)
+        self.assertEqual(2, self.run_git.call_count)
 
         # Verify only expected commands and ignore arguments to avoid copying
         # commands from fetch.py
         self.assertEqual(['config', 'sync'],
                          [a[0][0] for a in self.run_gclient.call_args_list])
-        self.assertEqual(['submodule', 'config', 'config'],
+        self.assertEqual(['config', 'config'],
                          [a[0][0] for a in self.run_git.call_args_list])
 
         # First call to gclient, format spec is expected to be called so "foo"