You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Aravind Vasudevan 9f9bab25da Reland "Update gclient to use git config caching"
This reverts commit 3569608028.

Reason for revert: This includes a fix for crbug.com/324358728.

The rebase-update command has logic which tries to specifically set a key to an empty string and this has been intentionally set this way[1]. The new SetConfig implementation does treats empty string as None and hence tries to unset the config, resulting in error code 5. The patchset 2 fixes this bug and adds a test to ensure SetConfig can set an empty string to be backward compatible.

[1] https://codereview.chromium.org/228353003

Original change's description:
> Revert "Update gclient to use git config caching"
>
> This reverts commit 3edda8d185.
>
> Reason for revert: Breaks rebase-update; crbug.com/324358728
>
> Original change's description:
> > Update gclient to use git config caching
> >
> > This change updates all the modules used by gclient to use `scm.GIT` for git config calls over directly invoking the subprocess.
> >
> > This change currently doesn't modify git_cache since the config reads and writes within it are done on bare repository. A follow-up CL will update git_cache.
> >
> > A follow-up CL will also update git_cl and git_map_branches since they have shown performance improvements too: https://crrev.com/c/4697786.
> >
> > Benchmarking
> > ============
> > With chromium/src as the baseline super project, this change reduces about 380 git config calls out of 507 total calls on cache hits during no-op. The below numbers are benchmarked with `update_depot_tools` turned off.
> >
> > Windows Benchmark
> > =================
> > Baseline (gpaste/6360045736951808): ~1min 12 sec.
> > With Caching (gpaste/6480065209040896): ~1min 3sec.
> > ~12.5% decrease in gclient sync noop runtime.
> >
> > Linux Benchmark
> > ===============
> > Baseline (gpaste/4730436763254784): ~3.739 sec.
> > With Caching (gpaste/4849870978940928): ~3.534 sec.
> > ~5.5% decrease in gclient sync noop runtime.
> >
> > Bug: 1501984
> > Change-Id: Ib48df2d26a0c742a9b555a1e2ed6366221c7db17
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5252498
> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 1501984
> Change-Id: I4a603238d9ed43edafc8e574493800670520a1d9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5279198
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 1501984
Change-Id: I405abc16c2ef6f0689031c82c61af71aad302122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5280779
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
2 years ago
bootstrap
fetch_configs
hooks
infra
man
metadata
python-bin
python2-bin
recipes
testing_support
tests
third_party
win_toolchain
zsh-goodies
.cipd_impl.ps1
.flake8
.gitattributes
.gitignore
.isort.cfg
.style.yapf
.vpython
.vpython3
BUILD_OWNERS
CROS_OWNERS
DIR_METADATA
LICENSE
LUCI_OWNERS
OWNERS
PRESUBMIT.py
README.gclient.md
README.git-cl.md
README.md
RECLIENT_OWNERS
WATCHLISTS
auth.py
autoninja
autoninja.bat
autoninja.py
autosiso
autosiso.bat
autosiso.py
bazel
bazel.py
bb
bb.bat
black
bootstrap_python3
breakpad.py
cbuildbot
cipd
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version
cipd_client_version.digests
cipd_manifest.txt
cipd_manifest.versions
cipd_manifest_cros_python2.txt
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py
cpplint_chromium.py
cros
cros_python2.vpython
cros_sdk
crosjobs
detect_host_arch.py
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py
ensure_bootstrap
fetch
fetch.bat
fetch.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py
gclient_utils.py
gerrit
gerrit_client.py
gerrit_util.py
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py
git_cl.py
git_cl_completion.sh
git_common.py
git_completion.sh
git_dates.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_migrate_default_branch.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
goma_auth
goma_auth.bat
goma_ctl
goma_ctl.bat
gsutil.py
gsutil.py.bat
gsutil.vpython3
infra_to_superproject
infra_to_superproject.bat
infra_to_superproject.py
isort
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py
metrics_utils.py
my_activity.py
ninja
ninja.bat
ninja.py
ninja_reclient.py
ninjalog.README.md
ninjalog_uploader.py
ninjalog_uploader_wrapper.py
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py
presubmit_support.py
profile.xml
prpc
prpc.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint-2.17
pylint-2.17.bat
pylint_main.py
pylintrc
pylintrc-2.17
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py
reclient_helper.py
reclient_metrics
reclient_metrics.README.md
reclient_metrics.bat
reclient_metrics.py
reclientreport
reclientreport.bat
reclientreport.py
repo
repo_launcher
roll-dep
roll-dep.bat
roll_dep.py
rustfmt.py
scm.py
setup_color.py
siso
siso.bat
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift-format
swift_format.py
update_depot_tools
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py
utils.py
vpython
vpython.bat
vpython3
vpython3.bat
watchlists.py
weekly
whitespace.txt
win32imports.py
wtf
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.