You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Philipp Wollermann 885ed47343 Remove assert statements in autoninja.py
These were introduced in crrev.com/c/6024739 and currently break
autoninja for non-Googlers who manually enable Siso by setting the
use_siso=true GN arg.

$ gn gen --args='use_siso=true' out/Debug
$ autoninja -C out/Debug base
Traceback (most recent call last):
  File "/home/philwo/depot_tools/autoninja.py", line 504, in <module>
    sys.exit(main(sys.argv))
                ^^^^^^^^^^^^^^
  File "/home/philwo/depot_tools/autoninja.py", line 493, in main
    exit_code = _main_inner(input_args, build_id, should_collect_logs)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/philwo/depot_tools/autoninja.py", line 249, in _main_inner
    assert use_siso != False
           ^^^^^^^^^^^^^^^^^
AssertionError

R=ukai@google.com

Change-Id: I6536576d39b4ef094daa4e7ec80f3d743ecefd85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6058992
Auto-Submit: Philipp Wollermann <philwo@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
3 months ago
bootstrap [win-bootstrap] Use flag to enable direct install git 3 months ago
fetch_configs Add webpagereplay fetch_config 4 months ago
hooks pre-commit: do not ignore submodule when running diff-index 1 year ago
infra Roll recipe dependencies (trivial). 3 months ago
infra_lib/telemetry Add telemetry initialization and opt out utility 5 months ago
man Add --tree option to rebase-update. 8 months ago
metadata Revert "Adding Supplement:Apache-2.0 to chromium license allowlist." 3 months ago
python-bin cipd/python: optimize cat usage 2 years ago
python2-bin cipd/python: optimize cat usage 2 years ago
recipes Return out_commit from bot_update.ensure_checkout. 3 months ago
testing_support Update CMDgitmodules to set `gclient-recursedeps` in .gitmodules file. 5 months ago
tests autoninja: use build/toolchain/use_reclient_value.py 3 months ago
third_party [depot_tools] annotate third_party/colorama as non security critical 6 months ago
win_toolchain Add timeout to git call in windows toolchain update script 4 months ago
zsh-goodies
.cipd_impl.ps1 Import Get-FileHash from PowerShell's version specific path 2 years ago
.flake8 Add a config file for the flake8 linter. 1 year ago
.git-blame-ignore-revs Reuse GIT_BLAME_IGNORE_REV_FILE variable 5 months ago
.gitattributes Establish a directory for chrome infra telemetry 6 months ago
.gitignore autoninja: check RBE project, not account 6 months ago
.isort.cfg isort: make available to users 3 years ago
.style.yapf switch to 4 space indent 2 years ago
.vpython3 autoninja: check RBE project, not account 6 months ago
BUILD_OWNERS add siso wrapper 2 years ago
CROS_OWNERS CROS_OWNERS: switch to our common shared lists 3 years ago
DIR_METADATA
LICENSE
LUCI_OWNERS add peep-software-deploy team to luci owners 2 years ago
OWNERS Remove brucedawson@ from some depot_tools OWNERS files 5 months ago
PRESUBMIT.py presubmit: Check freeze on commit only 4 months ago
README.gclient.md
README.git-cl.md
README.md Switch to using issues.chromium.org bug links 1 year ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 2 years ago
WATCHLISTS Update WATCHLISTS for ninja, siso and reclient changes 2 years ago
auth.py [gerrit_util] Add fallback if missing Gerrit account 5 months ago
autoninja autoninja: check RBE project, not account 6 months ago
autoninja.bat autoninja: check RBE project, not account 6 months ago
autoninja.py Remove assert statements in autoninja.py 3 months ago
bazel [ChromiumOS] Add a launcher for Bazel 2 years ago
bazel.py switch to 4 space indent 2 years ago
bb provide a way to override cipd root for *nix systems. 7 months ago
bb.bat
black black: add helper for formatting Python 3 years ago
bootstrap_python3 Use relative path for cipd 2 years ago
breakpad.py switch to 4 space indent 2 years ago
build_telemetry autoninja: Implement build_telemetry utils 8 months ago
build_telemetry.bat autoninja: Implement build_telemetry utils 8 months ago
build_telemetry.py build_telemetry: Do not print warning message for cipd auth-info error 6 months ago
cbuildbot
cipd cipd: allow overriding the location of where cipd binary is installed 6 months ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 2 years ago
cipd_bin_setup.bat Revert "Retry switching to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh provide a way to override cipd root for *nix systems. 7 months ago
cipd_client_version [depot_tools] Roll CIPD. 6 months ago
cipd_client_version.digests [depot_tools] Roll CIPD. 6 months ago
cipd_manifest.txt [led] Roll led to latest version. 4 months ago
cipd_manifest.versions [led] Roll led to latest version. 4 months ago
cipd_manifest_cros_python2.txt remove goma CIPD package 11 months ago
cipd_manifest_cros_python2.versions Redirect cros calls to py2.7 scripts to the vpython2.7 package. 2 years ago
clang-format
clang-format.bat
clang_format.py [clang_format] Update clang path 9 months ago
codereview.settings
compile_single_file Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.bat Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.py Make 'compile_single_file' use vpython3 1 year ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 3 years ago
cpplint.py [cpplint] add stdin support in stdin 5 months ago
cpplint_chromium.py switch to 4 space indent 2 years ago
cros cros: expand to cover more roots 1 year ago
cros_python2.vpython Redirect cros calls to py2.7 scripts to the vpython2.7 package. 2 years ago
cros_sdk
detect_host_arch.py enable fetch and gclient to run on z/OS part 1 1 year ago
dirmd provide a way to override cipd root for *nix systems. 7 months ago
dirmd.bat
download_from_google_storage
download_from_google_storage.bat use python3 for download_from_google_storage.bat 3 years ago
download_from_google_storage.py [depot_tools] Update GCS dotfile naming 10 months ago
ensure_bootstrap redirect stdout and stderr of cipd_bin_setup to /dev/null 7 months ago
fetch [py2] Drop envvar to run scripts with py2 2 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 2 years ago
fetch.py fail if fetch command is called in Cog 9 months ago
gclient [py2] Drop envvar to run scripts with py2 2 years ago
gclient-new-workdir.py fail gracefully if gclient-new-workdir.py is called in non-git env 9 months ago
gclient.bat [py2] Drop envvar to run scripts with py2 2 years ago
gclient.py gclient: Support alternative names for OSes in target_os 3 months ago
gclient_completion.sh
gclient_eval.py gclient_eval.py: Add "new_usages_require_review" to DEPS file schema 5 months ago
gclient_paths.py gclient: resolve symlink in gclient_entries before checking with current path 8 months ago
gclient_scm.py Fix error in gclient_scm.py during processing git configs 5 months ago
gclient_utils.py Flush stdout more often so password prompts come after explanations. 5 months ago
gerrit Symlink gerrit CLI into depot_tools 2 years ago
gerrit_client.py gerrit_client: introduce add message command 4 months ago
gerrit_util.py gerrit_util: add revision kwarg to SetReview 4 months ago
git-cache
git-cl
git-credential-luci provide a way to override cipd root for *nix systems. 7 months ago
git-credential-luci.bat [cipd] Add git-credential-luci (reland) 9 months ago
git-crrev-parse Fix git-crrev-parse to work with both master & main branches 3 years ago
git-drover
git-find-releases
git-footers
git-freeze
git-gs Enable searching starlark files with git gs. 1 year ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream print slightly better message if git nav-upstream is not called in git repo 10 months ago
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks Revert "Remove unused functionality in bot_update.py" 3 years ago
git-squash-branch
git-squash-branch-tree Add git squash-branch-tree 8 months ago
git-thaw
git-upstream-diff
git_auth.py [gerrit_util] Add fallback if missing Gerrit account 5 months ago
git_cache.py error if git cache commands are called in cog env. 10 months ago
git_cl.py Update the error message for detached head. 4 months ago
git_cl_completion.sh
git_common.py Prefer direct git installation for Windows 4 months ago
git_completion.sh Bash autocompletion for 'git new-branch' and 'git reparent-branch' 1 year ago
git_dates.py Fix multiline comment formatting 1 year ago
git_find_releases.py fail gracefully if git find-releases is called in cog 10 months ago
git_footers.py fail gracefully if git footers is called in cog 10 months ago
git_freezer.py fail gracefully if git freeze or git thaw are called in cog 10 months ago
git_hyper_blame.py Reuse GIT_BLAME_IGNORE_REV_FILE variable 5 months ago
git_map.py fail gracefully if git map is called in cog 10 months ago
git_map_branches.py fail gracefully if git map-branches is called in cog 10 months ago
git_mark_merge_base.py fail gracefully if git mark-merge-base is called in cog 10 months ago
git_nav_downstream.py fail gracefully if git nav-downstream is called in cog 10 months ago
git_new_branch.py Track origin/lkgr when using --lkgr flag in new-branch 5 months ago
git_number.py Revert "[git-number] Remove unused git-number script." 7 months ago
git_rebase_update.py Add --tree option to rebase-update. 8 months ago
git_rename_branch.py fail gracefully if git rename-branch is called in cog 10 months ago
git_reparent_branch.py fail gracefully if git reparent-branch is called in cog 10 months ago
git_retry.py Fix multiline comment formatting 1 year ago
git_squash_branch.py fail gracefully if git squash-branch is called in cog 10 months ago
git_squash_branch_tree.py Add git squash-branch-tree 8 months ago
git_upstream_diff.py fail gracefully if git upstream-diff is called in cog 10 months ago
gn
gn.bat
gn.py Reland "[depot_tools] Support both gn paths in gn.py" 10 months ago
gn_helper.py gn_helper: find correct directory for // 3 months ago
google-java-format [depot_tools] add google_java_format.py 10 months ago
google-java-format.bat [depot_tools] add google_java_format.py 10 months ago
google_java_format.py Fix google-java-format/cipd exists check. 9 months ago
gsutil.py [gsutil] Fix race when downloading gsutil 10 months ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 3 years ago
isort switch to 4 space indent 2 years ago
led provide a way to override cipd root for *nix systems. 7 months ago
led.bat
lockfile.py [gsutil] Fix race when downloading gsutil 10 months ago
luci-auth provide a way to override cipd root for *nix systems. 7 months ago
luci-auth.bat
lucicfg provide a way to override cipd root for *nix systems. 7 months ago
lucicfg.bat
mac_toolchain provide a way to override cipd root for *nix systems. 7 months ago
metrics.README.md [metrics] Add new auth metric 6 months ago
metrics.py [metrics] Add new auth metric 6 months ago
metrics_utils.py [metrics] Add new auth metric 6 months ago
my_activity.py [fix_encoding] Remove fix_encoding 1 year ago
newauth.py [git_cl] Let creds-check revert new auth config changes 8 months ago
ninja Revert "Use depot_tools python3 to call ninja.py" 2 years ago
ninja.bat Add single file compile support for Windows in ninja wrappers 2 years ago
ninja.py ninja: error if trying to build for use_remoteexec=true 8 months ago
ninjalog_uploader.py ninjalog_uploader: Send is_cloudtop=false explicitly 5 months ago
owners_client.py [owners] Limit number of concurrent Gerrit connections 1 year ago
owners_finder.py Remove __future__ imports 1 year ago
pinpoint provide a way to override cipd root for *nix systems. 7 months ago
pinpoint.bat
post_build_ninja_summary.py allow v6 ninja log format 9 months ago
presubmit_canned_checks.py Make the freeze check Chromium-specific and update dates 3 months ago
presubmit_diff.py Handle binaries in presubmit_diff 7 months ago
presubmit_support.py Use ProvidedDiffChange if diff is empty string 4 months ago
prpc provide a way to override cipd root for *nix systems. 7 months ago
prpc.bat
pylint-2.6 switch to 4 space indent 2 years ago
pylint-2.6.bat
pylint-2.7 switch to 4 space indent 2 years ago
pylint-2.7.bat Add pylint-2.7 3 years ago
pylint-2.17 pylint: Add pylint 2.17 1 year ago
pylint-2.17.bat pylint: Add pylint 2.17 1 year ago
pylint_main.py Remove __future__ imports 1 year ago
pylintrc
pylintrc-2.17 pylint: Add pylint 2.17 1 year ago
python_runner.sh [py2] Drop envvar to run scripts with py2 2 years ago
rdb provide a way to override cipd root for *nix systems. 7 months ago
rdb.bat
rdb_wrapper.py Fix multiline comment formatting 1 year ago
reclient_helper.py Revert "reclient_helper: tuning local execution parameter" 3 months ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 2 years ago
reclientreport.bat Remove unnesisary quotes from propagated args in reclientreport.bat 2 years ago
reclientreport.py [reclient] Keep previous 5 builds worth of logs 1 year ago
repo error if repo command is called in Cog environment 9 months ago
repo_launcher [repo] Update repo launcher to v2.48 4 months ago
roll-dep [py2] Drop envvar to run scripts with py2 2 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 2 years ago
roll_dep.py error if roll-dep command is called in Cog environment 9 months ago
roll_downstream_gcs_deps.py Update roll_downstream_gcs_deps to take a list of source and destination packages. 5 months ago
rustfmt.py switch to 4 space indent 2 years ago
scm.py [scm] Handle empty .gitmodules file 5 months ago
setup_color.py Fix multiline comment formatting 1 year ago
siso add siso wrapper 2 years ago
siso.bat add siso wrapper 2 years ago
siso.py siso: print error if siso binary doesn't exist in third_party/siso 6 months ago
split_cl.py Edit warning in split_cl.py 7 months ago
subcommand.py Fix multiline comment formatting 1 year ago
subprocess2.py Fix multiline comment formatting 1 year ago
swift-format Support git cl formatting for swift files 3 years ago
swift_format.py switch to 4 space indent 2 years ago
update_depot_tools Make update_depot_tools tell you if it's skipping an update. 6 months ago
update_depot_tools.bat remove goma CIPD package 11 months ago
update_depot_tools_toggle.py switch to 4 space indent 2 years ago
upload_metrics.py switch to 4 space indent 2 years ago
upload_to_google_storage.py upload_to_google_storage.py: set x-goog-meta-executable during upload instead of using setmeta 4 months ago
upload_to_google_storage_first_class.py [GCS] Add prefix option to upload_to_gs_f_c 9 months ago
utils.py Use $HOME/.config/depot_tools on linux for .cfg files 9 months ago
vpython3 Don't write pyc files if running from Cog 6 months ago
vpython3.bat Use the bundled interpreter instead of passing -vpython-interpreter. 3 years ago
watchlists.py Fix multiline comment formatting 1 year ago
whitespace.txt
win32imports.py switch to 4 space indent 2 years ago
yapf Always run yapf with vpython3. 1 year ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.