[depot_tools] Update GCS dotfile naming

Sometimes the object name can have more than one dot like
20.11.0/f9a337cfa0e2b92d3e5c671c26b454bd8e99769e.
Currently, the dotfiles would be .20_.*
This change makes it so that the dotfiles would be
.20_11_0_f9a337cfa0e2b92d3e5c671c26b454bd8e99769e.*

Bug: b/328065301
Change-Id: I043a4b5fd56e48b046cfdc9a2fde3204b1bb638c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5491861
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
changes/61/5491861/3
Stephanie Kim 12 months ago committed by LUCI CQ
parent 7438a7cd4c
commit 2f0f9bc0bd

@ -45,8 +45,8 @@ MIGRATION_TOGGLE_FILE_SUFFIX = '_is_first_class_gcs'
def construct_migration_file_name(gcs_object_name):
# Remove any forward slashes
gcs_file_name = gcs_object_name.replace('/', '_')
# Remove any extensions
gcs_file_name = gcs_file_name.split('.')[0]
# Remove any dots
gcs_file_name = gcs_file_name.replace('.', '_')
return f'.{gcs_file_name}{MIGRATION_TOGGLE_FILE_SUFFIX}'

@ -2653,7 +2653,7 @@ class GcsDependency(Dependency):
or f'.{gcs_file_name}')
# Remove any forward slashes and drop any extensions
file_prefix = self.object_name.replace('/', '_').split('.')[0]
file_prefix = self.object_name.replace('/', '_').replace('.', '_')
hash_file = os.path.join(output_dir, f'.{file_prefix}_hash')
migration_toggle_file = os.path.join(
output_dir,

Loading…
Cancel
Save