The git path is based on the git version, so it might change whenever git is
updated. Run git.bat instead, since that's updated with new git installs and
should always point to the right path.
Review URL: https://codereview.chromium.org/173393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252299 0039d316-1c4b-4281-b951-d872f2087c98
One line for the fix, 30 lines for the test :)
R=kbr@chromium.org, mmoss@chromium.org, stip@chromium.org, szager@chromium.org
BUG=345073
Review URL: https://codereview.chromium.org/165443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252138 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit cdd9690946, which
broke gerrit_unittest.py within the chroot, which has Java 6.
Original-Review URL: https://codereview.chromium.org/164023005
TBR=szager
BUG=344786
TEST=Run the unit tests before and after. Confirm this CL fixes them.
Review URL: https://codereview.chromium.org/170423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251976 0039d316-1c4b-4281-b951-d872f2087c98
These may be named git-snapshot-VERSION.war, where VERSION is the long
format defined in git-describe(1). In particular, this may include a
number of commits after the given tag name; treat more commits since
the tag as a higher version number. This is arguably not always
strictly correct due to non-linear history, but the maintainers expect
the total number of such snapshot versions to be low, and can remove
old snapshot versions that don't sort correctly.
Slightly de-obfuscate some of the variable names and logic while we're
at it.
R=szager@chromium.org
BUG=
Review URL: https://codereview.chromium.org/164023005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251888 0039d316-1c4b-4281-b951-d872f2087c98
The goal of this change is to include the DIA SDK (and strip out
a bit extra that was unnecessary).
Unfortunately, the msi that includes the DIA SDK includes a file with an
extraordinarily long path, 241 characters long. When prepended with
"C:\Program Files (x86)\" it extracts OK, however, when we extract to
%TEMP% it's not hard for it to exceed _MAX_PATH and have the msi tool
fail. So, when extracting MSIs, also do the equivalent of
"subst X: temp_dir" and use X:\ as the path given to msiexec. (sigh)
R=maruel@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/150333005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251085 0039d316-1c4b-4281-b951-d872f2087c98
It's somewhat annoying to have the script delete your toolchain
directory (at least during testing) and it necessitates downloading
3-4G to restore, so add a short timeout before doing so.
Also, hide the output of taskkill'ing mspdbsrv so that the first message
isn't '''ERROR: The process "..." not found.'''.
R=maruel@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/146583012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251084 0039d316-1c4b-4281-b951-d872f2087c98
This typo was introduced in https://codereview.chromium.org/106403003.
Rename options.dryrun to options.dry_run.
R=agable@chromium.org,dpranke@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/138623008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250802 0039d316-1c4b-4281-b951-d872f2087c98
To force revert to the old git, and uninstall the new one, set:
DEPOT_TOOLS_GIT_1852=0
BUG=341967
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/156713005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250622 0039d316-1c4b-4281-b951-d872f2087c98
This is in preparation for once again making 1.8.5.2 the default Windows git.
Also remove the CHROME_HEADLESS condition, which confuses bot setup because the
same bot will sometimes run without that set (e.g. at slave startup) and with
it set (e.g. during a build), leading to the wrong, or even no, git installed.
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/160033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250486 0039d316-1c4b-4281-b951-d872f2087c98
Relative root no longer makes sense after an os.chdir().
This is effectively a partial revert of r250248.
Review URL: https://codereview.chromium.org/135213006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250478 0039d316-1c4b-4281-b951-d872f2087c98
There are several bot failures, some understood, some not. This will revert
bots to the old git until all the failures can be investigated.
Users who want the new git can still install it with an explicit:
set DEPOT_TOOLS_GIT_1852=1
R=hinoka@google.com
Review URL: https://codereview.chromium.org/150203005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250239 0039d316-1c4b-4281-b951-d872f2087c98
The new git broke then XP bots because it relies on WinAPIs that are newer than
XP.
R=szager@chromium.org
Review URL: https://codereview.chromium.org/137213011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250211 0039d316-1c4b-4281-b951-d872f2087c98
This can be overridden, and the old git installed, with:
set DEPOT_TOOLS_GIT_1852=0
rd /s /q git-1.8.5.2.chromium.1_bin git-1.8.0_bin
gclient
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/136693024
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250132 0039d316-1c4b-4281-b951-d872f2087c98
The new git will only be installed when DEPOT_TOOLS_GIT_1852=1, otherwise the
previous version will be installed.
BUG=322954
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/152043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249609 0039d316-1c4b-4281-b951-d872f2087c98
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:339665
TEST=repo sync works
Review URL: https://codereview.chromium.org/146723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249277 0039d316-1c4b-4281-b951-d872f2087c98
Given that we search for the gclient root in ancestor directories based on the file name, specifying a file with separators doesn't make a lot of sense.
BUG=336946
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/150633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249077 0039d316-1c4b-4281-b951-d872f2087c98
Use the source root (src/ in Chromium) rather than the checkout root as
the path from which to locate the clang-format binaries.
webrtc uses the Chromium build/tools infrastructure but doesn't have
src/ as a source root path. This change allows us to continue to use
'git cl format' in a standalone webrtc checkout (which would be nice.)
BUG=240309
TESTED='git cl format' works on a trivial test change in both a
Chromium and webrtc checkout.
Review URL: https://codereview.chromium.org/135653014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248651 0039d316-1c4b-4281-b951-d872f2087c98
And for now, defaults to Express.
Main changes:
- Valid hash becomes a set of hashes one for Pro, one for Express
- Include WDK to get an old copy of ATL as that doesn't come
with Express
BUG=323300
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/148453008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248622 0039d316-1c4b-4281-b951-d872f2087c98
(It's a bit unfortunate that we're duplicating the default -regex list in
clang-format-diff.py here :-/ But the .js and .proto stuff is probably not
quite ready yet anyhow, so I'm only adding .mm for now.)
TEST=Edit a .mm file, commit, run `git cl format`, `git diff` shows formatted
output.
TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/152303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248424 0039d316-1c4b-4281-b951-d872f2087c98
urllib.urlopen() has issues with proxies similar to the ones reported in bug
134165 that are not present in urllib2.urlopen() -- namely, it does not
perform HTTP tunneling with proxy servers when fetching HTTPS URLs.
TEST=Pass --url=https://someurl to trychange.py behind a corporate proxy
R=maruel@chromium.org,iannucci@chromium.org,dpranke@chromium.org
BUG=
Review URL: https://codereview.chromium.org/133933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247914 0039d316-1c4b-4281-b951-d872f2087c98
VS2013 isos are mirrored to gs://chrome-wintoolchain/ (which is googler-
only accessible). This is used to isolate bots from external dependency
as detected by CHROME_HEADLESS=1 in the environment.
TBR=iannucci@chromium.orgR=hinoka@chromium.org
BUG=324987
Review URL: https://codereview.chromium.org/148613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247398 0039d316-1c4b-4281-b951-d872f2087c98
It looked like the bypass_prodaccess flag wasn't passed in all the way to
where it needed to be, causing it to be set to True by default at some point,
which caused the prodaccess path to never happen. This change takes the flag
and brings it all of the way.
BUG=337972
Review URL: https://codereview.chromium.org/147443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247049 0039d316-1c4b-4281-b951-d872f2087c98
For simplicity, the canned presubmit check just calls git cl format
directly with a new option --dry-run which does not change the files on
disk.
Because some users may not have git or clang-format might somehow have
errors, this canned check is a warning. Additionally, if git cl format
fails with an error then the presubmit check will silently report
success to avoid spamming misconfigured users during upload.
BUG=none
Review URL: https://codereview.chromium.org/141493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246066 0039d316-1c4b-4281-b951-d872f2087c98
This is necessary so that Cygwin users have a python directory in depot_tools/,
which will soon be used by gyp_chromium.
BUG=335180
Review URL: https://codereview.chromium.org/141523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245704 0039d316-1c4b-4281-b951-d872f2087c98
BUG=240309
TEST='git cl format' and 'git cl format --full' indent by 4 when run inside of third_party/WebKit
TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/136333010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245694 0039d316-1c4b-4281-b951-d872f2087c98
A very common pattern for the users of this script is to have binaries in
three different folders, eg:
some/folder/win/bin.exe
some/folder/mac/bin
some/folder/linux/bin
Instead of using --platform to specify three different paths, we can recognize
this usage and pass in --auto_platform, and then --directory some/folder/ as the
target.
When enumerating files, it will match each individual file to see if they have
(win|mac|linux) as a parent folder name, and filter out non-matching platforms.
BUG=
TEST= src/third_party/clang_format/bin$ download_from_google_storage --auto_platform --no_auth -b chromium-clang-fomat -dr .
0> Downloading ./linux/clang-format...
Review URL: https://codereview.chromium.org/126893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245643 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
This breaks `gclient sync` for me. Before this patch:
________ found .git directory; skipping src
After this patch:
Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again.
Original issue's description:
> If the destination directory doesn't contain the desired repo, delete it
>
> Basic functionality - this may not be in quite the right place.
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245404
TBR=iannucci@chromium.org,ilevy@chromium.org,cmp@chromium.org,maruel@chromium.org,morrita@chromium.org,borenet@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/141633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245530 0039d316-1c4b-4281-b951-d872f2087c98
As a slight improvement for making changes on Windows, at least run
the pylint steps. The tests do not currently work with a variety of
failures, but at least running pylint would have caught the regressions
encountered here https://codereview.chromium.org/134313007/#msg19.
R=maruel@chromium.org
BUG=334953
Review URL: https://codereview.chromium.org/137243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245420 0039d316-1c4b-4281-b951-d872f2087c98
Basic functionality - this may not be in quite the right place.
Review URL: https://codereview.chromium.org/61623008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245404 0039d316-1c4b-4281-b951-d872f2087c98
sergeyberezin@chromium.org
mmoss@chromium.org
iannucci@chromium.org
davidjames@chromium.org
dborowitz@google.com
scottmg@chromium.org
zty@chromium.org
wtc@chromium.org
hinoka@google.com
borenet@google.com
thestig@chromium.org
akeshet@google.com
mariakhomenko@chromium.org
rdsmith@chromium.org
petermayo@chromium.org
ajm@chromium.org
thakis@chromium.org
raphael.kubo.da.costa@intel.com
enne@chromium.org
bauerb@chromium.org
jsbell@chromium.org
pkasting@chromium.org
nick@chromium.org