aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,180 Commits
6 Branches
0 Tags
186 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'c3daf77a40'
${ noResults }
Commit Graph

10180 Commits (c3daf77a40e8ba8269c57294ae94e45c96cd32c7)
 

Author SHA1 Message Date
Takuto Ikuta 8efb05d3d4 check `siso summary` 
This is to make sure that the command runs as intended and make more
verbose if it has some error.

Bug: b/312632221
Change-Id: I44b372452b37b744f6c02c5a2e34fafe3717e351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5051585
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 1 year ago
recipe-roller 38b8de056e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763864785755509953

recipe_engine:
421035bba2
  421035b (randymaldonado@google.com)
      [recipes-py] adding some task backend helper functions for migr...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib7577d5bdea5e8a7dcdd2546b1d471d4a77bee40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046445
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Josip Sokcevic f078723bf4 [recipes] Trigger recipe roller 
To pick up pylint-2.13 fix

Change-Id: Ie1710a4bc54a7ee6144bc09da719ce1e7db1fa5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046548
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 1 year ago
Josip Sokcevic c348ad841f [pylint] Upgrade dill version 
pylint-2.13 with py3.11 doesn't work with dill-0.3.4. If multiprocessing
is used (--jobs > 1), pylint spins forever. Upgrading to dill-0.3.7
solves the problem.

Bug: 1502901
Change-Id: I78827c505146261e8ade7c907c0c9d2dc6fe8f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046339
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 1 year ago
Josip Sokcevic eb48a6ac0f git_cl: Fix xml format on Win 
Diff paths are no longer normalized, and we can use forward slashes as
separators regardless of the platform.

R=dpranke

Fixed: 1502689
Change-Id: I75a2fe824972f0d98b28eb2146c6f05ee4ae2d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5038641
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 1 year ago
Michael Savigny af69249965 Fix deletion of old build logs 
The code rotating the old build logs expects to delete directories
(since it uses rmtree) but tries to delete all items returned by
os.listdir(...) which may includes symbolic links or regular files.

Change it to only consider the old build logs directories instead.

Based on crrev/5028323, with fix to unit test.

Fixed: b/310900283
Change-Id: I4c618e6618c0193331c063028ebf02d8c4e7baee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5038467
Auto-Submit: Michael Savigny <msavigny@google.com>
Reviewed-by: Ramy Medhat <abdelaal@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
 1 year ago
Josip Sokcevic 06c4261af7 tests: Use collections.abc.MutableSet 
collections.MutableSet is deprecated and removed in py3.11

R=jojwang@google.com

Change-Id: Id09f6f4f64fd59ef66659e7369562f59b8aaa232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5039630
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 1 year ago
Sunny Sachanandani 44d6d1a666 Fix compile_single_file with remoteexec 
When using remoteexec, calling ninja directly instead of ninja_reclient
causes the build to hang. This also breaks compile_single_file since it
calls ninja directly. To fix this, switch it to call autoninja instead
which will take care of this and other details like using autosiso in
the near future.

Also, using autoninja has the side-effect of using a higher -j value
which can help when building a single file causes a lot of other files
to also be built.

Bug: 1502988
Change-Id: Ib86c5c820f7c53a8420973f1b83bf8e711a9af09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037618
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
 1 year ago
Josip Sokcevic 74ed6becbf Trigger recipe roller 
This is to pick up pylint change

Change-Id: I89ad02336f84eff9b7b3d7d99eedac9bca896b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037334
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
 1 year ago
Chan Li 2f184917c4 [depot_tools] roll led 
Changes included in this roll:
- https://crrev.com/c/4970874
- https://crrev.com/c/5001774

Bug: 1495215
Change-Id: I9498cfa5a9b1f8b85e5aa9773eceb5e3e1eb981f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037616
Auto-Submit: Chan Li <chanli@chromium.org>
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
 1 year ago
recipe-roller c38b501c76 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764257370812906417

recipe_engine:
eeeea0249f
  eeeea02 (mohrr@google.com)
      recipes_cfg: Add option to not use OWNERS in rolls

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0a605ddde50065a6d24ed395acd8e42b52e25930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5036794
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Takuto Ikuta df3e577855 apply black and `git cl format` for ninja related python files 
This is made by
$ black --line-length 79 *ninja*.py
$ git cl format

Change-Id: Ic446898a5461ae536542f6312cae2ce126dfe82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035265
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 1 year ago
Takuto Ikuta 0b98e7c063 fix for long line warnings 
This is preparation CL for https://crrev.com/c/5035265.

Change-Id: I9ab8ffed471d3813a0e94bbdb47bf95e3bb46337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5036119
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 1 year ago
Philipp Wollermann 58700cf7f8 Revert "gclient: Add skip-git experiment." 
This reverts commit 8672d51b79.

Reason for revert: crrev.com/c/5018522 has landed, so this is no longer required.

Original change's description:
> gclient: Add skip-git experiment.
>
> This experiment causes all dependencies of type 'git' to be skipped for
> all commands. This can be useful if you need to build Chromium in a
> working tree that is guaranteed to contain a consistent, pre-synced
> snapshot of the code that's managed by Git, but still need to install
> cipd dependencies and run the hooks to download the remaining
> dependencies.
>
> Bug: b/310485239
> Change-Id: Iee1e6a4d62b867b6d7235903817f927a9e806dc1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018571
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Auto-Submit: Philipp Wollermann <philwo@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: b/310485239
Change-Id: If1fc93d493daa9515ddfb568aecf4374deb6ec03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035260
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 1 year ago
Takuto Ikuta 5cbc521beb autoninja.py: remove use_rbe support 
This arg was not used anymore.

Change-Id: If578845fc3e200f4f23c8ca050542b92fcf13ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035261
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 1 year ago
Josip Sokcevic f1cbc0c0b5 tests: Skip tests for old stacked changes flow 
R=jojwang

Bug: 5030767
Change-Id: I8e9ff580404f386b9ad8bbeac2328e6228afbe63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5033924
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 1 year ago
Josip Sokcevic 4cf6518959 scm: Remove usage of distutil 
The package is deprecated and will be removed in py 3.12.

R=ddoman@google.com

Bug: 1500415
Change-Id: Ia130c556ad3f2135fac4a9b1d9bb4ecc088cfe9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030818
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Jonathan Nieder <jrn@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jonathan Nieder <jrn@google.com>
 1 year ago
Josip Sokcevic 8fb358e5b6 Add support for Cog SCM 
Change-Id: I450e1ce7943fda55edf1cb8016f201ce08cd9251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018522
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
recipe-roller 0d849838d9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764325319822961137

recipe_engine:
5944dc6a18
  5944dc6 (jiesheng@google.com)
      Fix the swarming test data init.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I83ab38957eef40f62d72df98a6750c9a75705a2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5034871
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Jie Sheng <jiesheng@google.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Josip Sokcevic 86c7f734f5 pylint: Add pylint 2.13 
Bug: 1500415
Change-Id: I05293251be810772c56530962ef5a33a0f0cc887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030756
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 1 year ago
Anas Sulaiman 1e503bf950 don't confuse users with unimportant and non-actionable error msg 
Bug: b/310852966
Change-Id: I2c64a92a36b817043ff1f7abfa528d4c7aa449e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030272
Reviewed-by: Michael Savigny <msavigny@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Anas Sulaiman <mrahs@google.com>
 1 year ago
Josip Sokcevic fba0ae4a38 recipe_modules/gclient: Exclude non-set properties 
Only set got_*_revision properties that are set.

R=chanli, gbeaty

Fixed: 1502012
Change-Id: I5c42da8d1d5ce37cd3816f1ef4b857a603fc1195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030871
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
 1 year ago
Takuto Ikuta b0cfbe504b infra/config: enable no_cc_authors 
This is to remove cc from 'Roll recipe dependencies' CLs.
I think it is more like spam and don't have good benefit for this
repository.

ref:
https://source.chromium.org/chromium/infra/infra/+/main:recipes-py/recipe_engine/recipes_cfg.proto;l=84-86;drc=63e03ca57cb20f6a776ae27dd1fee9e2dd60f1b7

Bug: 1497879
Change-Id: I8a40dcec3903c817f7212dfe68d0fff1044eef2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5028557
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
recipe-roller 30446729bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764439824095623777

recipe_engine:
9dea1246fd
  9dea124 (mohrr@google.com)
      [defer] Use ExceptionGroups

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifda933c8b6771d753613ee57dea332dfa3b51d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5027489
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Anas Sulaiman 7a9b709a6c avoid unnecessary failures in get_hostname 
The catch clause was specific to one error type, but other errors may also happen such as socket.herror. In any case, the point is to fallback anyways.

Bug: b/310216577
Change-Id: I55561f8f40446f90bee27ea2aab1a4e60c03e7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5024019
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Anas Sulaiman <mrahs@google.com>
Reviewed-by: Michael Savigny <msavigny@google.com>
 1 year ago
recipe-roller 481ceeb0b5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764490784423610257

recipe_engine:
a9737d853f
  a9737d8 (mohrr@google.com)
      [engine] Log step time in multiple formats

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I969bbe0e7c794186d7eaef3ad2c8bd4b58be5b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5028222
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Josip Sokcevic 1cd58a27b0 boostrap: Use python 3.11 in bleeding_edge 
R=bryner

Bug: 1500415
Change-Id: I37f90909f57be51253ca64faf3994938d57c3479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5026367
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 1 year ago
recipe-roller 940c4a01db Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764509030854892129

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
20788e5b9b
  20788e5 (mohrr@google.com)
      [recipe_engine] Always show full stacks

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb9047f921b1740485954fa5aa6e9b47a4e857d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5026363
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 1 year ago
Philipp Wollermann 8672d51b79 gclient: Add skip-git experiment. 
This experiment causes all dependencies of type 'git' to be skipped for
all commands. This can be useful if you need to build Chromium in a
working tree that is guaranteed to contain a consistent, pre-synced
snapshot of the code that's managed by Git, but still need to install
cipd dependencies and run the hooks to download the remaining
dependencies.

Bug: b/310485239
Change-Id: Iee1e6a4d62b867b6d7235903817f927a9e806dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018571
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Philipp Wollermann <philwo@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 1 year ago
Liviu Rau 7f22330c69 Make rdb status calculation reusable 
Bug:none
Change-Id: Ie7058e40d6e0174af382ef8f4ecfb62403683890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5017798
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 1 year ago
recipe-roller ea9bf7f343 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764834298602223825

recipe_engine:
2e756c9e02
  2e756c9 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from b9d18397d77b to bd7ce256f73f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8dd8e3b463a293af1f5cc7878da18cafa742f939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018311
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller dbd29671bd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764857576817952065

recipe_engine:
1453bfeae7
  1453bfe (bryner@google.com)
      Add the 'packaging' wheel for recipes.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7b42bbb920a8650602fece8c0c3e4ef6b27b0883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018304
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Josip Sokcevic 88cc0b8ca8 Remove old Cog detection 
This is no longer needed.

R=aravindvasudev@google.com

Change-Id: Ic1b2bbf0f00ca9d288c21fa1623c4ada80d59644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5014581
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 1 year ago
Philipp Wollermann 5828285134 Deprecate autosiso.bat and autosiso. 
These are no longer needed, since autoninja now delegates to either
Ninja or Siso based on the value of the "use_siso" GN arg.

Bug: b/293657720
Change-Id: I612640c6f902b2a1336f856fdf3f723214114ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4997648
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 1 year ago
recipe-roller 3a66263cd2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764943767322242401

recipe_engine:
5aabe73071
  5aabe73 (mohrr@google.com)
      [lint] Remove --whitelist compatibility option

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I934966367d0feb379b4a166b590aec09a545946d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5014361
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller ccad06fb9e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764970822512777857

recipe_engine:
d084b4e8e9
  d084b4e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2baa055d4de9 to 38b65dfa7a0d

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4fc9e7e4d0276980f0c17c96b996aaf3c20538c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5013629
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Anne Redulla a83e690662 [ssci] Add condition on license field separator warning 
This CL updates the License field validation so that the warning to use
the standard comma separator is only returned if processing the license
value resulted in multiple license types.

Bug: b:309712938
Change-Id: Ic9189b8dd76e60bc3d546dea41fdb36faae8dbb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5003558
Auto-Submit: Anne Redulla <aredulla@google.com>
Commit-Queue: Anne Redulla <aredulla@google.com>
Reviewed-by: Dan Le Febvre <dlf@google.com>
Commit-Queue: Dan Le Febvre <dlf@google.com>
 2 years ago
Thiago Perrotta 197399a8ac depot_tools: add a `--dry-run` alias to `--cq-dry-run` 
It is easier to remember.

Bug: none
Change-Id: I075fe57521c9743901f51bd1ed3476145553dc48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5010037
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Auto-Submit: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
recipe-roller e72395e5f2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765057016742708849

recipe_engine:
165afa5162
  165afa5 (mohrr@google.com)
      [recipe_engine] Handle Exceptions containing StepFailures

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib176adaa4849e446834e841d3d55ad3ee857e58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5011174
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic a309d29905 Remove .git suffix from git submodules 
.git suffix is not well supported by the systems that utilize
submodules. Since some tools expect DEPS to have .git suffix, it's not
possible to simply update DEPS without breaking the tools.

This patch updates `gclient gitmodules` to omit .git suffix and trailing
slashes. However, if `.gitmodule` already exists, we are expecting the
tool to generate the same result if DEPS didn't change.

R=aravindvasudev@google.com

Bug: b/303296048
Change-Id: I30497b9d5f4e9681e16b4a913151de0f4a7c9545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5008942
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller 7e176f1437 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765062049832958865

recipe_engine:
45ce979f73
  45ce979 (mohrr@google.com)
      [recipe_engine] Remove defer_results

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia1319648ecdd3d9b49d2bcaffac92c93d824a59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5010974
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller ccc34d2b44 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765128110125877921

recipe_engine:
351d79bca5
  351d79b (jwata@google.com)
      [cas] Change the default log level to info

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I819e37df296fdac63df47b912332a1a2224653d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5008954
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 0c5e8652fe Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765166478393504977

recipe_engine:
94e9b251b5
  94e9b25 (jonahhooper@google.com)
      [swarming] [recipe] Updated swarming cli to more recent version

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaeac515e49bcecdaa0675faaec9f5a181844a13b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5007795
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller b4e466e610 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765506226653258785

recipe_engine:
d9994e3522
  d9994e3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from dfbae63f58ac to 540222a3d0b1

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia282c8ff794bcf8b00e752e98632490c427a02fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5001969
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller f007e78ef9 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8765521324786787649

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
bc82350667
  bc82350 (iannucci@chromium.org)
      [recipe_engine] Switch recipes to execute with python3.11.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d1084286366429b245e958e453bf73e883c78e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5001769
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2 years ago
Philipp Wollermann 17debef507 autoninja.py: Enable offline mode for Siso when use_remoteexec not set 
Tested with:

$ autoninja -C out/fastbuild-siso-local base
offline mode
 2.48s loading build.ninja
pre:0 local:176 remote:0 5.7/s fallback:0
[...]
5m40.86s Build Succeeded: 1641 steps - 4.81/s

$ autoninja -C out/fastbuild-siso-reclient base
Running gcloud auth print-access-token --trace-token=interactiveauth
Proxy started successfully.
124.260 s to start reproxy
 5.32s loading build.ninja
15.93s Regenerating ninja files
 2.75s update filegroups
 4.84s loading build.ninja
pre:0 local:1 remote:0 30.2/s cache:100.00% fallback:0
[...]
2m05.55s Build Succeeded: 2560 steps - 20.39/s

R=jwata, ukai

Change-Id: Ib976b874796a20dca55005986ee6f7ee3c942245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4997466
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2 years ago
Aravind Vasudevan a413ee7249 [gsutil.py] Skip luci-auth wrapper on unsupported platforms 
On unsupported platforms, luci-auth is not downloaded from CIPD and
hence the scripts relying on gsutil.py fail. Given we aren't using
luci-auth in unsupported platforms anyway, skip wrapping gsutil with
luci-auth on unsupported platforms.

Curently, only "aix" is added to the unsupported platforms list
eventhough we have other unsupported platforms too. This list will be
expanded if necessary.

R=yiwzhang

Change-Id: I70f6fceddc672c76bbea9a108a75b84662e26459
Fixed: 1467752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4989412
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
Yiwei Zhang 23c4defd8d fetch: stop setting submodules config as we are not using it at all 
R=sokcevic

Bug: 1496925
Change-Id: I448fb1f49b225d1a5f60103dbbcacaea2c69bd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995365
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Yiwei Zhang 03a1a8936e pre-commit: do not ignore submodule when running diff-index 
Without this line, if the git config specifies to ignore submodule
change (what happned in the associated bug), this script is useless
because the command will never return gitlink change

R=sokcevic

Bug: 1496925
Change-Id: I6536b95502e708e44d6fd3e4909fd30eac8c7c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995364
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Junji Watanabe 9ed72f91a9 [siso] Propagte SIGINT to siso process 
siso's signal handler doesn't run as expected with siso/autosiso
wrappers.
This CL sets signal handlers for the Python wrappers to propagate
signals to siso.

Note that Siso immediately exists at the 2nd Ctrl-C.
So developers can stop Siso forcibly when they want.

Bug: b/308734805
Change-Id: Idd8cc1d99931d609cfc3bedfb4c0bb4319cd20b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4996768
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2 years ago