Edward Lemur
be83c310e3
git-hyper-blame: Make tests run on Python 3.
...
Bug: 1009809
Change-Id: If3099898a75837d3cee35bf9920680665dd4d322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838257
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
recipe-roller
cef11fda71
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/1cc8317a701750c47ac3fe5183af8e105f9c36bc swarming: always mock bot and task IDs in test mode. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I47dc290d63ef5c35c2adae5cd2d0480281eaadaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1848260
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
b7a7f1c05e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/3d26d5f05680aa707e527b8c291d298cd3d35748 swarming: support overriding default bot_id and task_id in test_api. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a1609364e8a9abb3a3a3d7f73ce5126ee8338f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1847962
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
c38e00052f
Revert "git-cl: Set legacy properties."
...
This reverts commit f0faf48ddb
.
Reason for revert:
Legacy properties are no longer used by Skia.
Original change's description:
> git-cl: Set legacy properties.
>
> Will be removed back again on Oct 9, 2019.
>
> Bug: 1004447
> Change-Id: I7003fac9ae8b184e2a7073b516535e8fd599f4f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825446
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
TBR=tandrii@google.com,ehmaldonado@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1004447
Change-Id: I4e1fb31b6179bf10c3d9554cd313f7040aaf1b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1847959
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
recipe-roller
15676c0e3b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f84207a8e5eb80f11bb414e98b4177471d69419e Make tandrii@ top level recipe engine OWNER. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I94d1a8cf32e7c29e5f94c588ecb272f82213eb93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1847957
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
1f3bafbab4
git-cl: Run using vpython
...
Bug: 1002153
Change-Id: I02ffa574f072575c4b6662a7f32678428ed3f85d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845498
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
352808fa15
git-number: Make tests run on Python 3.
...
Bug: 1009809
Change-Id: I044f10a7a04f4837cba6e17d8f3053471cd7a643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1841875
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Andrii Shyshkalov
1458d572f9
recipe_module git: remove non-LUCI mode.
...
R=maruel
Bug: 1012148
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: build
Change-Id: I386b540ef1d68d2f20031111ad5b693eb35c57a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846736
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
6 years ago
Andrii Shyshkalov
1ad5811acc
git cl upload --retry-failed: search back up to 5 patchsets.
...
Make it work the same way as "git cl try --retry-failed".
R=ehmaldonado
Change-Id: Id3a709dc40b6b6d068acbba0c610da254ced8ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845478
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
6 years ago
Andrii Shyshkalov
e7ae514a47
git_cl: fix test.
...
R=ehmaldonado
Change-Id: Ia5c5d5fffdace2ce18fb0b2e5535370b9619dde4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846771
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
6f6611617c
git-drover: Fix tests to run on Python 3.
...
Bug: 1009809
Change-Id: I5f453c7e019376e502716ab2e9891a97663d1f28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838254
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
6 years ago
Edward Lesmes
ab51754cc7
depot_tools: Run git_cache_test and git_footers_test on windows.
...
Bug: Some
Change-Id: I74eef44bfe3d940c773e548e6d1035dee4cd45ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842638
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Bob Haarman
eeafa0eaec
Revert "gclient_utils: buffer output as bytestrings in Annotated"
...
This reverts commit 5d284fdf48
.
Reason for revert: breaks buildbots, crbug.com/1011982
Original change's description:
> gclient_utils: buffer output as bytestrings in Annotated
>
> In Python 3 byestrings and normal strings can't be concatenated.
> To fix this we buffer as bytestrings in the Annotated wrapper.
> We can't decode to a string because the output might come byte-by-byte, so it doesn't work with Unicode characters like ✔.
>
> Also had to update gclient_test.py, where double-wrapping stdout with Annotated caused made output not work and include_zero=True working caused other unintended side-effects.
>
> Example error from "fetch chromium":
> Traceback (most recent call last):
> File "C:\Google\depot_tools\gclient_scm.py", line 1045, in _Clone
> self._Run(clone_cmd, options, cwd=self._root_dir, retry=True,
> File "C:\Google\depot_tools\gclient_scm.py", line 1370, in _Run
> gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
> File "C:\Google\depot_tools\gclient_utils.py", line 583, in CheckCallAndFilter
> show_header_if_necessary(needs_header, attempt)
> File "C:\Google\depot_tools\gclient_utils.py", line 533, in show_header_if_necessary
> stdout_write(header.encode())
> File "C:\Google\depot_tools\gclient_utils.py", line 391, in write
> obj[0] += out
> TypeError: can only concatenate str (not "bytes") to str
>
> Bug: 984182
> Change-Id: If7037d30e9faf524f2405258281f6e6cd0bcdcae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778745
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Raul Tambre <raul@tambre.ee>
TBR=dpranke@chromium.org,ehmaldonado@chromium.org,raul@tambre.ee
Change-Id: I5ea8d3249c58a3487996649a264bb5be059fe884
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845500
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
3306bbe476
depot_tools: Remove buildbucket.py
...
Change-Id: I6b66880361a5fcbff4652b40adbe96da85ecabac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845819
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
6 years ago
recipe-roller
c9598be3ad
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/60cb7d1afaec1ce649a9d233e9575dc752881b5f scheduler: stop supporting using `properties`. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I068e32f1df035e83701cbc25872175fb765a9086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845820
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Raul Tambre
5d284fdf48
gclient_utils: buffer output as bytestrings in Annotated
...
In Python 3 byestrings and normal strings can't be concatenated.
To fix this we buffer as bytestrings in the Annotated wrapper.
We can't decode to a string because the output might come byte-by-byte, so it doesn't work with Unicode characters like ✔.
Also had to update gclient_test.py, where double-wrapping stdout with Annotated caused made output not work and include_zero=True working caused other unintended side-effects.
Example error from "fetch chromium":
Traceback (most recent call last):
File "C:\Google\depot_tools\gclient_scm.py", line 1045, in _Clone
self._Run(clone_cmd, options, cwd=self._root_dir, retry=True,
File "C:\Google\depot_tools\gclient_scm.py", line 1370, in _Run
gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
File "C:\Google\depot_tools\gclient_utils.py", line 583, in CheckCallAndFilter
show_header_if_necessary(needs_header, attempt)
File "C:\Google\depot_tools\gclient_utils.py", line 533, in show_header_if_necessary
stdout_write(header.encode())
File "C:\Google\depot_tools\gclient_utils.py", line 391, in write
obj[0] += out
TypeError: can only concatenate str (not "bytes") to str
Bug: 984182
Change-Id: If7037d30e9faf524f2405258281f6e6cd0bcdcae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778745
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
6 years ago
Raphael Kubo da Costa
5189047f97
download_from_google_storage: Decode string passed to re.search()
...
The code in _downloader_worker_thread() does not work with Python 3:
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python3.7/threading.py", line 926, in _bootstrap_inner
self.run()
File "/usr/lib/python3.7/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/home/rakuco/src/depot_tools/download_from_google_storage.py", line 343, in _downloader_worker_thread
elif re.search(r'executable:\s*1', out):
File "/usr/lib/python3.7/re.py", line 183, in search
return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object
Bug: 984182, 1007872
Change-Id: I09df8169d802b010596ac4f34501b4bda805e6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1844833
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Raphael Kubo da Costa
e225ef6ac5
download_from_google_storage: Do not call decode() on a string twice
...
This throws an exception when running with Python 3:
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python3.7/threading.py", line 926, in _bootstrap_inner
self.run()
File "/usr/lib/python3.7/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/home/rakuco/src/depot_tools/download_from_google_storage.py", line 259, in _downloader_worker_thread
file_url = '%s/%s' % (base_url, input_sha1_sum.decode())
AttributeError: 'str' object has no attribute 'decode'
We are already calling bytes.decode() in enumerate_input(), whose output
is passed to _downloader_worker_thread().
Bug: 984182, 1007872
Change-Id: I55c4835192caf69a8dee9e89ae1bb5531f4bacae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1844832
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Raphael Kubo da Costa
107c97c837
gclient_utils: Stop using execfile()
...
execfile() does not exist in Python 3; replace it with open(), read()
and exec().
Bug: 984182
Change-Id: I2266ff2bd63bffc458bd04500c8c0d6c360f1b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1844831
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
recipe-roller
4102985e14
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ac1ee2b1e0f55d7bdd89ab7746bc00d679c93728 Followup to https://chromium-review.googlesource.com/c/1843211 . (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie4c20535c7526a5c7825cb077480ae0120176ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1844635
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
c9256e1630
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b3a48f21daa4a8f74a59d9d868c760aecfba360d [futures] Expose metadata for Futures. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b5d4c94b8c1958bc0980e9f175ce84b4f2816fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1843271
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Robert Iannucci
09315982bc
[git_cache] Add option to break locks on populate.
...
R=ehmaldonado@chromium.org, tandrii@chromium.org
Change-Id: Icd7b0afc98e6d9365f74e8a6eb232700c6362d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842832
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
6 years ago
recipe-roller
d696f20129
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/8dd8812fab57cb92382a2d20a0be10164b51cdf5 [vpython] Add pywin32 wheel on 32bit windows too. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ief5cef362e4353dfdb3ed7987a3ba440cd7685c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842336
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
37c463fe9c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/82c1aa10460d1e0f498026a8f5cff566a269b1c9 [third_party/logdog] Only asyncify the file after the handshake. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7812d0c02f69256ddfd4b742ac0dc23e05d94f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1841189
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
8a85962557
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6277a86cea12e7c3e24b78f32271f0a40b035726 [luciexe] Allow luciexe recipes to always set summary_markdown. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I08be31f5d56d81e2a45233474a0a3ea673f2ed11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1841182
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
aa4d8a7560
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e051b6e61887a79ca02fa2f912163032754d7948 [context] Fix context module to use greenlet-specific storage. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2ea83d559c18f7c59f82c37bf39186c14107e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1839548
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
94c33f91b3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/cb5e29908c24ae791cbc0c1fc17e9098bc2157cc Revert "recipe module buildbucket: migrate to protos for inputs." (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibbdaebb39481e6d5c817f074a88bdfb2fb91164e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1839252
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
d2b74ffc01
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/aa84e2a4f50fe7ed19690fa61b0d1f8294964b14 Account for step resource costs before opening file handles for them. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iec475ff0be5440f789dc1ca1f105e1ed8c2b2a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838708
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
3453ca5cd5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/d2e4b2a70ea05c4b1230dee1f1f45029419a029e Add internal API to set summary markdown directly. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib18ea53c3134da65329c5f00543be28ed353319f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838560
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
e5dc26e9be
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/27118793ad8c4be3e818cacece11c425ef6f224a buildbucket: add generic_build to test API. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8884b6fae8b26b1117e1ea6f30c53a38ac6f9a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838705
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
f3c5fefedb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/714c8e0c2a2fc10569e6f943198685acbbdd845c recipe module buildbucket: migrate to protos for inputs. (tandrii@google.com )
https://crrev.com/671bf52ae83b2335d65be8618855444b8fec0f20 [logdog/bootstrap] Fix behavior of bootstrap to match go version. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97ee3efc3db222c42f1eec05e1e366cb9d8c8836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838259
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
678a6843ee
git-cl: Clean-up
...
Get rid of _process_codereview_select_options and detected_codereview_from_url and simplify issue parsing.
Change-Id: I4200fd83ee868587c8627d6771c64f886b34a88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838384
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
6215c79a8c
git-cl: Better warning message for legacy buckets.
...
Bug: 976104
Change-Id: Ide06f73faf7a9ce6aa2d7f47deffc0c505dcdb14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835017
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
5da394f8e1
depot_tools: Run git_footers_test on Python 3.
...
Bug: 1009809
Change-Id: I39bbb288a96bbb349747a3aa080f505d3b3a2cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835041
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
6 years ago
Edward Lemur
12a537f932
depot_tools: Run git_common_test in Python 3
...
Bug: 1009809
Change-Id: Idfcbd26de3420798f092c7fa55a6126d7c389a8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1834317
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
4508b4223b
git-cl: Set CC from watchlists only on first upload
...
This will prevent moving reviewers to cc when uploading patches.
Bug: 1010499
Change-Id: Ida16a4686f46350ba009bdaec1542895208c3f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835016
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
6 years ago
Dan Beam
b295105c22
Make presubmit bark at FIXED= in CL description
...
"Fixed:" is equivalent and the preferred syntax.
Also sets up a more generic mechanism for "unwanted tags",
which BUG= and TBR= may eventually be when we're ready to
move over to git-footers more fully.
Bug: monorail:4470
Change-Id: I2e999d364292447124870b8d3539fde1ac1eb4ec
Recipe-Nontrivial-Roll: chromiumos
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836607
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
6 years ago
Dan Beam
6295404c95
Support "Fixed:" syntax in BugsFromDescription()
...
Bug: monorail:4470
Change-Id: I2a1dcc1fe00d29f9d058152c15c75f8f904c354a
Recipe-Nontrivial-Roll: chromiumos
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836601
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
6 years ago
recipe-roller
d73aef1548
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e1e1d1ba78ce2f3c129dbe6ba4d92b431deec422 recipe module buildbucket: get rid of real legacy `buildbucket` property. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I89c92126dc46b9ba00f8e65e65f7b501ed5e36a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1838556
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
e90e5fe206
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/802a2286d006c308502f97f98bd9f44a1b72b31e Remove trigger_specs. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic53ad3b8ef9cb426b8e4caef867eee7d3d08ebee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1837373
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
336a2b1faf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/8e2b5104ac52091e7d02228665b7eca4eade38ad [futures] Close non-parent steps when launching a new greenlet. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I212bf0029ab8a4da09181255e23c790df5e66038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836640
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
0a33d2b80f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/da69b209693657ea0d95ec8dbdaaff2cb2d56f80 [futures] Add docstring for README TOC. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia38dfc6a36b85255831ccb207aa8dd6d258fef2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836634
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
4ebf3a7598
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/fc4aeac8bd7b0f6eeaa913826d4aa7054803697e recipe module buildbucket: do not depend `properties` module in test_api. (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I996fbb6fc907a2f8a1221ee46499a2fd4ca7f9e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836480
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
f417d3ad50
depot_tools: Run git_cache_test and git_dates_test on Python 3.
...
Bug: 1009809
Change-Id: I430b5a78ee0f63388d7bed5be542abe10b37cd53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835040
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
recipe-roller
6154fb127e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/beadb7584b9086527329b8054230344de88d1873 Revert "[futures:examples/background_helper] Speculatively switch to os._exit" (tandrii@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd63dd43eb571e5cb5b2170fadb29ea5cf73df17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836181
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Michael Moss
6b4c2a88f3
Run git_cl commands as a python step.
...
Otherwise this fails on Windows because git_cl.py "is not a valid Win32
application".
R=gbeaty@google.com, iannucci@google.com
Bug: 726111
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835598
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
2458b31208
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/39baf65a40b3d08e7cd414493fe607eaf18637d0 [futures:examples/background_helper] Speculatively switch to os._exit (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6aec1774291320d3efcb98badb2ca14895615750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835593
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
d9682cc2dc
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/88c098c1d36351d6b551c604122ddb27236b2038 [step] Improve cost model to cover memory, disk and network resources, too. (iannucci@chromium.org )
https://crrev.com/b82054e1d929cdff567df166edf927361181bf67 Revert "[step] Improve cost model to cover memory, disk and network resources, too." (iannucci@chromium.org )
https://crrev.com/ba63a44cf653ce3c0689eb83c9e1e1ac9c56cd19 [step] Reland: Improve cost model to cover memory, disk and network resources, too. (iannucci@chromium.org )
https://crrev.com/1420284b2c0f4907392b8381d60fcb72d3a2faa9 [stream/luci] Initially mark steps as SCHEDULED. (iannucci@chromium.org )
https://crrev.com/7323ee69d6f28d139a8713e9c4d89dbe10f3ac4e [third_party/logdog] Remove defunct features. (iannucci@chromium.org )
https://crrev.com/343724f653bf18d849d16fb07d0050a4ea7d93cc [luciexe] Make butler streams async, throttle build.proto updates. (iannucci@chromium.org )
https://crrev.com/76efe56b109dde457e2a2dec61923759bd21083c [luciexe] Mark non-subprocess steps as started, too :) (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib87050a805a3811639d43196f0451e0992a91e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835050
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Andrii Shyshkalov
2025b98401
recipes: update to stop using legacy properties.
...
The only exception is 'revision' of gclient's weird RevisionResolver,
which will be tackled in https://crbug.com/949334
R=ehmaldonado
Bug: 877161
Change-Id: Ic65a2d13578802cf093f2a1cfb4002fe97509b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818973
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
6 years ago
Edward Lemur
5eac9d3013
depot_tools: Fix bug when running download_from_google on Python 3.
...
Issue caused by utf-8 vs byte mismatch in python 3.
Bug: 1009698
Change-Id: I8ab6b129ea9ab18f06f8ff4eb5da3aa018829365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1832773
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
6 years ago