Revert "git-cl: Set legacy properties."

This reverts commit f0faf48ddb.

Reason for revert:
Legacy properties are no longer used by Skia.

Original change's description:
> git-cl: Set legacy properties.
> 
> Will be removed back again on Oct 9, 2019.
> 
> Bug: 1004447
> Change-Id: I7003fac9ae8b184e2a7073b516535e8fd599f4f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825446
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1004447
Change-Id: I4e1fb31b6179bf10c3d9554cd313f7040aaf1b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1847959
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

git_cl.py

@@ -462,7 +462,6 @@ def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
 
   gerrit_changes = [changelist.GetGerritChange(patchset)]
   shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
-  shared_properties.update(changelist.GetLegacyProperties(patchset))
   if getattr(options, 'clobber', False):
     shared_properties['clobber'] = True
   shared_properties.update(_get_properties_from_options(options) or {})
@@ -2748,34 +2747,6 @@ class Changelist(object):
     if data['status'] in ('ABANDONED', 'MERGED'):
       return 'CL %s is closed' % self.GetIssue()
 
-  # TODO(1004447): Remove on Oct 9th, 2019.
-  def GetLegacyProperties(self, patchset=None):
-    host = self.GetCodereviewServer()
-    issue = self.GetIssue()
-    patchset = int(patchset or self.GetPatchset())
-    data = self._GetChangeDetail(['ALL_REVISIONS'])
-
-    assert host and issue and patchset, 'CL must be uploaded first'
-
-    revision_data = None  # Pylint wants it to be defined.
-    for revision_data in data['revisions'].itervalues():
-      if int(revision_data['_number']) == patchset:
-        break
-    else:
-      raise Exception('Patchset %d is not known in Gerrit change %d' %
-                      (patchset, issue))
-
-    return {
-        'patch_issue': issue,
-        'patch_set': patchset,
-        'patch_project': data['project'],
-        'patch_storage': 'gerrit',
-        'patch_ref': revision_data['fetch']['http']['ref'],
-        'patch_repository_url': revision_data['fetch']['http']['url'],
-        'patch_gerrit_url': host,
-    }
-
-
   def GetGerritChange(self, patchset=None):
     """Returns a buildbucket.v2.GerritChange message for the current issue."""
     host = urlparse.urlparse(self.GetCodereviewServer()).hostname

tests/git_cl_test.py

@@ -3230,15 +3230,6 @@ class CMDTryTestCase(unittest.TestCase):
                     "category": "git_cl_try",
                     "json": [{"a": 1}, None],
                     "key": "val",
-                    'patch_issue': 123456,
-                    'patch_set': 7,
-                    'patch_project': 'depot_tools',
-                    'patch_storage': 'gerrit',
-                    'patch_ref': 'refs/changes/56/123456/7',
-                    'patch_repository_url':
-                        'https://chromium.googlesource.com/depot_tools',
-                    'patch_gerrit_url':
-                        'https://chromium-review.googlesource.com',
                 },
                 "tags": [
                     {"value": "win", "key": "builder"},