Commit Graph

8210 Commits (a40c1e166623f178ea2e83731c57b9136765327c)
 

Author SHA1 Message Date
Greg Guterman be5fccd4de [rts] Add -q flag to git cl try, upload, and set_commit
Quick run is only set when the -q flag is passed. It is not set to 0 by
other flags because only Chromium has Quick run and there are other
depot_tools users. We rely on the CQ to set the flag back to 0.

Bug: 1192827
Change-Id: I3310c9f005343f7d3eea56eaad5f19c7ba751921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927818
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Dirk Pranke ef579a1192 Revert "Reland "Update gsutil to use gsutil version 4.61, python3.""
This reverts commit e53a593956.

Reason for revert: Speculative revert for build failures on Mac11 bots: crbug.com/1219065.

Original change's description:
> Reland "Update gsutil to use gsutil version 4.61, python3."
>
> This reverts commit af121aeec9.
>
> Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance.
>
> Original change's description:
> > Revert "Update gsutil to use gsutil version 4.61, python3."
> >
> > This reverts commit f059ec9368.
> >
> > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640.
> >
> > Original change's description:
> > > Update gsutil to use gsutil version 4.61, python3.
> > >
> > > This CL updates the gsutil.py wrapper to download and use
> > > v4.61 of GCP's gsutil, which is Python3-compatible.
> > >
> > > v4.61 appears to be fully self-contained and have all of the
> > > packages it needs vendored into it. So, there's no reason to
> > > use vpython anymore, and this CL removes that.
> > >
> > > Also, this CL removes the 'fallback' option to gsutil and
> > > the ability to force a version switch, as this should no
> > > longer be necessary (it was added for a migration back in 2014
> > > but apparently this code was never removed afterwards).
> > >
> > > This CL also updates download_from_google_storage.py and
> > > upload_to_google_storage.py to similarly not have the version flags
> > > and to just use regular python3, not vpython3.
> > >
> > > Bug: 1184108
> > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439
> > > Reviewed-by: Mike Frysinger <vapier@chromium.org>
> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> >
> > Bug: 1184108
> > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
>
> Bug: 1184108
> Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155
> Reviewed-by: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>

Bug: 1184108
Change-Id: Ib0757e0873d6e6b39621d50d327d959f0fa43720
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2957473
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
Brian Ryner e5d455cca7 Roll new cpython(3) packages to depot_tools.
This contains
https://chromium-review.googlesource.com/c/infra/infra/+/2943752 , a
stability fix for Mac (and potential startup performance improvement).

Bug: 1215121
Change-Id: I77a90b8b00ddf0570dc8e0e5821c0b31b60ab79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2951423
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
4 years ago
Dirk Pranke e53a593956 Reland "Update gsutil to use gsutil version 4.61, python3."
This reverts commit af121aeec9.

Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance.

Original change's description:
> Revert "Update gsutil to use gsutil version 4.61, python3."
>
> This reverts commit f059ec9368.
>
> Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640.
>
> Original change's description:
> > Update gsutil to use gsutil version 4.61, python3.
> >
> > This CL updates the gsutil.py wrapper to download and use
> > v4.61 of GCP's gsutil, which is Python3-compatible.
> >
> > v4.61 appears to be fully self-contained and have all of the
> > packages it needs vendored into it. So, there's no reason to
> > use vpython anymore, and this CL removes that.
> >
> > Also, this CL removes the 'fallback' option to gsutil and
> > the ability to force a version switch, as this should no
> > longer be necessary (it was added for a migration back in 2014
> > but apparently this code was never removed afterwards).
> >
> > This CL also updates download_from_google_storage.py and
> > upload_to_google_storage.py to similarly not have the version flags
> > and to just use regular python3, not vpython3.
> >
> > Bug: 1184108
> > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439
> > Reviewed-by: Mike Frysinger <vapier@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
>
> Bug: 1184108
> Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>

Bug: 1184108
Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
Roberto Carrillo 7fcdef0a66 [resultdb] Push rdb cli pin forward.
This is to pick up crrev.com/c/2921147

Bug: 1169866
Change-Id: I7e1d78536fd7820c54066bc675fa0c7404454783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2930649
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
4 years ago
Edward Lesmes 58542b7fef gclient: Report hook metrics
Change-Id: I34eed860f9fd68c2382cdcf955f2f5e10ebb31c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946936
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
Edward Lesmes 6d099d543d bot_update: Don't collect metrics if not running as part of a build.
When running using led, DEPOT_TOOLS_REPORT_BUILD might not be set, and
bots will try to collect metrics.

Set DEPOT_TOOLS_COLLECT_METRICS so metrics are not collected on this
case.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chromiumos
Change-Id: I8b1083b31ef6daf87d24544a990bee863543aa1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946935
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Fumitoshi Ukai d3a987159d Roll out new goma client binary VERSION=223
Bug: b/190141502
Change-Id: I6c5074a2d91082fee398e80e6fd1682e07997dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2950609
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
4 years ago
recipe-roller 415b1142ef Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
7dd172078b
  7dd1720 (chanli@chromium.org)
      [resultdb] support exonerate_unexpected_pass

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieef8f3f630d9df87105fa53491ee90da5d5e017a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2952065
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic b4a7cffc40 [py3] Decode stdout in presubmit runs
Bug: 1215375
Change-Id: I068801f5e7482cf13cf70dd6c3a70c39f22a39f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2949974
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Josip Sokcevic 84434e8481 Use py3 with gerrit_client.py
R=ehmaldonado@chromium.org

Change-Id: I93a4c20121010e8644982aa7910ff41884734f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2949972
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Takuto Ikuta 4bb3a7d00d ninjalog_uploader: ignore http.client.RemoteDisconnected
Bug: b/190562569
Change-Id: Iaa8d119ad643e64bdf231fe5ae43ea4daa69996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947272
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
4 years ago
recipe-roller b14cdaeb30 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c939f76712
  c939f76 (bpastene@chromium.org)
      swarming: Allow resultdb_info to be optionally excluded in tests.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01e00af3920fcd91124423ce284ddf99cdce0e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2948201
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic 104ca4d094 Use input_api.sys instead of import sys
Follow up on https://crrev.com/c/2929386

R=dpranke@google.com

Change-Id: Id977cfae561ecfb231372348387b084e098e6747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947981
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Brian Ryner b9236628c6 Roll depot_tools bleeding edge python versions.
This contains
https://chromium-review.googlesource.com/c/infra/infra/+/2943752 , a
stability fix for Mac (and potential startup performance improvement).

Bug: 1215121
Change-Id: Ifac20c066d7c6527574e9a128e4f5d60774824b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2944646
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Josip Sokcevic 0b12346bf3 [py3] Return list of strings in GitChange.AllFiles
Currently, GitChange.AllFiles returns a list of byte[]. This is
inconsistent with py2 and may cause issues when byte[] is used when
string is expected.

Change-Id: I3e73bc5f71aa787f55357b8139cdeeabee056047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946934
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller 680e077ed1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
1b52b3c87b
  1b52b3c (olivernewman@google.com)
      [file] Handle EnvironmentError with errno=None

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48c561b77eee78cf5f875621efb373179afd0222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947004
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes b508ecd932 bot_update: Initialize synced_solutions before syncing.
If sync fails, synced_solutions is not initialized, resulting in a
use-before-init error.

Bug: 1217352
Change-Id: I2367d0f8030faa571b5c2743d5d97aa4c0329a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2945663
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller 730b974ee7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
e2aec9bad4
  e2aec9b (yiwzhang@google.com)
      raw_io: fix the format of code block in raw_io doc

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I565df8639f03c4a3e5784fba4f987615bec97f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2945657
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic 965c544f1d recipes.cfg: update all branches to main
All repositories have main branch and it's default branch

R=ehmaldonado@chromium.org

Change-Id: I1206574901124012254948095c5a3450b8449517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939020
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller a5b6b2f8b7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
9ab7500f84
  9ab7500 (ihuh@google.com)
      [swarming] Fix cas_instance key name in cas_output_root.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I960ee0ac8bd5ddfb86b301d47f790e05a99cabba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941922
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 3ba11d965c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
f3a6a12aa6
  f3a6a12 (yuanjunh@google.com)
      [python3] Generate vpython3 compatible scripts in the bundle co...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2cce76fc73a025b5b3c84b122f0dbbd33c43c2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941672
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic 8b3bc259a0 Fix gclient_utils.FileRead() behavior for both 2 and 3.
We always want gclient_utils.FileRead() to return a text
string these days, but the existing code didn't work
right for Python2 if you called it explicitly with mode='r'.

R=ehmaldonado@chromium.org

Bug: 1210746
Change-Id: If540746f31308b671f9101334b5cd9848a7e9257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2930626
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Dan Harrington a0b0f12874 Fix GetPylint with USE_PYTHON3=True
kwargs['stdin'] is passed in to subprocess communicate(), which
expects bytes, not str.

Bug: 1215602
Change-Id: I95326eed08cffecd31abc6b0380de2a3c2ff3dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2929386
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dan H <harringtond@chromium.org>
4 years ago
recipe-roller 93c73563c5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
2f91f3e786
  2f91f3e (ihuh@google.com)
      [cas][swarming] Display CAS URL.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2547fb8a349b81df06c18bc4ef6b39094a066f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939011
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Fumitoshi Ukai 8891092106 Revert "Roll out new goma client binary VERSION=222"
This reverts commit 681604eb7d.

Reason for revert: 
performance regression on windows.

Original change's description:
> Roll out new goma client binary VERSION=222
>
> Bug: b/189050323
> Change-Id: I003e38d71a9b40db7f4c0fcf43543205dd8da454
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939942
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>

Bug: b/189050323
Change-Id: I5f323ad15294a56c8884c4b5f9f1b9c40689c452
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939618
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
4 years ago
Fumitoshi Ukai 681604eb7d Roll out new goma client binary VERSION=222
Bug: b/189050323
Change-Id: I003e38d71a9b40db7f4c0fcf43543205dd8da454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2939942
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
4 years ago
Edward Lesmes 9705687c25 bot_update: Add experiment to avoid fetching if checked out revision is recent enough.
If checked-out revision is less than 6 hours old, skip fetching latest
revision.

Bug: 1199853
Change-Id: Ifd2a61055de286fe6fd94a5d43f80a1885a6931c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911015
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller 4708027597 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ac7e7183a2
  ac7e718 (olivernewman@google.com)
      [file] Catch IOErrors

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I70e76d7105174e7e9b04c7c4a98f8111f81fcdf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2937308
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic b7f797be55 Add support for py3 presubmit
Depot tools git cl presubmit supports py2 and py3. However, presumbit
recipe only runs py2. This patch adds support for running py3 presubmit
checks too.

Bug: 1214829
Recipe-Nontrivial-Roll: build
Change-Id: I089460eaf65d4b6f1238eea13eb087fadb21cad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2934371
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Dirk Pranke 7288f88590 Fix output flushing when getting warnings that should prompt in py3.
When presubmit checks create warnings that should raise a prompt
whether or not to continue, the output wasn't being flushed
properly under python3.

Bug: 1213316
Change-Id: Ibb4b4d965d49f0cd65ccc0737282e5f5b5f58004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921323
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
Marco Georgaklis 85557a08f4 Implemented suppport for getrelatedchanges endpoint in gerrit module
The endpoint documentation can be found here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes

This involved adding support for the command in gerrit_client and
gerrit_util and then incorporating functionality and testing into
the gerrit recipe module.

The reasoning for this is to be able to identify chained builds for
improved accuracy of the new test identification for the FLake
Endorser project.

Bug:1204163
Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016
Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
Edward Lesmes c8f63d390c gclient: Upload metrics for sync'd deps.
Change-Id: I5340fa9b989cccda61e7a14b4cd30749e2f2c017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2935003
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Nicolas Boichat cd3696cf7e my_activity: Add config file option to add additional gerrit instances
my_activity can definitely be useful outside of Chromium, and the
gerrit instances are sometimes private. This allows users to carry
an additional list of instances in a json file (and possibly
monorail projects, but that seems like likely to be useful).

Change-Id: Ic0fec3bd4f815200f27cc0a8530cfd88f4328269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2925677
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Greg Thompson 30cde45e06 Fix error handling in case of unicode decode error.
Commit 6fc394f added some diagnostics, but it didn't quite work out the
way it was planned.

Bug: 1210746
Change-Id: Ia4f30606e87d3f8b1362441bd74bb7ed0f5ca886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928771
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Brian Ryner 424504a1b2 Bump the cpython version for bleeding_edge.
There should be no functional changes for depot_tools. However, this
version contains a fix for building Python wheels, and we're trying to
standardize on this version everywhere.

Change-Id: Ibb8259028f0c7aa39f03a75ffdedbbb5349b4fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927689
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
recipe-roller 0694fa65f8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
d21e9df679
  d21e9df (mgeorgaklis@google.com)
      Added option to not log builds in presentation for buildbucket...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I62a226159c98f0ae2b693cb50be77bb936fc6f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922983
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 57e20d2b61 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
fdd7ffd886
  fdd7ffd (mgeorgaklis@google.com)
      Created function for GetTestResultHistory rpc call in resultdb...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I33e406a81bb3db1fb797887c6626a2e06c7e4359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922982
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Dirk Pranke 6fc394f93d Fix crash during presubmit checking.
If a presubmit happened to generate a crash, the logic we have
for reporting the presubmit check times would call `six.reraise()`
incorrectly, leading to a second crash.

This CL fixes the invocation of the second crash, and also adds
an error message to help users tripping over one possible source
of the first crash (reading a binary file as text).

Bug: 1210746
Change-Id: Ic46f38901b6acf2055b3feb7272dc751dc69037c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921322
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
Edward Lesmes 50cd6e416a Reland "bot_update: Don't use gclient sync output and rely on gclient revinfo."
This is a reland of 856ccef0e9

Use a tempfile instead of stdout for gclient revinfo output

Original change's description:
> bot_update: Don't use gclient sync output and rely on gclient revinfo.
>
> In preparation for skipping gclient sync if there are no DEPS changes.
>
> Bug: 1199853
> Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1199853
Change-Id: Ib50c4e943cbb51e4a2463beee9b7d1dee824ad29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910950
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Zhaoyang Li 6c7a6fee67 [mac_toolchain] Roll mac_toolchain in depot_tools to latest version
The roll in depot_tools enables new features of uploading iOS runtimes
to separate packages, etc, for human users using the tool to upload
Xcode.

Bug: 1191260
Change-Id: Id6334afd599c9345f05c7fefbd8407f3bc3f8124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2918693
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
4 years ago
Brian Ryner 72bc20ef29 cpython 2.7.18.chromium.36 to full depot_tools release.
Bug: 1208146
Change-Id: I9347a6f95454cfab58eecc08a636957a5fcdb35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2916176
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
4 years ago
Gavin Mak 6d45691f60 Add rest of the plugins to gclient config
Recipe-Manual-Change: infra
Bug: 1201483
Change-Id: Id57c2e93e028baad101416bfecbf41ce136ad5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904102
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
Josip Sokcevic 7fc02e848a Revert "[dirmd] Roll dirmd"
This reverts commit 1cf97004ab.

Reason for revert: roll fails https://crrev.com/c/2915655
Error: dirmd failed.

Original change's description:
> [dirmd] Roll dirmd
>
> Earlier git-ls-files-based optimizations was reverted
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692.
> Since then the root cause was fixed
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/2911979
> and this CL relands the optimization.
>
> This CL also picks up "mixins" feature which enables reducing duplication of metadata.
> See https://chromium-review.googlesource.com/c/chromium/src/+/2897943
>
> Bug: 1179786, 1201822
> Change-Id: I9697bae9342f6cdc947abe025bebce22b09b530e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912261
> Reviewed-by: Prakhar Asthana <pasthana@google.com>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

Bug: 1179786
Bug: 1201822
Change-Id: Iea5aad69382da9cfd3e32c74db10721f37aee930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2909617
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Brian Ryner 7fcae6e928 New python 2.7 version with likely fix for crbug/1208146.
Bug: 1208146
Change-Id: Ifb27636063a3fbe02f605f42af3f04b2dbda1529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2914233
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
4 years ago
Stephen Martinis e2d7d8cd9b Revert "bot_update: Don't use gclient sync output and rely on gclient revinfo."
This reverts commit 856ccef0e9.

Reason for revert: Probably broke chrome os waterfall

Original change's description:
> bot_update: Don't use gclient sync output and rely on gclient revinfo.
>
> In preparation for skipping gclient sync if there are no DEPS changes.
>
> Bug: 1199853
> Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1199853
Change-Id: Ib893704dffc68b02dfa7f977e751e236003b7e0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910949
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
4 years ago
Edward Lesmes 856ccef0e9 bot_update: Don't use gclient sync output and rely on gclient revinfo.
In preparation for skipping gclient sync if there are no DEPS changes.

Bug: 1199853
Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Fumitoshi Ukai 0c58e24a04 Roll out new goma client binary VERSION=221
Bug: b/187774798
Change-Id: I4746b764b1201fe6a92b90da50186078a1e3f6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2913018
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
4 years ago
Nodir Turakulov 1cf97004ab [dirmd] Roll dirmd
Earlier git-ls-files-based optimizations was reverted
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692.
Since then the root cause was fixed
https://chromium-review.googlesource.com/c/chromium/tools/build/+/2911979
and this CL relands the optimization.

This CL also picks up "mixins" feature which enables reducing duplication of metadata.
See https://chromium-review.googlesource.com/c/chromium/src/+/2897943

Bug: 1179786, 1201822
Change-Id: I9697bae9342f6cdc947abe025bebce22b09b530e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912261
Reviewed-by: Prakhar Asthana <pasthana@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
4 years ago
Edward Lesmes 6097a92db0 bot_update: Remove more unused arguments.
Change-Id: I00b32eb109cdff7e138ef5d9497eda77c33188f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912295
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
4 years ago