We now have an arm python binary, so this should no longer be needed.
Bug: 1103326,1184767,1103236
Change-Id: I5510bf2c61adc2d0d505a886956a6677303df271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2888957
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
We have vpython wheels for py3 but not for py2 on mac/arm. With this,
download_from_google_storage.py works on arm mac even without the
vpython bypass. (Also, moving from py2 to py3 seems like a good thing
in general.)
Bug: 1205263,1103236
Change-Id: I6cb08b7c56e5e6fc160fb5abc86d68e04a01f8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2881917
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This version will no longer enforce that wheels exist for linux-x86
when running in "verify" mode. This is a prerequisite to rolling out
new wheels to vpython specs that use verification, since we no longer
build for Linux 32-bit.
Bug: 1176014
Change-Id: I13e77fe7b9ccc3741fa05ae493d171d0ed9aecac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2878769
Commit-Queue: Brian Ryner <bryner@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
b64b15afdf
b64b15a (iannucci@chromium.org)
[python3] Add test and fix syntax+warnings for py3.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibda2918e076d774608ec0b49f15beaefb7827b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880846
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This time, the mac/intel binary was built with an older macOS SDK
which makes the runtime believe that the macOS version on Big Sur is
10.16 instead of 11.0, which should work around the Big Sur issue we had
in the last attempt.
This version was pushed to bleeding_edge in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311
Bug: 1124119,1103236,1184768,1175200
Change-Id: I8614d6f22704d46bfa78b81c8e4b9ff7e6668487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880559
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Otherwise, when the step completes, it won't be able to close
files used for stdout/stderr, since the metrics process is still
running.
Bug: 1206429
Change-Id: Id88578cbd9dab070e07f92e545ec137245566d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877608
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
972327732a
9723277 (iannucci@chromium.org)
[python3] Add a python3 unittest which does nothing.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic95165944ec7285f5e8ee37a36b3b92bc4598c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2879164
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
The new version is built with an older Xcode version for mac-amd64,
using the 10.15 SDK, which gives us better Big Sur compatibility for
some of the very old Python libraries we have in use. In particular,
it will see the OS version as 10.16 rather than 11.0, and recognize
the 10.x-built vpython wheels as compatible.
Bug: 1175200
Change-Id: I23be64b11c8a2fb31910ce5e13b98bd5b38eeb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
609ceedcf6
609ceed (iannucci@chromium.org)
[.vpython] Bump protobuf and six versions.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c41f4530c3191dd8cd1abf2f2ebd1daa26df016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877607
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Users sometimes type in "y" to confirm the default patchset message,
resulting in a patchset being uploaded with "y" as the message.
We can make a fair assumption that no-one would willingly use a patchset
message of "y", so this CL uses the default patchset message whenever
this happens.
(I have personally done this myself and have seen at least one other
person do the same.)
Bug: None
Change-Id: Iad314d35aa830b62152ab2910eb37d876b7e450b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861643
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>
In theory this should prevent `git rebase-update` from invoking
potentially expensive `git gc` operations after every `git rebase`
(ideally once per branch, but sometimes as many as three per branch (!)).
This has outsized effects as the size of the repo or number of branches
increases, and additionally has penalties on Windows due to git's
POSIXey assumptions around how disk I/O works.
After doing all rebase stuff, we run `git gc --auto` from rebase-update
once (assuming we were successful; if the command failed then we don't
run gc at all).
R=apolito@google.com
Bug: 617218
Change-Id: I37a8f7953779f15b320e4ed7bb85119cb4bb665a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2868766
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
43f6400705
43f6400 (gbeaty@chromium.org)
Update the recipe guides to remove non-inclusive terms.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I740724b3a4a4516f39d98169b2a43fac75efabd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867123
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
61c083c605
61c083c (mmoss@google.com)
Allow setting the type of file when extracting archives.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I66143910ed1cd63ff590059498c6db53f3d67d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867122
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Gonna add a small warning in chromium's recipe when this footer is
used. Add it here so we can refer to the footer as a constant in
tryserver recipe_mod.
Bug: None
Change-Id: Ie4f9d1d208c0dad8d0df8f07b74e761da1051a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2864005
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
bbe9a55707
bbe9a55 (mohrr@google.com)
[path] Add isdir() and isfile()
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib801c9f06a973ba531c4efd66785009f9a4a3d7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2864505
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
If the DEPOT_TOOLS_REPORT_BUILD envvar is set, Depot Tools will
report information about the builder running the command
(e.g. buildbucket project, bucket, builder and build id).
It will also authenticate to the metrics server, and ignore any
requests not made by ChOps service accounts.
Change-Id: I078a4c2170b4226086c42f289fa449bdebc87179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861213
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
This is to deploy the changes of crbug.com/1149662, which enables
BatchCreateArtifacts in ResultSink.
Bug: 1149662
Change-Id: Ib3669ad9c2f02deb62455a9e3ef05ef858ef1290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862880
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
This change includes the following commits from the infra/infra
repository:
$ git log --format='%h %s (%ae)' \
97ee9cecaac4d99be09278169f987e61b8116672..HEAD \
-- go/src/infra/chromeperf/pinpoint/cli
dabbed3140 pinpoint: Add support for experiment presets (dberris@google.com)
2c16cdc58a pinpoint: Initial support for user configurations (dberris@google.com)
R=dpranke@google.com
Change-Id: I0bb7a5a167e57b64d8328f497386d5b68f3e4a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862344
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
782fd4903e
782fd49 (yiwzhang@google.com)
cq: accept modes instead of mode_regexp for cq.allow_reuse_for api
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d24cd20449dd7c1f8915e8fc3a039a2be6aad90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2860878
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
With this, it's possible to run some things without
export VPYTHON_BYPASS="manually managed python not supported by chrome operations"
on an arm mac, such as `git cl upload` -- this CL was uploaded
from my M1 MBP :)
(Presubmits need py2 which we don't have yet, but with
`--bypass-hooks` it works.)
Bug: 1103326,1184767,1103236
Change-Id: I46f5b880dfd72b8d811d39b43311fdee17ccad3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2858534
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
The change I landed in 61bf638 couldn't include the proper tests
because of crbug.com/1201918 (I think), and so I split the
test file out into this separate follow-up CL.
Bug: 1157663
Change-Id: I06697a5b76f81f0dc96ad457406a8d4d942d882c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2846635
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
a80d44a95d
a80d44a (iannucci@chromium.org)
[deps] Move dependant recipe discovery to be an option.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id5bb0bb56f8c956213ee4a3917197a0b9e6d36c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2856095
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This change is needed to enable CQ for the tricium plugin.
Bug: 1201483
Change-Id: I685d04055a5cabd94c7f02a79a0b9cbc4694db0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2847232
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
75cf2faf5d
75cf2fa (iannucci@chromium.org)
[deps] Add deps subcommand.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icef236b13c71d13b94d33bc0754ecfc4059a1b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2854976
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This reverts commit 90aee2acaf.
Reason for revert: the new rdb caused blink web tests to fail
Original change's description:
> [resultdb] move cipd pin of rdb to enable BatchArtifactsUpload
>
> This is to deploy the changes of crbug.com/1149662, which enables
> batch-uploading for artifacts in ResultSink.
>
> Bug: 1149662
> Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Chan Li <chanli@chromium.org>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
Bug: 1149662
Change-Id: I7b3e5b5fae3e6262134582c0f002ff46065a9eb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2852455
Auto-Submit: Scott Lee <ddoman@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
This is to deploy the changes of crbug.com/1149662, which enables
batch-uploading for artifacts in ResultSink.
Bug: 1149662
Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Nico Weber
Mike Frysinger
Yoshisato Yanagisawa
Scott Lee
Brian Ryner
recipe-roller
Edward Lesmes
Edward Lesmes
mlcui
Yuanjun Huang
Robert Iannucci
Andrii Shyshkalov
Ben Pastene
Anthony Polito
Dean Michael Berris
Yiwei Zhang
Dirk Pranke
Gavin Mak