Commit Graph

8210 Commits (a40c1e166623f178ea2e83731c57b9136765327c)
 

Author SHA1 Message Date
Vadim Shtayura c0798956ff [cipd] Update CIPD client and vpython.
The CIPD client picks up "use all CPU to unzip by default".
vpython picks up parallel package fetching and unzipping.

R=iannucci@chromium.org

Change-Id: I5c9c73355043a0c53bc785d82e5d9351c91e74b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3000858
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
4 years ago
recipe-roller 8330754092 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
fad480e7fc~..89cf3c8702748d8b801b3acca01b078f44595a1a
  fad480e (qyearsley@chromium.org)
      [python3 compatibility] Run some futurize "stage 2" fixers on r...
  89cf3c8 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8dd195b8fed9 to e14bb15691db

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I19d51ce0087d14652586ae8f38fd92481827123f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3002442
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller e933d0658c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
78cc13b5b5
  78cc13b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9464003f0708 to 8dd195b8fed9

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e616713004bb731f6984130fab89ea1564d6ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3000857
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 58742caff2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
bc01d1b943~..cd13c553e440480647346e57ba843f6864055b53
  bc01d1b (qyearsley@chromium.org)
      [python3 compatibility] Switch to iteritems in recipe engine un...
  cd13c55 (qyearsley@chromium.org)
      recipe engine: Spellcheck and minor formatting

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib063aac209bd17f4d6d64212b78e74471ed291d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3000855
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller eb746eb34f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b14cfa08dc
  b14cfa0 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8dce0cb59e09 to 9464003f0708

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61fffcac9d8aa41c931c9881e8ef9842dcf93110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3000853
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 628439cc4e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
1b6e18444c
  1b6e184 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f8fee322da09 to 68a9d9f74279

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa199b2e8237e5043abfe53fda44abc9b82f5ecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3001774
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 103224626d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
010e03b7b0
  010e03b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from c277f3162d43 to 1403fab7e195

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I80e08f8f54226bbf9eaeb9be0217d77efc122bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3001922
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 56fcc142f5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
d731cbd709~..f62b45dbedac9c192b442641ab538d0eba1f3dac
  d731cbd (iannucci@chromium.org)
      Add ability to read + simulate GLOBAL_SHUTDOWN.
  0032604 (tandrii@google.com)
      Make autoroller owner of CAS Client pin.
  f62b45d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 78702ac003f3 to 76ddc72fae59

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I70c14fffbbbf2e9184763223a7787e0c3813440c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3001331
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic b3d52d34cd Revert "Use main as default branch for git recipe module"
This reverts commit 6b08432689.

Reason for revert: creates CLs that are on top of stale commits, not ToT

Original change's description:
> Use main as default branch for git recipe module
>
> R=​apolito@google.com, ehmaldonado@chromium.org
>
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Change-Id: Ia0d39ae574852fa008a55e366c2320eb1845dc86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941678
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

Change-Id: I64ed8e7fbeab8cf8a0be6be4456fee400f770883
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2998588
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
4 years ago
recipe-roller da25c084de Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
7b628b8a4e
  7b628b8 (iannucci@chromium.org)
      [python3] Add indicator for python3 compat at recipe/module level.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77fd6dcf7f497c42ecf25f29b5a369a585c52c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2998277
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Viktor Samun 0aabd63461 Fix python2/3 compatibility in DownloadUsingHttp function
Change-Id: I59ed965d066b7875c1739408054498b328652be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988315
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Josip Sokcevic f0d7ed89cf Allow custom filters for json validation
JSON check may be useful for files that don't necessaraly end with
.json. For example, infra/config/recipes.cfg should be a json file. This
change allows users to add custom file_filter that can include such
files.

R=apolito@google.com

Bug: 1223923
Change-Id: Ia6fc7f86fa368510baaee978d9a0a27eccb6b31f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992735
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Peter Wen 866be0f290 Add an option to specify pylint version
This allows us to migrate PRESUBMIT.py files over to pylint-2.6 bit by
bit. It also allows us to support and upgrade pylint to newer versions
in the future.

Bug: 1221143
Fixed: 1221143
Change-Id: I9af96f5f06caf48e9923ad5fae75b98a0a7aeb49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2994723
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Josip Sokcevic 6b08432689 Use main as default branch for git recipe module
R=apolito@google.com, ehmaldonado@chromium.org

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Change-Id: Ia0d39ae574852fa008a55e366c2320eb1845dc86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2941678
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
Sigurd Schneider 1bfda8eee9 Respect git config cl.date-order in `git cl st`
In the previous commit https://crrev.com/c/2532835 the option
to order branches by date was added. This CL adds a git config
variable cl.date-order than can be set to achive the same effect.

Change-Id: Iaf24c46c5f7b63b1e518c18aedc455808a2dc752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992887
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
4 years ago
recipe-roller 7f69c8fe8f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b19a5afca9
  b19a5af (yuanjunh@google.com)
      [python3] Make recipes doc command py3-compatible

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I85ddcb9eceb8982cbd12a328fa14ce3ce2307fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2994756
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
kyle Ju 965a05bedf Fix py3 presubmit error. Use unicode strings explicitly.
Bug:1225052
Change-Id: I7c536819133c75130baca2f8d295360d7d1ca69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2995072
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Kyle Ju <kyleju@chromium.org>
4 years ago
Vadim Shtayura a50bd44b06 [cipd] Update CIPD client to 2.6.0.
It now fetches and installs packages in parallel. This has a side
effect that the order of unzipping of packages in a manifest is
non-deterministic and depends on when particular packages finish
downloading.

To be able to show progress of parallel operations there's also
a new terminal UI with progress bars. It activates when running
CIPD at `info` logging level (default) if the stderr is attached
to a terminal (i.e. not piping to a file or the recipe engine).

Two new env vars control the new behavior:
 * CIPD_PARALLEL_DOWNLOADS: set to 0 to completely disable
   parallelism and restore pre 2.6.0 behavior. Set to 1 to fetch
   and unzip packages in paralle, but fetch at most one package
   at once. Default is 4.
 * CIPD_SIMPLE_TERMINAL_UI: set to 1 to use log-based UI instead
   of progress bars.

R=iannucci@chromium.org
BUG=1217435

Change-Id: I16815dbc397137fbb8ef09e09d0a04c77660c0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2993750
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
4 years ago
Josip Sokcevic db632b6a13 Use main as default branch in documentation
Bug: 1118433
Change-Id: I55d4c1cecf881d39c3189ed4fa4ef71db6eede08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2981113
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
4 years ago
Bruce Dawson a806594b95 Reland "Reland "use python3 for goma related scripts""
This reverts commit fc3fb20e51.

Reason for revert: Previous versions of this changed used %scriptdir% in
goma_ctl.bat and goma_auth.bat but never defined it. This eluded manual
testing because these scripts would work properly as long as they were
run from the depot_tools directory, but would fail when run from
elsewhere.

The fix to make this reland work can be found by comparing patchset 1 to
patchset 3.

Original change's description:
> Revert "Reland "use python3 for goma related scripts""
>
> This reverts commit 2a6dffaf4b.
>
> Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
> "The system cannot find the path specified."
>
> Original change's description:
> > Reland "use python3 for goma related scripts"
> >
> > This reverts commit 59140d436a.
> >
> > Reason for revert:
> > Make this works in git bash.
> >
> > Original change's description:
> > > Revert "use python3 for goma related scripts"
> > >
> > > This reverts commit 138ec7c56d.
> > >
> > > Reason for revert:
> > > This might have caused the following issue:
> > > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
> > >
> > > Original change's description:
> > > > use python3 for goma related scripts
> > > >
> > > > This uses python3 like autoninja{,.bat}.
> > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> > > >
> > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > >
> > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> > > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> >
> > Bug: 1221233
> > Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
>
> Bug: 1221233
> Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

Bug: 1221233
Change-Id: I50412a5ea62f1607660cb7a7ab8851251c3dfe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992151
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
4 years ago
Bruce Dawson fc3fb20e51 Revert "Reland "use python3 for goma related scripts""
This reverts commit 2a6dffaf4b.

Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
"The system cannot find the path specified."

Original change's description:
> Reland "use python3 for goma related scripts"
>
> This reverts commit 59140d436a.
>
> Reason for revert:
> Make this works in git bash.
>
> Original change's description:
> > Revert "use python3 for goma related scripts"
> >
> > This reverts commit 138ec7c56d.
> >
> > Reason for revert:
> > This might have caused the following issue:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
> >
> > Original change's description:
> > > use python3 for goma related scripts
> > >
> > > This uses python3 like autoninja{,.bat}.
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> > >
> > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> >
> > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
>
> Bug: 1221233
> Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 1221233
Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
4 years ago
Josip Sokcevic 457736028d Reland "Reland "Update gsutil to use gsutil version 4.61, python3.""
This is a reland of e53a593956

Additional bug fixes:
* handle race condition in gsutil when creating its directory
* limit to one gsutil process on darwin due to bug in python3

Original change's description:
> Reland "Update gsutil to use gsutil version 4.61, python3."
>
> This reverts commit af121aeec9.
>
> Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance.
>
> Original change's description:
> > Revert "Update gsutil to use gsutil version 4.61, python3."
> >
> > This reverts commit f059ec9368.
> >
> > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640.
> >
> > Original change's description:
> > > Update gsutil to use gsutil version 4.61, python3.
> > >
> > > This CL updates the gsutil.py wrapper to download and use
> > > v4.61 of GCP's gsutil, which is Python3-compatible.
> > >
> > > v4.61 appears to be fully self-contained and have all of the
> > > packages it needs vendored into it. So, there's no reason to
> > > use vpython anymore, and this CL removes that.
> > >
> > > Also, this CL removes the 'fallback' option to gsutil and
> > > the ability to force a version switch, as this should no
> > > longer be necessary (it was added for a migration back in 2014
> > > but apparently this code was never removed afterwards).
> > >
> > > This CL also updates download_from_google_storage.py and
> > > upload_to_google_storage.py to similarly not have the version flags
> > > and to just use regular python3, not vpython3.
> > >
> > > Bug: 1184108
> > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439
> > > Reviewed-by: Mike Frysinger <vapier@chromium.org>
> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> >
> > Bug: 1184108
> > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
>
> Bug: 1184108
> Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155
> Reviewed-by: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>

Bug: 1184108
Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Takuto Ikuta 2a6dffaf4b Reland "use python3 for goma related scripts"
This reverts commit 59140d436a.

Reason for revert:
Make this works in git bash.

Original change's description:
> Revert "use python3 for goma related scripts"
>
> This reverts commit 138ec7c56d.
>
> Reason for revert:
> This might have caused the following issue:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
>
> Original change's description:
> > use python3 for goma related scripts
> >
> > This uses python3 like autoninja{,.bat}.
> > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> >
> > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
>
> Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1221233
Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
4 years ago
Fabrice de Gans a73eec2873 Add a new argument to skip shebang checks on python3
A bug in the logic enabling tests to be run on python3 resulted in
tests never being run in python3 unless they also have a shebang line
pointing to python3. Since this bug was introduced, effectively, most
tests that are supposed to be run on python3 do not run at all. Since
then a lot of python3 tests have regressed in Chromium.

In order to fix the issue moving forward, this introduces a new
argument that skips the shebang check to run a test in python3. Tests
will be re-enabled one by one until every single instance in Chromium
has been updated.

Bug: 1223478
Change-Id: I91a0688c6f4d9b4fbf18e3d446366cded8c7f2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2986400
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Fabrice de Gans <fdegans@chromium.org>
4 years ago
Dirk Pranke 6f0df68e8b Add use_python3 to codereview.settings to set default for PRESUBMITs.
This CL adds a new field to the codereview.settings file used by
git_cl for project-wide defaults. If `USE_PYTHON3` is set to True,
then we will run the PRESUBMIT checks under Python3 by default
instead of Python2, unless the PRESUBMIT.py file contains
`USE_PYTHON3 = False` on a line by itself

(as opposed to now, where we'll use Python2 by default unless the
file contains `USE_PYTHON3 = True`).

This will allow us have Python3 be the default for new files
and to eventually eliminate any uses of `USE_PYTHON3` from the
individual presubmit files. Of course, you will have to go in and
explicitly add `USE_PYTHON3 = False` to any Py2-only files prior
to enabling this.

Bug: 1207012
Change-Id: Id8ec45b43940e5bcffeee196398c711c541e733e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2917747
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
Raphael Kubo da Costa 9f6aa1ba78 gerrit_util: Make GceAuthenticator also consider proxy errors in httplib2
Some HTTP proxies may return an HTTP error such as 503 when DNS
resolution fails for GceAuthenticator._INFO_URL
(http://metadata.google.internal), which causes e.g. git-cl to throw an
exception rather than falling back to checking for .netrc or
.gitcookies.

Make GceAuthenticator._get() also consider an httplib2 proxy error a
sign that the code is not running in GCE.

Change-Id: Icc094829f9b044176be44e51f3cad49d4a374f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2982611
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller cf60c0af45 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
f6ae625286
  f6ae625 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 34b847e00d95 to bcbbe2d4b506

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I304bec5b4b3e969e87e5bb06dbd239fada1a8fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2983608
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Nodir Turakulov 3ac55bcdf0 Revert "[dirmd] Roll dirmd"
This reverts commit 74ef838a40.

Reason for revert: b/191388102

Original change's description:
> [dirmd] Roll dirmd
>
> This CL picks up
> 1. DIR_METADATA discovery optimization, based on git-ls-files
> 2. Mixin support
> 3. New subcommand "read" that supersedes "export" and "compute"
>
> Last time it was reverted because depot_tools->src got blocked, because
> dirmd was used in Swarming task. The latter was resolved in
> https://chromium-review.googlesource.com/c/chromium/src/+/2921324
>
> Bug: 1201822, 1179786
> Change-Id: I76a580c5d60b506c1f015890fc07817de553975d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2965866
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1201822, 1179786
Change-Id: I6d73267278802a424a6513357f0adda191317535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2983385
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
recipe-roller 3745d59ea4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
fd22f03f11
  fd22f03 (tikuta@chromium.org)
      cas: simplify _version a bit

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7bcc5475771058089733f5607cf026045f6e64cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2982759
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Song Fangzhen 534f505b77 Update format of `git cl split`
This change updates the output format of `git cl split` when
`description_file` has no footers.

Bug: 1215852
Change-Id: I69764885337ec31134f2b5e2d861930e0bc8cd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2936161
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Fangzhen Song <songfangzhen@bytedance.com>
4 years ago
recipe-roller 2dd15401da Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
fe59faf05e
  fe59faf (tikuta@chromium.org)
      cas: get cipd package revision from file

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d37e4bee7bffcd67cb79fefa67760a9c2bf2390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2981358
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes 09f358bae3 metrics: Don't collect metrics on DEPOT_TOOLS_METRICS=0
Before crrev.com/c/2876082, DEPOT_TOOLS_METRICS=0 was the
env var used to disable metrics collection.

Bug: b/191388102
Change-Id: I0db9d034562f2eb1afb53818b3853cef50c09826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2980230
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jack Neus <jackneus@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Jack Neus <jackneus@google.com>
4 years ago
recipe-roller b714c17658 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
31016748af
  3101674 (chanli@chromium.org)
      Reland "[recipe-py] rdb query: support tr_fields"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia743c0d34196a920480f3e7bde512c7361bf3e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976865
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 70dcfe26e2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c3be45efdc
  c3be45e (chanli@chromium.org)
      Revert "[recipe-py] rdb query: support tr_fields"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib29ccd4ecec4fed441efcee44c5b9af9708df0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976855
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller d234949b7f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
7c7d1692a2
  7c7d169 (chanli@chromium.org)
      [recipe-py] rdb query: support tr_fields

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8f90a98006ceee927e7939341303cfe6e70077b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976854
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Chan Li e430db18f1 [depot-tools] roll rdb
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2973340

Bug: 1166491
Change-Id: I1ab50fbc86542916e779e9ef5dc49a7588285a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976851
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
4 years ago
recipe-roller 255179cd46 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
349e1d966f
  349e1d9 (chonggu@google.com)
      [cipd] Add verification timeout as a passable flag.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I973cc0c7e0cf0612a70c03a092864fa74dd9a7b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2976852
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Scott Lee c1c99b0624 [lucicfg][depot_tools] roll out lucicfg-1.26.0
This is to deploy the changes of https://crrev.com/c/2973339.

Change-Id: If6f39f88e923d06e68e1f320438c3f21784b0dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2973672
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
4 years ago
Chong Gu 473499ba26 [cipd] Add verification-timeout as a passable flag
For Fuchsia official builders, we need a way to increase
the verification timeout so that our packages are uploaded
successfully

Bug:1215771
Change-Id: Ie59dc149e2b88864afea1aaf6700a94324593196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2973226
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Yoshisato Yanagisawa 59140d436a Revert "use python3 for goma related scripts"
This reverts commit 138ec7c56d.

Reason for revert:
This might have caused the following issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1221233

Original change's description:
> use python3 for goma related scripts
>
> This uses python3 like autoninja{,.bat}.
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
>
> Fixed: 1203012
> Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Takuto Ikuta 138ec7c56d use python3 for goma related scripts
This uses python3 like autoninja{,.bat}.
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat

Fixed: 1203012
Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Nodir Turakulov 74ef838a40 [dirmd] Roll dirmd
This CL picks up
1. DIR_METADATA discovery optimization, based on git-ls-files
2. Mixin support
3. New subcommand "read" that supersedes "export" and "compute"

Last time it was reverted because depot_tools->src got blocked, because
dirmd was used in Swarming task. The latter was resolved in
https://chromium-review.googlesource.com/c/chromium/src/+/2921324

Bug: 1201822, 1179786
Change-Id: I76a580c5d60b506c1f015890fc07817de553975d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2965866
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Peter Wen 592d5ec077 Add pylint-2.6.bat to prepare for migration
Bug: 1157931
Change-Id: I42d1b5be0e7983e1d8311b59e841468cc33fa378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2966637
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Fumitoshi Ukai e319aba2ba Reland "Roll out new goma client binary VERSION=224"
This reverts commit ecdc362593.

Reason for revert: http://b/191118784 was not reproduced.

Original change's description:
> Revert "Roll out new goma client binary VERSION=224"
>
> This reverts commit 6ec423c7f3.
>
> Reason for revert: http://b/191118784
>
> Original change's description:
> > Roll out new goma client binary VERSION=224
> >
> > Bug: b/190680102
> > Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> Bug: b/190680102, b/191118784
> Change-Id: I732413b6b639f440383a89cfeb6b35d8ece995c0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960304
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: b/190680102, b/191118784
Change-Id: I6152af3c21d77454c0f7ef564f8a9b433996a15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2963795
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
4 years ago
Mike Frysinger 7f0091e524 chrome_set_ver: punt old script
We deleted this in chromite back in 2013.  Looks like we forgot to
clean up depot_tools.

Bug: 216050
Change-Id: I7e7591aaa319ab1aeb7cc3f34e33b313b5029257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812199
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller 96ef6419fd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
caa7771389
  caa7771 (yuanjunh@google.com)
      [python3] Support recipe fetch and bundle to run in py2 and py3...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia920ce72e2e64c9e9052aa236e10c3a641c28ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2964481
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Takuto Ikuta ecdc362593 Revert "Roll out new goma client binary VERSION=224"
This reverts commit 6ec423c7f3.

Reason for revert: http://b/191118784

Original change's description:
> Roll out new goma client binary VERSION=224
>
> Bug: b/190680102
> Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>

Bug: b/190680102, b/191118784
Change-Id: I732413b6b639f440383a89cfeb6b35d8ece995c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960304
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
4 years ago
Fumitoshi Ukai 6ec423c7f3 Roll out new goma client binary VERSION=224
Bug: b/190680102
Change-Id: If6e176c37292d8dc2b6f1131c90187a94cc2c534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2960154
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
4 years ago
Bruce Dawson 3b56309183 Ignore \r characters in CheckLicense
If you copy\paste a license header in such a way that \r\n line endings
are used (I have done this) then CheckLicense would fail. This is quite
confusing because the license looks perfect in most text editors. This
change tells CheckLicense to treat \r\n line endings as equivalent to \n
and let CheckForWindowsLineEndings do its job of warning about the \r\n
line endings. This avoids confusing presubmit messages.

Bug: 801033
Change-Id: I37fa4a6d9cd0f1a4dcce1267175f4b8fd298b906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2951788
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
4 years ago
recipe-roller cdd52af784 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0afd693c9b
  0afd693 (gbeaty@chromium.org)
      Update StepCommandContains to support regexes.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8cb750a0ca5a4a3f4bae499d59711d9c83b24c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2961794
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago