a309d29905
Remove .git suffix from git submodules
...
.git suffix is not well supported by the systems that utilize
submodules. Since some tools expect DEPS to have .git suffix, it's not
possible to simply update DEPS without breaking the tools.
This patch updates `gclient gitmodules` to omit .git suffix and trailing
slashes. However, if `.gitmodule` already exists, we are expecting the
tool to generate the same result if DEPS didn't change.
R=aravindvasudev@google.com
Bug: b/303296048
Change-Id: I30497b9d5f4e9681e16b4a913151de0f4a7c9545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5008942
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
7e176f1437
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765062049832958865
recipe_engine:
45ce979f73mohrr@google.com )
[recipe_engine] Remove defer_results
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia1319648ecdd3d9b49d2bcaffac92c93d824a59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5010974
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
ccc34d2b44
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765128110125877921
recipe_engine:
351d79bca5jwata@google.com )
[cas] Change the default log level to info
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I819e37df296fdac63df47b912332a1a2224653d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5008954
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
0c5e8652fe
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765166478393504977
recipe_engine:
94e9b251b5jonahhooper@google.com )
[swarming] [recipe] Updated swarming cli to more recent version
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaeac515e49bcecdaa0675faaec9f5a181844a13b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5007795
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
b4e466e610
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765506226653258785
recipe_engine:
d9994e3522chromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from dfbae63f58ac to 540222a3d0b1
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia282c8ff794bcf8b00e752e98632490c427a02fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5001969
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
f007e78ef9
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765521324786787649
Please review the expectation changes, and LGTM+CQ.
recipe_engine:
bc82350667iannucci@chromium.org )
[recipe_engine] Switch recipes to execute with python3.11.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d1084286366429b245e958e453bf73e883c78e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5001769
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
2 years ago
17debef507
autoninja.py: Enable offline mode for Siso when use_remoteexec not set
...
Tested with:
$ autoninja -C out/fastbuild-siso-local base
offline mode
2.48s loading build.ninja
pre:0 local:176 remote:0 5.7/s fallback:0
[...]
5m40.86s Build Succeeded: 1641 steps - 4.81/s
$ autoninja -C out/fastbuild-siso-reclient base
Running gcloud auth print-access-token --trace-token=interactiveauth
Proxy started successfully.
124.260 s to start reproxy
5.32s loading build.ninja
15.93s Regenerating ninja files
2.75s update filegroups
4.84s loading build.ninja
pre:0 local:1 remote:0 30.2/s cache:100.00% fallback:0
[...]
2m05.55s Build Succeeded: 2560 steps - 20.39/s
R=jwata, ukai
Change-Id: Ib976b874796a20dca55005986ee6f7ee3c942245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4997466
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
2 years ago
a413ee7249
[gsutil.py] Skip luci-auth wrapper on unsupported platforms
...
On unsupported platforms, luci-auth is not downloaded from CIPD and
hence the scripts relying on gsutil.py fail. Given we aren't using
luci-auth in unsupported platforms anyway, skip wrapping gsutil with
luci-auth on unsupported platforms.
Curently, only "aix" is added to the unsupported platforms list
eventhough we have other unsupported platforms too. This list will be
expanded if necessary.
R=yiwzhang
Change-Id: I70f6fceddc672c76bbea9a108a75b84662e26459
Fixed: 1467752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4989412
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
2 years ago
23c4defd8d
fetch: stop setting submodules config as we are not using it at all
...
R=sokcevic
Bug: 1496925
Change-Id: I448fb1f49b225d1a5f60103dbbcacaea2c69bd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995365
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
03a1a8936e
pre-commit: do not ignore submodule when running diff-index
...
Without this line, if the git config specifies to ignore submodule
change (what happned in the associated bug), this script is useless
because the command will never return gitlink change
R=sokcevic
Bug: 1496925
Change-Id: I6536b95502e708e44d6fd3e4909fd30eac8c7c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995364
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
9ed72f91a9
[siso] Propagte SIGINT to siso process
...
siso's signal handler doesn't run as expected with siso/autosiso
wrappers.
This CL sets signal handlers for the Python wrappers to propagate
signals to siso.
Note that Siso immediately exists at the 2nd Ctrl-C.
So developers can stop Siso forcibly when they want.
Bug: b/308734805
Change-Id: Idd8cc1d99931d609cfc3bedfb4c0bb4319cd20b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4996768
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
2 years ago
00777b41d5
reclient_helper: simplify tests
...
This is followup CL for https://crrev.com/c/4916355 .
Bug: b/300945159
Change-Id: I27ee47e8b66671aba81d73347f9d5ebe77a098f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4975086
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
2 years ago
05db51709b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765686161139553377
recipe_engine:
e5bce86f12mohrr@google.com )
[defer] Add context manager support
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb33714585728047e132aba8ff2291d91faf48c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4996384
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
38683d842f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765691194101392369
recipe_engine:
636a3cd1f6mohrr@google.com )
[defer] Make "collect" step optional
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1b6324c2a3c2fed9b8b1093c550e9327856b674a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4995374
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
fd6e527668
repo_launcher: sync to v2.39
...
R=ddoman@google.com, vapier@google.com
Change-Id: Ie4d6dc42c554dc42f46accafe669d5dc3c3824fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4993976
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
2 years ago
fdceee14df
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8765713214698536737
recipe_engine:
25405bce22jonahhooper@google.com )
[swarming] [recipe] recipe experiment for new swarming cli
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie6cccf385ab0b2416f59bb9bbc2e21d563c45789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4993971
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
5388959fd7
reclient_helper: delete directory synchronously
...
This is for
https://crrev.com/c/4916355/8/reclient_helper.py#177
Let me use synchronous directory deletion as reclient doesn't produce
many log files.
Change-Id: I44f616c9d825bc6b9dbeea329ca1db00a578a9fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4988347
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Savigny <msavigny@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
2 years ago
9f3b33a275
[py3.12] Use a Raw String in post_build_ninja_summary
...
depot_tools/post_build_ninja_summary.py:5: SyntaxWarning: invalid
escape sequence '\d'
"""Summarize the last ninja build, invoked with ninja's -C syntax.
Bug: chromium:1487454
Change-Id: I117b94872d65552168c295b4886ccb48a2fd4052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4986821
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Ho Cheung <uioptt24@gmail.com>
2 years ago
c7628f7809
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766052325171270433
recipe_engine:
4cb9330372randymaldonado@google.com )
[recipe-engine] adding a stack trace in the debug log for each...
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If518bdf4d5f09951310b5ca15008a56117469c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4982023
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
cd9f6dc4b1
cros: disable Python caches in citc checkouts
...
Since citc doesn't support gitignore, it doesn't like it when you
dirty checkouts with pyc/pyo files. Disable it here when running
the launchers.
Change-Id: I0fd65da489d477bcc3027cf0059ce7122bb90c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4983229
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
2 years ago
d3acdc8c57
recipes: Remove unnecessary use of defer_results
...
Bug: chromium:1495428
Change-Id: I266cb0d8cb101dc5ce8fb25622bb0d5d800ca27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4979598
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Rob Mohr <mohrr@google.com>
2 years ago
ee5d42b76a
schema: pull LICENSE whitespace trim from upstream
...
This is copied into other projects, so clean it up here.
Change-Id: I6ef0829210053b7dd3e4961a6e5a80c8fe1493c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4983215
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
fa9968dcd4
cros: convert to pathlib
...
Change-Id: I696be34716f31cb4ca9fc39cc2c8a3f51890f92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4983214
Reviewed-by: Tim Bain <tbain@google.com>
Commit-Queue: Tim Bain <tbain@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
2 years ago
7751ddfa9e
[depot_tools] roll led
...
Bug: b:293933330
Change-Id: I5f9c80084a72fb53cd2f24f3db1d0c689b415771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4979322
Reviewed-by: Bryan Ni <bniche@google.com>
Commit-Queue: Bryan Ni <bniche@google.com>
2 years ago
0b210c1f66
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766131595365223089
recipe_engine:
3932a9ace9bpastene@chromium.org )
Allow the 'cost' of 'bb collect' cmds to be specified in recipes
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9dc053b8866b6ce4516712ec07c59f0369e035e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4981648
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
ba429812fe
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766134742050722849
recipe_engine:
f0684c8cf5mohrr@google.com )
[defer] Initial commit
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8db5d354d757d7401da5983bc046ddaad256df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4981213
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
4782738d62
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766144804832300689
recipe_engine:
27885607aeiannucci@chromium.org )
[random] Remove hacks for python2 compatibility.
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If97038704d212af9fa76d1b260b9049143af2198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4981209
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
27ea34f94e
[reclient] Keep previous 5 builds worth of logs
...
Test: Updated unit tests
Bug: b/300945159
Change-Id: Id0ce3471be17ab05dbef8e3091333149bd9bde6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4916355
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Michael Savigny <msavigny@google.com>
2 years ago
744bfd2a7b
git_cl: show actual gerrit host instead of placeholder
...
This removes necessity of URL modification to open the settings.
Change-Id: I22314d3e04eac476499773a8680dec32a1886eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4970438
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
2 years ago
8abeeaab0f
git_cl: prepend http for go link
...
This allows users to click the URL from terminal.
Change-Id: I0b5c2b9d5a8221c41d5152b529edcf82f97464c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4969974
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
43582381dd
roll lucicfg to v1.40.0
...
To pick up https://crrev.com/c/4908058
R=yuanjunh
Change-Id: I90352f6ca172da7e6c6a5b110d04339498a08352
Bug: 1232565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4960855
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
2 years ago
10cd8e406d
[ssci] Recognize other date formats for third party metadata
...
This CL expands on the date format validation for third party
metadata. Now, values that are recognized to be using a different format
from the preferred format of YYYY-MM-DD will only return a warning,
instead of an error.
Bug: b:285453019
Change-Id: I344dc863601b4e03e801cdfb3cc5912cfe13b762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4961973
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Anne Redulla <aredulla@google.com>
2 years ago
b49c84d812
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766680212465065105
recipe_engine:
a9a3ff21camohrr@google.com )
[util] Remove unused map_defer_exceptions
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d8a033e3bf2bda718e01bbb073b474a4a35ddfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4960616
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
f2449cd841
Fix accessing of non-existent exception attribute in error handler
...
Fixed: 1488385
Change-Id: Ie401b1580091aa1ad31091e71e55b59e26e6fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4931232
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
2 years ago
ce4aac950f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766760104840571473
recipe_engine:
58fefbd25cchanli@chromium.org )
[buildbucket]recipe_module:allow schedule shadow child builds i...
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54b4c0c57cf2a58246598c020960957bc604eefa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4957523
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
767a521586
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766787795919569697
recipe_engine:
909800ddc2ayatane@google.com )
[bcid_reporter] Uprev provenance_broker
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic01172b2b1f594315a9a9824ec784036ee06ba51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4954951
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
8f761f5795
Mention updating inclusive language excluded directories for 3p code.
...
In an ideal world, exclusions to this check would never be needed, but
for third-party code, fixing this can often be non-trivial (e.g. it
might involve renaming git branches and fixing CI infrastructure).
Change-Id: I7e27f5a65fce0d8356765b58474c23321d1cf361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4944933
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
2 years ago
406be8281e
autoninja: don't allow use_siso=true and use_goma=true
...
Bug: b/306048338
Change-Id: Ib34eb5abe3c419d4afefb7a9cd083441ef755110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4951553
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
2 years ago
a3ae284553
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8766941306795794337
recipe_engine:
748f6ffd0emohrr@google.com )
[buildbucket] Add test_data arg to search()
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic2c4ad66883f34917ea3430b2ea20596aeff78b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4950815
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
491aa5d18a
Do not fail "git cl format" when google-java-format.jar is missing
...
The file is conditionally downloaded in chrome, and we do not want to
have "git cl format" fail when editing a .java file on non-linux /
non-android checkouts.
Bug: 1462204
Change-Id: I5fc3b74484e1d9304089118449678acb506d5831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4943676
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
3d0d2793cf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8767047632773177233
recipe_engine:
5699c27a54chromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from 143c67d734d9 to 924cfd2323a9
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I195bdb48b2178ced3acbd15e94e458506653e27b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4943382
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
73b69b0167
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8767315649605498593
recipe_engine:
a0b2af1af3yuanjunh@google.com )
[recipe-py] Add config_service protos into recipe_proto
Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md
Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iec7a4129b88d31a3b1c407637f025dfc52b2d24a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4939343
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
f2f500022d
git_cl: add a long option for git cl patch -b
...
R=sokcevic
Fixed: 1492418
Change-Id: I09b7b05c8eb4968f079303406c474f90c34b66a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937884
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
c51829968b
[autoninja] Update Siso .ninja_log comments
...
Siso is going to generate non-empty .ninja_log for the analysis tools.
https://crrev.com/c/4907677
This CL fixes the comment about empty ninja_log.
It's not compatible with Ninja's .ninja_log. So `gn clean` will still
be required.
Bug: b/298594790
Change-Id: Ib4c60f3ed22f516d6f7e2847aaf57e228121eccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937692
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
2 years ago
a51863b2f8
Fix missing \n in an error message.
...
Change-Id: Icd567773f56b977afd7725f9ecfff51311ef381f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937211
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
2 years ago
0b943400a4
Execute Ninja / Siso directly from autoninja.py.
...
Instead of printing a command-line, we just directly call into the respective main functions from Python. This saves spawning another interpreter and prevents things that can go wrong from having to quote, unquote, split and tunnel arguments through shells.
Part of my bigger auto{ninja,siso} refactoring.
Tested:
- Handling of the ^^ suffix on Windows still works correctly.
- Handling of error codes - i.e.; making sure
"autoninja base_unittests && base_unittests.exe" behaves properly
in the success/failure case.
- Make sure the command prompt title is reliably reset on exit.
I tested autoninja with all combinations of these:
- Host platform: Linux, macOS, Windows
- Remote GN args: <none>, use_goma=true, use_remoteexec=true
- Siso GN args: <none>, use_siso=true
- Targets: base, ../../base/types/expected_macros_unittest.cc^ (on Linux) and ../../base/types/expected_macros_unittest.cc^^ (on Windows)
R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org
Bug: b/293657720
Change-Id: I275a775fdc5abb6555f79d4beab76cd0914d4bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924185
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
2 years ago
69e597f8e5
Do not fail formatting when google-java-formatter is not found
...
A missing google-java-format should not break older chromium branches
and non-chromium projects. This causes the formatting step to skip .java
files when google-java-format is not available, and introduces an
environment variable GOOGLE_JAVA_FORMAT_PATH to set a custom path.
Bug: 1491627
Change-Id: I5e3155553630ddc59c1a8d197e96079f6a372454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4930437
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
aabd869daf
autoninja.py: Add unit test for gn_lines with 100% coverage
...
Part of my bigger auto{ninja,siso} refactoring.
R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org
Bug: b/293657720
Change-Id: I5c228ecf9910b0a8ce18afc816f213f08b941299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924715
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Philipp Wollermann <philwo@chromium.org>
2 years ago
4566632822
[dirmd] Roll dirmd in depot_tools
...
Changes include:
* crrev/c/4925716
* crrev/c/4909980
Bug:1488997, 1491512
Change-Id: I46ad310f32fe747ee9f3607ddeb0f37c2a660976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4928010
Reviewed-by: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
2 years ago
2ef0787c49
Add a config file for the flake8 linter.
...
Part of my bigger auto{ninja,siso} refactoring.
R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org
Bug: b/293657720
Change-Id: I2a7783b8675ecc7dac16a490a290b2edf4b9d64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924716
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Philipp Wollermann <philwo@chromium.org>
2 years ago
Josip Sokcevic
recipe-roller
Philipp Wollermann
Aravind Vasudevan
Yiwei Zhang
Junji Watanabe
Takuto Ikuta
Ho Cheung
Mike Frysinger
Rob Mohr
Mike Frysinger
Chan Li
Ben Segall
Anne Redulla
Philipp Thiel
Daniel Cheng
Fumitoshi Ukai
Andrew Grieve
Alexei Svitkine
Jeff Yoon