svn info doesn't like it when handed a symlink - you get an 'is not a working copy' error message. Unfortunately, the Mac uses BSD readlink, and doesn't have -f, so the subshell CD/PWD idiom must be used.
BUG=none
TEST=Create a symlink to depot_tools, put it early in your path, and do update_depot_tools. You should not get any 'not a working copy' error messages.
Review URL: http://codereview.chromium.org/6838001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81323 0039d316-1c4b-4281-b951-d872f2087c98
At the moment it just fetches the patch. It's still useful to debug rietveld
issues.
Improve resiliency to invalid patches.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6825085
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81305 0039d316-1c4b-4281-b951-d872f2087c98
Since no output is user visible anyway, causing a hang with no clue about what
to type in.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6823091
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81302 0039d316-1c4b-4281-b951-d872f2087c98
It could result in failed tests so I'll revert if it ever becomes problematic.
It ran fine with my limited testing.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6813114
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81279 0039d316-1c4b-4281-b951-d872f2087c98
Exposes InputApi.rietveld and deprecate host_url.
This is useful since it places authentication at a single place.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6825008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98
Add better code to handle diff header, especially add more patch verification
code.
Add a lot of tests.
Add mangling of \ to /.
R=dpranke@chromium.org
BUG=78561
TEST=
Review URL: http://codereview.chromium.org/6802021
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81017 0039d316-1c4b-4281-b951-d872f2087c98
Add propagation of verbose flag from git cl to presubmit_support
Rename NotImplementedException to standard NotImplementError.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80798 0039d316-1c4b-4281-b951-d872f2087c98
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac.
For an unknown reason, it was dying here trying to process the minidom import.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6799021
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
Also fix a few issues found along the way.
Tests had regressed a lot. Add a lot of tweaks to make most test pass.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6792060
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
Do s/Popen+communicate/check_call/ replacement in a later change in case it
breaks something.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6794057
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80615 0039d316-1c4b-4281-b951-d872f2087c98
It will be used for:
- git cl patch so binary files can be patched
- try jobs instead of doing a curl <url> | patch
BUG=
TEST=
Review URL: http://codereview.chromium.org/6792028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80355 0039d316-1c4b-4281-b951-d872f2087c98
Make sure every site that catches gclient_utils.Error also catch
subprocess2.CalledProcessError.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6691034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80339 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise I get useless stack traces and the user too.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6794020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80338 0039d316-1c4b-4281-b951-d872f2087c98
It should be fine now that I've fixed python2.5 compatilibity issues in subprocess2.py.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6759074
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80216 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise tree status with non-ascii characters could throw at the console.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6788013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80173 0039d316-1c4b-4281-b951-d872f2087c98
Not changed git-cl integration tests because they assume the current directory
is ./tests/
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6690046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80156 0039d316-1c4b-4281-b951-d872f2087c98
Deprecate RunPythonUnitTests() since it is a bit awkward.
Add os_listdir, os_walk and platform to InputApi.
GOAL=Slowly adds python 2.5 support for unit tests
BUG=none
TEST=new unit test
R=dpranke@chromium.org
Review URL: http://codereview.chromium.org/6778027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80009 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=Poor mac users should be able to use git-cl back again.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79932 0039d316-1c4b-4281-b951-d872f2087c98
This make possible to apply private issues or rietveld instances requiring
authentication.
Forces simplejson to be installed or uses python 2.6's json
Make local_rietveld.py usable standalone.
R=dpranke@chromium.org
TEST=unit tests + manual testing, owners.sh is currentl broken, unrelated to this change.
BUG=none
Review URL: http://codereview.chromium.org/6721031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79734 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
scottbyer@chromium.org
bauerb@chromium.org
dpranke@chromium.org
bradnelson@google.com