Mostly useful for commit-queue as I want to both send the trace and be able to
read it locally.
TBR=jam
Review URL: http://codereview.chromium.org/5608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98
When an HTTP exception information is logged, no information is sent by
default. Add an helper function to manually extract interesting information
to append it to the exception type.
Also disable another pylint warning.
TEST=manual test
BUG=none
Review URL: http://codereview.chromium.org/5303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98
If the host parameter is invalid, like having a trailing backslash, it will
result on HTTP 400 later which is much harder to diagnose.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5339001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67295 0039d316-1c4b-4281-b951-d872f2087c98
Don't block execution.
Python 2.4 has been untested for a while and may break unexpectedly.
TEST=manual testing
BUG=none
Review URL: http://codereview.chromium.org/5110009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66870 0039d316-1c4b-4281-b951-d872f2087c98
This issue is only on python 2.4.
BUG=
TEST=
Review URL: http://codereview.chromium.org/5216004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66867 0039d316-1c4b-4281-b951-d872f2087c98
We need this now for an imminent rietveld instance move.
TEST=worked with manual testing
BUG=none
Review URL: http://codereview.chromium.org/5138007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66810 0039d316-1c4b-4281-b951-d872f2087c98
Improve SendToRietveld to hardcode less function arguments.
TEST=manually tested that gcl works on both chromium and non-chromium rietveld instances
BUG=none
Review URL: http://codereview.chromium.org/5015005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66499 0039d316-1c4b-4281-b951-d872f2087c98
on system that don't hard code bash's path.
For example, BSD's bash lives in /usr/local/bin on freebsd & openbsd.
Patch contributed by Sevan Janiyan (venture37 at gmail)
TEST=didn't break ubuntu users
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66124 0039d316-1c4b-4281-b951-d872f2087c98
Make -D -f combination more effective by deleting directories even if there is
modified files.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4803001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65845 0039d316-1c4b-4281-b951-d872f2087c98
Python standard library is not thread safe. Work around it by leaking a bit.
The problem is particularly visible on python 2.4.
TEST=none
BUG=60623
Review URL: http://codereview.chromium.org/4465001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65048 0039d316-1c4b-4281-b951-d872f2087c98
Most of them are style issues or variable aliasing.
TEST=Can almost enable pylint warnings
BUG=none
Review URL: http://codereview.chromium.org/4360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
This is especially annoying on empty __init__.py files.
TEST=new unit test
BUG=none
Review URL: http://codereview.chromium.org/4310001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64904 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise files containing these characters can be created on the file system,
making it harder to get rid of those files.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4127014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64782 0039d316-1c4b-4281-b951-d872f2087c98
Upload hook are only run with the --upload flag.
Most of the time the same hook is run in both case so gcl presubmit is simply 2x
slower than it could be otherwise.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4277003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64779 0039d316-1c4b-4281-b951-d872f2087c98
BUG=None
TEST=Add '*.diff' to 'global-ignores' in your local SVN configuration. Submit a try job using 'gcl try'.
Review URL: http://codereview.chromium.org/4240003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64768 0039d316-1c4b-4281-b951-d872f2087c98
This makes gcl to use a specific rietveld instance per change list. This is
useful when moving from one rietveld instance to another, so in-flight reviews
are sent to the right instance.
Also clear gcl.CODEREVIEW_SETTINGS between gcl_unittest tests to remove tests interference.
TEST=updated unit tests
BUG=none
Review URL: http://codereview.chromium.org/4218006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64631 0039d316-1c4b-4281-b951-d872f2087c98
The new format will be introduced in the next change.
TEST=not much, mostly manually tested.
BUG=none
Review URL: http://codereview.chromium.org/4106011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64600 0039d316-1c4b-4281-b951-d872f2087c98
Doing static analysis on the script greatly easy refactoring since it reduces
the chances of leaving a typo in rarely executed & untested & untested code.
This is in preparation to refactor changelist on-disk format to use json.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64427 0039d316-1c4b-4281-b951-d872f2087c98
Previously, solution's properties would be ignored if there was no DEPS file in
source control. Change the behavior to evaluate the properties anyway.
TEST=new smoke test
BUG=none
Review URL: http://codereview.chromium.org/4154004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64232 0039d316-1c4b-4281-b951-d872f2087c98
To make sure to regression is added while looking into the code more deeply.
BUG=none
TEST=new smoke test
Review URL: http://codereview.chromium.org/4215001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64230 0039d316-1c4b-4281-b951-d872f2087c98
Create an update_depot_tools.bat file to use for updated when on cygwin, and
properly call it from the update_depot_tools shell script and gclient batch
files.
BUG=none
TEST=gclient sync and git cl work again on cygwin. Can also turn echo on in update_depot_tools.bat to verify updating working correctly.
Review URL: http://codereview.chromium.org/3856006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63234 0039d316-1c4b-4281-b951-d872f2087c98
Also, modify git-cl to also update depot_tools. Otherwise, the git-cl
script never gets updated for folks that only use git-cl but
not gclient. This fixes a bug ChromiumOS developers are currently seeing
where there git-cl checkout is still pointing to src.chromium.org
and not git.chromium.org.
BUG=none
TEST=Verified that git-cl help and gclient help work.
Review URL: http://codereview.chromium.org/3817011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62948 0039d316-1c4b-4281-b951-d872f2087c98
This is nicer than an error message.
TEST=manually tested the url was overwritten
BUG=none
Review URL: http://codereview.chromium.org/3796010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62923 0039d316-1c4b-4281-b951-d872f2087c98
Prints a meaningful message instead of throwing an exception.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3828010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62920 0039d316-1c4b-4281-b951-d872f2087c98
It happens when a user uses --diff foo.diff so the list of file is not defined.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62547 0039d316-1c4b-4281-b951-d872f2087c98
This occurs when gclient compares the cached deps in .gclient_entries
to the new DEPS and tries to construct an SCM for any cached entries
which no longer exist. In this situation gclient doesn't account for
the case where previous entries may have been ignored by setting their
url to None via the custom_deps section in .gclient.
Contributed by Jay Soffian.
Review URL: http://codereview.chromium.org/3769002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62540 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
jam@chromium.org
erg@google.com
joi@chromium.org
erikwright@chromium.org
scheib@chromium.org
scottbyer@chromium.org
msb@chromium.org
chase@chromium.org
mattm@google.com