Commit Graph

11527 Commits (3be09c6d74ab3e69c99a4dfef5cac79d075b7142)
 

Author SHA1 Message Date
Struan Shrimpton 3be09c6d74 telemetry: Fix imports
Logging was missing from __init__.py which broke under mac. This adds
that back in and remove unused imports from other files. The os check
is also moved up to be the first thing we look for since is_google_host
does not work with mac at the moment.

Bug:326277821
Change-Id: I3f28838d367eb9583332fd33ad35d71c0851fe4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6604498
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
6 months ago
recipe-roller 68f0a29a64 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713453865358003793

recipe_engine:
e84c69f5be
  e84c69f (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 1b36fc761e1c to 963177240b1a

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5310258ba76b080a2e606f57106dd89f8ebabdab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6607117
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
recipe-roller cdaf46a7e0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713464560643898273

recipe_engine:
577d861408
  577d861 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from bd5a29a53796 to 84cdfc9415e1

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idf1f9106c3e32d6f6095a7046465be4a95d5ec7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6607116
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Tom Anderson bba26d14be Add checkout_riscv64 variable
Bug: 42050595
Change-Id: Ie4830b88db8bc6c0e0c9ed3e28b5c8dff104b3bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6602743
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
6 months ago
recipe-roller c9fe205c66 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713552641393801633

recipe_engine:
b5f961898a
  b5f9618 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from cf9bf9afdbf3 to 25a9a65cf954

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib0366769af98f33ade65acc3cbeacebdc8366da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6600018
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Junji Watanabe e68bbfc572 Prepend caffeinate to build commands on macOS
When building on macOS, it's better to avoid sleeping with caffeinate by
default. This CL prepends `caffeinate` to the build commands, which can
be opted out with `--no-caffeinate`.

Change-Id: Iacb72acb6523576305b38fe45bfef12f87121a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6596109
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
6 months ago
Mike Frysinger 2b62f95de3 git_auth: fix ~/ handling in http.cookiefile
Change-Id: Ifa9505477fa1e1e717e1a499f5200f8840d7be50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6597961
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
6 months ago
Gavin Mak d0540cbe13 Add rev to rootRepo push option
Bug: 401148931
Change-Id: I19dd68ef56e07b24a442ec964dd49e52fa3a8385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6579730
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
6 months ago
recipe-roller 2ec0bed3c8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713609264677844609

recipe_engine:
034bef2e48
  034bef2 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 56c955411cc4 to 14c3619c125e

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c4bb63d45a64560f5bf191833a56e53a90c4481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6594597
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
recipe-roller 5a482425b1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713611780675996241

recipe_engine:
a73575ca63
  a73575c (mohrr@google.com)
      [post_process] Add checks for links

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9c45ef2aa4948b01264abcbb0359f9b2d7ec8d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6598143
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Vadim Shtayura 321bb9ac20 Update luci-auth to the latest version.
To pick up
https://chromium.googlesource.com/infra/luci/luci-go/+/91d90388c2a

R=borenet@google.com

Change-Id: I649e88eb78bb427e89eae48b1e75657262500803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6598134
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
6 months ago
recipe-roller 0b1d80ab9e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713658336808169873

recipe_engine:
c82828447d
  c828284 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 987394c06ef0 to 3ec1c178f296

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7d083c0e3037916604a193e2c376a2f2765794aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6594095
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Michael Cui 332e5f1815 git_cl: Use tuple argument to str.endswith in CMDformat
This greatly simplifies `MatchingFileType`, so it is now inlined.

Bug: None
Change-Id: I6a6a21009aa2193a85383fe1db7c401b8fd9c4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508213
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
6 months ago
Gavin Mak 0772b51a97 Make cipd available in recipe bundle for dirmd
dirmd is present in the CIPD package, but running it gets:
./cipd_bin_setup.sh: line 25: ./cipd: No such file or directory

Bug: 416037494
Change-Id: I69b6640056ba9454737d02973119ee5cde771d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6580852
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
6 months ago
recipe-roller 1f6f9c478a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713696085699410513

recipe_engine:
b80f470ca4
  b80f470 (mohrr@google.com)
      [annotations] Assume new-style annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9e4078235003559f281314c63046f72b5458881c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6594091
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Junji Watanabe a8900cc0f0 autoninja: Read default use_siso variable from .gn
This CL allows non-Chromium projects to enable Siso by default via
`.gn`.

How to determine use_siso default:
1) If //build/config/siso/.sisoenv doesn't exist, use Ninja.
2) If it's not on corp machine, use Ninja.
3) If .gn specifies use_siso=True, use Siso.
4) If //build/config/gclient_args.gni specifies
`build_with_chromium = true`, use Siso.
5) If the build dir has already used Siso, use Siso.
Otherwise, use Ninja.

Note that the condition 4) will be removed after Chromium specifies
use_siso=true in .gn and waits for a while.

Bug: 409223168
Change-Id: I05d36b0e4e0c50cca8a1587135724ec837f4ee36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6585977
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
6 months ago
recipe-roller e0ece52cfb Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714104401764543089

recipe_engine:
4ed4f15066
  4ed4f15 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 14c1dfd95e07 to 218dc31109b1

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9aea3d04cb12db699b34b5764a887439f46d2033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6582222
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
recipe-roller 2b2ac20ac0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714116984007880465

recipe_engine:
203131bb2c
  203131b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from db7e9d50d2f8 to 14c1dfd95e07

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09965860f35099393df018b5f3e1e356314e0c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6581222
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
recipe-roller 2ce4c87bda Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714147808557051793

recipe_engine:
f3ec175669
  f3ec175 (mohrr@google.com)
      [cipd] Add annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54cb0b207fa75c60310a5d5480d84969faa459f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6579754
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Patrick Meiring 77408187c6 [ResultSink] Roll to prod (depot_tools).
Includes:
28e46d8e36..1bf944acb4/resultdb/sink/

(via 962d2d0953..3543fb152a/go/src/go.chromium.org/luci)

BUG=b:415878114

Change-Id: Ie962a559b1857e14d291c77af63fd6f5238f3628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6577851
Reviewed-by: Chan Li <chanli@chromium.org>
Auto-Submit: Patrick Meiring <meiring@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
6 months ago
recipe-roller d4e0bd4085 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714154733812660801

recipe_engine:
fb4f6a64e0
  fb4f6a6 (mohrr@google.com)
      [cipd] Add make_link() method

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I298986817d1b07a8fd5878fb15ba7402fca5976d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6580297
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Adam Rice b986c3475d git cl split: Use relative path for $description
Do not include the repository path when substituting the $description
variable into the CL description. It is too long, not useful for people
reviewing the CLs, and may include private information.

Change-Id: Ic1a637df42386535c02d77a989ef7997ebf4186d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6562142
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Adam Rice <ricea@google.com>
6 months ago
recipe-roller f73c587323 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714250991723838561

recipe_engine:
1371a134f3
  1371a13 (mohrr@google.com)
      [step_data] Fail if extra arguments are provided

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57aa3c46cfc6926451289e05d5dfcd5bb7a4a995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6575860
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
recipe-roller 0888983e47 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714330894395818337

recipe_engine:
b6ef81c466
  b6ef81c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from b96d86b25626 to d1951818759b

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iabd7a139b2181cf3b66f42cc42dd97f34cca04c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6569629
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 months ago
Jordan Brown 196d941610 Change to '--no-update-readme' in commit message
After the change to add '--no' to --update-readme (swapping the default
behaviour), I forgot to change the commit message.

E.g:
* https://crrev.com/c/6558948
* https://crrev.com/c/6553930

Change-Id: I5f68e6b0517a0a9ad7182c7389332134c98c0c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6559761
Reviewed-by: Rachael Newitt <renewitt@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Auto-Submit: Jordan Brown <rop@google.com>
6 months ago
Ramin Halavati f810dae272 Add two items to licenses allow list.
Add the following two items to the licenses allow list as dependencies
of ScreenAI:
 - LicenseRef-MicrosoftEnterpriseWindowsDriverKit
 - LicenseRef-Public-Domain-Gutenberg

Bug: 378472917
Change-Id: I4f8786fb9880a61dcb379b57e0ead3d3ae9cff41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6529681
Commit-Queue: Jordan Brown <rop@google.com>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jordan Brown <rop@google.com>
6 months ago
Gavin Mak c273e3eb62 Make dirmd available in recipe bundle
`dirmd` was not previously included in the recipes bundle, and couldn't
be used in recipes. Update `.gitattributes` to include it in the bundle.

Its dependencies should already be covered by `/*.bat`, `/*.sh`,
and `/cipd_manifest*` patterns.

Bug: 416037494
Change-Id: I320cb6ef9b5f1679c95c4f36ece534ddc75bcdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6546185
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
6 months ago
Aleksey Khoroshilov a9cc320bf7 git cl format: Fix return code when using both --dry-run and --diff
When running `git cl format` with both --dry-run and --diff flags, some
formatters weren't returning exit code 2 when files needed formatting.
This made it impossible to detect formatting issues when using both
flags together.

Modified the following formatters to consistently return exit code 2
when files need formatting under --dry-run --diff flags:
- java
- rustfmt
- swift-format
- yapf
- gn

Also fixed incorrect usage of --presubmit flag in rustfmt and
swift-format. This flag is only intended to filter out formatters that
have dedicated presubmit checks, not to control their return codes.
Since CheckPatchFormatted in presubmit_canned_checks.py always passes
both --dry-run and --presubmit flags, the presubmit behavior remains
unchanged.

Change-Id: I4c26f22fc197c700a5c08d42b96ea4fc535ce293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6509717
Commit-Queue: Aleksei Khoroshilov <akhoroshilov@brave.com>
Auto-Submit: Aleksei Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
7 months ago
Matt Stark 032eddc73b Attach siso metadata to the metadata, if provided.
Change-Id: I3edc6f20738fc1817aae1aaa70b63cd80d0467bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6544987
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Matt Stark <msta@google.com>
7 months ago
recipe-roller 14bfda1708 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715019178055328577

recipe_engine:
1442030ff2
  1442030 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8bc47f0b7013 to 45d1c0a0168f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8df68d4e3248f0a76db3e8e5fe68113ff212a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6538728
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Brian Ryner 7d94687e8d python -> python3 in depot_tools tutorial, and regenerate docs.
Bug: 416084048
Change-Id: I79badc2944ea9f92ace246853f1bf699a3ff0147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6521565
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
7 months ago
recipe-roller 7d18f85450 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715057555637793329

recipe_engine:
8fa1df233c
  8fa1df2 (mohrr@google.com)
      [lint] Allow the enum module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87389aae0f92aaae7b1947da1491d46e9c11e0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6534000
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Gavin Mak 21c86aad65 Specify full dirmd path in CheckDirMetadataFormat
If dirmd_bin` is not provided, default to an absolute path to dirmd.
Otherwise, some builders can fail with a `No such file or directory:
'dirmd'.` like:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/27711/infra

Bug: 416037494
Change-Id: Ibe3c0a80f2b605583321cce95241de62edcaec4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6533317
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
7 months ago
Fumitoshi Ukai 208d245ee8 git_cl: run gn.py instead of gn
fix for https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715095169268935393/overview

Change-Id: I1fa4565ffe44ea0ed29b4b8710ddf933d19f9f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6536211
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
7 months ago
Jordan Brown 977c37458f Change readme updating to be on by default for roll_dep.py
Change-Id: Id6d5a365e55ad0a79e512af24e72f141f8b9a60a
Bug: b/390067679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6521682
Reviewed-by: Rachael Newitt <renewitt@google.com>
Reviewed-by: Andy Perelson <ajp@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
7 months ago
recipe-roller d1f9fa6c92 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715338785807078849

recipe_engine:
5c6fb8b0d9
  5c6fb8b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 82016ce81da7 to 4486e4bb411a

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic193c632a0af502ff5042272fa730e3422068726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6530523
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Fumitoshi Ukai a7571b1596 Reland "Reland "Use bundled python to run gn""
This reverts commit 6678906cf8.

Reason for revert:
run gn.py instead of gn on PATH in presubmit check.

Bug: 414312048
Original change's description:
> Revert "Reland "Use bundled python to run gn""
>
> This reverts commit 49fcbee29e.
>
> Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview
>
> Bug: 414312048
> Original change's description:
> > Reland "Use bundled python to run gn"
> >
> > This reverts commit a3cdfed6c4.
> >
> > Reason for revert:
> > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
> >
> > Original change's description:
> > > Revert "Use bundled python to run gn"
> > >
> > > This reverts commit fa8fc854e1.
> > >
> > > Reason for revert: Most likely culprit for consistent failure
> > > to generate orderfiles (see crbug.com/414312048).
> > >
> > > Bug: 414312048
> > >
> > > Original change's description:
> > > > Use bundled python to run gn
> > > >
> > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > >
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> >
> > Bug: 414312048
> > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
>
> Bug: 414312048
> Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
> Commit-Queue: Garrett Beaty <gbeaty@google.com>
> Reviewed-by: Garrett Beaty <gbeaty@google.com>
> Owners-Override: Garrett Beaty <gbeaty@google.com>
> Auto-Submit: Liviu Rau <liviurau@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: I86d611b234bd5b2e91b184c7610c18cfe79f9816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6515221
Reviewed-by: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
7 months ago
Michael Cui fab0a4296b subcommand: Add type annotations
This should make it easier for people unfamiliar with how the command
parsers work to follow along.

Bug: None
Change-Id: I6a6a2100cb881610a14b298303a3040e9ea5ffb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508214
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Michael Cui <mlcui@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
7 months ago
Fumitoshi Ukai 18580cf9c4 DEPOT_TOOLS_WIN_TOOLCHAIN=0 does not work with remote execution
Bug: 313567009
Change-Id: I7192b1bc5e9d7ddb2648508999e26fc6eb64d695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6507987
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
7 months ago
Michael Cui 8c9aa83747 git_cl: Add type annotations to CMDformat and related functions
This should not change any runtime behaviour.

Bug: None
Change-Id: I6a6a2100826919ea8675b743adbcf3d4fbf05b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508212
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Michael Cui <mlcui@google.com>
7 months ago
Michael Cui e760b35cbc git_cl: Replace `+= [...]` with `.append(...)` in CMDformat
This should be a bit more understandable, especially as `formatters` is
a list of tuples.

Bug: None
Change-Id: I6a6a2100e5169f1270bc3167a584274f67b80ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508211
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
7 months ago
recipe-roller 30d9438e7b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715683557097989857

recipe_engine:
283e15116d
  283e151 (mohrr@google.com)
      [buildbucket] Add RPC explorer link to search()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b4cf1da65f9b27438d410e90925f45ba38d794f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6514142
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Liviu Rau 6678906cf8 Revert "Reland "Use bundled python to run gn""
This reverts commit 49fcbee29e.

Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview

Bug: 414312048
Original change's description:
> Reland "Use bundled python to run gn"
>
> This reverts commit a3cdfed6c4.
>
> Reason for revert: 
> https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
>
> Original change's description:
> > Revert "Use bundled python to run gn"
> >
> > This reverts commit fa8fc854e1.
> >
> > Reason for revert: Most likley culprit for consistent failure
> > to generate orderfiles (see crbug.com/414312048).
> >
> > Bug: 414312048
> >
> > Original change's description:
> > > Use bundled python to run gn
> > >
> > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> >
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
>
> Bug: 414312048
> Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>

Bug: 414312048
Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Owners-Override: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
7 months ago
recipe-roller d66abd0ede Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715933327969659505

recipe_engine:
65c813d875
  65c813d (mohrr@google.com)
      [scheduler] Always get url of current build

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id77b2111ab994dc6fb9134535b5656778fb1981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6509823
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Kameron Lutes 53c3b05869 Add hjson wheel for web-tests presubmit support
Change-Id: I2b7c8ebec60fefd8b0d4ee6d1362ca37ae604278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6502114
Commit-Queue: Kameron Lutes <kalutes@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
7 months ago
Scott Lee 8a150ad9d7 Reland "git-cache: contains_revision returns False if sentient file exists"
This reverts commit 550706e9f4.

Reason for revert: https://crrev.com/c/6497038 was landed to make a fix for the lock failure.

Bug: 41488725
Original change's description:
> Revert "git-cache: contains_revision returns False if sentient file exists"
>
> This reverts commit 5a267a66a6.
>
> Reason for revert: Causing gclient sync failures: https://ci.chromium.org/ui/p/chromeos/builders/staging/staging-amd64-generic-msan-fuzzer/b8716255278944170913
>
> Bug: 41488725
> Original change's description:
> > git-cache: contains_revision returns False if sentient file exists
> >
> > If git_cache.populate() gets interrupted midway, it can possibly leave
> > a git mirror in a state where only some commits are available. Cloning
> > such a repo results in an empty repository and causes subsequent git
> > checkout to fail.
> >
> > If the sentient file exists, it indicates that the bootstrapping
> > process was interrupted. This CL updates git_cache.contains_revision()
> > such that it returns False if the sentient file exists. Then,
> > the caller can call mirror.populate() to re-populate the repo/rev.
> >
> > Bug: 41488725
> > Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
> > Reviewed-by: Gavin Mak <gavinmak@google.com>
> > Commit-Queue: Scott Lee <ddoman@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 41488725
> Change-Id: I50f3ce5f0b6802db5969546d43a4fe1ab2dcf3c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497449
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Auto-Submit: Andrew Lamb <andrewlamb@chromium.org>

Bug: 41488725
Change-Id: Ia74db70be221f7cdf0960632644162bb3d39e5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6507483
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
7 months ago
recipe-roller 354f6026f1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716109482291793009

recipe_engine:
eb38681bf0
  eb38681 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8dabdee3cdfa to a9a10995e288

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc633637659c57698a223150d284c75033a920e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504159
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
7 months ago
Fumitoshi Ukai 49fcbee29e Reland "Use bundled python to run gn"
This reverts commit a3cdfed6c4.

Reason for revert: 
https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed

Original change's description:
> Revert "Use bundled python to run gn"
>
> This reverts commit fa8fc854e1.
>
> Reason for revert: Most likley culprit for consistent failure
> to generate orderfiles (see crbug.com/414312048).
>
> Bug: 414312048
>
> Original change's description:
> > Use bundled python to run gn
> >
> > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
7 months ago
Kameron Lutes 5982a1aeb3 Add fetch config for web-tests
Add a fetch config for the web-tests repo.

Change-Id: I27a9f24d6099db687dacd7a6302b01bde5b98005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491216
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Kameron Lutes <kalutes@google.com>
7 months ago
Fumitoshi Ukai d5d4b956e2 explain build tools and depot_tools installations
Bug: 414330998
Change-Id: If65a11c2dc5448636ee608866959aad0bf298fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497244
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
7 months ago