aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reland "Use bundled python to run gn"

Browse Source 
This reverts commit a3cdfed6c4.

Reason for revert: 
https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed

Original change's description:
> Revert "Use bundled python to run gn"
>
> This reverts commit fa8fc854e1.
>
> Reason for revert: Most likley culprit for consistent failure
> to generate orderfiles (see crbug.com/414312048).
>
> Bug: 414312048
>
> Original change's description:
> > Use bundled python to run gn
> >
> > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
changes/76/6504176/2
Fumitoshi Ukai 6 months ago committed by LUCI CQ
parent 5982a1aeb3
commit 49fcbee29e
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File

2
gn
Unescape Escape View File

@ -11,4 +11,4 @@ if [ "$(expr "$(uname -s)" : "^MINGW64_NT")" == "10" ]; then
exit
fi
PYTHONDONTWRITEBYTECODE=1 exec python3 "$base_dir/gn.py" "$@"
PYTHONDONTWRITEBYTECODE=1 "$base_dir/python-bin/python3" "$base_dir/gn.py" "$@"

4
gn.bat
Unescape Escape View File

@ -8,5 +8,7 @@ setlocal
:: standalone, but allow other PATH manipulations to take priority.
set PATH=%PATH%;%~dp0
set scriptdir=%~dp0
:: Defer control.
python3 "%~dp0\gn.py" %*
@call %scriptdir%python-bin\python3 "%~dp0\gn.py" %*

Write Preview
Loading…
Cancel
Save