aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
11,513 Commits
6 Branches
0 Tags
194 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '1f6f9c478a'
${ noResults }
Commit Graph

11513 Commits (1f6f9c478a6d10a0c568e6d089068d7223a80c18)
 

Author SHA1 Message Date
recipe-roller 1f6f9c478a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8713696085699410513

recipe_engine:
b80f470ca4
  b80f470 (mohrr@google.com)
      [annotations] Assume new-style annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9e4078235003559f281314c63046f72b5458881c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6594091
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
Junji Watanabe a8900cc0f0 autoninja: Read default use_siso variable from .gn 
This CL allows non-Chromium projects to enable Siso by default via
`.gn`.

How to determine use_siso default:
1) If //build/config/siso/.sisoenv doesn't exist, use Ninja.
2) If it's not on corp machine, use Ninja.
3) If .gn specifies use_siso=True, use Siso.
4) If //build/config/gclient_args.gni specifies
`build_with_chromium = true`, use Siso.
5) If the build dir has already used Siso, use Siso.
Otherwise, use Ninja.

Note that the condition 4) will be removed after Chromium specifies
use_siso=true in .gn and waits for a while.

Bug: 409223168
Change-Id: I05d36b0e4e0c50cca8a1587135724ec837f4ee36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6585977
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 6 months ago
recipe-roller e0ece52cfb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714104401764543089

recipe_engine:
4ed4f15066
  4ed4f15 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 14c1dfd95e07 to 218dc31109b1

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9aea3d04cb12db699b34b5764a887439f46d2033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6582222
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
recipe-roller 2b2ac20ac0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714116984007880465

recipe_engine:
203131bb2c
  203131b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from db7e9d50d2f8 to 14c1dfd95e07

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09965860f35099393df018b5f3e1e356314e0c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6581222
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
recipe-roller 2ce4c87bda Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714147808557051793

recipe_engine:
f3ec175669
  f3ec175 (mohrr@google.com)
      [cipd] Add annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54cb0b207fa75c60310a5d5480d84969faa459f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6579754
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
Patrick Meiring 77408187c6 [ResultSink] Roll to prod (depot_tools). 
Includes:
28e46d8e36..1bf944acb4/resultdb/sink/

(via 962d2d0953..3543fb152a/go/src/go.chromium.org/luci)

BUG=b:415878114

Change-Id: Ie962a559b1857e14d291c77af63fd6f5238f3628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6577851
Reviewed-by: Chan Li <chanli@chromium.org>
Auto-Submit: Patrick Meiring <meiring@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 6 months ago
recipe-roller d4e0bd4085 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714154733812660801

recipe_engine:
fb4f6a64e0
  fb4f6a6 (mohrr@google.com)
      [cipd] Add make_link() method

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I298986817d1b07a8fd5878fb15ba7402fca5976d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6580297
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
Adam Rice b986c3475d git cl split: Use relative path for $description 
Do not include the repository path when substituting the $description
variable into the CL description. It is too long, not useful for people
reviewing the CLs, and may include private information.

Change-Id: Ic1a637df42386535c02d77a989ef7997ebf4186d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6562142
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Adam Rice <ricea@google.com>
 6 months ago
recipe-roller f73c587323 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714250991723838561

recipe_engine:
1371a134f3
  1371a13 (mohrr@google.com)
      [step_data] Fail if extra arguments are provided

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57aa3c46cfc6926451289e05d5dfcd5bb7a4a995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6575860
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
recipe-roller 0888983e47 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8714330894395818337

recipe_engine:
b6ef81c466
  b6ef81c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from b96d86b25626 to d1951818759b

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iabd7a139b2181cf3b66f42cc42dd97f34cca04c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6569629
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 months ago
Jordan Brown 196d941610 Change to '--no-update-readme' in commit message 
After the change to add '--no' to --update-readme (swapping the default
behaviour), I forgot to change the commit message.

E.g:
* https://crrev.com/c/6558948
* https://crrev.com/c/6553930

Change-Id: I5f68e6b0517a0a9ad7182c7389332134c98c0c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6559761
Reviewed-by: Rachael Newitt <renewitt@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Auto-Submit: Jordan Brown <rop@google.com>
 6 months ago
Ramin Halavati f810dae272 Add two items to licenses allow list. 
Add the following two items to the licenses allow list as dependencies
of ScreenAI:
 - LicenseRef-MicrosoftEnterpriseWindowsDriverKit
 - LicenseRef-Public-Domain-Gutenberg

Bug: 378472917
Change-Id: I4f8786fb9880a61dcb379b57e0ead3d3ae9cff41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6529681
Commit-Queue: Jordan Brown <rop@google.com>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jordan Brown <rop@google.com>
 7 months ago
Gavin Mak c273e3eb62 Make dirmd available in recipe bundle 
`dirmd` was not previously included in the recipes bundle, and couldn't
be used in recipes. Update `.gitattributes` to include it in the bundle.

Its dependencies should already be covered by `/*.bat`, `/*.sh`,
and `/cipd_manifest*` patterns.

Bug: 416037494
Change-Id: I320cb6ef9b5f1679c95c4f36ece534ddc75bcdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6546185
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 7 months ago
Aleksey Khoroshilov a9cc320bf7 git cl format: Fix return code when using both --dry-run and --diff 
When running `git cl format` with both --dry-run and --diff flags, some
formatters weren't returning exit code 2 when files needed formatting.
This made it impossible to detect formatting issues when using both
flags together.

Modified the following formatters to consistently return exit code 2
when files need formatting under --dry-run --diff flags:
- java
- rustfmt
- swift-format
- yapf
- gn

Also fixed incorrect usage of --presubmit flag in rustfmt and
swift-format. This flag is only intended to filter out formatters that
have dedicated presubmit checks, not to control their return codes.
Since CheckPatchFormatted in presubmit_canned_checks.py always passes
both --dry-run and --presubmit flags, the presubmit behavior remains
unchanged.

Change-Id: I4c26f22fc197c700a5c08d42b96ea4fc535ce293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6509717
Commit-Queue: Aleksei Khoroshilov <akhoroshilov@brave.com>
Auto-Submit: Aleksei Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 7 months ago
Matt Stark 032eddc73b Attach siso metadata to the metadata, if provided. 
Change-Id: I3edc6f20738fc1817aae1aaa70b63cd80d0467bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6544987
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Matt Stark <msta@google.com>
 7 months ago
recipe-roller 14bfda1708 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715019178055328577

recipe_engine:
1442030ff2
  1442030 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8bc47f0b7013 to 45d1c0a0168f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8df68d4e3248f0a76db3e8e5fe68113ff212a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6538728
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Brian Ryner 7d94687e8d python -> python3 in depot_tools tutorial, and regenerate docs. 
Bug: 416084048
Change-Id: I79badc2944ea9f92ace246853f1bf699a3ff0147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6521565
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 7 months ago
recipe-roller 7d18f85450 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715057555637793329

recipe_engine:
8fa1df233c
  8fa1df2 (mohrr@google.com)
      [lint] Allow the enum module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87389aae0f92aaae7b1947da1491d46e9c11e0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6534000
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Gavin Mak 21c86aad65 Specify full dirmd path in CheckDirMetadataFormat 
If dirmd_bin` is not provided, default to an absolute path to dirmd.
Otherwise, some builders can fail with a `No such file or directory:
'dirmd'.` like:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/27711/infra

Bug: 416037494
Change-Id: Ibe3c0a80f2b605583321cce95241de62edcaec4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6533317
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 7 months ago
Fumitoshi Ukai 208d245ee8 git_cl: run gn.py instead of gn 
fix for https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715095169268935393/overview

Change-Id: I1fa4565ffe44ea0ed29b4b8710ddf933d19f9f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6536211
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 7 months ago
Jordan Brown 977c37458f Change readme updating to be on by default for roll_dep.py 
Change-Id: Id6d5a365e55ad0a79e512af24e72f141f8b9a60a
Bug: b/390067679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6521682
Reviewed-by: Rachael Newitt <renewitt@google.com>
Reviewed-by: Andy Perelson <ajp@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
 7 months ago
recipe-roller d1f9fa6c92 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715338785807078849

recipe_engine:
5c6fb8b0d9
  5c6fb8b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 82016ce81da7 to 4486e4bb411a

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic193c632a0af502ff5042272fa730e3422068726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6530523
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Fumitoshi Ukai a7571b1596 Reland "Reland "Use bundled python to run gn"" 
This reverts commit 6678906cf8.

Reason for revert:
run gn.py instead of gn on PATH in presubmit check.

Bug: 414312048
Original change's description:
> Revert "Reland "Use bundled python to run gn""
>
> This reverts commit 49fcbee29e.
>
> Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview
>
> Bug: 414312048
> Original change's description:
> > Reland "Use bundled python to run gn"
> >
> > This reverts commit a3cdfed6c4.
> >
> > Reason for revert:
> > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
> >
> > Original change's description:
> > > Revert "Use bundled python to run gn"
> > >
> > > This reverts commit fa8fc854e1.
> > >
> > > Reason for revert: Most likely culprit for consistent failure
> > > to generate orderfiles (see crbug.com/414312048).
> > >
> > > Bug: 414312048
> > >
> > > Original change's description:
> > > > Use bundled python to run gn
> > > >
> > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > >
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> >
> > Bug: 414312048
> > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
>
> Bug: 414312048
> Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
> Commit-Queue: Garrett Beaty <gbeaty@google.com>
> Reviewed-by: Garrett Beaty <gbeaty@google.com>
> Owners-Override: Garrett Beaty <gbeaty@google.com>
> Auto-Submit: Liviu Rau <liviurau@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: I86d611b234bd5b2e91b184c7610c18cfe79f9816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6515221
Reviewed-by: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 7 months ago
Michael Cui fab0a4296b subcommand: Add type annotations 
This should make it easier for people unfamiliar with how the command
parsers work to follow along.

Bug: None
Change-Id: I6a6a2100cb881610a14b298303a3040e9ea5ffb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508214
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Michael Cui <mlcui@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 7 months ago
Fumitoshi Ukai 18580cf9c4 DEPOT_TOOLS_WIN_TOOLCHAIN=0 does not work with remote execution 
Bug: 313567009
Change-Id: I7192b1bc5e9d7ddb2648508999e26fc6eb64d695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6507987
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 7 months ago
Michael Cui 8c9aa83747 git_cl: Add type annotations to CMDformat and related functions 
This should not change any runtime behaviour.

Bug: None
Change-Id: I6a6a2100826919ea8675b743adbcf3d4fbf05b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508212
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Michael Cui <mlcui@google.com>
 7 months ago
Michael Cui e760b35cbc git_cl: Replace `+= [...]` with `.append(...)` in CMDformat 
This should be a bit more understandable, especially as `formatters` is
a list of tuples.

Bug: None
Change-Id: I6a6a2100e5169f1270bc3167a584274f67b80ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508211
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 7 months ago
recipe-roller 30d9438e7b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715683557097989857

recipe_engine:
283e15116d
  283e151 (mohrr@google.com)
      [buildbucket] Add RPC explorer link to search()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b4cf1da65f9b27438d410e90925f45ba38d794f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6514142
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Liviu Rau 6678906cf8 Revert "Reland "Use bundled python to run gn"" 
This reverts commit 49fcbee29e.

Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview

Bug: 414312048
Original change's description:
> Reland "Use bundled python to run gn"
>
> This reverts commit a3cdfed6c4.
>
> Reason for revert: 
> https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
>
> Original change's description:
> > Revert "Use bundled python to run gn"
> >
> > This reverts commit fa8fc854e1.
> >
> > Reason for revert: Most likley culprit for consistent failure
> > to generate orderfiles (see crbug.com/414312048).
> >
> > Bug: 414312048
> >
> > Original change's description:
> > > Use bundled python to run gn
> > >
> > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> >
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
>
> Bug: 414312048
> Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>

Bug: 414312048
Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Owners-Override: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 7 months ago
recipe-roller d66abd0ede Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8715933327969659505

recipe_engine:
65c813d875
  65c813d (mohrr@google.com)
      [scheduler] Always get url of current build

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id77b2111ab994dc6fb9134535b5656778fb1981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6509823
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Kameron Lutes 53c3b05869 Add hjson wheel for web-tests presubmit support 
Change-Id: I2b7c8ebec60fefd8b0d4ee6d1362ca37ae604278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6502114
Commit-Queue: Kameron Lutes <kalutes@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 7 months ago
Scott Lee 8a150ad9d7 Reland "git-cache: contains_revision returns False if sentient file exists" 
This reverts commit 550706e9f4.

Reason for revert: https://crrev.com/c/6497038 was landed to make a fix for the lock failure.

Bug: 41488725
Original change's description:
> Revert "git-cache: contains_revision returns False if sentient file exists"
>
> This reverts commit 5a267a66a6.
>
> Reason for revert: Causing gclient sync failures: https://ci.chromium.org/ui/p/chromeos/builders/staging/staging-amd64-generic-msan-fuzzer/b8716255278944170913
>
> Bug: 41488725
> Original change's description:
> > git-cache: contains_revision returns False if sentient file exists
> >
> > If git_cache.populate() gets interrupted midway, it can possibly leave
> > a git mirror in a state where only some commits are available. Cloning
> > such a repo results in an empty repository and causes subsequent git
> > checkout to fail.
> >
> > If the sentient file exists, it indicates that the bootstrapping
> > process was interrupted. This CL updates git_cache.contains_revision()
> > such that it returns False if the sentient file exists. Then,
> > the caller can call mirror.populate() to re-populate the repo/rev.
> >
> > Bug: 41488725
> > Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
> > Reviewed-by: Gavin Mak <gavinmak@google.com>
> > Commit-Queue: Scott Lee <ddoman@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 41488725
> Change-Id: I50f3ce5f0b6802db5969546d43a4fe1ab2dcf3c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497449
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Auto-Submit: Andrew Lamb <andrewlamb@chromium.org>

Bug: 41488725
Change-Id: Ia74db70be221f7cdf0960632644162bb3d39e5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6507483
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 7 months ago
recipe-roller 354f6026f1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716109482291793009

recipe_engine:
eb38681bf0
  eb38681 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8dabdee3cdfa to a9a10995e288

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc633637659c57698a223150d284c75033a920e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504159
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Fumitoshi Ukai 49fcbee29e Reland "Use bundled python to run gn" 
This reverts commit a3cdfed6c4.

Reason for revert: 
https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed

Original change's description:
> Revert "Use bundled python to run gn"
>
> This reverts commit fa8fc854e1.
>
> Reason for revert: Most likley culprit for consistent failure
> to generate orderfiles (see crbug.com/414312048).
>
> Bug: 414312048
>
> Original change's description:
> > Use bundled python to run gn
> >
> > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 7 months ago
Kameron Lutes 5982a1aeb3 Add fetch config for web-tests 
Add a fetch config for the web-tests repo.

Change-Id: I27a9f24d6099db687dacd7a6302b01bde5b98005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491216
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Kameron Lutes <kalutes@google.com>
 7 months ago
Fumitoshi Ukai d5d4b956e2 explain build tools and depot_tools installations 
Bug: 414330998
Change-Id: If65a11c2dc5448636ee608866959aad0bf298fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497244
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 7 months ago
Fumitoshi Ukai e6596746dc better error message from python3 when not initialized 
Bug: 414330998
Change-Id: I47fcd9571ba3de0a080e31624f9bdf0fa738914a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6498079
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 7 months ago
recipe-roller 8f95112db7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716145979252344769

recipe_engine:
0d18da34ce
  0d18da3 (olivernewman@google.com)
      [change_verifier] Allow searching runs by patchset

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5111ed205dc62ad7aabb54ec2a513ddbe0cc9d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6501681
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
recipe-roller 6bcdcd8a85 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716195051818979713

recipe_engine:
be22546f87
  be22546 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 415dbeb2667e to 74734688ffc9

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb1546d503e174bca940c6d1fb8e186aa7fb1df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6499850
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Scott Lee df1785bdc2 lockfile: release the lock before closing the file handler 
After crrev.com/c/6486489 landed, gclient sync failed randomly due to
lock failures. After investigation, it was concluded that the locks
are not immediately released after the lock file handler close so that
it fails to acquire the lock if gclient_scm.py attempts to lock it
immediately after mirror.populate().

In Linux, there is no guarantee that the file close will release
all the locks before processing the file description closure, unlike
the CloseHandle() do in Microsoft Windows.

This CL is to update the logic so that it releases the lock
before os.close().

Bug: 407795715
Change-Id: I0f58627d368922f27c0590dcea2e7fde4242ae17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497038
Auto-Submit: Scott Lee <ddoman@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 7 months ago
wnwen@chromium.org 3b73c8d8eb android: Add wnwen to OWNERS 
To help maintain android_build_server_helper.py and revert any failing
changes to it.

R=sokcevic@google.com

Bug: 393136861
Change-Id: Ib4d111ffa03e21a3d733dec64141e7d00da573b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6499329
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 7 months ago
wnwen@chromium.org d6a7a6bd9c android: Allow anonymous pipes for benchmarking 
In a typical scenario we would not want to run the build server if
autoninja is run as part of a script (see https://crrev.com/c/6278629),
but specifically for benchmarking, we want to allow callers who
explicitly set AUTONINJA_STDOUT_NAME to still run the build server, as
these callers need the build server to run to properly time and
benchmark, even if all the output is discarded.

R=agrieve@chromium.org

Bug: 393136861
Change-Id: I97f556c2238eacc5cc8240287f4c6da0160efb71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6499328
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
 7 months ago
recipe-roller 85b059fe00 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716230913990375921

recipe_engine:
05f1abb5b3
  05f1abb (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9f2cd408ac98 to 4a13ff8ec3a4

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c73a3fc1db4c6fee5076ae6e8a3a0a87949c6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497450
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Vadim Shtayura eefd2ed010 [cipd] Update lucicfg to v1.45.0. 
This picks up PACKAGE.star support.

R=iannucci@chromium.org

Change-Id: I7f1169084c9a5b543fae41a84842b094ca8e9684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6496449
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
 7 months ago
Andrew Lamb 550706e9f4 Revert "git-cache: contains_revision returns False if sentient file exists" 
This reverts commit 5a267a66a6.

Reason for revert: Causing gclient sync failures: https://ci.chromium.org/ui/p/chromeos/builders/staging/staging-amd64-generic-msan-fuzzer/b8716255278944170913

Bug: 41488725
Original change's description:
> git-cache: contains_revision returns False if sentient file exists
>
> If git_cache.populate() gets interrupted midway, it can possibly leave
> a git mirror in a state where only some commits are available. Cloning
> such a repo results in an empty repository and causes subsequent git
> checkout to fail.
>
> If the sentient file exists, it indicates that the bootstrapping
> process was interrupted. This CL updates git_cache.contains_revision()
> such that it returns False if the sentient file exists. Then,
> the caller can call mirror.populate() to re-populate the repo/rev.
>
> Bug: 41488725
> Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 41488725
Change-Id: I50f3ce5f0b6802db5969546d43a4fe1ab2dcf3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497449
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Andrew Lamb <andrewlamb@chromium.org>
 7 months ago
Gavin Mak 4edb194e91 Set rootRepo custom-keyed-value push option on upload 
This associates a CL with its superproject.

Bug: 401148931
Change-Id: I7fe7bd91485e6e1066963b25f1b95980db6d3381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6476918
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 7 months ago
recipe-roller 43d3eba89b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716298232676626273

recipe_engine:
95805c3153
  95805c3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2cb1ac029774 to 94e82b5e2ea9

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ed4e7e609b93e52a1fb4592e2f10415c1f2a908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497023
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
recipe-roller c3f63ba875 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716318364658264689

recipe_engine:
93db2be6a5
  93db2be (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 426147c8f9cf to eb1acfb1fe32

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1fc3ff2d6c4c4f95cbc6990807bbd51c679ff0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6495264
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 7 months ago
Scott Lee 5a267a66a6 git-cache: contains_revision returns False if sentient file exists 
If git_cache.populate() gets interrupted midway, it can possibly leave
a git mirror in a state where only some commits are available. Cloning
such a repo results in an empty repository and causes subsequent git
checkout to fail.

If the sentient file exists, it indicates that the bootstrapping
process was interrupted. This CL updates git_cache.contains_revision()
such that it returns False if the sentient file exists. Then,
the caller can call mirror.populate() to re-populate the repo/rev.

Bug: 41488725
Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 7 months ago
Yiwei Zhang 2f575c52fc presubmit: do not include long_text in uploaded findings 
The long_text includes stack_trace[1] which is very verbose and not
providing much value. If user really need stacktrace or long_text,
they can access it by going to the build page.

[1]: https://screenshot.googleplex.com/5dcPwjNrtizEVBK

Change-Id: I2c5a5c2703875906f4ccaa1c8b1e83fe3a2f6115
Bug: 404837554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6486346
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 7 months ago