Fix bug with parsing capitalized git shas

Fix identification of shas that contain capitalized
hexadecimal characters.  Addresses comments from
http://crrev.com/18262002/

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18292005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@210429 0039d316-1c4b-4281-b951-d872f2087c98
experimental/szager/collated-output
ilevy@chromium.org 12 years ago
parent 87b091128b
commit 224ba24fef

@ -454,12 +454,12 @@ class GIT(object):
if re.match(r'^[0-9a-fA-F]{40}$', rev):
lookup_rev = rev[:-1]
try:
sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd)
sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd).lower()
if lookup_rev != rev:
# Make sure we get the original 40 chars back.
return rev == sha
return rev.lower() == sha
if sha_only:
return sha.startswith(rev)
return sha.startswith(rev.lower())
return True
except subprocess2.CalledProcessError:
return False

Loading…
Cancel
Save