From 224ba24fefdcb07cf737e04070f25d87ee8504fd Mon Sep 17 00:00:00 2001 From: "ilevy@chromium.org" Date: Mon, 8 Jul 2013 22:02:31 +0000 Subject: [PATCH] Fix bug with parsing capitalized git shas Fix identification of shas that contain capitalized hexadecimal characters. Addresses comments from http://crrev.com/18262002/ R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/18292005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@210429 0039d316-1c4b-4281-b951-d872f2087c98 --- scm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scm.py b/scm.py index 8810c2aa26..5e72464e5f 100644 --- a/scm.py +++ b/scm.py @@ -454,12 +454,12 @@ class GIT(object): if re.match(r'^[0-9a-fA-F]{40}$', rev): lookup_rev = rev[:-1] try: - sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd) + sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd).lower() if lookup_rev != rev: # Make sure we get the original 40 chars back. - return rev == sha + return rev.lower() == sha if sha_only: - return sha.startswith(rev) + return sha.startswith(rev.lower()) return True except subprocess2.CalledProcessError: return False