6418 Commits (73ab41c5722ac8fde55d69c7ba1d3ff6f8c22018)

Author SHA1 Message Date
Adriaan de Groot cba2733471 [plasmalnf] Move job creation to config 6 years ago
Adriaan de Groot 0af12546ef [plasmalnf] Migrate more settings to Config 6 years ago
Adriaan de Groot b4aca7e188 [libcalamares] Tidy up documentation for System::runCommand
- Make explicit which one runs in the host, which one is selectable.
- Document *location* parameter in the selectable version.
- Tidy up alignment of apidox.
6 years ago
Adriaan de Groot 00293d1111 [plasmalnf] Move the lookandfeeltool path setting to Config 6 years ago
Adriaan de Groot 0f07550006 [plasmalnf] Introduce (empty) Config object 6 years ago
Adriaan de Groot a8359696ca [plasmalnf] Remove unnecessary includes 6 years ago
Adriaan de Groot 76b0981918 [plasmalnf] Apply workaround for lookandfeeltool
The lookandfeeltool does not (always?) write the LookAndFeelPackage
key that the KCM does -- and which this module reads on startup
to find the default LnF. This seems to be a regression in recent
lookandfeeltool versions (or in the KCM code that backs it).

Workaround supplied by jghodd.

Fixes #1573
6 years ago
Adriaan de Groot 8f590848bd [plasmalnf] Simplify code
- Look-and-Feel job has no status to speak of
- Coding style
6 years ago
Chrysostomus 543a9e1afc Remove extra static keyword 6 years ago
Adriaan de Groot b503aa645b
Merge pull request #1563 from LordTermor/calamares
[users] Full name transliteration support for user creation
6 years ago
Artem Grinev 16eca3c1be [users] Apply code format 6 years ago
Artem Grinev ca033583a4 Simplified logic a bit, made punctuation handling more correct 6 years ago
Artem Grinev da5fb2d3e1 Improved comment 6 years ago
Artem Grinev d5e678157d Changed TRANSLITERATOR_ID type to array 6 years ago
Gaël PORTAY 7859d98a32 [unpackfs] Skip overlay extended attributes
The module preserves the extended attributes at rsync and the overlay
filesystem stores extended attributes by inodes.

The overlay filesystem keeps traces of the lower directory by encoding
and storing its UUID to the attribute trusted.overlay.origin. If the
index feature is on, that attribute is compared to the UUID of the lower
directory at every subsequent mounts and causes mount to fail with
ESTATE if it does not match.

This filters the namespace trusted.overlay.* by using the rsync option
--filter='-x trusted.overlay.*' to make sure the overlays extended
attributes are not preserved.

Fixes:
        # mount -t overlay -o lowerdir=...,upperdir,...,workdir= overlay /mnt/etc
        mount: /var/mnt/etc: mount(2) system call failed: Stale file handle.

        # dmesg
        (...)
        overlayfs: "xino" feature enabled using 32 upper inode bits.
        overlayfs: failed to verify origin (/etc, ino=524292, err=-116)
        overlayfs: failed to verify upper root origin
6 years ago
Chrysostomus e3ee3c623d Add some relevant looking stuff to header file 6 years ago
Adriaan de Groot b4c3236e4a [users] Consume error information from libpwquality
Previously, the auxerror information was never stored, and
the messages were all un-numbered or un-explained.
Now, consume that information and store it when check()
is called, ready to be used when (possibly much later,
or after a translation change) explanation() is called.
6 years ago
Adriaan de Groot 43565027f5 [users] m_auxerror never set, always nullptr 6 years ago
Adriaan de Groot f3e37f3cee [users] Remove unused PWQuality method 6 years ago
Adriaan de Groot a5dfe7cd68 i18n: update english translations 6 years ago
Adriaan de Groot 4e9c18a565 [users] Translate PWQuality error messages with numbers 6 years ago
Adriaan de Groot 2a9bbf1dd5 [users] Add test for jobs-creation
- This tries to avoid the now-fixed situation where a sudoersGroup job
  is not created at all (because of a logic error).
- While here, coding style
6 years ago
Chrysostomus adc8d7e624 Fix typo 6 years ago
Adriaan de Groot 3b152ba455 Merge branch 'fix-sudo-settings' into calamares 6 years ago
Adriaan de Groot 43e271dfec [users] Missing negation 6 years ago
Adriaan de Groot 8e53b83f9f [users] Test for setting / resetting sudo settings 6 years ago
Chrysostomus b7cc4860e0 Put the condition on a single line for prettiness sake 6 years ago
Chrysostomus 3731dfb146 Try not to create the keyfile if not necessary 6 years ago
Adriaan de Groot 6f41949bba [users] Log when sudo is skipped 6 years ago
Gaël PORTAY 6e9ce7194f [mount] Ignore unformatted filesystems only
Mount guesses the filesystem if it is unset or if it is set to auto,
thanks to blkid. That is the case for the bind mountpoints like /dev or
/run/udev in mount.conf. See `mount(8)` for more details.
6 years ago
Matti Hyttinen 73b5c62ab8
Update main.py
typo in a comment
6 years ago
Adriaan de Groot afb4e00f92 [keyboard] Pre-select pc105 6 years ago
Adriaan de Groot e5b7e66ee9 [locale] Filter zones combo always
The drop-down of zones was initially unfiltered, so you could start
in Europe/Amsterdam and the zones drop-down would also show Australian
zones; picking Perth would have weird effects, since Europe/Perth
doesn't exist and so you'd end up in New York instead.

- set the filtering region immediately, rather than only when the
  region changes.
6 years ago
Adriaan de Groot 83b2b95381 [libcalamares] Reduce object churn
- we don't need to allocate a new translator each time the language changes
6 years ago
Chrysostomus 741c1c5d1e Use constructor instead of a loop 6 years ago
Adriaan de Groot 59255c7a57 Changes: apply coding style 6 years ago
Adriaan de Groot be7b63051e Enable keyboard-model and layout-name translations.
SEE #1515
6 years ago
Chrysostomus 26b1c349d3 Set default value inside the relevant function 6 years ago
Adriaan de Groot c4de62cb9a Merge branch 'fix-keyboardq' into calamares
Various file writes were not being checked, and the code
was a bit tangled; specifically keyboardq did **not**
configure properly on KaOS and now seems ok.
6 years ago
Adriaan de Groot 83d2c06f68 [keyboard] Apply coding style 6 years ago
Adriaan de Groot 705e6dd8d6 [keyboard] Improve debug-logging for writing etc/default 6 years ago
Adriaan de Groot cbc376a206 [keyboard] Improve debug-logging for writing X11 config 6 years ago
Philip Müller 5191df2bde
Merge pull request #1568 from gportay/partition-fix-typo
[partition] Fix typo
6 years ago
Adriaan de Groot 57da222c72 [keyboard] Improve debug-logging for vconsole-config 6 years ago
Gaël PORTAY e2b00bc517 [partition] Fix typo 6 years ago
Gaël PORTAY e9e4be1c60 [umount] Fix list of mount-points to unmount
The root mount-point can end with a / while the mount-point read from
the file /etc/mtab does not end with a /.

This leads to skip the unmounting of the root mount-point and causes the
removal of the root mountpoint directory to fail with EBUSY because it
is still mounted.

This uses the python functions os.path.normpath() to normalize the root
mount-point (i.e. to drop the trailing /) and os.path.commonprefix() to
determine the longest common prefix between the two mount-points. If the
returned prefix is identical to the normalized root mount-point then the
mount-point must be added to the list of the mount-points to unmount.

More generally, the python modules should rely on the os.path functions
to compare for paths instead of using strings. It covers this way lots
of corner cases (path with "//", "/../", "/./", ...).
6 years ago
Adriaan de Groot 845fb3f6da [keyboard] Refactor writing-various-files
- put the writing of each kind of file in its own block -- this should
  become separate functions -- so that variables become more local
  and debugging can be improved.
- while here, fix the error message for /etc/default/keyboard:
  it would complain and name the vconsole file path if it ever failed.
6 years ago
Adriaan de Groot 3e51d77782 [keyboard] Check for successful file-write 6 years ago
Adriaan de Groot 2c297a068f [partition] Log when an EFI problem has been solved 6 years ago
Adriaan de Groot 0f38ee624e [partition] static-assert that our shortcut makes sense 6 years ago
Artem Grinev 94f7efb89f [users] Remove ' from transliterated string 6 years ago
Artem Grinev f20d0a7593 [users] Name cleanup after transliteration 6 years ago
Artem Grinev aa5ef7a6b8 [users] New transliterator ID 6 years ago
Adriaan de Groot 15ace5202d [partition] Simplify EFI-flags checking with KPMCore 4 6 years ago
Adriaan de Groot 85bb8c27b3 [partition] Simplify flags calculations
- factor out the flags-we-want from the flags-we-already-have
 - the use of ->activeFlags() meant that the state on *disk* was
   being compared with the flags-we-want; if a partition was re-edited,
   then you couldn't change the flags back to the state-on-disk
   (eg. enable a flag, then change your mind and disable it).
 - set the flags before refreshing the partition, because the
   refresh checks for EFI bootability and that needs the new flags,
   not the old ones.
6 years ago
Adriaan de Groot 949e33f1e8 [partition] Massage logging while checking for EFI boot 6 years ago
Adriaan de Groot 63964de4bd [partition] Explain underlying type for flags variant 6 years ago
Adriaan de Groot 87c77d9807 [partition] When flags are explicitly invalid, return early 6 years ago
Adriaan de Groot 356e13ae93 [partition] Improve logging readability 6 years ago
Chrysostomus fe291bc51a Write the crypttab entry still 6 years ago
Chrysostomus 9f52282e4c Don't use keyfile if there /boot is unencrypted 6 years ago
Chrysostomus 3eae98eac3 Don't enable grub password query if /boot is on unencrypted partition 6 years ago
Adriaan de Groot 72c9df67d2
Merge pull request #1565 from Chrysostomus/calamares
[initcpiocfg] Use graphical decryption prompt with plymouth
6 years ago
Adriaan de Groot f898840e16 [users] Expand schema to cover new possibilities 6 years ago
Chrysostomus 84558333bf Regular plymouth hook is also still needed 6 years ago
Chrysostomus 3bf57c7785 Use graphical decryption prompt with plymouth as adviced here: https://wiki.archlinux.org/index.php/plymouth#The_plymouth_hook 6 years ago
Adriaan de Groot 36f9fd56a3 [users] Expand the example config with new possibilities 6 years ago
Adriaan de Groot 7c268b2e4d [users] Correct terminology in configuration documentation 6 years ago
Adriaan de Groot 2516f18d1b
Merge pull request #1560 from gportay/partition-mount-make-mountPoint-and-filesystem-optionals
[partition,mount] Make mountPoint and filesystem optionals
6 years ago
Adriaan de Groot ffce79e30e [partition] Initialize the filesystem type, not the partition type
- Passing FileSystem::Type to the QString constructor for
  partition type is not what I intended.
6 years ago
Adriaan de Groot 73b5a0898d [partition] Migrate the defaultFS type
- remove the m_defaultFSType from PartitionLayout, because it is
  set on construction -- which is too early, before the configuration
  has been read.
- make the default FS explicit in the init() calls which pass in
  a configuration; this needs support in the intermediate
  PartitionCoreModule.
6 years ago
Adriaan de Groot 23eabd74c6 [partition] Set FS type explicitly if no layout is given
- the "simple" constructor for PartitionEntry left the FS type
  set as the constructor left it -- which is Unknown by default.
  This leads to install failures in systems that don't set a
  special layout but just want a single / -- because the FS is
  set to Unknown.
- massage the constructor and consumer of the code, push
  Ext4 FS in the tests and use the configured default in production.
6 years ago
Artem Grinev c85d1ae1fe Explanation why ICU is needed for usersq module 6 years ago
Adriaan de Groot f78752303b [partition] Improve constructors for layout
- initialize flags by default
- the copy constructor was just doing the default thing,
  so make that explicit
6 years ago
Gaël PORTAY 6013ed52f8 [partition] Ignore unformatted filesystem 6 years ago
Gaël PORTAY db08d2db8b [partition] Make filesystem optional and default to unformatted 6 years ago
Gaël PORTAY 163351a803 [mount] Ignore empty or unformatted filesystems 6 years ago
Gaël PORTAY c6feedf923 [mount] Ignore empty mountpoints 6 years ago
Gaël PORTAY 54fd1f4b26 [mount] Print a warning if mount failure
The return of the call to libcalamares.utils.mount is never tested and
it may fail silently; this causes some mounpoints to be missing.

This adds a warning if mountpoint cannot be mounted.

	chcon: failed to get security context of '/tmp/verity': Operation not supported
	06:44:23 [6]: static CalamaresUtils::ProcessResult CalamaresUtils::System::runCommand(CalamaresUtils::System::RunLocation, const QStringList&, const QString&, const QString&, std::chrono::seconds)
	    Running "env" ("mount", "-t", "unformatted", "/dev/sdb2", "/tmp/calamares-root-kv8dqgb5/tmp/verity")
	    ..  Finished. Exit code: 32
	    ..  Target cmd: ("mount", "-t", "unformatted", "/dev/sdb7", "/tmp/calamares-root-kv8dqgb5/tmp/verity") output:
	 mount: /tmp/calamares-root-kv8dqgb5/tmp/verity: unknown filesystem type 'unformatted'.
6 years ago
Gaël PORTAY 1f9f506a16 [partition] Make mountPoint optional
Some devices cannot be mounted (as DM_verity_hash), therefore, it is
nosense to set a mountPoint for them.
6 years ago
Adriaan de Groot 486cdaeeb6 [users] Shuffle library order to satisfy CI build 6 years ago
Adriaan de Groot 2bd3f1d8c1 Merge branch 'issue-1523' into calamares 6 years ago
Adriaan de Groot b61b5f8650 [users] Run an expected-to-fail test in creating groups 6 years ago
Adriaan de Groot 8127ae704c [users] Expand tests for groups a little 6 years ago
Adriaan de Groot e66f81f6ee CMake: comment on BUILD_AS_TEST 6 years ago
Adriaan de Groot 10991346b7
Merge pull request #1561 from gportay/partition-set-swap-partition-name
[partition] Allow a configurable swap Partition name
6 years ago
Adriaan de Groot 7578768c46
Merge pull request #1562 from gportay/partition-group-efi-things-together
[partition] Group EFI things together
6 years ago
Artem Grinev 4e54a2aefe [users] Cleaned error handling a bit 6 years ago
Artem Grinev 8e07bb00f9 [users] Construct icu::UnicodeString from QString's utf16 chars directly 6 years ago
Artem Grinev 48eae463cc [users] Full name transliteration support for user creation 6 years ago
Adriaan de Groot 0bad5469fc [libcalamares] Fix tests failures from JobQueue asserts
Some compile flags changed recently, triggering assert()
in the jobqueue when there is more than one. There's no
real reason for JobQueue to be a singleton, but it wants
to be. So clean up pointers a little more enthusiastically.
6 years ago
Adriaan de Groot 4746754344 [keyboard] Translate layouts as well 6 years ago
Adriaan de Groot 6863db0dc1 [keyboard] Use the translations if they were loaded 6 years ago
Adriaan de Groot f088efdf84 [keyboard] Re-jig translation extraction
- Use classes to prompt lupdate to extract with a better
  context (e.g. the class name, rather than plain "QObject")
  so that the translation-lookup can use the named context.
- Add hard-coded "default" variant
- Add totally bogus Tajik translations, for testing purposes
6 years ago
Adriaan de Groot 1a5fa36fb6 i18n: build keyboard translations
This is the Wrong Thing To Do, but we'll do it for now: build the
keyboard translations into the executable. In the medium term
they should move to the modules that use them, with the re-vamp
of how translation changes are signalled.
6 years ago
Adriaan de Groot 4a08fdbb92 [partition] Reduce warnings from KPMCore
- make KPMHelper.h an "everything include" and suppress warnings
  from it, then use it in the tests.
6 years ago
Adriaan de Groot d26fde6647 [partition] Reduce warnings
- Add a helper header that munges the warnings-settings so that
  KPMcore headers can be included.
6 years ago
Adriaan de Groot c41ff94f8a [locale] Reduce warnings (C++17)
Now that Calamares is compiled as C++17, we get this:

src/modules/locale/timezonewidget/TimeZoneImage.cpp:28:55: warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Wdeprecated]
/* static constexpr */ const QSize TimeZoneImageList::imageSize;
6 years ago
Adriaan de Groot 4d444cbfbb [partition] Reduce warnings (Clang, FreeBSD)
The code doesn't match the comment: there are no by-ref captures
in the code, and the shadowing of parameters and local variables
is confusing. Remove one variable that is passed in as an argument
(and just pass the value as argument) and copy-capture the other
rather than doing weird argument passing.
6 years ago
Adriaan de Groot 0a44ce381e [partition] Reduce warnings (Clang, FreeBSD)
- remove unused this captures from lambda
- rename variables that are short, cryptic, and shadowed
- remove documentation for parameters that don't exist
6 years ago
Gaël PORTAY 3967cfe0eb [partition] Group EFI things together 6 years ago
Gaël PORTAY a1d45122eb [partition] Update partition.conf 6 years ago
Gaël PORTAY dad9587c3e [partition] Allow a configurable swap Partition name
This commit adds the new configuration `swapPartitionName` to the file
partition.conf.

This option sets the partition name to the swap partition that is
created. If this option is unset, the partition is left unnamed.
6 years ago
Adriaan de Groot 4387b8061e [keyboard] Move responsibility for retranslation to Config
- only widgets get language change events, so we need to
  hook that up to the ViewSteps and inform the Config
  object so that it can (re)load translations for the
  keyboard data.
6 years ago
Adriaan de Groot 71e0081fce [keyboard] SPDX-tagging 6 years ago
Adriaan de Groot 7db398cfdf
Merge pull request #1558 from gportay/partition-cleanups
[partition] cleanups
6 years ago
Adriaan de Groot 89a180ee58 [keyboard] Initial support for translated keyboard names 6 years ago
Adriaan de Groot b72eba8157 [libcalamares] Extend the Deleter-helper with "preserve"
Sometimes you want to keep the thing around after all.
6 years ago
Adriaan de Groot 7659dfdb9d [libcalamares] Expose a translations-loading function 6 years ago
Gaël PORTAY f03ae06deb [partition] Rename execute to createPartitions 6 years ago
Gaël PORTAY f2bfe2bd6a [partition] Fix coding style 6 years ago
Gaël PORTAY cd725fbb4b Fix missing SPDX-FileCopyrightText in header 6 years ago
Gaël PORTAY 2007335865 [partition] Rename the KPMCore Partition local to part 6 years ago
Gaël PORTAY 32c1f81fbf [partition] Rename iterator in for loop to entry 6 years ago
Gaël PORTAY 3016b93c8f [partition] Simplify the method execute
- Rename the "size" locals using "sectors" in their name. Size may be
  confusing or not enough specific as it can be interpreted a size in
  Byte.
    partSizeMap -> partSectorsMap,
    totalSize -> totalSectors,
    availablesize -> availableSectors,
    size -> sectors,
    minSize -> minSectors
    maxSize -> maxSectors
- Create a the new local currentSector to iterate over the sectors;
  instead of using the parameter firstSector.
- Remove the variable end that does not help much; too many variable
  already. Expand its expression instead.
6 years ago
Gaël PORTAY 81bec68b3d [partition] Introduce new constructors for PartitionEntry
- Introduces new constructors for PartitionEntry: copy constructory and
  constructor with all attributes.
- Use the new constructor in method addEntry().
6 years ago
Gaël PORTAY 3f2dd516d3 [partition] Simplify the retrieval of the size attributes
- The variant helper toString() takes a default value since commit
  c9f942ad6 ([libcalamares] Add default value to variant helpers).
- Set the default value to 0 and simplify the retreival of size values
  by calling the helper toString() and removing the temporary variables.
6 years ago
Gaël PORTAY 03df5f6891 [libcalamares] Fix constness of functions 6 years ago
Gaël PORTAY aec066359a [libcalamares] Fix coding style 6 years ago
Gaël PORTAY db7cf74034 [partition] Remove the call the method contains
- The variant helper getString() calls contains() already.
6 years ago
Gaël PORTAY d6ea30b23e [partition] Move initLayout logic to object PartitionLayout
- The logic of the method initLayout belongs to the object
  PartitionLayout. Move logic to that object.
- Use a single method initLayout in object PartitionCoreModule.
- Member m_partLayout in object PartitionCoreModule is no longer
  allocated.
6 years ago
Gaël PORTAY eae1e90dce [partition] Remove unused PartitionLayout constructor
- The constructor PartitionLayout with PartitionEntry appears to be
  unused since its always. Drop it!
6 years ago
Gaël PORTAY f2960366c8 [partition] Remove unused addEntry method
- The method addEntry with PartitionEntry appears to be unused since its
  always. Drop it!
6 years ago
Adriaan de Groot ac6c9fae4a [libcalamares] Do not use moved-from object 6 years ago
Adriaan de Groot 2e9a44269c [keyboard] Extracted strings from keyboard list 6 years ago
Adriaan de Groot 5a378090c2 [keyboard] Do not munge keyboard model name
The translation happens whenever this code is run, which may
not match the language the user subsequently selects.
It also causes general problems with the translation,
since we end up with a possibly-partly-translated name.
6 years ago
Adriaan de Groot 7ec8c454bd [keyboard] Ukranian needs a switcher, too 6 years ago
Adriaan de Groot 8457a00ad0 [keyboard] Fix group-switcher multiplying
FIXES #1556
6 years ago
Adriaan de Groot daaf16d331 Merge branch 'calamares' into issue-1523 6 years ago
Adriaan de Groot cd9c0ea781 [keyboard] Reduce debugging output 6 years ago
Adriaan de Groot 2e5301c5c9 [keyboard] Simplify back down to lambdas
- With debugging and untangling done, the lambdas are simple
  and short, so return to using them. One point of improvement
  might be to give the models suitable slots themselves,
  to avoid even this indirection.
6 years ago
Adriaan de Groot 0bf28b0b94 [keyboard] Sanity in setCurrentIndex() parameters 6 years ago
Adriaan de Groot 9e141636c5 [keyboard] Tidy up the debugging output, add docs 6 years ago
Adriaan de Groot 14a76a386a [keyboard] Replace broken-ish variants model with k-v list
- Use the just-refactored XKBListModel to store the xkb key-value
  pairs for variants, drop most of the complicated implementation,
  store just a single list of values.
6 years ago
Adriaan de Groot d536173d66 [keyboard] Factor out a 2-column k-v list 6 years ago
Adriaan de Groot 5afe54132b [keyboard] Use the models from Config
- Remove code that is duplicated in Config.
- Hook up UI for physical keyboard model, and back.
- For now, introduce some named slots with debugging output.
  This makes debugging a lot easier since we have function names
  to work with rather than anonymous lambdas
6 years ago
Adriaan de Groot 168be02c96 [keyboard] Hook up the model-selection again 6 years ago
Adriaan de Groot 87aafb2442 [keyboard] Tear up connections between widgets and model 6 years ago
Adriaan de Groot 193efe1710 [keyboard] Restore the notion of PC105 default index 6 years ago
Adriaan de Groot 6aedf4401f [keyboard] Apply coding style 6 years ago
Adriaan de Groot 365a2ad6fd [keyboard] Re-do the keyboard physical models model from scratch 6 years ago
Adriaan de Groot a1c70b46a1 [keyboard] Typo in comment 6 years ago
Adriaan de Groot 5f1d7b2e8d [keyboard] Rename UI widgets to make code clearer 6 years ago
Adriaan de Groot d464e98e89 [keyboard] Move remaining variables to Config
- Config already *has* everythind, but drop the useless copies
  and duplicated code from the Page
- Plug the models model into the Page
- While here, document the model / layout / variant distinctions

The code doesn't fill the UI properly, and the drop-down
for the models combobox is not right, but at least the data
is shared.
6 years ago
Adriaan de Groot fe5757c7d1 [keyboard] Matching of layouts is very suspect 6 years ago
Adriaan de Groot 4f0d6a8f25 Merge branch 'calamares' into fix-keyboardq 6 years ago
Adriaan de Groot dca9ae0c93
Merge pull request #1553 from LordTermor/calamares
Initial additional layout support for non-ASCII layouts
6 years ago
Artem Grinev 4434e85d4d [keyboard] Simplified variable name 6 years ago
Artem Grinev 3552233bf1 [keyboard] Minor logic rework 6 years ago
Artem Grinev 6667ea834f [keyboard] Adjusted indents 6 years ago