e7ab0e9127
common/file_util: Remove unnecessary return at end of void StripTailDirSlashes()
...
While we're at it, also invert the conditional into a guard clause.
6 years ago
11e9bee91d
common/file_util: Make GetCurrentDir() return a std::optional
...
nullptr was being returned in the error case, which, at a glance may
seem perfectly OK... until you realize that std::string has the
invariant that it may not be constructed from a null pointer. This
means that if this error case was ever hit, then the application would
most likely crash from a thrown exception in std::string's constructor.
Instead, we can change the function to return an optional value,
indicating if a failure occurred.
6 years ago
943f6da1ac
common/file_util: Remove duplicated documentation comments
...
These are already present within the header, so they don't need to be
repeated in the cpp file.
6 years ago
2b1fcc8a14
common/file_util: Make ReadFileToString and WriteStringToFile consistent
...
Makes the parameter ordering consistent, and also makes the filename
parameter a std::string. A std::string would be constructed anyways with
the previous code, as IOFile's only constructor with a filepath is one
taking a std::string.
We can also make WriteStringToFile's string parameter utilize a
std::string_view for the string, making use of our previous changes to
IOFile.
6 years ago
e3b2539986
common/file_util: Remove unnecessary c_str() calls
...
The file stream open functions have supported std::string overloads
since C++11, so we don't need to use c_str() here. Same behavior, less
code.
6 years ago
8cd3d9be26
common/file_util: Make IOFile's WriteString take a std::string_view
...
We don't need to force the usage of a std::string here, and can instead
use a std::string_view, which allows writing out other forms of strings
(e.g. C-style strings) without any unnecessary heap allocations.
6 years ago
195b54602f
shader/decode/memory: Remove left in debug pragma
6 years ago
de23847184
renderer_opengl/gl_shader_decompiler: Remove redundant name specification in format string
...
This accidentally slipped through a rebase.
6 years ago
9ffc60b5b3
Merge pull request #2455 from lioncash/config
...
configuration/config: Move config loading and saving to functions based off groups
6 years ago
dbcff5d574
Merge pull request #2503 from lioncash/util
...
yuzu/game_list: Specify string conversions explicitly
6 years ago
9a17b20896
Merge pull request #2494 from lioncash/shader-text
...
gl_shader_decompiler: Add AddLine() overloads with single function that forwards to libfmt
6 years ago
bc32474901
yuzu/game_list: Specify string conversions explicitly
...
Allows the game list code to compile successfully with implicit string
conversions disabled.
6 years ago
ed2fedac13
yuzu/game_list_worker: Specify string conversions explicitly
...
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
6 years ago
7a82d6f394
yuzu/game_list_p: Amend mentions of SMDH in comments
...
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
6 years ago
486c3e6085
yuzu/game_list_p: Specify string conversions explicitly
...
Allows the game list item code to build with implicit string conversions
disabled.
6 years ago
922d8c6cb4
yuzu/loading_screen: Specify string conversions explicitly
...
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
6 years ago
fd34732e26
yuzu/bootmanager: Specify string conversions explicitly
...
Allows the bootmanager code to compile with implicit string conversions
disabled.
6 years ago
317f1263fb
yuzu/util: Specify string conversions explicitly
...
Allows the util code to build with implicit string conversions disabled.
6 years ago
58a0c13e34
gl_shader_decompiler: Tidy up minor remaining cases of unnecessary std::string concatenation
6 years ago
6fb29764d6
gl_shader_decompiler: Replace individual overloads with the fmt-based one
...
Gets rid of the need to special-case brace handling depending on the
overload used, and makes it consistent across the board with how fmt
handles them.
Strings with compile-time deducible strings are directly forwarded to
std::string's constructor, so we don't need to worry about the
performance difference here, as it'll be identical.
6 years ago
784d2b6c3d
gl_shader_decompiler: Utilize fmt overload of AddLine() where applicable
6 years ago
0adb54abc1
Merge pull request #2499 from lioncash/translate
...
yuzu/configuration: Specify string conversions explicitly
6 years ago
73ee85e9ae
Merge pull request #2500 from FernandoS27/revert-2466
...
Revert #2466
6 years ago
911fafb967
Revert #2466
...
This reverts a tested behavior on delay slots not exiting if the exit
flag is set. Currently new tests are required in order to ensure this
behavior.
6 years ago
91ec251c4a
gl_shader_decompiler: Add AddLine() overload that forwards to fmt
...
In a lot of places throughout the decompiler, string concatenation via
operator+ is used quite heavily. This is usually fine, when not heavily
used, but when used extensively, can be a problem. operator+ creates an
entirely new heap allocated temporary string and given we perform
expressions like:
std::string thing = a + b + c + d;
this ends up with a lot of unnecessary temporary strings being created
and discarded, which kind of thrashes the heap more than we need to.
Given we utilize fmt in some AddLine calls, we can make this a part of
the ShaderWriter's API. We can make an overload that simply acts as a
passthrough to fmt.
This way, whenever things need to be appended to a string, the operation
can be done via a single string formatting operation instead of
discarding numerous temporary strings. This also has the benefit of
making the strings themselves look nicer and makes it easier to spot
errors in them.
6 years ago
d49efbfb4a
Merge pull request #2441 from ReinUsesLisp/al2p
...
shader: Implement AL2P and ALD.PHYS
6 years ago
13dda1d8ed
Merge pull request #2410 from lioncash/affinity
...
kernel/svc: Reorganize and fix up the initial handling of svcSetThreadCoreMask()
6 years ago
2318c394a8
yuzu/configuration/configure_web: Specify string conversions explicitly
...
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
6 years ago
d9c4d64ed5
yuzu/configuration/configure_system: Specify string conversions explicitly
...
Allows the system config code to build successfully with implicit string
conversions disabled.
6 years ago
428d8098a7
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
...
This is a user-facing string, so it should be marked as translatable.
6 years ago
17255cd835
yuzu/configuration/configure_per_general: Specify string conversions explicitly
...
Allows the per-game configuration to be successfully built with implicit
string conversions disabled.
6 years ago
3039211c20
yuzu/configuration/configure_mouse_advanced: Clean up array accesses
...
Deduplicates array accesses and uses a named variable where appropriate.
6 years ago
c9c4208c4a
yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitly
...
Allows the advanced mouse configuration code to build with implicit
string conversions disabled.
6 years ago
aa83639b78
yuzu/configuration/configure_input_player: Clean up array accesses
...
Rather than repeatedly index arrays that have quite a large array index,
we can just use a named variable instead.
6 years ago
4d2da5a40a
yuzu/configuration/configure_input_player: Specify string conversions explicitly
...
Allows the player input configuration code to compile with implicit
string conversions disabled.
6 years ago
b94b08fa6f
Merge pull request #2491 from FernandoS27/dma-fix
...
Dma_pusher: ASSERT on empty command_list
6 years ago
d81d4a0f68
yuzu/configuration/configure_input: Mark controller type names as translateable
...
These are user-facing strings, so they should be localizable.
6 years ago
7e650088dd
yuzu/configuration/configure_general: Specify string conversions explicitly
...
Allows the general configuration code to successfully compile with
implicit string conversions disabled.
6 years ago
05235ccaa9
yuzu/configuration/configure_gamelist: Specify string conversions explicitly
...
Allows the gamelist configuration code to compile with implicit string
conversions disabled.
6 years ago
5f01ec338e
yuzu/configuration/configure_audio: Store power on query into a variable
...
Avoids using the system accessor more than necessary, and ensures that
both dialog boxes see the same power on state.
6 years ago
d00ca5c6c8
yuzu/configuration/configure_audio: Tidy up function cast
...
We can just use qOverload here to tidy up the function cast.
6 years ago
d184224e8f
yuzu/configuration/configure_audio: Specify string conversions explicitly
...
Allows the audio configuration code to build with implicit string
conversions disabled.
6 years ago
f8b1e53369
Merge pull request #2452 from FernandoS27/raster-cache-fix
...
Correct possible error on Rasterizer Caches
6 years ago
2aebbe9bf9
Merge pull request #2497 from lioncash/shader-ir
...
shader/shader_ir: Minor changes
6 years ago
fadf66993c
Merge pull request #2495 from lioncash/cache
...
gl_shader_disk_cache: Minor cleanup
6 years ago
9e98100c94
Dma_pusher: ASSERT on empty command_list
...
This is a measure to avoid crashes on command list reading as an empty
command_list is considered a NOP.
6 years ago
6fd247c84a
Merge pull request #2439 from lioncash/audren
...
service/audren_u: Get rid of magic values within GetAudioRendererWorkBufferSize
6 years ago
18cdbdafa2
Merge pull request #2467 from lioncash/move
...
video_core/gpu_thread: Remove redundant copy constructor for CommandDataContainer
6 years ago
594328f494
Merge pull request #2463 from lioncash/set
...
service/set: Correct and simplify behavior related to copying language codes
6 years ago
9175bffbdb
Merge pull request #2466 from yuzu-emu/mme-exit-delay-slot
...
GPU/MMEInterpreter: Ignore the 'exit' flag when it's executed inside a delay slot.
6 years ago
Lioncash
bunnei
Hexagon12
Fernando Sahmkow