configure_hotkeys: Remove unused EmitHotkeysChanged()

1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
pull/8/head
Lioncash 6 years ago
parent 5d645c6dd9
commit c03fb00ac1

@ -25,9 +25,6 @@ ConfigureDialog::ConfigureDialog(QWidget* parent, HotkeyRegistry& registry)
adjustSize(); adjustSize();
ui->selectorList->setCurrentRow(0); ui->selectorList->setCurrentRow(0);
// Synchronise lists upon initialisation
ui->hotkeysTab->EmitHotkeysChanged();
} }
ConfigureDialog::~ConfigureDialog() = default; ConfigureDialog::~ConfigureDialog() = default;

@ -31,10 +31,6 @@ ConfigureHotkeys::ConfigureHotkeys(QWidget* parent)
ConfigureHotkeys::~ConfigureHotkeys() = default; ConfigureHotkeys::~ConfigureHotkeys() = default;
void ConfigureHotkeys::EmitHotkeysChanged() {
emit HotkeysChanged(GetUsedKeyList());
}
QList<QKeySequence> ConfigureHotkeys::GetUsedKeyList() const { QList<QKeySequence> ConfigureHotkeys::GetUsedKeyList() const {
QList<QKeySequence> list; QList<QKeySequence> list;
for (int r = 0; r < model->rowCount(); r++) { for (int r = 0; r < model->rowCount(); r++) {
@ -87,7 +83,6 @@ void ConfigureHotkeys::Configure(QModelIndex index) {
tr("You're using a key that's already bound.")); tr("You're using a key that's already bound."));
} else { } else {
model->setData(index, key_sequence.toString(QKeySequence::NativeText)); model->setData(index, key_sequence.toString(QKeySequence::NativeText));
EmitHotkeysChanged();
} }
} }

@ -24,8 +24,6 @@ public:
void applyConfiguration(HotkeyRegistry& registry); void applyConfiguration(HotkeyRegistry& registry);
void retranslateUi(); void retranslateUi();
void EmitHotkeysChanged();
/** /**
* Populates the hotkey list widget using data from the provided registry. * Populates the hotkey list widget using data from the provided registry.
* Called everytime the Configure dialog is opened. * Called everytime the Configure dialog is opened.
@ -33,9 +31,6 @@ public:
*/ */
void Populate(const HotkeyRegistry& registry); void Populate(const HotkeyRegistry& registry);
signals:
void HotkeysChanged(QList<QKeySequence> new_key_list);
private: private:
void Configure(QModelIndex index); void Configure(QModelIndex index);
bool IsUsedKey(QKeySequence key_sequence) const; bool IsUsedKey(QKeySequence key_sequence) const;

Loading…
Cancel
Save