Renamed CheckIfOperationChanged to OnDockedModeChanged

src/yuzu/configuration/configure_general.cpp

@@ -41,25 +41,27 @@ void ConfigureGeneral::PopulateHotkeyList(const HotkeyRegistry& registry) {
     ui->widget->Populate(registry);
 }
 
-void ConfigureGeneral::CheckIfOperationChanged(bool last_state, bool new_state) {
+void ConfigureGeneral::OnDockedModeChanged(bool last_state, bool new_state) {
-    if (last_state != new_state) {
+    if (last_state == new_state) {
-        Core::System& system{Core::System::GetInstance()};
+        return;
-        Service::SM::ServiceManager& sm = system.ServiceManager();
+    }
-
+
-        // Message queue is shared between these services, we just need to signal an operation
+    Core::System& system{Core::System::GetInstance()};
-        // change to one and it will handle both automatically
+    Service::SM::ServiceManager& sm = system.ServiceManager();
-        auto applet_oe = sm.GetService<Service::AM::AppletOE>("appletOE");
+
-        auto applet_ae = sm.GetService<Service::AM::AppletAE>("appletAE");
+    // Message queue is shared between these services, we just need to signal an operation
-        bool has_signalled = false;
+    // change to one and it will handle both automatically
-
+    auto applet_oe = sm.GetService<Service::AM::AppletOE>("appletOE");
-        if (applet_oe != nullptr) {
+    auto applet_ae = sm.GetService<Service::AM::AppletAE>("appletAE");
-            applet_oe->GetMessageQueue()->OperationModeChanged();
+    bool has_signalled = false;
-            has_signalled = true;
+
-        }
+    if (applet_oe != nullptr) {
-
+        applet_oe->GetMessageQueue()->OperationModeChanged();
-        if (applet_ae != nullptr && !has_signalled) {
+        has_signalled = true;
-            applet_ae->GetMessageQueue()->OperationModeChanged();
+    }
-        }
+
+    if (applet_ae != nullptr && !has_signalled) {
+        applet_ae->GetMessageQueue()->OperationModeChanged();
     }
 }
 
@@ -72,7 +74,7 @@ void ConfigureGeneral::applyConfiguration() {
     Settings::values.use_cpu_jit = ui->use_cpu_jit->isChecked();
     const bool pre_docked_mode = Settings::values.use_docked_mode;
     Settings::values.use_docked_mode = ui->use_docked_mode->isChecked();
-    CheckIfOperationChanged(pre_docked_mode, Settings::values.use_docked_mode);
+    OnDockedModeChanged(pre_docked_mode, Settings::values.use_docked_mode);
 
     Settings::values.enable_nfc = ui->enable_nfc->isChecked();
 }

src/yuzu/configuration/configure_general.h

@@ -25,7 +25,7 @@ public:
 
 private:
     void setConfiguration();
-    void CheckIfOperationChanged(bool last_state, bool new_state);
+    void OnDockedModeChanged(bool last_state, bool new_state);
 
     std::unique_ptr<Ui::ConfigureGeneral> ui;
 };