jason taylor
f2c7998903
doc: add clarity around HOME_NET/EXTERNAL_NET
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
76cca8b08a
doc: minor example rule description update
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
4f61a35fe7
doc: minor wording restructure
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
845ba154a6
doc: add tcp-pkt/tcp-stream to intro
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
56f49bfe8e
doc: minor punctuation update
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
ab300ab0ae
doc: intro example rule update to simpler example
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
jason taylor
2f240230f0
doc: minor intro wording update
...
Signed-off-by: jason taylor <jtfas90@gmail.com>
3 years ago
Philippe Antoine
c57052181c
snmp: rustfmt detect.rs
3 years ago
Philippe Antoine
c7214be99b
snmp: adds usm keyword
...
as is logged
Ticker: #5416
3 years ago
Victor Julien
4adab8f271
github/codeowners: update
3 years ago
Philippe Antoine
5a31b3508d
ftp: optimized tx iterator
...
To be more efficient with larger number of transactions.
Ticket: #5314
3 years ago
Victor Julien
6d3140bc01
mime: remove unused length fields
3 years ago
Victor Julien
816bbeb7dc
fuzz/mime: fix call conditions and args
...
The SMTP parser should not supply lines w/o EOL chars to the mime
parser unless its in the BODY parsing stage. Mimic this in the fuzz
target by testing the state for inputs that have no EOL.
Additionally, make sure the delim cnt reflects the missing EOL.
3 years ago
Victor Julien
d81582c4a2
mime: fix corner case
...
Fix a corner case where a base64 sequence including a space was followed
by a newline in the input data.
3 years ago
Victor Julien
5805ed47f5
mime: add base64 related debug messages
3 years ago
Victor Julien
41c2c1ed5a
mime: improved empty line handling
...
Make sure a new body is not set up on empty lines unless it is
a body that is not encoded as base64/quoted printable.
3 years ago
Victor Julien
074cfb5c68
mime: fix and cleanup tests
...
Line count check was failing after recent delim handling updates.
3 years ago
Victor Julien
6e2c066ce1
smtp: fix passing a wrong delim len around
3 years ago
Victor Julien
b82b8825e7
mime: properly pass full lines to non-decoded body
...
Use actual delim count and make sure we also pass on empty lines
(so delim(s) only).
3 years ago
Victor Julien
0d6ab727c5
mime/base64: fix final data not getting processed
...
If the last data of the body was not a multple of 4 and not padded
to be a multiple of 4, it would not be processed.
3 years ago
Victor Julien
100d821a9f
stream: fix GAP check
...
Gap check would consider a GAP when the current data was in fact
exactly not a gap, but next segment(s) were already available.
3 years ago
Victor Julien
29ec1b1e7b
mime: minor code cleanup
3 years ago
Victor Julien
0871029d17
mime: remove unused 'linerem' logic
3 years ago
Victor Julien
5953a7d2eb
smtp/mime: fix parsing edge case
...
Correctly track "remaining" bytes after partial base64 decoding.
Add comment clarifications and debug validation checks.
3 years ago
Victor Julien
a38f2f2a52
smtp: skip preprocessing for mime headers
...
Mime parser doesn't expect partial lines, which preprocessing can
provide. Add a check to let mime headers be handled by regular line
parsing.
3 years ago
Victor Julien
929faae6d4
eve/schema: add drop.udplen, email fields
3 years ago
Juliana Fajardini
2544be4672
source/pcap: fix infinite loop if interface goes down
...
When in live-pcap mode, if the sniffed interface went down and up again,
Suri would enter an infinite and keep running, while not registering new
events. This fixes that behavior by allowing Suri to retry to open the
pcap in case of a retry on an already activated capture
('PCAP_ERROR_ACTIVATED').
This change is based on Zhiyuan Liao's work.
Bug #3846
3 years ago
dependabot[bot]
dc6fff2cca
github-actions: bump ossf/scorecard-action from 1.1.1 to 1.1.2
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](3e15ea8318...ce330fde6b
)
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
Philippe Antoine
585e5e0d3c
detect: impose limits on pcrexform
...
As is done for pcre keyword
Ticket: #5409
3 years ago
Juliana Fajardini
45b7aad2b5
devguide: incorporate contribution process page
...
That page existed only in our redmine. Updated and added a few things,
like a paragraph about our expectations for feature contributors.
Also updated links, contacts and some other processes that may have
changed since last edition.
Added some section labels in related documents, for ease of referencing.
Task #4929
3 years ago
Victor Julien
a89840929b
detect: set drop reason for rule based drops
...
Call `PacketDrop` with drop reason for drops, keep old logic
in place for the rest.
3 years ago
Victor Julien
ad14e71efe
stream: suppress exception policy debug message
3 years ago
Victor Julien
046287c2b5
detect/filestore: clean up stream flag handling
3 years ago
Victor Julien
7ced8de6c4
github/workflows: add cargo for all Ubuntu jobs
3 years ago
Victor Julien
3617be326c
eve/schema: add pcap_filename field
3 years ago
Victor Julien
71ef62bfc5
file: consistently track size of gaps
...
Until now only the size of gaps counted in the regular append, not
close and open.
Bug: #5392 .
3 years ago
Victor Julien
fc566037b4
eve/schema: add new flow fields
3 years ago
Victor Julien
1594e41b06
stream: remove unused TCP_LISTEN
...
Keep the values the same so we might be able to bring it back
w/o issues.
3 years ago
Victor Julien
e05b6f44e3
counter: tcp liberal counter
3 years ago
Victor Julien
0ebe372607
stream: after missing segments, be liberal on RST
...
This avoids long lasting inactive flows because in the most likely
case the RST did in fact end the connection. However Suricata may
still consider it to be "established".
3 years ago
Victor Julien
b0993d6fd8
flow: add various flow counters
...
Add flow.end state counters
Add active TCP sessions counter
Add flow.active counter
Add flow.total counter
Ticket: #1478 .
3 years ago
Victor Julien
aa31d2193f
counters: add StatsDecr
3 years ago
Victor Julien
88edc8630c
flow/manager: add flow.mgr.rows_sec counter
3 years ago
Victor Julien
f271fb4575
flow/recycler: bring back pthread_cond_t sleep
...
Bug #4379 .
3 years ago
Victor Julien
633e6cf09e
flow/recycler: minor code cleanups
3 years ago
Victor Julien
73138809e2
flow/manager: move counters into util func
3 years ago
Victor Julien
0c048d3e5c
flow/manager: minor code cleanups
3 years ago
Victor Julien
7f4e120a97
flow/manager: remove debug and dead code
3 years ago
Victor Julien
e6ac2e4e8a
flow/manager: sleep handled by pthread_cond_t again
...
Use only in live mode to allow FM to respond quickly to time
increases in offline mode.
Bug #4379 .
3 years ago
Victor Julien
39141a8836
time: add timeradd implementation
...
timeradd isn't available on MinGW.
3 years ago