12281 Commits (e1035fd3aed7e546f3ef18fceba8ae7f1441cd24)

 

All Branches   

Search

Author	SHA1	Message	Date
Philippe Antoine	3e81d20a71	ci: rebase specified s-v pr ... So that CI does not fail, if suricata PR got upgraded in a new version, but S-V PR did not get upgraded, and S-V changed in master	4 years ago
Philippe Antoine	44bd3169eb	dnp3: regenerate object decoding code ... Ticket: #4558 So as to avoid intra-structure overflow	4 years ago
Philippe Antoine	126a7dcb4f	dnp3: adds bounds check for prefix chararray ... Ticket: #4558 Avoids intra structure overflow	4 years ago
Philippe Antoine	5ec9688f03	dnp3: use base64 macro in gen script ... As is done already in C cf commit ea0936199d	4 years ago
Victor Julien	9551cd0535	threading: don't pass locked flow between threads ... Previously the flow manager would share evicted flows with the workers while keeping the flows mutex locked. This reduced the number of unlock/ lock cycles while there was guaranteed to be no contention. This turns out to be undefined behavior. A lock is supposed to be locked and unlocked from the same thread. It appears that FreeBSD is stricter on this than Linux. This patch addresses the issue by unlocking before handing a flow off to another thread, and locking again from the new thread. Issue was reported and largely analyzed by Bill Meeks. Bug: #4478	4 years ago
Jason Ish	cf21694ba6	rust(lint): suppress clippy lints that we should fix ... Suppress all remaining clippy lints that we trip. This can be fixed on a per-lint basis.	4 years ago
Jason Ish	91402f9fba	rust(lint): remove manual implement of map method ... Using `if let` expressions in these cases is better expressed by the map method, and considered idiomatic Rust for this usage.	4 years ago
Jason Ish	b021726a0d	rust(lint): map the error instead of using or_else ... This is the preffered style and easier to understand the meaning of the code.	4 years ago
Jason Ish	dcf57ecd96	rust(lint): replace push_str of single char to push(<char>)	4 years ago
Jason Ish	d5c0962299	rust(lint): fix some usages of references ... - ref is discouraged for top level variables - the other borrow is not required	4 years ago
Jason Ish	d0772e04b1	rust(lint): replace checked_mul with saturating_mul ... When defaulting checked_mul to u64::max, Rust has a method that does the same thing called saturating_mul.	4 years ago
Jason Ish	d0be7541e9	rust(lint): removed unused unit () return ... This is code that is not needed and is a bit confusing to see.	4 years ago
Jason Ish	4abbfd0d97	rust(lint): remove extra parens around bitwise or ... This is a readability fix, as on first look they almost look like a Rust tuple.	4 years ago
Jason Ish	ac3a20b6e0	rust(lint): remove useless conversions and clones ... These add complexity and may not be optimized out by the compiler.	4 years ago
Jason Ish	8bb6dab69d	rust(lint): remove useless format calls ... In these simple cases to_string() is recommended and likely performs better as the formatter is not called.	4 years ago
Jason Ish	5bf5de3350	rust(lint): don't use unwrap_or for function calls ... Calling a function in unwrap_or causes that function to always be called even when not needed. Instead use unwrap_or_else with a closure which will only be called when needed.	4 years ago
Jason Ish	602bb05e75	rust(lint): fix redundant closures ... This lint checks for a closure where a function can be directly supplied. Runtime performance is unchanged, but this makes less work for the compiler.	4 years ago
Jason Ish	69cf5c9eea	rust(lint): remove needless borrows ... These are needless borrows (references) as the item is already a reference.	4 years ago
Jason Ish	363b5f99c3	rust: functions that reference raw pointers are unsafe ... Based on the Rust clippy lint that recommends that any public function that dereferences a raw pointer, mark all FFI functions that reference raw pointers with build_slice and cast_pointer as unsafe. This commits starts by removing the unsafe wrapper inside the build_slice and cast_pointer macros then marks all functions that use these macros as unsafe. Then fix all not_unsafe_ptr_arg_deref warnings from clippy. Fixes clippy lint: https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref	4 years ago
Jason Ish	53413f2d7a	rust: remove all usage of transmute ... All cases of our transmute can be replaced with more idiomatic solutions and do no require the power of transmute. When returning an object to C for life-time management, use Box::into_raw to convert the boxed object to pointer and use Box::from_raw to convert back. For cases where we're just returning a pointer to Rust managed data, use a cast.	4 years ago
KevinWang	cbd03c7ea4	output/redis: Fix possible segv	4 years ago
Philippe Antoine	7ca4b13568	qa: use time on fuzz targets being run on corpus	4 years ago
Juliana Fajardini	ff976df704	stream-tcp-reassemble: fix typo, updt copyright yr	4 years ago
Juliana Fajardini	613f9b2f5a	stream-tcp-reassemble: fix ConfGetBool unc'kd call	4 years ago
Juliana Fajardini	2e0d76e6e7	stream-tcp: fix typos, update copyright year	4 years ago
Juliana Fajardini	4839088359	stream-tcp: fix ConfGetBool unchecked call	4 years ago
Juliana Fajardini	7198355324	util-napatech: fix typos, update copyright year	4 years ago
Juliana Fajardini	fbade25848	util-napatech: fix ConfGetBool unchecked call	4 years ago
Juliana Fajardini	09ea412614	util-debug: fix unchecked ConfGetBool call	4 years ago
Victor Julien	9d24a53c53	nfs: minor code cleanup	4 years ago
Victor Julien	aa9d8658ef	smb: minor formatting fixup	4 years ago
Victor Julien	094208823b	smb: minor code cleanup	4 years ago
Shivani Bhardwaj	8fd47cb84c	smtp: fix clang fmt	4 years ago
Shivani Bhardwaj	0a1747c1ba	nfs: fix comment	4 years ago
Shivani Bhardwaj	58ac9b0f38	nfs: Add rust registration function ... Get rid of the C glue code and move registration completely to Rust.	4 years ago
Shivani Bhardwaj	61fca4e9db	nfs: add missing code from rust impl of fns	4 years ago
Shivani Bhardwaj	de50ac631e	nfs: Change fn sign as per rust registration requirement ... Registering parsers in Rust requires signatures to be a certain way and compatible with C. Change signatures of all the functions. Probe fn has also been changed to return AppProto as required by the new fn signature.	4 years ago
Shivani Bhardwaj	e5c948df87	smb: Add rust registration function ... Get rid of the C glue code and move registration completely to Rust.	4 years ago
Shivani Bhardwaj	27af4bb002	smb: add missing code from rust impl of fns	4 years ago
Shivani Bhardwaj	6420df84b7	smb: Change fn sign as per rust registration requirement ... Registering parsers in Rust requires signatures to be a certain way and compatible with C. Change signatures of all the functions.	4 years ago
Shivani Bhardwaj	4d6b6b5dfe	smb: add constants	4 years ago
Shivani Bhardwaj	d1ea00521b	rust/core: Add flow flags	4 years ago
Jason Ish	222e55847c	flow: provide flags accessor function ... Add an accessor function for flow flags. To be used by Rust where the flow struct is an opaque data type.	4 years ago
Shivani Bhardwaj	cb8bd8c669	rust/applayer: add more externs	4 years ago
Victor Julien	843c4b20da	stream: check if ACK packet is outdated ... Outdated packets are ACK packets w/o data that have an ACK value lower than our last_ack and also don't have an SACK records that are new. This can happen when some packets come in later than others (possibly due to different paths taken).	4 years ago
Victor Julien	b7a79978ac	stream/sack: clean up includes	4 years ago
Victor Julien	8eccd02c94	stream/sack: minor debug improvements	4 years ago
Victor Julien	35c2a02eb8	stream: minor debug additions	4 years ago
Shivani Bhardwaj	51be8f0238	doc/dcerpc: add proto keywords	4 years ago
Sascha Steinbiss	9aedc7fd1a	mqtt: enable in config and remove misleading comment	4 years ago