Victor Julien
ab65b6f83b
netmap: fix coverity warning 1362789
...
** CID 1362789: Null pointer dereferences (FORWARD_NULL)
/src/runmode-netmap.c: 247 in ParseNetmapConfig()
________________________________________________________________________________________________________
*** CID 1362789: Null pointer dereferences (FORWARD_NULL)
/src/runmode-netmap.c: 247 in ParseNetmapConfig()
241 strlcpy(aconf->iface_name, iface_name, sizeof(aconf->iface_name));
242 SC_ATOMIC_INIT(aconf->ref);
243 (void) SC_ATOMIC_ADD(aconf->ref, 1);
244
245 /* Find initial node */
246 netmap_node = ConfGetNode("netmap");
>>> CID 1362789: Null pointer dereferences (FORWARD_NULL)
>>> Comparing "netmap_node" to null implies that "netmap_node" might be null.
247 if (netmap_node == NULL) {
248 SCLogInfo("Unable to find netmap config using default value");
249 } else {
250 if_root = ConfFindDeviceConfig(netmap_node, aconf->iface_name);
251 if_default = ConfFindDeviceConfig(netmap_node, "default");
252 }
10 years ago
Andreas Herz
e9a2a341ce
util-threshold-config: parse suppress rules with spaces in ip list
...
This modified regex allows spaces witihn the ip list for supress rules
like [10.0.0.1, 10.0.0.2]
10 years ago
Jason Ish
f0e22c91cb
privs: add capability CAP_SYS_NICE.
...
Allows the setting of thread priorities after dropping privileges.
10 years ago
Victor Julien
6045420812
detect: reduce verbosity, don't warn on empty files
10 years ago
Victor Julien
46ac5ed7b7
pfring: move output to 'Perf' level
10 years ago
Victor Julien
18de4c9654
offloading: work around missing TOE support
10 years ago
Victor Julien
9b80c21d78
offloading: distinguish between csum and the rest
...
As AF_PACKET handles csum offloading don't check for this type of
offloading. Other methods like pcap and netmap do require it to be
turned off.
Improve disable command suggestion wording.
10 years ago
Victor Julien
03d46f1369
offloading: reduce verbosity
10 years ago
Victor Julien
507027845d
afpacket: update offloading warning
10 years ago
Victor Julien
45fa25eb0c
offloading: improve checks on FreeBSD
...
Move FreeBSD specific (but not netmap specific) checks from the netmap
code to the general ioctl wrapper code.
Warn from the check functions now, so callers no longer need to.
10 years ago
Victor Julien
33f8769001
offloading: move linux specific into their own func
10 years ago
Victor Julien
54bc471810
offloading: check for more offloading on Linux
10 years ago
Victor Julien
b1d191b478
netmap: fix enabling promisc mode on FreeBSD
...
In FreeBSD setting the IFF_PROMISC flag has no effect. Instead we
need to set the IFF_PPROMISC flag.
10 years ago
Victor Julien
6c7bf006b7
netmap: redo config parsing
...
Normally we parse the config per interface only. But to properly
setup the bridge, netmap also needs the config of it's peering
interface. Instead of using a complicated peering scheme like in
afpacket, simply parse the peers config too.
10 years ago
Victor Julien
0e9134930d
changelog: update for 3.1 and add missing 3.1rc1 tickets
10 years ago
Andreas Herz
d0baa83d2b
util-runmode: pass initdata to runmode workers for nfqueue
...
The VerdictNFQ was missing the initdata which results in a segfault
within CaptureStatsSetup. This commit adds the passing of the initdata.
10 years ago
Victor Julien
f7124b1149
afpacket: disable tpacket-v3 by default
...
It's still considered experimental at this point.
10 years ago
Victor Julien
66346e4632
libnet: work around older libnet type difference
...
Older libnet 1.1.x have a non-const type for libnet_init's dev
argument.
10 years ago
Victor Julien
9119007d00
pfring: no longer link against rt and numa libs
10 years ago
Victor Julien
a88359dcf0
detect: get proper legacy custom values. Issue #1804
10 years ago
Victor Julien
5c974f92a8
livedev: shorten devname at registration
10 years ago
Victor Julien
b673e14411
afl: fix various --afl-* options
10 years ago
Victor Julien
d4f8445564
Update Changelog for 3.1RC1
10 years ago
Victor Julien
e76b334f8d
http body: fix compression tests
10 years ago
Victor Julien
5ec885e451
http: set of response body decompress limit
...
This is a per personality setting.
10 years ago
Victor Julien
ed7dc0c6b3
unittest: minor cleanup
10 years ago
Victor Julien
b313f8ca7b
http: update compression mismatch test
10 years ago
Victor Julien
439b62fe69
configure: cleanup configure output
...
Don't present missing spatch as a warning. Remove verbose libnet
warnings as well.
10 years ago
Andreas Herz
36e4126227
detect-filemagic: fix heap-use-after-free
...
This fixes the heap-use-after-free issue with sm being freed without
being removed from the signature (s) list. Move the protocol check for
rules with filemagic before the alloc and make the error log more
precise.
10 years ago
Victor Julien
a309598721
netmap: work around mtu error on iface+ settings
10 years ago
Victor Julien
648a69759b
netmap: don't set more than 1 thread on sw ring
10 years ago
Victor Julien
86d44cea96
netmap: code cleanup
10 years ago
Victor Julien
ffba26d04a
configure: don't set -march=native for powerpc
10 years ago
Victor Julien
0b6171854d
yaml: improve affinity defaults
10 years ago
Victor Julien
b5633b9bfd
affinity: small cleanups to output & code
10 years ago
Victor Julien
5f9de1e734
affinity: rename detect -> worker set internall
10 years ago
Victor Julien
723e90a174
affinity: rename detect-cpu-set to worker-cpu-set
...
Add fallback for existing configs.
10 years ago
Victor Julien
45b72d61c9
affinity: improve suricata.yaml doc
10 years ago
Victor Julien
570b9d06e0
affinity: remove unused settings
...
These were never referenced to in the code so they can be removed.
Add bypass to config parser in case the settings are still in old
yamls.
10 years ago
Victor Julien
bdc2c6e9ce
affinity: type cleanup
10 years ago
Victor Julien
2aac437927
output: reduce verbosity on info level
10 years ago
Victor Julien
4c663bb143
netmap: don't check for offloading twice
10 years ago
Victor Julien
2beb39469b
netmap: output cleanup
10 years ago
Victor Julien
b3bf7a5729
output: introduce config and perf output levels
...
Goal is to reduce info output
10 years ago
Victor Julien
cc2ed783c5
output: improve notice and warning/error color handling
10 years ago
Victor Julien
1c0f20f0e5
yaml: profiling 'json' depend on jansson availability
10 years ago
Victor Julien
e11753e3f2
profiling: fix minor compiler warning
10 years ago
Victor Julien
4369161b92
netmap: get offloading settings and warn if needed
...
Add FreeBSD lookup function and use the existing code on Linux.
10 years ago
Victor Julien
a8a918545b
netmap: get correct RSS queues on Linux as well
10 years ago
Victor Julien
d861bf100b
netmap: reduce verbosity at startup
10 years ago