9976 Commits (51ab06256a50f8e7143cc7bfd4807a59ac66dfaa)

 

All Branches   

Search

Author	SHA1	Message	Date
Eric Leblond	51ab06256a	bypass: account callback method in stats	6 years ago
Eric Leblond	f78e5ba1e1	bypass: restore interface counter	6 years ago
Eric Leblond	d119845d98	bypass: compress flow keys structure	6 years ago
Eric Leblond	69d2c8eb75	ebpf: get rid of hash in map value	6 years ago
Eric Leblond	b07bda7a7b	bypass: new callback stragegy ... This patch introduces and uses a new bypass strategy based on a callback. EBPF bypass implementation is updated to use this new strategy. Once the flow manager detect that a flow should be timeouted, it asks the capture method if it has seen packets in the interval. If it is the case the lastts of the flow is updated and the timeout is postponed.	6 years ago
Eric Leblond	fcae1c18de	af-packet: improve error handling for some hw ... Some cards seems to return EAGAIN when there is no more place in the hash table.	6 years ago
Eric Leblond	0bfbb4a889	bypass: fix accounting ... The flow bypass stats is computed at every pass so the accounting needs to be done at each pass. This patch fixes the accounting in the flow_bypassed counters.	6 years ago
Eric Leblond	44566e5a24	ebpf: only display that file is loaded if we do it	6 years ago
Eric Leblond	5e62ae6d28	af-packet: avoid error flooding when bypass fails	6 years ago
Eric Leblond	af6daceeda	util-ebpf: more useful error message ... At the time of the writing, libbpf output useful error message on strdout only and errno is not really interesting. So let's tell user to look at stdout.	6 years ago
Eric Leblond	833d9ef7e1	ebpf: don't use nexthdr to build hash ... As pointed by Victor Julien, it is not a good idea to use the nexthdr value, as init key for the hash as it could contain some other headers and can be changed for a session.	6 years ago
Eric Leblond	0f64c25b73	util-ebpf: improve code readability ... As pointed by Victor Julien, the pkts_cnt usage was quite confusing so functions are now returning a bool.	6 years ago
Eric Leblond	a8f35cc30e	util-ebpf: discard flow if no Flow storage	6 years ago
Eric Leblond	dbf3606169	doc: document flow event_type	6 years ago
Eric Leblond	efb648aa24	util-ebpf: fix ebpf bypass ... Fix endian order in eBPF bypass. It has to be updated after the bypassed flows handling change.	6 years ago
Eric Leblond	f8aa9ee986	bypass: fix wait time at exit ... The loop on bypassed flow maps can take a few seconds on heavily loaded system causing Suricata to not honor a stop before a few seconds. This patch adds the code needed to detect the need to exit from the check loop.	6 years ago
Eric Leblond	a277f2eb0c	af-packet: fix use after free on config ... ASAN did find that afp config was used after free. This was in fact done in the Flow bypass manager hence this patch.	6 years ago
Eric Leblond	fc2f2fa7d3	bypass: allow bypass for packet without flow ... For capture method that have their own flow structure (not maintained by Suricata), it can make sense to bypass a packet even if there is no Flow in Suricata. For AF_PACKET it does not make sense as the eBPF map entry will be destroyed as soon as it will be checked by the flow bypass manager. Thus we shortcut the bypass function if ever no Flow is attached to the packet. This path also removes reference to Flow in the bypass functions for AF_PACKET. It was not necessary and we possibly could benefit of it if ever we change the bypass algorithm.	6 years ago
Eric Leblond	285768c59e	ebpf: fix bypass filter vlan	6 years ago
Eric Leblond	8a11581ac8	doc: update ebpf doc following bypass_filter change	6 years ago
Eric Leblond	853d832de7	ebpf: complete vlan support for ebpf bypass filter	6 years ago
Eric Leblond	253c011c70	doc: update for latest xdp_filter.c change	6 years ago
Eric Leblond	6ab1cbcb8e	bypass: use flow storage for bypass counter ... There is a synchronization issue occuring when a flow is added to the eBPF bypass maps. The flow can have packets in the ring buffer that have already passed the eBPF stage. By consequences, they are not accounted in the eBPF counter but are accounted by Suricata flow engine. This was causing counters to be completely wrong. This code fixes the issue by avoiding the counter change in invalid case. To avoid adding 4 64bits integers to the Flow structure for the bypass accounting, we use instead a FlowStorage. This limits the memory usage to the size of a pointer.	6 years ago
Eric Leblond	640bc937b4	ebpf: add vlan tracking option to xdp_filter ... If vlan is not use for tracking in Suricata this result in vlan not being used in the flow key in Suricata and we need to adjust that in the XDP filter to avoid any problem.	6 years ago
Eric Leblond	34b8583f35	ebpf: tls encrypted bypass in xdp_filter ... Tests have shown that when we bypass encrypted traffic a non neglicteable amount of encrypted packets of the session are already in the capture ring buffer. Result is that Suricata is doing unnecessary work on these packets. These packets can be identified via the first bytes of their payloads so we can bypass them directly in the XDP code. This is done here for application data packets on port 443 and for TLS 1.2.	6 years ago
Eric Leblond	d2d3a5a92a	ebpf: fix UDP bypass in xdp_filter	6 years ago
Eric Leblond	98b68e87eb	ebpf: fix typo in xdp_filter.c comment	6 years ago
Eric Leblond	4e6add7faa	bypass: generalize iface bypass stats ... Introduce functions in util-device.c to be able to manage the flow bypassed count stats.	6 years ago
Eric Leblond	7e8f4b70f0	ebpf: add comment for some define in XDP filter	6 years ago
Eric Leblond	455d78728e	ebpf: remove useless var in xdp_filter	6 years ago
Eric Leblond	258e90be76	util-ebpf: change flow accounting logic ... Update the flow counters during the life of a bypassed flow instead of just accounting at the end of it.	6 years ago
Eric Leblond	3026e9a80d	util-ebpf: better error handling	6 years ago
Eric Leblond	2ffd3ad2b7	util-ebpf: better error handling of map unlink	6 years ago
Eric Leblond	b952b32a26	util-ebpf: rename field 'unlink' to avoid confusion	6 years ago
Eric Leblond	edf2db4e30	af-packet: improve warning message	6 years ago
Eric Leblond	567b5ee1bc	af-packet: rename option 'no-percpu-hash'	6 years ago
Eric Leblond	0f6b1297a9	af-packet: warn when XDP is not supported	6 years ago
Eric Leblond	b1c9b39435	af-packet: remove question from code	6 years ago
Eric Leblond	1992093c88	flow-bypass: rename variables	6 years ago
Eric Leblond	d239e0f2d5	flow-hash: doc and code cleaning	6 years ago
Eric Leblond	b736344975	flow-bypass: clock_gettime error handling ... Only reason clock_gettime could fail is a permission so let's error and leave the flow bypass manager if it is the case. Also let's suppress the error message if ever the error appear in the middle of a run (which is unlikely).	6 years ago
Eric Leblond	4129938c21	util-ebpf: log level fixes and code cleaning	6 years ago
Eric Leblond	140269a6be	util-ebpf: init code optimization	6 years ago
Eric Leblond	ccb8f3cd4b	configure: libbpf path	6 years ago
Eric Leblond	373afab9e0	ebpf: reindent xdp_filter.c	6 years ago
Eric Leblond	ca50f8852e	doc: improve ebpf doc ... Add example of bypass rules and explain clang dependency.	6 years ago
Eric Leblond	c11eb78141	doc: document netronome hardware bypass usage	6 years ago
Eric Leblond	c5e2af0545	util-ebpf: fix error reported by coccinelle check ... Some allocation errors were not checked during init phase.	6 years ago
Eric Leblond	c1fd0da550	af-packet: add vlan_id in bypass key ... Bypassing on vlan was not supported due to the missing key.	6 years ago
Eric Leblond	651a27e4fb	ebpf: fix percpu hash handling ... An alignement issue was preventing the code to work properly. We introduce macros taken from Linux source code sample to get something that should work on the long term.	6 years ago