14402 Commits (03e0a60f9671cc23c605d556d37554c25aa605f3)

 

All Branches   

Search

Author	SHA1	Message	Date
Victor Julien	03e0a60f96	detect/sigorder: remove unused struct fields	3 years ago
Victor Julien	000064de7d	detect: fix scan-build warnings ... detect-engine-address.c:1140:17: warning: Use of memory after it is freed [unix.Malloc] r = DetectAddressCmp(ag, ag2); ^~~~~~~~~~~~~~~~~~~~~~~~~ detect-engine-address.c:1169:17: warning: Use of memory after it is freed [unix.Malloc] r = DetectAddressCmp(ag, ag2); ^~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. detect-engine-port.c:1161:9: warning: Use of memory after it is freed [unix.Malloc] DetectPortPrint(ag2); ^~~~~~~~~~~~~~~~~~~~ 1 warning generated. Bug: #3150. Bug: #3151.	3 years ago
Victor Julien	c8694634af	mpm/ac-bs: work around scan-build warnings ... util-mpm-ac-bs.c:482:32: warning: Result of 'malloc' is converted to a pointer of type 'uint16_t[256]', which is incompatible with sizeof operand type 'uint16_t' [unix.MallocSizeof] ctx->state_table_u16 = SCMalloc(ctx->state_count * ^~~~~~~~ ./util-mem.h:35:18: note: expanded from macro 'SCMalloc' #define SCMalloc malloc ^~~~~~ util-mpm-ac-bs.c:524:32: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t[256]', which is incompatible with sizeof operand type 'uint32_t' [unix.MallocSizeof] ctx->state_table_u32 = SCMalloc(ctx->state_count * ^~~~~~~~ ./util-mem.h:35:18: note: expanded from macro 'SCMalloc' #define SCMalloc malloc ^~~~~~ 2 warnings generated. Bug: #3148.	3 years ago
Victor Julien	ee683a7074	mpm/ac: work around scan-build warnings ... util-mpm-ac.c:531:32: warning: Result of 'malloc' is converted to a pointer of type 'uint16_t[256]', which is incompatible with sizeof operand type 'uint16_t' [unix.MallocSizeof] ctx->state_table_u16 = SCMalloc(ctx->state_count * ^~~~~~~~ ./util-mem.h:35:18: note: expanded from macro 'SCMalloc' #define SCMalloc malloc ^~~~~~ util-mpm-ac.c:575:32: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t[256]', which is incompatible with sizeof operand type 'uint32_t' [unix.MallocSizeof] ctx->state_table_u32 = SCMalloc(ctx->state_count * ^~~~~~~~ ./util-mem.h:35:18: note: expanded from macro 'SCMalloc' #define SCMalloc malloc ^~~~~~ 2 warnings generated. Bug: #3148.	3 years ago
Victor Julien	ec84ba1a3c	mpm/hs: fix scan-build warning ... util-mpm-hs.c:340:20: warning: Potential leak of memory pointed to by 'p' [unix.Malloc] p->sids[0] = sid; ~~~~~~~~~~~^~~~~ 1 warning generated. Incorrect error handling could lead to a memory leak.	3 years ago
Victor Julien	59ca5cc655	decode: suppress scan-build warning	3 years ago
Victor Julien	c13a6fa73c	suricata: work around scan-build warnings ... suricata.c:691:17: warning: Value stored to 'bits' during its initialization is never read [deadcode.DeadStores] const char *bits = "<unknown>-bits"; ^~~~ ~~~~~~~~~~~~~~~~ suricata.c:692:17: warning: Value stored to 'endian' during its initialization is never read [deadcode.DeadStores] const char *endian = "<unknown>-endian"; ^~~~~~ ~~~~~~~~~~~~~~~~~~ 2 warnings generated.	3 years ago
Victor Julien	0c15114450	stream: fix minor scan-build warning ... stream-tcp.c:134:14: warning: Value stored to 'presize' during its initialization is never read [deadcode.DeadStores] uint64_t presize = SC_ATOMIC_GET(st_memuse); ^~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated.	3 years ago
Victor Julien	bcf8187443	scan-build: treat as debug validate	3 years ago
Victor Julien	b700222240	eve: no need to check fields ... Cppcheck 2.10: src/output-json-dns.c:460:23: warning: Identical inner 'if' condition is always true (outer condition is 'field' and inner condition is 'field!=NULL'). [identicalInnerCondition] if (field != NULL) ^ src/output-json-dns.c:458:9: note: outer condition: field TAILQ_FOREACH(field, &custom->head, next) ^ src/output-json-dns.c:460:23: note: identical inner condition: field!=NULL if (field != NULL) ^ src/output-json-email-common.c:408:27: warning: Identical inner 'if' condition is always true (outer condition is 'field' and inner condition is 'field!=NULL'). [identicalInnerCondition] if (field != NULL) { ^ src/output-json-email-common.c:407:13: note: outer condition: field TAILQ_FOREACH(field, &custom->head, next) { ^ src/output-json-email-common.c:408:27: note: identical inner condition: field!=NULL if (field != NULL) { ^ src/output-json-email-common.c:430:27: warning: Identical inner 'if' condition is always true (outer condition is 'field' and inner condition is 'field!=NULL'). [identicalInnerCondition] if (field != NULL) { ^ src/output-json-email-common.c:429:13: note: outer condition: field TAILQ_FOREACH(field, &md5_conf->head, next) { ^ src/output-json-email-common.c:430:27: note: identical inner condition: field!=NULL if (field != NULL) { ^ src/output-json-http.c:574:27: warning: Identical inner 'if' condition is always true (outer condition is 'field' and inner condition is 'field!=NULL'). [identicalInnerCondition] if (field != NULL) ^ src/output-json-http.c:572:13: note: outer condition: field TAILQ_FOREACH(field, &custom->head, next) ^ src/output-json-http.c:574:27: note: identical inner condition: field!=NULL if (field != NULL) ^	3 years ago
Victor Julien	29ac7b366b	yaml: fix dead store ... conf-yaml-loader.c:391:17: warning: Value stored to 'retval' is never read [deadcode.DeadStores] retval = -1; ^ ~~ 1 warning generated.	3 years ago
Victor Julien	be91955356	debug: suppress warning for scan-build ... app-layer-ssl.c:1497:27: error: call to undeclared function 'RecordAlreadyProcessed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] DEBUG_VALIDATE_BUG_ON(RecordAlreadyProcessed(ssl_state->curr_connp)); ^ 1 error generated.	3 years ago
Victor Julien	89c947129d	stream: check debug check for multi-SYN/ACK in TFO	3 years ago
Victor Julien	e61673cbc4	stream: segment insertion error handling cleanup	3 years ago
Victor Julien	54f34dea5c	detect/http2.header_name: fix multi buffer setup	3 years ago
Victor Julien	a94ca44620	detect/parse: minor validation code cleanups	3 years ago
Victor Julien	021f626ab1	detect: add error message for transform w/o matches	3 years ago
Victor Julien	2c0e434bb8	detect: pass de_ctx to DetectBufferSetActiveList	3 years ago
Victor Julien	f43b7191ae	detect/http_method: use list util in tests; cleanups	3 years ago
Victor Julien	4278f3df4a	detect/http_header: use list util in tests ... Cleanups.	3 years ago
Victor Julien	5cb2e6ad6a	detect/http_client_body: use list util in tests ... Cleanups.	3 years ago
Victor Julien	45d92a330c	detect/isdataat: use list util in tests; cleanups	3 years ago
Victor Julien	10a1c15ac0	detect/tls: use list util in tests; cleanups	3 years ago
Victor Julien	ad3088be14	detect/fast_pattern: use list util	3 years ago
Victor Julien	a718f19b0e	detect/byte_extract: use list util in tests	3 years ago
Victor Julien	9e098020c9	detect/content: use list util in tests; cleanups	3 years ago
Victor Julien	b4c7a76194	detect/dnp3: use list util in tests; cleanups	3 years ago
Victor Julien	7377ebc369	detect/http_uri: remove obsolete tests; clean up	3 years ago
Victor Julien	c41923f9c4	detect/http_user_agent: remove obsolete tests	3 years ago
Victor Julien	d6adb5c304	detect/http_stat_msg: remove obsolete tests	3 years ago
Victor Julien	6ac01c213a	detect/http_stat_code: remove obsolete tests	3 years ago
Victor Julien	746456deca	detect/http_server_body: remove obsolete tests	3 years ago
Victor Julien	5994aafe00	detect/http_raw_header: remove obsolete tests	3 years ago
Victor Julien	85639ea174	detect/http_method: remove obsolete tests	3 years ago
Victor Julien	72775e9c5f	detect/http_host: remove obsolete tests	3 years ago
Victor Julien	456786b36d	detect/http_header: remove obsolete tests	3 years ago
Victor Julien	1a1a7e00e0	detect/http_cookie: remove obsolete tests	3 years ago
Victor Julien	a7e1eaaa2c	detect/http_client_body: remove and update tests	3 years ago
Victor Julien	d4e998e0b8	detect/file_data: remove obsolete tests	3 years ago
Victor Julien	5c8ff17186	detect/uricontent: remove obsolete tests	3 years ago
Victor Julien	233f663053	detect/replace: reduce sm_lists use	3 years ago
Victor Julien	67ef4b15bb	detect/pkt_data: remove obsolete tests	3 years ago
Victor Julien	6b27087527	detect/pcre: remove obsolete tests	3 years ago
Victor Julien	243c285fe9	detect/isdataat: remove obsolete test; reduce sm_lists use	3 years ago
Victor Julien	343a7fd900	detect/ftpbounce: remove obsolete tests	3 years ago
Victor Julien	1b1a51efa6	detect/geoip: reduce use of sm_list macro	3 years ago
Victor Julien	8bab0f31b1	detect/dns_query: remove obsolete tests	3 years ago
Victor Julien	a66890d60f	detect/distance: reduce use of sm_list macro	3 years ago
Victor Julien	34735a54d8	detect/dce_stub_data: remove obsolete tests	3 years ago
Victor Julien	416c5d4bf6	detect/dce_stub_data: remove obsolete tests	3 years ago