aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rust: fix clippy lints for unneeded reference in debug code

Browse Source
pull/8073/head
Jason Ish 3 years ago committed by Victor Julien
parent 6a7439a26b
commit f0952aef0d
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File

4
rust/src/dns/lua.rs
Unescape Escape View File

@ -170,7 +170,7 @@ pub extern "C" fn rs_dns_lua_get_answer_table(clua: &mut CLuaState,
DNSRData::A(ref bytes) | DNSRData::AAAA(ref bytes) => { DNSRData::A(ref bytes) | DNSRData::AAAA(ref bytes) => {
if !bytes.is_empty() { if !bytes.is_empty() {
lua.pushstring("addr"); lua.pushstring("addr");
lua.pushstring(&dns_print_addr(&bytes)); lua.pushstring(&dns_print_addr(bytes));
lua.settable(-3); lua.settable(-3);
} }
}, },
@ -183,7 +183,7 @@ pub extern "C" fn rs_dns_lua_get_answer_table(clua: &mut CLuaState,
DNSRData::Unknown(ref bytes) => { DNSRData::Unknown(ref bytes) => {
if !bytes.is_empty() { if !bytes.is_empty() {
lua.pushstring("addr"); lua.pushstring("addr");
lua.pushstring(&String::from_utf8_lossy(&bytes)); lua.pushstring(&String::from_utf8_lossy(bytes));
lua.settable(-3); lua.settable(-3);
} }
}, },

12
rust/src/nfs/nfs4.rs
Unescape Escape View File

@ -184,11 +184,11 @@ impl NFSState {
} }
} }
&Nfs4RequestContent::Open(ref rd) => { &Nfs4RequestContent::Open(ref rd) => {
SCLogDebug!("OPENv4: {}", String::from_utf8_lossy(&rd.filename)); SCLogDebug!("OPENv4: {}", String::from_utf8_lossy(rd.filename));
xidmap.file_name = rd.filename.to_vec(); xidmap.file_name = rd.filename.to_vec();
} }
&Nfs4RequestContent::Lookup(ref rd) => { &Nfs4RequestContent::Lookup(ref rd) => {
SCLogDebug!("LOOKUPv4: {}", String::from_utf8_lossy(&rd.filename)); SCLogDebug!("LOOKUPv4: {}", String::from_utf8_lossy(rd.filename));
xidmap.file_name = rd.filename.to_vec(); xidmap.file_name = rd.filename.to_vec();
} }
&Nfs4RequestContent::Write(ref rd) => { &Nfs4RequestContent::Write(ref rd) => {
@ -225,9 +225,9 @@ impl NFSState {
&Nfs4RequestContent::SetClientId(ref _rd) => { &Nfs4RequestContent::SetClientId(ref _rd) => {
SCLogDebug!( SCLogDebug!(
"SETCLIENTIDv4: client id {} r_netid {} r_addr {}", "SETCLIENTIDv4: client id {} r_netid {} r_addr {}",
String::from_utf8_lossy(&_rd.client_id), String::from_utf8_lossy(_rd.client_id),
String::from_utf8_lossy(&_rd.r_netid), String::from_utf8_lossy(_rd.r_netid),
String::from_utf8_lossy(&_rd.r_addr) String::from_utf8_lossy(_rd.r_addr)
); );
} }
&_ => {} &_ => {}
@ -325,7 +325,7 @@ impl NFSState {
for d in &rd.listing { for d in &rd.listing {
if let &Some(ref _d) = d { if let &Some(ref _d) = d {
SCLogDebug!("READDIRv4: dir {}", String::from_utf8_lossy(&_d.name)); SCLogDebug!("READDIRv4: dir {}", String::from_utf8_lossy(_d.name));
} }
} }
} }

2
rust/src/smb/smb.rs
Unescape Escape View File

@ -1057,7 +1057,7 @@ impl SMBState {
Ok("suricata::dcerpc") => ("unknown", true), Ok("suricata::dcerpc") => ("unknown", true),
Err(_) => ("MALFORMED", false), Err(_) => ("MALFORMED", false),
Ok(&_) => { Ok(&_) => {
SCLogDebug!("don't know {}", String::from_utf8_lossy(&n)); SCLogDebug!("don't know {}", String::from_utf8_lossy(n));
("UNKNOWN", false) ("UNKNOWN", false)
}, },
} }

Write Preview
Loading…
Cancel
Save