port: don't lead memory on port parsing failure

[src/detect-engine-port.c:1354]: (error) Memory leak: gh
pull/699/head
Victor Julien 13 years ago
parent 435f99409f
commit d5db0cc033

@ -1326,11 +1326,13 @@ int DetectPortTestConfVars(void)
"Port var \"%s\" probably has a sequence(something " "Port var \"%s\" probably has a sequence(something "
"in brackets) value set without any quotes. Please " "in brackets) value set without any quotes. Please "
"quote it using \"..\".", seq_node->name); "quote it using \"..\".", seq_node->name);
DetectPortCleanupList(gh);
goto error; goto error;
} }
int r = DetectPortParseDo(&gh, &ghn, seq_node->val, /* start with negate no */0); int r = DetectPortParseDo(&gh, &ghn, seq_node->val, /* start with negate no */0);
if (r < 0) { if (r < 0) {
DetectPortCleanupList(gh);
goto error; goto error;
} }
@ -1340,6 +1342,8 @@ int DetectPortTestConfVars(void)
"with it's value \"%s\". Port space range is NIL. " "with it's value \"%s\". Port space range is NIL. "
"Probably have a !any or a port range that supplies " "Probably have a !any or a port range that supplies "
"a NULL address range", seq_node->name, seq_node->val); "a NULL address range", seq_node->name, seq_node->val);
DetectPortCleanupList(gh);
DetectPortCleanupList(ghn);
goto error; goto error;
} }

Loading…
Cancel
Save