Fix potential parsing issue in detection filter code.

remotes/origin/master-1.0.x
Victor Julien 15 years ago
parent 94d480536b
commit a2480bc07b

@ -116,6 +116,8 @@ DetectThresholdData *DetectDetectionFilterParse (char *rawstr) {
int i = 0; int i = 0;
copy_str = SCStrdup(rawstr); copy_str = SCStrdup(rawstr);
if (copy_str == NULL)
goto error;
for(pos = 0, df_opt = strtok(copy_str,","); pos < strlen(copy_str) && df_opt != NULL; pos++, df_opt = strtok(NULL,",")) { for(pos = 0, df_opt = strtok(copy_str,","); pos < strlen(copy_str) && df_opt != NULL; pos++, df_opt = strtok(NULL,",")) {
@ -126,9 +128,7 @@ DetectThresholdData *DetectDetectionFilterParse (char *rawstr) {
if(strstr(df_opt,"track")) if(strstr(df_opt,"track"))
track_found++; track_found++;
} }
SCFree(copy_str);
if(copy_str)
SCFree(copy_str);
if(count_found != 1 || seconds_found != 1 || track_found != 1) if(count_found != 1 || seconds_found != 1 || track_found != 1)
goto error; goto error;

Loading…
Cancel
Save