Don't display a warning when log-pcap tries to remove an already removed file.

remotes/origin/HEAD
Victor Julien 14 years ago
parent 7109a056a5
commit 8cd460dde5

@ -188,31 +188,29 @@ int PcapLogRotateFile(ThreadVars *t, PcapLogData *pl)
SCLogDebug("Removing pcap file %s", pf->filename); SCLogDebug("Removing pcap file %s", pf->filename);
if (remove(pf->filename) != 0) { if (remove(pf->filename) != 0) {
SCLogWarning(SC_ERR_PCAP_FILE_DELETE_FAILED, // VJ remove can fail because file is already gone
"failed to remove log file %s: %s", //LogWarning(SC_ERR_PCAP_FILE_DELETE_FAILED,
pf->filename, strerror( errno )); // "failed to remove log file %s: %s",
// pf->filename, strerror( errno ));
} }
else {
SCLogDebug("success! removed log file %s", pf->filename);
/* Remove directory if Sguil mode and no files left in sguil dir */ /* Remove directory if Sguil mode and no files left in sguil dir */
if (pl->mode == LOGMODE_SGUIL) { if (pl->mode == LOGMODE_SGUIL) {
pfnext = TAILQ_NEXT(pf,next); pfnext = TAILQ_NEXT(pf,next);
if (strcmp(pf->dirname, pfnext->dirname) == 0) { if (strcmp(pf->dirname, pfnext->dirname) == 0) {
SCLogDebug("Current entry dir %s and next entry %s " SCLogDebug("Current entry dir %s and next entry %s "
"are equal: not removing dir", "are equal: not removing dir",
pf->dirname, pfnext->dirname); pf->dirname, pfnext->dirname);
} else { } else {
SCLogDebug("current entry %s and %s are " SCLogDebug("current entry %s and %s are "
"not equal: removing dir", "not equal: removing dir",
pf->dirname, pfnext->dirname); pf->dirname, pfnext->dirname);
if (remove(pf->dirname) != 0) { if (remove(pf->dirname) != 0) {
SCLogWarning(SC_ERR_PCAP_FILE_DELETE_FAILED, SCLogWarning(SC_ERR_PCAP_FILE_DELETE_FAILED,
"failed to remove sguil log %s: %s", "failed to remove sguil log %s: %s",
pf->dirname, strerror( errno )); pf->dirname, strerror( errno ));
}
} }
} }
} }

Loading…
Cancel
Save