clean: replace MD5_STRING_LENGTH with more used SC_MD5_HEX_LEN

pull/8157/head
Philippe Antoine 3 years ago committed by Victor Julien
parent 5a0d07b13f
commit 7823653a30

@ -30,8 +30,6 @@
#include "detect-engine.h" #include "detect-engine.h"
#define MD5_STRING_LENGTH 33
/** /**
* \brief Allocate new buffer. * \brief Allocate new buffer.
* *
@ -226,14 +224,14 @@ char *Ja3GenerateHash(JA3Buffer *buffer)
return NULL; return NULL;
} }
char *ja3_hash = SCMalloc(MD5_STRING_LENGTH); char *ja3_hash = SCMalloc(SC_MD5_HEX_LEN + 1);
if (ja3_hash == NULL) { if (ja3_hash == NULL) {
SCLogError(SC_ERR_MEM_ALLOC, SCLogError(SC_ERR_MEM_ALLOC,
"Error allocating memory for JA3 hash"); "Error allocating memory for JA3 hash");
return NULL; return NULL;
} }
SCMd5HashBufferToHex((unsigned char *)buffer->data, buffer->used, ja3_hash, MD5_STRING_LENGTH); SCMd5HashBufferToHex((unsigned char *)buffer->data, buffer->used, ja3_hash, SC_MD5_HEX_LEN + 1);
return ja3_hash; return ja3_hash;
} }

Loading…
Cancel
Save