aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

detect/csum: remove pseudo packet checks

Browse Source
pull/11326/head
Victor Julien 10 months ago committed by Victor Julien
parent 64f5865efc
commit 6958efa2dc
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File

15
src/detect-csum.c
Unescape Escape View File

@ -237,7 +237,7 @@ static int DetectIPV4CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv4(p) || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv4(p))
return 0; return 0;
if (p->flags & PKT_IGNORE_CHECKSUM) { if (p->flags & PKT_IGNORE_CHECKSUM) {
@ -316,7 +316,7 @@ static int DetectTCPV4CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv4(p) || !PacketIsTCP(p) || p->proto != IPPROTO_TCP || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv4(p) || !PacketIsTCP(p) || p->proto != IPPROTO_TCP)
return 0; return 0;
if (p->flags & PKT_IGNORE_CHECKSUM) { if (p->flags & PKT_IGNORE_CHECKSUM) {
@ -396,7 +396,7 @@ static int DetectTCPV6CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv6(p) || !PacketIsTCP(p) || p->proto != IPPROTO_TCP || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv6(p) || !PacketIsTCP(p) || p->proto != IPPROTO_TCP)
return 0; return 0;
if (p->flags & PKT_IGNORE_CHECKSUM) { if (p->flags & PKT_IGNORE_CHECKSUM) {
@ -477,7 +477,7 @@ static int DetectUDPV4CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv4(p) || !PacketIsUDP(p) || p->proto != IPPROTO_UDP || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv4(p) || !PacketIsUDP(p) || p->proto != IPPROTO_UDP)
return 0; return 0;
const UDPHdr *udph = PacketGetUDP(p); const UDPHdr *udph = PacketGetUDP(p);
@ -560,7 +560,7 @@ static int DetectUDPV6CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv6(p) || !PacketIsUDP(p) || p->proto != IPPROTO_UDP || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv6(p) || !PacketIsUDP(p) || p->proto != IPPROTO_UDP)
return 0; return 0;
if (p->flags & PKT_IGNORE_CHECKSUM) { if (p->flags & PKT_IGNORE_CHECKSUM) {
@ -643,7 +643,7 @@ static int DetectICMPV4CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv4(p) || !PacketIsICMPv4(p) || p->proto != IPPROTO_ICMP || PKT_IS_PSEUDOPKT(p)) if (!PacketIsIPv4(p) || !PacketIsICMPv4(p) || p->proto != IPPROTO_ICMP)
return 0; return 0;
if (p->flags & PKT_IGNORE_CHECKSUM) { if (p->flags & PKT_IGNORE_CHECKSUM) {
@ -723,8 +723,7 @@ static int DetectICMPV6CsumMatch(DetectEngineThreadCtx *det_ctx,
{ {
const DetectCsumData *cd = (const DetectCsumData *)ctx; const DetectCsumData *cd = (const DetectCsumData *)ctx;
if (!PacketIsIPv6(p) || !PacketIsICMPv6(p) || p->proto != IPPROTO_ICMPV6 || if (!PacketIsIPv6(p) || !PacketIsICMPv6(p) || p->proto != IPPROTO_ICMPV6) {
PKT_IS_PSEUDOPKT(p)) {
return 0; return 0;
} }
const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p); const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p);

Write Preview
Loading…
Cancel
Save