ike: don't log empty server objects

pull/13975/head
Jason Ish 3 weeks ago committed by Victor Julien
parent 2848061d0d
commit 5e2dc9ace3

@ -2571,6 +2571,7 @@
"server": { "server": {
"type": "object", "type": "object",
"additionalProperties": false, "additionalProperties": false,
"minProperties": 1,
"properties": { "properties": {
"key_exchange_payload": { "key_exchange_payload": {
"type": "string" "type": "string"

@ -173,26 +173,31 @@ fn log_ikev1(state: &IKEState, tx: &IKETransaction, jb: &mut JsonBuilder) -> Res
jb.close()?; // client jb.close()?; // client
// server data // server data
jb.open_object("server")?; if !state.ikev1_container.server.key_exchange.is_empty()
if !state.ikev1_container.server.key_exchange.is_empty() { || !state.ikev1_container.server.nonce.is_empty()
jb.set_string( {
"key_exchange_payload", jb.open_object("server")?;
&state.ikev1_container.server.key_exchange, if !state.ikev1_container.server.key_exchange.is_empty() {
)?; jb.set_string(
if let Ok(server_key_length) = "key_exchange_payload",
u64::try_from(state.ikev1_container.server.key_exchange.len()) &state.ikev1_container.server.key_exchange,
{ )?;
jb.set_uint("key_exchange_payload_length", server_key_length / 2)?; if let Ok(server_key_length) =
u64::try_from(state.ikev1_container.server.key_exchange.len())
{
jb.set_uint("key_exchange_payload_length", server_key_length / 2)?;
}
} }
} if !state.ikev1_container.server.nonce.is_empty() {
if !state.ikev1_container.server.nonce.is_empty() { jb.set_string("nonce_payload", &state.ikev1_container.server.nonce)?;
jb.set_string("nonce_payload", &state.ikev1_container.server.nonce)?; if let Ok(server_nonce_length) =
if let Ok(server_nonce_length) = u64::try_from(state.ikev1_container.server.nonce.len()) u64::try_from(state.ikev1_container.server.nonce.len())
{ {
jb.set_uint("nonce_payload_length", server_nonce_length / 2)?; jb.set_uint("nonce_payload_length", server_nonce_length / 2)?;
}
} }
jb.close()?; // server
} }
jb.close()?; // server
if !tx.hdr.ikev1_header.vendor_ids.is_empty() { if !tx.hdr.ikev1_header.vendor_ids.is_empty() {
jb.open_array("vendor_ids")?; jb.open_array("vendor_ids")?;

Loading…
Cancel
Save