clean: remove useless * sizeof(char)

src/app-layer-ssl.c

@@ -475,7 +475,7 @@ static inline int TlsDecodeHSCertificateFingerprint(
     if (unlikely(connp->cert0_fingerprint != NULL))
         return 0;
 
-    connp->cert0_fingerprint = SCCalloc(1, SHA1_STRING_LENGTH * sizeof(char));
+    connp->cert0_fingerprint = SCCalloc(1, SHA1_STRING_LENGTH);
     if (connp->cert0_fingerprint == NULL)
         return -1;
 

src/suricata.c

@@ -524,7 +524,7 @@ static void SetBpfStringFromFile(char *filename)
     }
     bpf_len = st.st_size + 1;
 
-    bpf_filter = SCMalloc(bpf_len * sizeof(char));
+    bpf_filter = SCMalloc(bpf_len);
     if (unlikely(bpf_filter == NULL)) {
         SCLogError(SC_ERR_MEM_ALLOC, "Failed to allocate buffer for bpf filter in file %s", filename);
         exit(EXIT_FAILURE);

src/util-ja3.c

@@ -83,7 +83,7 @@ static int Ja3BufferResizeIfFull(JA3Buffer *buffer, uint32_t len)
     while (buffer->used + len + 2 > buffer->size)
     {
         buffer->size *= 2;
-        char *tmp = SCRealloc(buffer->data, buffer->size * sizeof(char));
+        char *tmp = SCRealloc(buffer->data, buffer->size);
         if (tmp == NULL) {
             SCLogError(SC_ERR_MEM_ALLOC, "Error resizing JA3 buffer");
             return -1;
@@ -177,7 +177,7 @@ int Ja3BufferAddValue(JA3Buffer **buffer, uint32_t value)
     }
 
     if ((*buffer)->data == NULL) {
-        (*buffer)->data = SCMalloc(JA3_BUFFER_INITIAL_SIZE * sizeof(char));
+        (*buffer)->data = SCMalloc(JA3_BUFFER_INITIAL_SIZE);
         if ((*buffer)->data == NULL) {
             SCLogError(SC_ERR_MEM_ALLOC,
                        "Error allocating memory for JA3 data");
@@ -226,15 +226,14 @@ char *Ja3GenerateHash(JA3Buffer *buffer)
         return NULL;
     }
 
-    char *ja3_hash = SCMalloc(MD5_STRING_LENGTH * sizeof(char));
+    char *ja3_hash = SCMalloc(MD5_STRING_LENGTH);
     if (ja3_hash == NULL) {
         SCLogError(SC_ERR_MEM_ALLOC,
                    "Error allocating memory for JA3 hash");
         return NULL;
     }
 
-    SCMd5HashBufferToHex((unsigned char *)buffer->data, buffer->used, ja3_hash,
+    SCMd5HashBufferToHex((unsigned char *)buffer->data, buffer->used, ja3_hash, MD5_STRING_LENGTH);
-            MD5_STRING_LENGTH * sizeof(char));
     return ja3_hash;
 }