Fix bug in logging msg when using --init-errors-fatal

src/detect-parse.c

@@ -804,10 +804,6 @@ error:
             SigFree(sig->next);
         SigFree(sig);
     }
-    if (de_ctx->failure_fatal == 1) {
-        SCLogError(SC_ERR_INVALID_SIGNATURE,"Signature init failed \"%s\"",sigstr);
-        exit(EXIT_FAILURE);
-    }
     /* if something failed, restore the old signum count
      * since we didn't install it */
     de_ctx->signum = oldsignum;
@@ -852,10 +848,6 @@ Signature *DetectEngineAppendSig(DetectEngineCtx *de_ctx, char *sigstr) {
 
 error:
     if ( sig != NULL ) SigFree(sig);
-    if (de_ctx->failure_fatal == 1) {
-        SCLogError(SC_ERR_INVALID_SIGNATURE,"Signature init failed %s ",sigstr);
-        exit(EXIT_FAILURE);
-    }
     return NULL;
 }
 

src/detect.c

@@ -274,6 +274,9 @@ int DetectLoadSigFile(DetectEngineCtx *de_ctx, char *sig_file, int *sigs_tot) {
             good++;
         } else {
             SCLogError(SC_ERR_INVALID_SIGNATURE, "Error parsing signature \"%s\" from file %s at line %"PRId32"", line, sig_file, lineno - multiline);
+            if (de_ctx->failure_fatal == 1) {
+                exit(EXIT_FAILURE);
+            }
             bad++;
         }
         multiline = 0;