detect/flow: don't overwrite hook direction

pull/13152/head
Victor Julien 7 months ago committed by Victor Julien
parent 6ee32cba3b
commit 3fe9bd7cbb

@ -414,9 +414,12 @@ int DetectFlowSetup (DetectEngineCtx *de_ctx, Signature *s, const char *flowstr)
} }
s->flags |= SIG_FLAG_TOCLIENT; s->flags |= SIG_FLAG_TOCLIENT;
} else { } else {
/* if direction wasn't already set, e.g. by rule hook, assume both */
if ((s->flags & (SIG_FLAG_TOSERVER | SIG_FLAG_TOCLIENT)) == 0) {
s->flags |= SIG_FLAG_TOSERVER; s->flags |= SIG_FLAG_TOSERVER;
s->flags |= SIG_FLAG_TOCLIENT; s->flags |= SIG_FLAG_TOCLIENT;
} }
}
if (fd->flags == 0 || fd->flags == DETECT_FLOW_FLAG_TOSERVER || if (fd->flags == 0 || fd->flags == DETECT_FLOW_FLAG_TOSERVER ||
fd->flags == DETECT_FLOW_FLAG_TOCLIENT) { fd->flags == DETECT_FLOW_FLAG_TOCLIENT) {
/* no direct flow is needed for just direction, /* no direct flow is needed for just direction,

Loading…
Cancel
Save