detect/http: request/response line keyword modernization

src/detect-http-request-line.c

@@ -73,14 +73,15 @@ static int g_http_request_line_buffer_id = 0;
  */
 void DetectHttpRequestLineRegister(void)
 {
-    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].name = "http_request_line";
+    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].name = "http.request_line";
-    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].desc = "content modifier to match only on the HTTP request line";
+    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].alias = "http_request_line";
+    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].desc = "sticky buffer to match on the HTTP request line";
     sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].url = DOC_URL DOC_VERSION "/rules/http-keywords.html#http-request-line";
     sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].Match = NULL;
     sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].Setup = DetectHttpRequestLineSetup;
     sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].RegisterTests = DetectHttpRequestLineRegisterTests;
 
-    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].flags |= SIGMATCH_NOOPT;
+    sigmatch_table[DETECT_AL_HTTP_REQUEST_LINE].flags |= SIGMATCH_NOOPT|SIGMATCH_INFO_STICKY_BUFFER;
 
     DetectAppLayerInspectEngineRegister2("http_request_line",
             ALPROTO_HTTP, SIG_FLAG_TOSERVER, HTP_REQUEST_LINE,
@@ -112,8 +113,12 @@ void DetectHttpRequestLineRegister(void)
  */
 static int DetectHttpRequestLineSetup(DetectEngineCtx *de_ctx, Signature *s, const char *arg)
 {
-    DetectBufferSetActiveList(s, g_http_request_line_buffer_id);
+    if (DetectBufferSetActiveList(s, g_http_request_line_buffer_id) < 0)
-    s->alproto = ALPROTO_HTTP;
+        return -1;
+
+    if (DetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0)
+        return -1;
+
     return 0;
 }
 

src/detect-http-response-line.c

@@ -62,12 +62,10 @@
 
 static int DetectHttpResponseLineSetup(DetectEngineCtx *, Signature *, const char *);
 static void DetectHttpResponseLineRegisterTests(void);
-static int PrefilterTxHttpResponseLineRegister(DetectEngineCtx *de_ctx,
+static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx,
-        SigGroupHead *sgh, MpmCtx *mpm_ctx);
+        const DetectEngineTransforms *transforms,
-static int DetectEngineInspectHttpResponseLine(ThreadVars *tv,
+        Flow *_f, const uint8_t _flow_flags,
-        DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx,
+        void *txv, const int list_id);
-        const Signature *s, const SigMatchData *smd,
-        Flow *f, uint8_t flags, void *alstate, void *txv, uint64_t tx_id);
 static int g_http_response_line_id = 0;
 
 /**
@@ -75,21 +73,23 @@ static int g_http_response_line_id = 0;
  */
 void DetectHttpResponseLineRegister(void)
 {
-    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].name = "http_response_line";
+    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].name = "http.response_line";
+    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].alias = "http_response_line";
     sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].desc = "content modifier to match only on the HTTP response line";
     sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].url = DOC_URL DOC_VERSION "/rules/http-keywords.html#http-response-line";
-    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].Match = NULL;
     sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].Setup = DetectHttpResponseLineSetup;
     sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].RegisterTests = DetectHttpResponseLineRegisterTests;
 
-    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].flags |= SIGMATCH_NOOPT;
+    sigmatch_table[DETECT_AL_HTTP_RESPONSE_LINE].flags |= SIGMATCH_NOOPT|SIGMATCH_INFO_STICKY_BUFFER;
 
-    DetectAppLayerMpmRegister("http_response_line", SIG_FLAG_TOCLIENT, 2,
+    DetectAppLayerInspectEngineRegister2("http_response_line",
-            PrefilterTxHttpResponseLineRegister);
-
-    DetectAppLayerInspectEngineRegister("http_response_line",
             ALPROTO_HTTP, SIG_FLAG_TOCLIENT, HTP_RESPONSE_LINE,
-            DetectEngineInspectHttpResponseLine);
+            DetectEngineInspectBufferGeneric,
+            GetData);
+
+    DetectAppLayerMpmRegister2("http_response_line", SIG_FLAG_TOCLIENT, 2,
+            PrefilterGenericMpmRegister, GetData,
+            ALPROTO_HTTP, HTP_RESPONSE_LINE);
 
     DetectBufferTypeSetDescriptionByName("http_response_line",
             "http response line");
@@ -112,101 +112,33 @@ void DetectHttpResponseLineRegister(void)
  */
 static int DetectHttpResponseLineSetup(DetectEngineCtx *de_ctx, Signature *s, const char *arg)
 {
-    s->init_data->list = g_http_response_line_id;
+    if (DetectBufferSetActiveList(s, g_http_response_line_id) < 0)
-    s->alproto = ALPROTO_HTTP;
+        return -1;
-    return 0;
-}
-
-/** \brief HTTP response line Mpm prefilter callback
- *
- *  \param det_ctx detection engine thread ctx
- *  \param p packet to inspect
- *  \param f flow to inspect
- *  \param txv tx to inspect
- *  \param pectx inspection context
- */
-static void PrefilterTxHttpResponseLine(DetectEngineThreadCtx *det_ctx,
-        const void *pectx,
-        Packet *p, Flow *f, void *txv,
-        const uint64_t idx, const uint8_t flags)
-{
-    SCEnter();
-
-    const MpmCtx *mpm_ctx = (MpmCtx *)pectx;
-    htp_tx_t *tx = (htp_tx_t *)txv;
 
-    if (tx->response_line == NULL)
+    if (DetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0)
-        return;
+        return -1;
 
-    const uint32_t buffer_len = bstr_len(tx->response_line);
+    return 0;
-    const uint8_t *buffer = bstr_ptr(tx->response_line);
-
-    if (buffer_len >= mpm_ctx->minlen) {
-        (void)mpm_table[mpm_ctx->mpm_type].Search(mpm_ctx,
-                &det_ctx->mtcu, &det_ctx->pmq, buffer, buffer_len);
-    }
-}
-
-static int PrefilterTxHttpResponseLineRegister(DetectEngineCtx *de_ctx,
-        SigGroupHead *sgh, MpmCtx *mpm_ctx)
-{
-    SCEnter();
-
-    return PrefilterAppendTxEngine(de_ctx, sgh, PrefilterTxHttpResponseLine,
-        ALPROTO_HTTP, HTP_RESPONSE_LINE,
-        mpm_ctx, NULL, "http_response_line");
 }
 
-/**
+static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx,
- * \brief Do the content inspection & validation for a signature
+        const DetectEngineTransforms *transforms,
- *
+        Flow *_f, const uint8_t _flow_flags,
- * \param de_ctx Detection engine context
+        void *txv, const int list_id)
- * \param det_ctx Detection engine thread context
- * \param s Signature to inspect
- * \param sm SigMatch to inspect
- * \param f Flow
- * \param flags app layer flags
- * \param state App layer state
- *
- * \retval 0 no match.
- * \retval 1 match.
- * \retval 2 Sig can't match.
- */
-int DetectEngineInspectHttpResponseLine(ThreadVars *tv,
-        DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx,
-        const Signature *s, const SigMatchData *smd,
-        Flow *f, uint8_t flags, void *alstate, void *txv, uint64_t tx_id)
 {
-    htp_tx_t *tx = (htp_tx_t *)txv;
+    InspectionBuffer *buffer = InspectionBufferGet(det_ctx, list_id);
-
+    if (buffer->inspect == NULL) {
-    if (tx->response_line == NULL) {
+        htp_tx_t *tx = (htp_tx_t *)txv;
-        if (AppLayerParserGetStateProgress(IPPROTO_TCP, ALPROTO_HTTP, txv, flags) > HTP_RESPONSE_LINE)
+        if (unlikely(tx->response_line == NULL)) {
-            return DETECT_ENGINE_INSPECT_SIG_CANT_MATCH;
+            return NULL;
-        else
+        }
-            return DETECT_ENGINE_INSPECT_SIG_NO_MATCH;
+        const uint32_t data_len = bstr_len(tx->response_line);
-    }
+        const uint8_t *data = bstr_ptr(tx->response_line);
-
+
-    det_ctx->discontinue_matching = 0;
+        InspectionBufferSetup(buffer, data, data_len);
-    det_ctx->buffer_offset = 0;
+        InspectionBufferApplyTransforms(buffer, transforms);
-    det_ctx->inspection_recursion_counter = 0;
-
-#if 0
-    PrintRawDataFp(stdout, (uint8_t *)bstr_ptr(tx->response_line),
-            bstr_len(tx->response_line));
-#endif
-
-    /* run the inspection against the buffer */
-    int r = DetectEngineContentInspection(de_ctx, det_ctx, s, smd,
-                                          f,
-                                          bstr_ptr(tx->response_line),
-                                          bstr_len(tx->response_line),
-                                          0, DETECT_CI_FLAGS_SINGLE,
-                                          DETECT_ENGINE_CONTENT_INSPECTION_MODE_STATE, NULL);
-    if (r == 1) {
-        return DETECT_ENGINE_INSPECT_SIG_MATCH;
-    } else {
-        return DETECT_ENGINE_INSPECT_SIG_CANT_MATCH;
     }
+    return buffer;
 }
 
 /************************************Unittests*********************************/