Coverity 1005134: fix minor memory leak on flowvar rule setup errors.

12 years ago · 07b751b0df
parent e45f683c19
commit 07b751b0df
1 changed files with 3 additions and 1 deletions
--- a/src/detect-flowvar.c
+++ b/src/detect-flowvar.c
@ -323,7 +323,7 @@ int DetectFlowvarPostMatchSetup(Signature *s, uint16_t idx) {
    fv->idx = idx;

    sm = SigMatchAlloc();
-    if (sm == NULL)
+    if (unlikely(sm == NULL))
        goto error;

    sm->type = DETECT_FLOWVAR_POSTMATCH;
@ -332,6 +332,8 @@ int DetectFlowvarPostMatchSetup(Signature *s, uint16_t idx) {
    SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_POSTMATCH);
    return 0;
 error:
+    if (fv != NULL)
+        DetectFlowvarDataFree(fv);
    return -1;
 }