You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/app/controllers/api
Akihiko Odaki 552e886b64
Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673)
The old implementation had two queries:
1. The query constructed in Api::V1::FavouritesController#results
2. The query constructed in #cached_favourites, which is merged with 1.

Both of them are issued againt PostgreSQL. The combination of the two
queries caused the following problems:
- The small window between the two queries involves race conditions.
- Minor performance inefficiency.

Moreover, the construction of query 2, which involves merging with query
1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
returns an array when min_id parameter is specified. The behavior prevents
from merging the query, and in the real world, ActiveRecord simply ignores
the merge (!), which results in querying the entire scan of statuses and
favourites table.

This change fixes these issues by simply letting query 1 get all the works
done.
5 years ago
..
v1 Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673) 5 years ago
v2 Change local media attachments to perform heavy processing asynchronously (#13210) 5 years ago
web Remove useless `respond_to` calls (#13208) 5 years ago
base_controller.rb Fix functional user requirements in whitelist mode (#14093) 5 years ago
oembed_controller.rb Fix OEmbed leaking information about existence of non-public statuses (#12930) 5 years ago
proofs_controller.rb Fix proofs API being inaccessible in secure mode (#12495) 6 years ago