You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/app
Akihiko Odaki 552e886b64
Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673)
The old implementation had two queries:
1. The query constructed in Api::V1::FavouritesController#results
2. The query constructed in #cached_favourites, which is merged with 1.

Both of them are issued againt PostgreSQL. The combination of the two
queries caused the following problems:
- The small window between the two queries involves race conditions.
- Minor performance inefficiency.

Moreover, the construction of query 2, which involves merging with query
1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
returns an array when min_id parameter is specified. The behavior prevents
from merging the query, and in the real world, ActiveRecord simply ignores
the merge (!), which results in querying the entire scan of statuses and
favourites table.

This change fixes these issues by simply letting query 1 get all the works
done.
5 years ago
..
chewy Change `tootctl search deploy` algorithm (#14300) 6 years ago
controllers Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673) 5 years ago
helpers Add a visibility icon to status (#14123) 6 years ago
javascript Add WebAuthn as an alternative 2FA method (#14466) 5 years ago
lib Fix dereferencing remote statuses not using the correct account (#14656) 5 years ago
mailers Add WebAuthn as an alternative 2FA method (#14466) 5 years ago
models Add WebAuthn as an alternative 2FA method (#14466) 5 years ago
policies
presenters Add user notes on accounts (#14148) 6 years ago
serializers Add thumbnail_remote_url in MediaAttachment REST response (#14358) 6 years ago
services Use Status.group instead of Status.distinct in HashQueryService (#14662) 5 years ago
validators Improve email address validation (#14565) 6 years ago
views Add WebAuthn as an alternative 2FA method (#14466) 5 years ago
workers Changed retries and rescued in ActivityPub::ProcessingWorker (#14355) 6 years ago