refactor: MVC sign up password view

lib/config/routes.dart

@@ -2,6 +2,7 @@ import 'package:adaptive_page_layout/adaptive_page_layout.dart';
 import 'package:famedlysdk/famedlysdk.dart';
 import 'package:fluffychat/controllers/homeserver_picker_controller.dart';
 import 'package:fluffychat/controllers/sign_up_controller.dart';
+import 'package:fluffychat/controllers/sign_up_password_controller.dart';
 import 'package:fluffychat/views/widgets/matrix.dart';
 import 'package:fluffychat/views/archive.dart';
 import 'package:fluffychat/views/chat.dart';
@@ -25,7 +26,6 @@ import 'package:fluffychat/views/settings_ignore_list.dart';
 import 'package:fluffychat/views/settings_multiple_emotes.dart';
 import 'package:fluffychat/views/settings_notifications.dart';
 import 'package:fluffychat/views/settings_style.dart';
-import 'package:fluffychat/views/sign_up_password.dart';
 import 'package:flutter/material.dart';
 
 class FluffyRoutes {

lib/controllers/sign_up_password_controller.dart

@@ -2,9 +2,9 @@ import 'package:adaptive_dialog/adaptive_dialog.dart';
 import 'package:adaptive_page_layout/adaptive_page_layout.dart';
 
 import 'package:famedlysdk/famedlysdk.dart';
+import 'package:fluffychat/views/sign_up_password_view.dart';
 
 import 'package:fluffychat/views/widgets/matrix.dart';
-import 'package:fluffychat/views/widgets/one_page_card.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:url_launcher/url_launcher.dart';
@@ -16,17 +16,19 @@ class SignUpPassword extends StatefulWidget {
   final String displayname;
   const SignUpPassword(this.username, {this.avatar, this.displayname});
   @override
-  _SignUpPasswordState createState() => _SignUpPasswordState();
+  SignUpPasswordController createState() => SignUpPasswordController();
 }
 
-class _SignUpPasswordState extends State<SignUpPassword> {
+class SignUpPasswordController extends State<SignUpPassword> {
   final TextEditingController passwordController = TextEditingController();
   String passwordError;
   String _lastAuthWebViewStage;
   bool loading = false;
   bool showPassword = true;
 
-  void _signUpAction(BuildContext context, {AuthenticationData auth}) async {
+  void toggleShowPassword() => setState(() => showPassword = !showPassword);
+
+  void signUpAction({AuthenticationData auth}) async {
     var matrix = Matrix.of(context);
     if (passwordController.text.isEmpty) {
       setState(() => passwordError = L10n.of(context).pleaseEnterYourPassword);
@@ -59,8 +61,7 @@ class _SignUpPasswordState extends State<SignUpPassword> {
                 true);
 
         if (currentStage == 'm.login.dummy') {
-          _signUpAction(
+          signUpAction(
-            context,
             auth: AuthenticationData(
               type: currentStage,
               session: exception.session,
@@ -86,8 +87,7 @@ class _SignUpPasswordState extends State<SignUpPassword> {
                 cancelLabel: L10n.of(context).cancel,
                 useRootNavigator: false,
               )) {
-            _signUpAction(
+            signUpAction(
-              context,
               auth: AuthenticationData(session: exception.session),
             );
           } else {
@@ -127,62 +127,5 @@ class _SignUpPasswordState extends State<SignUpPassword> {
   }
 
   @override
-  Widget build(BuildContext context) {
+  Widget build(BuildContext context) => SignUpPasswordView(this);
-    return OnePageCard(
-      child: Scaffold(
-        appBar: AppBar(
-          elevation: 0,
-          leading: loading ? Container() : BackButton(),
-          title: Text(
-            L10n.of(context).chooseAStrongPassword,
-          ),
-        ),
-        body: ListView(
-          children: <Widget>[
-            Padding(
-              padding: const EdgeInsets.all(12.0),
-              child: TextField(
-                controller: passwordController,
-                obscureText: !showPassword,
-                autofocus: true,
-                readOnly: loading,
-                autocorrect: false,
-                onSubmitted: (t) => _signUpAction(context),
-                autofillHints: loading ? null : [AutofillHints.newPassword],
-                decoration: InputDecoration(
-                    prefixIcon: Icon(Icons.lock_outlined),
-                    hintText: '****',
-                    errorText: passwordError,
-                    suffixIcon: IconButton(
-                      tooltip: L10n.of(context).showPassword,
-                      icon: Icon(showPassword
-                          ? Icons.visibility_off_outlined
-                          : Icons.visibility_outlined),
-                      onPressed: () =>
-                          setState(() => showPassword = !showPassword),
-                    ),
-                    labelText: L10n.of(context).password),
-              ),
-            ),
-            SizedBox(height: 12),
-            Hero(
-              tag: 'loginButton',
-              child: Padding(
-                padding: EdgeInsets.symmetric(horizontal: 12),
-                child: ElevatedButton(
-                  onPressed: loading ? null : () => _signUpAction(context),
-                  child: loading
-                      ? LinearProgressIndicator()
-                      : Text(
-                          L10n.of(context).createAccountNow.toUpperCase(),
-                          style: TextStyle(color: Colors.white, fontSize: 16),
-                        ),
-                ),
-              ),
-            ),
-          ],
-        ),
-      ),
-    );
-  }
 }

lib/views/sign_up_password_view.dart

@@ -0,0 +1,75 @@
+import 'package:fluffychat/controllers/sign_up_password_controller.dart';
+
+import 'package:fluffychat/views/widgets/one_page_card.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/l10n.dart';
+
+class SignUpPasswordView extends StatelessWidget {
+  final SignUpPasswordController controller;
+
+  const SignUpPasswordView(
+    this.controller, {
+    Key key,
+  }) : super(key: key);
+
+  @override
+  Widget build(BuildContext context) {
+    return OnePageCard(
+      child: Scaffold(
+        appBar: AppBar(
+          elevation: 0,
+          leading: controller.loading ? Container() : BackButton(),
+          title: Text(
+            L10n.of(context).chooseAStrongPassword,
+          ),
+        ),
+        body: ListView(
+          children: <Widget>[
+            Padding(
+              padding: const EdgeInsets.all(12.0),
+              child: TextField(
+                controller: controller.passwordController,
+                obscureText: !controller.showPassword,
+                autofocus: true,
+                readOnly: controller.loading,
+                autocorrect: false,
+                onSubmitted: (_) => controller.signUpAction,
+                autofillHints:
+                    controller.loading ? null : [AutofillHints.newPassword],
+                decoration: InputDecoration(
+                    prefixIcon: Icon(Icons.lock_outlined),
+                    hintText: '****',
+                    errorText: controller.passwordError,
+                    suffixIcon: IconButton(
+                      tooltip: L10n.of(context).showPassword,
+                      icon: Icon(controller.showPassword
+                          ? Icons.visibility_off_outlined
+                          : Icons.visibility_outlined),
+                      onPressed: controller.toggleShowPassword,
+                    ),
+                    labelText: L10n.of(context).password),
+              ),
+            ),
+            SizedBox(height: 12),
+            Hero(
+              tag: 'loginButton',
+              child: Padding(
+                padding: EdgeInsets.symmetric(horizontal: 12),
+                child: ElevatedButton(
+                  onPressed:
+                      controller.loading ? null : controller.signUpAction,
+                  child: controller.loading
+                      ? LinearProgressIndicator()
+                      : Text(
+                          L10n.of(context).createAccountNow.toUpperCase(),
+                          style: TextStyle(color: Colors.white, fontSize: 16),
+                        ),
+                ),
+              ),
+            ),
+          ],
+        ),
+      ),
+    );
+  }
+}

test/sign_up_password_test.dart

@@ -0,0 +1,16 @@
+import 'package:fluffychat/controllers/sign_up_password_controller.dart';
+import 'package:fluffychat/main.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+  testWidgets('Test if the widget can be created', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      FluffyChatApp(
+        testWidget: SignUpPassword(
+          'test_user',
+          displayname: 'Test User',
+        ),
+      ),
+    );
+  });
+}