refactor: Remove unnecessary FutureBuilder

lib/pages/chat/events/message_content.dart

@@ -251,34 +251,24 @@ class MessageContent extends StatelessWidget {
             final bigEmotes = event.onlyEmotes &&
                 event.numberEmotes > 0 &&
                 event.numberEmotes <= 10;
-            return FutureBuilder<String>(
-              future: event.calcLocalizedBody(
+            return Linkify(
+              text: event.calcLocalizedBodyFallback(
                 MatrixLocals(L10n.of(context)!),
                 hideReply: true,
               ),
-              builder: (context, snapshot) {
-                return Linkify(
-                  text: snapshot.data ??
-                      event.calcLocalizedBodyFallback(
-                        MatrixLocals(L10n.of(context)!),
-                        hideReply: true,
-                      ),
-                  style: TextStyle(
-                    color: textColor,
-                    fontSize: bigEmotes ? fontSize * 3 : fontSize,
-                    decoration:
-                        event.redacted ? TextDecoration.lineThrough : null,
-                  ),
-                  options: const LinkifyOptions(humanize: false),
-                  linkStyle: TextStyle(
-                    color: textColor.withAlpha(150),
-                    fontSize: bigEmotes ? fontSize * 3 : fontSize,
-                    decoration: TextDecoration.underline,
-                    decorationColor: textColor.withAlpha(150),
-                  ),
-                  onOpen: (url) => UrlLauncher(context, url.url).launchUrl(),
-                );
-              },
+              style: TextStyle(
+                color: textColor,
+                fontSize: bigEmotes ? fontSize * 3 : fontSize,
+                decoration: event.redacted ? TextDecoration.lineThrough : null,
+              ),
+              options: const LinkifyOptions(humanize: false),
+              linkStyle: TextStyle(
+                color: textColor.withAlpha(150),
+                fontSize: bigEmotes ? fontSize * 3 : fontSize,
+                decoration: TextDecoration.underline,
+                decorationColor: textColor.withAlpha(150),
+              ),
+              onOpen: (url) => UrlLauncher(context, url.url).launchUrl(),
             );
         }
       case EventTypes.CallInvite:

lib/pages/chat/events/state_message.dart

@@ -21,22 +21,15 @@ class StateMessage extends StatelessWidget {
             color: Theme.of(context).colorScheme.background,
             borderRadius: BorderRadius.circular(AppConfig.borderRadius / 2),
           ),
-          child: FutureBuilder<String>(
-            future: event.calcLocalizedBody(MatrixLocals(L10n.of(context)!)),
-            builder: (context, snapshot) {
-              return Text(
-                snapshot.data ??
-                    event.calcLocalizedBodyFallback(
-                      MatrixLocals(L10n.of(context)!),
-                    ),
-                textAlign: TextAlign.center,
-                style: TextStyle(
-                  fontSize: 12 * AppConfig.fontSizeFactor,
-                  decoration:
-                      event.redacted ? TextDecoration.lineThrough : null,
-                ),
-              );
-            },
+          child: Text(
+            event.calcLocalizedBodyFallback(
+              MatrixLocals(L10n.of(context)!),
+            ),
+            textAlign: TextAlign.center,
+            style: TextStyle(
+              fontSize: 12 * AppConfig.fontSizeFactor,
+              decoration: event.redacted ? TextDecoration.lineThrough : null,
+            ),
           ),
         ),
       ),

lib/pages/chat/pinned_events.dart

@@ -63,33 +63,24 @@ class PinnedEvents extends StatelessWidget {
       future: controller.room.getEventById(pinnedEventIds.last),
       builder: (context, snapshot) {
         final event = snapshot.data;
-        return FutureBuilder<String>(
-          future: event?.calcLocalizedBody(
-            MatrixLocals(L10n.of(context)!),
-            withSenderNamePrefix: true,
-            hideReply: true,
-          ),
-          builder: (context, snapshot) => ChatAppBarListTile(
-            title: snapshot.data ??
-                event?.calcLocalizedBodyFallback(
-                  MatrixLocals(L10n.of(context)!),
-                  withSenderNamePrefix: true,
-                  hideReply: true,
-                ) ??
-                L10n.of(context)!.loadingPleaseWait,
-            leading: IconButton(
-              splashRadius: 20,
-              iconSize: 20,
-              color: Theme.of(context).colorScheme.onSurfaceVariant,
-              icon: const Icon(Icons.push_pin),
-              tooltip: L10n.of(context)!.unpin,
-              onPressed:
-                  controller.room.canSendEvent(EventTypes.RoomPinnedEvents)
-                      ? () => controller.unpinEvent(event!.eventId)
-                      : null,
-            ),
-            onTap: () => _displayPinnedEventsDialog(context),
+        return ChatAppBarListTile(
+          title: event?.calcLocalizedBodyFallback(
+                MatrixLocals(L10n.of(context)!),
+                withSenderNamePrefix: true,
+                hideReply: true,
+              ) ??
+              L10n.of(context)!.loadingPleaseWait,
+          leading: IconButton(
+            splashRadius: 20,
+            iconSize: 20,
+            color: Theme.of(context).colorScheme.onSurfaceVariant,
+            icon: const Icon(Icons.push_pin),
+            tooltip: L10n.of(context)!.unpin,
+            onPressed: controller.room.canSendEvent(EventTypes.RoomPinnedEvents)
+                ? () => controller.unpinEvent(event!.eventId)
+                : null,
           ),
+          onTap: () => _displayPinnedEventsDialog(context),
         );
       },
     );

lib/pages/chat/reply_display.dart

@@ -66,27 +66,17 @@ class _EditContent extends StatelessWidget {
           color: Theme.of(context).colorScheme.primary,
         ),
         Container(width: 15.0),
-        FutureBuilder<String>(
-          future: event.calcLocalizedBody(
+        Text(
+          event.calcLocalizedBodyFallback(
             MatrixLocals(L10n.of(context)!),
             withSenderNamePrefix: false,
             hideReply: true,
           ),
-          builder: (context, snapshot) {
-            return Text(
-              snapshot.data ??
-                  event.calcLocalizedBodyFallback(
-                    MatrixLocals(L10n.of(context)!),
-                    withSenderNamePrefix: false,
-                    hideReply: true,
-                  ),
-              overflow: TextOverflow.ellipsis,
-              maxLines: 1,
-              style: TextStyle(
-                color: Theme.of(context).textTheme.bodyMedium!.color,
-              ),
-            );
-          },
+          overflow: TextOverflow.ellipsis,
+          maxLines: 1,
+          style: TextStyle(
+            color: Theme.of(context).textTheme.bodyMedium!.color,
+          ),
         ),
       ],
     );

lib/pages/chat_list/chat_list_item.dart

@@ -226,51 +226,34 @@ class ChatListItem extends StatelessWidget {
                             maxLines: 1,
                             softWrap: false,
                           )
-                        : FutureBuilder<String>(
-                            future: room.lastEvent?.calcLocalizedBody(
-                                  MatrixLocals(L10n.of(context)!),
-                                  hideReply: true,
-                                  hideEdit: true,
-                                  plaintextBody: true,
-                                  removeMarkdown: true,
-                                  withSenderNamePrefix: !isDirectChat ||
-                                      directChatMatrixId !=
-                                          room.lastEvent?.senderId,
-                                ) ??
-                                Future.value(L10n.of(context)!.emptyChat),
-                            builder: (context, snapshot) {
-                              return Text(
-                                room.membership == Membership.invite
-                                    ? isDirectChat
-                                        ? L10n.of(context)!.invitePrivateChat
-                                        : L10n.of(context)!.inviteGroupChat
-                                    : snapshot.data ??
-                                        room.lastEvent
-                                            ?.calcLocalizedBodyFallback(
-                                          MatrixLocals(L10n.of(context)!),
-                                          hideReply: true,
-                                          hideEdit: true,
-                                          plaintextBody: true,
-                                          removeMarkdown: true,
-                                          withSenderNamePrefix: !isDirectChat ||
-                                              directChatMatrixId !=
-                                                  room.lastEvent?.senderId,
-                                        ) ??
-                                        L10n.of(context)!.emptyChat,
-                                softWrap: false,
-                                maxLines: 1,
-                                overflow: TextOverflow.ellipsis,
-                                style: TextStyle(
-                                  fontWeight: unread || room.hasNewMessages
-                                      ? FontWeight.bold
-                                      : null,
-                                  color: theme.colorScheme.onSurfaceVariant,
-                                  decoration: room.lastEvent?.redacted == true
-                                      ? TextDecoration.lineThrough
-                                      : null,
-                                ),
-                              );
-                            },
+                        : Text(
+                            room.membership == Membership.invite
+                                ? isDirectChat
+                                    ? L10n.of(context)!.invitePrivateChat
+                                    : L10n.of(context)!.inviteGroupChat
+                                : room.lastEvent?.calcLocalizedBodyFallback(
+                                      MatrixLocals(L10n.of(context)!),
+                                      hideReply: true,
+                                      hideEdit: true,
+                                      plaintextBody: true,
+                                      removeMarkdown: true,
+                                      withSenderNamePrefix: !isDirectChat ||
+                                          directChatMatrixId !=
+                                              room.lastEvent?.senderId,
+                                    ) ??
+                                    L10n.of(context)!.emptyChat,
+                            softWrap: false,
+                            maxLines: 1,
+                            overflow: TextOverflow.ellipsis,
+                            style: TextStyle(
+                              fontWeight: unread || room.hasNewMessages
+                                  ? FontWeight.bold
+                                  : null,
+                              color: theme.colorScheme.onSurfaceVariant,
+                              decoration: room.lastEvent?.redacted == true
+                                  ? TextDecoration.lineThrough
+                                  : null,
+                            ),
                           ),
                   ),
                   const SizedBox(width: 8),