Common/BitField: Fix off-by-one error for signed types

Fixes Darkstalkers 3 character select screen.
6 years ago · 341b163ca1
parent dc1e1b5adf
commit 341b163ca1
1 changed files with 2 additions and 2 deletions
--- a/src/common/bitfield.h
+++ b/src/common/bitfield.h
@ -119,8 +119,8 @@ struct BitField
    }
    else if constexpr (std::is_signed_v<DataType>)
    {
-      constexpr int shift = 8 * sizeof(DataType) - BitCount;
-      return (static_cast<DataType>((data & GetMask()) >> BitIndex) << shift) >> shift;
+      constexpr int shift = 8 * sizeof(DataType) - BitCount + 1;
+      return (static_cast<DataType>(data >> BitIndex) << shift) >> shift;
    }
    else
    {